Slow Array Build. Can someone help speed this up?

[wisem2540]

I know this is not efficient, but I do not know how to fix it.  The file should always have 11 columns, but the number of lines will change.  Currently the file is over 6,000 lines, and 813k in file size

My Current process is to read the file into a 1D aray, then split each CSV like into seperate elements.  It takes about 1min to complete, which is too long for the GUI I want to build.

#include <array.au3>
#include <file.au3>
Dim $oneDarray
_FileReadToArray("C:\file.csv", $oneDarray)


Local $Array[0][11]

For $x = 1 to $OneDArray[0]
   _ArrayAdd ($Array,$OneDArray[$x],0,",")
   ;MsgBox (0, "", @Error)
Next

_ArrayDisplay ($Array)

Edited February 5, 2015 by wisem2540

[Melba23]

wisem2540,

The _FileReadToArray function in the latest Beta versions will read your file directly into a 2D array.

M23

Edited February 5, 2015 by Melba23
Wrote the wrong function name!

[MikahS]

Why not try out:

#include <File.au3>
 
_FileReadToArray("C:\file.csv", $oneDarray, 1, ",")

?

Edited February 5, 2015 by MikahS

[MikahS]

  On 2/5/2015 at 4:18 PM, Melba23 said:

wisem2540,

The _FileListToArray function in the latest Beta versions will read your file directly into a 2D array.

M23

That will only list files and folders in an array, not the contents of the file.

EDIT: Unless the beta version has this capability, if so disregard this.

Edited February 5, 2015 by MikahS

[Melba23]

MikahS,

Brain failure!

M23

[wisem2540]

  On 2/5/2015 at 4:19 PM, MikahS said:

Why not try out:

#include <File.au3>
 
_FileReadToArray("C:\file.csv", $oneDarray, 1, ",")

?

 

I thought this would work too, but when I do an _Arraydisplay, nothing happened.

[Melba23]

wisem2540,

How about posting a copy of the file so we can test?

M23

[wisem2540]

I am using autoit 3.3.12.  I will upgrade based on M23's suggestion and see how it goes....

[wisem2540]

  On 2/5/2015 at 4:32 PM, Melba23 said:

wisem2540,

How about posting a copy of the file so we can test?

M23

 

Sure, Ill need to take some data out of it first...  gimmie a sec

[MikahS]

  On 2/5/2015 at 4:30 PM, wisem2540 said:

I thought this would work too, but when I do an _Arraydisplay, nothing happened.

 

Try this:

_FileReadToArray("C:\file.csv", $oneDarray, 2, ",")

 

  On 2/5/2015 at 4:27 PM, Melba23 said:

Brain failure!

 

I know I have my moments! yay, for old age!

[MikahS]

  On 2/5/2015 at 4:32 PM, wisem2540 said:

I am using autoit 3.3.12.  I will upgrade based on M23's suggestion and see how it goes....

see post #5

[Melba23]

MikahS,

The Beta _FileReadToArray does indeed have the required functionality - I just wrote the wrong function name.

M23

[wisem2540]

Mikah,

Your original solution worked...my Array was just the wrong size.  Thanks for the help.  I misinterpreted the meaning of the help file.  My mistake.

[MikahS]

  On 2/5/2015 at 4:39 PM, Melba23 said:

MikahS,

The Beta _FileReadToArray does indeed have the required functionality - I just wrote the wrong function name.

M23

Good deal, thank you for clarifying Melba.

 

  On 2/5/2015 at 4:44 PM, wisem2540 said:

Mikah,

Your original solution worked...my Array was just the wrong size.  Thanks for the help.  I misinterpreted the meaning of the help file.  My mistake.

 

Glad to have helped.

[wisem2540]

Actually, after more testing, I had one weird characters in one of the columns.  When I edited the file to post for you guys, it masked the issue.  Anyway, still fixed

[MikahS]

  On 2/5/2015 at 5:23 PM, wisem2540 said:

Actually, after more testing, I had one weird characters in one of the columns.  When I edited the file to post for you guys, it masked the issue.  Anyway, still fixed

 

No problem, if you have anymore questions relating to reading the file contents into an array post here, otherwise you can start a new topic if you hit anymore snags.