kevinz

Last IF statement in a function not getting executed?

3 posts in this topic

#1 ·  Posted (edited)

So in my script, I have multiple text boxes that I would like to read from.
This is what my code looks like so far:
 

 
Func readInputboxes()
;read the inputs (after the button has been pressed) and add it to the master String. the filepath is verified in the initial "while" loop
;add all to $commandString
 
$filepath = GUICtrlRead($txtFilepath)
$commandString = $filepath
 
If GUICtrlRead($txtChromeID) <> 0 Then
   $crxID = GUICtrlRead($txtChromeID)
   $commandString = $commandString & " CRXID=" & $crxID
EndIf


If GUICtrlRead($txtPartner) <> 0 Then
   $partnerCode = GUICtrlRead($txtPartner)
   $commandString = $commandString & " PARTNER=" & $partnerCode
EndIf


If GUICtrlRead($txtIP) <> 0 Then
   $ip = GUICtrlRead($txtIP)
   $commandString = $commandString & " IP=" & $ip
EndIf


If GUICtrlRead($txtReguninstall) <> 0 Then
   $regUninstall = GUICtrlRead($txtReguninstall)
   $commandString = $commandString & " REGUNINSTALL=" & $regUninstall
EndIf  

;debugging section MsgBox(0, 'Valid Input', $commandString) ;FOR DEBUGGING 
EndFunc

However, it seems like the last IF statement is not getting executed.

Test case 1: I fill out all fields. Then the last string "$txtReguninstall" will not be appended to $commandString.
Test case 2: I fill out the first 2 fields only. However upon submitting, only the first field's text will be appended to $commandString

Test case 3: I fill out first 2 fields, and the last field (there are 2 empty fields in the middle of the GUI). However when submitting, again it's just the first two fields. It seems like as soon as I hit an empty string, the function exits.

So I'm sure it's a logic issue. Anyone have a better way to handle this?

Help please? :)

Edited by kevinz

Share this post


Link to post
Share on other sites



kevinz,

Your function works perfectly when I test it: :)

#include <GUIConstantsEx.au3>
#include <MsgBoxConstants.au3>

$hGUI = GUICreate("Test", 500, 500)

$txtFilepath = GUICtrlCreateInput("", 10, 10, 200, 20)
$txtChromeID = GUICtrlCreateInput("", 10, 50, 200, 20)
$txtPartner = GUICtrlCreateInput("", 10, 90, 200, 20)
$txtIP = GUICtrlCreateInput("", 10, 130, 200, 20)
$txtReguninstall = GUICtrlCreateInput("", 10, 170, 200, 20)

$cButton = GUICtrlCreateButton("Read", 10, 350, 80, 30)

GUISetState()

While 1

    Switch GUIGetMsg()
        Case $GUI_EVENT_CLOSE
            Exit
        Case $cButton
            readInputboxes()
    EndSwitch

WEnd

Func readInputboxes()
    ;read the inputs (after the button has been pressed) and add it to the master String. the filepath is verified in the initial "while" loop
    ;add all to $commandString

    $filepath = GUICtrlRead($txtFilepath)
    $commandString = $filepath

    If GUICtrlRead($txtChromeID) <> "" Then ; GUICtrlRead returns a string, so best compare to an empty string <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
        $crxID = GUICtrlRead($txtChromeID)
        $commandString = $commandString & " CRXID=" & $crxID
    EndIf


    If GUICtrlRead($txtPartner) <> "" Then
        $partnerCode = GUICtrlRead($txtPartner)
        $commandString = $commandString & " PARTNER=" & $partnerCode
    EndIf


    If GUICtrlRead($txtIP) <> "" Then
        $ip = GUICtrlRead($txtIP)
        $commandString = $commandString & " IP=" & $ip
    EndIf


    If GUICtrlRead($txtReguninstall) <> "" Then
        $regUninstall = GUICtrlRead($txtReguninstall)
        $commandString = $commandString & " REGUNINSTALL=" & $regUninstall
    EndIf


    MsgBox($MB_SYSTEMMODAL, 'Valid Input', $commandString) ;FOR DEBUGGING

EndFunc   ;==>readInputboxes
The problem must lie elsewhere. Do you want to share the whole script? :huh:

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites
Solution found...
 
Func readInputboxes()
;read the inputs (after the button has been pressed) and add it to the master String. the filepath is verified in the initial "while" loop
;add all to $commandString


$filepath = GUICtrlRead($txtFilepath)
$commandString = $filepath
$crxID = GUICtrlRead($txtChromeID)
$partnerCode = GUICtrlRead($txtPartner)
$ip = GUICtrlRead($txtIP)
$regUninstall = GUICtrlRead($txtReguninstall)


If StringLen($crxID) <> 0 Then
   $commandString = $commandString & " CRXID=" & $crxID
EndIf


If StringLen($partnerCode) <> 0 Then
   $commandString = $commandString & " PARTNER=" & $partnerCode
EndIf


If StringLen($ip) <> 0 Then
   $commandString = $commandString & " IP=" & $ip
EndIf


If StringLen($regUninstall) <> 0 Then
   $commandString = $commandString & " REGUNINSTALL=" & $regUninstall
EndIf




;debugging section
MsgBox(0, 'Valid Input', $commandString) ;FOR DEBUGGING
EndFunc

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now