Jump to content
Medallyon

_ArrayFindAll doesn't work with variable :(

Recommended Posts

Medallyon

Hello again dear AutoIt Community.

Today I have a problem regarding Arrays. The faulty code is shown below.

$oIE = _IECreate($idURL, 0, 1, 1, 0)
_IELoadWait($oIE)

$links = _IELinkGetCollection($oIE)

Global $aTxt[1]

Local $iIndex = 0

For $link in $links
   _ArrayInsert($aTxt, $iIndex, $link.innerText)
   $iIndex += 1
   ConsoleWrite("$Number of Texts (links) = " & $iIndex & @CRLF)
Next

If IsArray($aTxt) Then
   _ArrayDisplay($aTxt, "1D array")
EndIf

;This works
;If _ArrayFindAll($aTxt, "Fairy") Then
;   MsgBox(0, "Success", "Found all instances and saved it in an array (apparently), BUT WHERE?")
;EndIf

;This results in an error
Local $aiResult = _ArrayFindAll($aTxt, "Fairy")

If IsArray($aiResult) Then
   _ArrayDisplay($aiResult)
Else
   MsgBox(0, @error, "$aiResult is not an array." & @CRLF & "Error Code " & $aiResult)
EndIf

ConsoleWrite("The code executed without errors." & @CRLF)
Exit

The symptoms I'm experiencing are that I cannot get hold of an array that should have been created by "_ArrayFindAll". The only thing I'm presented with is an error code "-1" (sets the @error flag to non-zero).

I'd be very grateful for anyone willing to help out. Many Thanks in advance,

~Medallyon

Share this post


Link to post
Share on other sites
Medallyon

;This results in an error Local $aiResult = _ArrayFindAll($aTxt, "Fairy")

Also to add, There is certainly at least a dozen of instances where the Substring "Fairy" appears, so that's not the problem as I see it.

Share this post


Link to post
Share on other sites
kaisies

Also to add, There is certainly at least a dozen of instances where the Substring "Fairy" appears, so that's not the problem as I see it.

Well, without the URL I could only throw shit on a wall, but you are improperly using the return of _arrayfindall()

 

You can't:

If _ArrayFindAll($aTxt, "Fairy") Then
       MsgBox(0, "Success", "Found all instances and saved it in an array (apparently), BUT WHERE?")
EndIf

Because that's not how the return of _ArrayFindAll Works.  Just look at this code:  

#include <Array.au3>

Global $aTxt[0]

_ArrayAdd($aTxt,"")
_ArrayAdd($aTxt,"")
_ArrayAdd($aTxt,"")
_ArrayAdd($aTxt,"")
_ArrayAdd($aTxt,"")

Local $iIndex = 0

If IsArray($aTxt) Then
   _ArrayDisplay($aTxt, "1D array")
EndIf

;This works
If _ArrayFindAll($aTxt, "Fairy") Then
       MsgBox(0, "Success", "Found all instances and saved it in an array (apparently), BUT WHERE?")
EndIf

;This results in an error
Local $aiResult = _ArrayFindAll($aTxt, "Fairy")

If IsArray($aiResult) Then
   _ArrayDisplay($aiResult)
Else
   MsgBox(0, @error, "$aiResult is not an array." & @CRLF & "Error Code " & $aiResult)
EndIf

ConsoleWrite("The code executed without errors." & @CRLF)
Exit

Clearly there is no "Fairy" in the array, but the message box displays.

 

This works just fine:

#include <Array.au3>

Global $aTxt[0]

_ArrayAdd($aTxt,"Fairy")
_ArrayAdd($aTxt,"")
_ArrayAdd($aTxt,"Fairy")
_ArrayAdd($aTxt,"")
_ArrayAdd($aTxt,"Fairy")

Local $iIndex = 0

If IsArray($aTxt) Then
   _ArrayDisplay($aTxt, "1D array")
EndIf

;This results in an error
Local $aiResult = _ArrayFindAll($aTxt, "Fairy")

If IsArray($aiResult) Then
   _ArrayDisplay($aiResult)
Else
   MsgBox(0, @error, "$aiResult is not an array." & @CRLF & "Error Code " & $aiResult)
EndIf

ConsoleWrite("The code executed without errors." & @CRLF)
Exit

So clearly the problem is the wall. (your source array)

Edited by kaisies

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • Skeletor
      By Skeletor
      Hi Virtual People,
      My array works perfectly fine. However, what is the best practice if the line in the array doesn't have the correct amount of columns and if I can add a placeholder?

       
      For $count = 1 To _FileCountLines($FileRead1) Step 1 $string = FileReadLine($FileRead1, $count) $input = StringSplit($string, ",", 1) $value1 = $input[1] $value2 = $input[2] $value3 = $input[3] _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "A1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "B1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1") Next  
    • MrCheese
      By MrCheese
      hi all,
      reviewing the forum, this thread is applicable: 
       
       
      I wanted to know if there is now a better way to do this?
      In essence, I load a tab delimited txt file into an array (works well). I used tab, as some fields in the original csv contains commas.
      However, I needed autoit to manipulate this array, and output it as a csv.
      IF my array contains items with a comma, without double quotes around the field, then how best do I get a csv out of this?
      My current workaround is to filewritefromarray tab delimited, then open it in excel and save as a csv. I will need to check this to see how the address fields behave that contain a comma.
       
      Any thoughts would be appreciated.
       
    • Skeletor
      By Skeletor
      Hi All,

      I would like to know how you would take a FileLineRead and insert it into an array which then inserts it into Excel?
      One thing to know is the files content is broken up, so I only use half of the content within $FileRead1.
      So its imperative that the $value1, $value2, etc variables be used. 
      Code below:
      $FileRead1 = FileReadLine("C:\temp\sample.txt",1) For $count = 1 To _FileCountLines($FileRead1) Step 1 $string = FileReadLine($FileRead1, $count) $input = StringSplit($string, ",", 1) $value1 = $input[1] $value2 = $input[2] $value3 = $input[3] $value4 = $input[4] _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "A1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "B1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value4, "D1") Next  
    • AnonymousX
      By AnonymousX
      Hello,
      I'm trying to write a script that moves copies excel cells into an array. I'll than manipulate the values and send array into another program. 
      I don't want range to be specific to a workbook, or sheet, or set of cells.
      I want user to be able to highlight desired cells and to copy either normally ("Ctrl+C") or by a hotkey ("Alt+C"). 
      Could someone help me with this?
      Thank you,
      I've tried to write the framework: (edited)
      #include <MsgBoxConstants.au3> #include <Array.au3> #include <Excel.au3> HotKeySet("!v", "Pastedata") While True Sleep(1000) WEnd func Makearray() local $bArray ;User has cells already copied ;Convert clipboard into an array ;I don;t know how excel stores data to clipboard so don;t know how to bring it into array _Arraydisplay($bArray) MsgBox(0,0,$bArray) return $bArray endfunc func Pastedata() Local $aArray MsgBox(0,0,"wait",1) ;make array based on assumption user has already copied a range to clipboard $aArray = Makearray() ;paste code ;don;t worry about this I got the rest endfunc  
    • Dzenan03
      By Dzenan03
      I want to make a while loop, that creates variables based on a array. For thist I created the array $iDsO with the number and the name of folders in an other folder. Every folder has a different name an I want to create variables(arrays) for each folder that show me all the files in that folder. For example: I have the Folder \Folder1. In it there are the Folders \1, \2, \3. In 1, 2 and 3 there are some files(.png). The array for Folder1 is $iDsO and now I want to crate the arrays $iDsO1, $iDsO2 and $iDsO3 with the files in them can I make something like this:
      While $iDs > 0 ;$iDs is the number of files in Folder1>> $iDsO[0] $iDs#here should come the Foldername for example '1'# = _FileListtoArray(@ProgramFilesDir&"\Folder1\"&$iDsO[$iDs]) $iDs = $iDs - 1 Wend So that in the End I have three variabels ($iDs1, $iDs2 and $iDs3)
       
      Is this posible or if not what could I do instead ( I don´t know the number of folders in Folder1 in the begining).
×