Jump to content
Sign in to follow this  
Myicq

[Solved] ArrayInsert and overwrite

Recommended Posts

Myicq

I am currently doing a project involving keeping some parameters in an internal 2d array. I am reading part of that to and from an ini file.

As part of the reading I need to put the variables from the ini file into the 2D array. I have found _arrayinsert(), but that creates additional lines.

Bascially I would like something as this:

Original array:

[1]  a1  a2  a3  a4
[2]  b1  b2  b3  b4
[3]  c1  c2  c3  c4

And reading setting for "2" being    d1  d2  d3  d4   I should now have

[1]  a1  a2  a3  a4
[2]  d1  d2  d3  d4
[3]  c1  c2  c3  c4

Is there a built-in UDF or similar to do something like that already ? Or did I missing something real obvious ?

I have rolled my own code, which works. But of course it could be improved.

; function to insert and OVERWRITE data in a 2d array..
; so we can insert data and NOT create new rows..
Func _array_insert2d_overwrite(byref $sourceArray, $where, $dataarray)
    ; do we have arrays at all
    if not IsArray($sourceArray) then
        return 3
    EndIf

    if not IsArray($dataarray) then
        return 4
    EndIf


    ; check if sizes are OK
    if UBound($sourceArray,2) < UBound($dataarray) then   ; ,2 is for number of COLUMNS
        return 2
    EndIf

    if UBound($sourceArray) < $where then       ; this is ROWS
        return 1                                ; that row does not exist
    EndIf

    ; we should be OK to do action now.
    for $i = 0 to UBound($dataarray)-1
        $sourceArray[$where][$i] = $dataarray[$i]
    Next
EndFunc

Thanks for all comments, happy to learn from you all !

 

Edited by Myicq
solved marking

I am just a hobby programmer, and nothing great to publish right now.

Share this post


Link to post
Share on other sites
TouchOdeath

You could _arraydelete then _arrayinsert the same index.

Share this post


Link to post
Share on other sites
BrewManNH

Just overwrite the contents of the row of the array, no need to use any of the array functions for this at all. A simple loop would suffice.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites
TouchOdeath

Just overwrite the contents of the row of the array, no need to use any of the array functions for this at all. A simple loop would suffice.

I agree this is the best solution, It looks like hes already doing that in his function.  As far as improvements to his function, Its best practice to only have one single 'return' in a function.  So to fix, use a '$return' variable (and of course make sure your function still flows properly).

Edited by TouchOdeath

Share this post


Link to post
Share on other sites
AutoBert

The solution of MyICQ is Errorhandling and a (very) little bit faster. It's also better readable and so why not?

Edited by AutoBert

Share this post


Link to post
Share on other sites
czardas

Here's a solution that drops items if not enough columns are available, or stops overwriting if too many columns exist. Perhaps it's an idea to play around with.

#include <Array.au3>

Local $aArray = [['a1','a2','a3','a4'],['b1','b2','b3','b4'],['c1','c2','c3','c4']]
_ArrayDisplay($aArray, 'before')

Local $aRow = ['d1','d2','d3','d4','d5'], $iRowNum = 1
_RowOverwrite($aArray, $aRow, $iRowNum)
_ArrayDisplay($aArray, 'after')

Func _RowOverwrite(ByRef $aArray, $aRow, $iRowNum)
    If Not (IsArray($aArray) And IsArray($aRow) And IsInt($iRowNum)) Then Return SetError(1) ; one param is not an array, or $iRowNum is not an integer
    If UBound($aArray, 0) <> 2 Or UBound($aRow, 0) <> 1 Then Return SetError(2) ; one array dimension did not match
    If $iRowNum > UBound($aArray) -1 Then Return SetError(3) ; out of bounds row number

    Local $iItems = UBound($aRow), $iCols = UBound($aArray, 2)
    If $iItems > $iCols Then $iItems = $iCols

    For $i = 0 To $iItems - 1
        $aArray[$iRowNum][$i] = $aRow[$i]
    Next
EndFunc

 

Edited by czardas
  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

  • Similar Content

    • Skeletor
      By Skeletor
      Hi Virtual People,
      My array works perfectly fine. However, what is the best practice if the line in the array doesn't have the correct amount of columns and if I can add a placeholder?

       
      For $count = 1 To _FileCountLines($FileRead1) Step 1 $string = FileReadLine($FileRead1, $count) $input = StringSplit($string, ",", 1) $value1 = $input[1] $value2 = $input[2] $value3 = $input[3] _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "A1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "B1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1") Next  
    • MrCheese
      By MrCheese
      hi all,
      reviewing the forum, this thread is applicable: 
       
       
      I wanted to know if there is now a better way to do this?
      In essence, I load a tab delimited txt file into an array (works well). I used tab, as some fields in the original csv contains commas.
      However, I needed autoit to manipulate this array, and output it as a csv.
      IF my array contains items with a comma, without double quotes around the field, then how best do I get a csv out of this?
      My current workaround is to filewritefromarray tab delimited, then open it in excel and save as a csv. I will need to check this to see how the address fields behave that contain a comma.
       
      Any thoughts would be appreciated.
       
    • Skeletor
      By Skeletor
      Hi All,

      I would like to know how you would take a FileLineRead and insert it into an array which then inserts it into Excel?
      One thing to know is the files content is broken up, so I only use half of the content within $FileRead1.
      So its imperative that the $value1, $value2, etc variables be used. 
      Code below:
      $FileRead1 = FileReadLine("C:\temp\sample.txt",1) For $count = 1 To _FileCountLines($FileRead1) Step 1 $string = FileReadLine($FileRead1, $count) $input = StringSplit($string, ",", 1) $value1 = $input[1] $value2 = $input[2] $value3 = $input[3] $value4 = $input[4] _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "A1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "B1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value4, "D1") Next  
    • AnonymousX
      By AnonymousX
      Hello,
      I'm trying to write a script that moves copies excel cells into an array. I'll than manipulate the values and send array into another program. 
      I don't want range to be specific to a workbook, or sheet, or set of cells.
      I want user to be able to highlight desired cells and to copy either normally ("Ctrl+C") or by a hotkey ("Alt+C"). 
      Could someone help me with this?
      Thank you,
      I've tried to write the framework: (edited)
      #include <MsgBoxConstants.au3> #include <Array.au3> #include <Excel.au3> HotKeySet("!v", "Pastedata") While True Sleep(1000) WEnd func Makearray() local $bArray ;User has cells already copied ;Convert clipboard into an array ;I don;t know how excel stores data to clipboard so don;t know how to bring it into array _Arraydisplay($bArray) MsgBox(0,0,$bArray) return $bArray endfunc func Pastedata() Local $aArray MsgBox(0,0,"wait",1) ;make array based on assumption user has already copied a range to clipboard $aArray = Makearray() ;paste code ;don;t worry about this I got the rest endfunc  
    • Dzenan03
      By Dzenan03
      I want to make a while loop, that creates variables based on a array. For thist I created the array $iDsO with the number and the name of folders in an other folder. Every folder has a different name an I want to create variables(arrays) for each folder that show me all the files in that folder. For example: I have the Folder \Folder1. In it there are the Folders \1, \2, \3. In 1, 2 and 3 there are some files(.png). The array for Folder1 is $iDsO and now I want to crate the arrays $iDsO1, $iDsO2 and $iDsO3 with the files in them can I make something like this:
      While $iDs > 0 ;$iDs is the number of files in Folder1>> $iDsO[0] $iDs#here should come the Foldername for example '1'# = _FileListtoArray(@ProgramFilesDir&"\Folder1\"&$iDsO[$iDs]) $iDs = $iDs - 1 Wend So that in the End I have three variabels ($iDs1, $iDs2 and $iDs3)
       
      Is this posible or if not what could I do instead ( I don´t know the number of folders in Folder1 in the begining).
×