Sign in to follow this  
Followers 0
Myicq

[Solved] ArrayInsert and overwrite

6 posts in this topic

#1 ·  Posted (edited)

I am currently doing a project involving keeping some parameters in an internal 2d array. I am reading part of that to and from an ini file.

As part of the reading I need to put the variables from the ini file into the 2D array. I have found _arrayinsert(), but that creates additional lines.

Bascially I would like something as this:

Original array:

[1]  a1  a2  a3  a4
[2]  b1  b2  b3  b4
[3]  c1  c2  c3  c4

And reading setting for "2" being    d1  d2  d3  d4   I should now have

[1]  a1  a2  a3  a4
[2]  d1  d2  d3  d4
[3]  c1  c2  c3  c4

Is there a built-in UDF or similar to do something like that already ? Or did I missing something real obvious ?

I have rolled my own code, which works. But of course it could be improved.

; function to insert and OVERWRITE data in a 2d array..
; so we can insert data and NOT create new rows..
Func _array_insert2d_overwrite(byref $sourceArray, $where, $dataarray)
    ; do we have arrays at all
    if not IsArray($sourceArray) then
        return 3
    EndIf

    if not IsArray($dataarray) then
        return 4
    EndIf


    ; check if sizes are OK
    if UBound($sourceArray,2) < UBound($dataarray) then   ; ,2 is for number of COLUMNS
        return 2
    EndIf

    if UBound($sourceArray) < $where then       ; this is ROWS
        return 1                                ; that row does not exist
    EndIf

    ; we should be OK to do action now.
    for $i = 0 to UBound($dataarray)-1
        $sourceArray[$where][$i] = $dataarray[$i]
    Next
EndFunc

Thanks for all comments, happy to learn from you all !

 

Edited by Myicq
solved marking

I am just a hobby programmer, and nothing great to publish right now.

Share this post


Link to post
Share on other sites

You could _arraydelete then _arrayinsert the same index.

Share this post


Link to post
Share on other sites

Just overwrite the contents of the row of the array, no need to use any of the array functions for this at all. A simple loop would suffice.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

#4 ·  Posted (edited)

Just overwrite the contents of the row of the array, no need to use any of the array functions for this at all. A simple loop would suffice.

I agree this is the best solution, It looks like hes already doing that in his function.  As far as improvements to his function, Its best practice to only have one single 'return' in a function.  So to fix, use a '$return' variable (and of course make sure your function still flows properly).

Edited by TouchOdeath

Share this post


Link to post
Share on other sites

#5 ·  Posted (edited)

The solution of MyICQ is Errorhandling and a (very) little bit faster. It's also better readable and so why not?

Edited by AutoBert

Share this post


Link to post
Share on other sites

#6 ·  Posted (edited)

Here's a solution that drops items if not enough columns are available, or stops overwriting if too many columns exist. Perhaps it's an idea to play around with.

#include <Array.au3>

Local $aArray = [['a1','a2','a3','a4'],['b1','b2','b3','b4'],['c1','c2','c3','c4']]
_ArrayDisplay($aArray, 'before')

Local $aRow = ['d1','d2','d3','d4','d5'], $iRowNum = 1
_RowOverwrite($aArray, $aRow, $iRowNum)
_ArrayDisplay($aArray, 'after')

Func _RowOverwrite(ByRef $aArray, $aRow, $iRowNum)
    If Not (IsArray($aArray) And IsArray($aRow) And IsInt($iRowNum)) Then Return SetError(1) ; one param is not an array, or $iRowNum is not an integer
    If UBound($aArray, 0) <> 2 Or UBound($aRow, 0) <> 1 Then Return SetError(2) ; one array dimension did not match
    If $iRowNum > UBound($aArray) -1 Then Return SetError(3) ; out of bounds row number

    Local $iItems = UBound($aRow), $iCols = UBound($aArray, 2)
    If $iItems > $iCols Then $iItems = $iCols

    For $i = 0 To $iItems - 1
        $aArray[$iRowNum][$i] = $aRow[$i]
    Next
EndFunc

 

Edited by czardas
1 person likes this

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • ronmage
      By ronmage
      So I have a loop that keeps reading data from an array and searching it for the same value. If the value is no there it does work then adds the value to the array to prevent it from doing the same work.
      If _ArraySearch($ID,$filearray[$i]) = -1 Then Work.... _ArrayAdd($ID,$filearray[$i]) EndIf This is in a for loop hence $i
      So what is happening is the code works great for several hours. After a period of time _ArraySearch($ID,$filearray[$i]) will result in -1 even if $ID = $filearray. So it ready as if there is no data in the array. Anyone have this problem? 
       
      Also I am just running in using F5 not compiling it and running it if that makes a difference.
       
    • Ascer
      By Ascer
      1. Description.
      Udf working with MSDN System.Collections.ArrayList. Allow you to make fast operations on huge arrays, speed is even x10 better than basic _ArrayAdd.  Not prefered for small arrays < 600 items. 2. Requirements
      .NET Framework 1.1+ System Windows 3. Possibilities.
      ;=============================================================================================================== ; UDF Name: List.au3 ; ; Date: 2018-02-17, 10:52 ; Description: Simple udf to create System Collections as ArrayList and make multiple actions on them. ; ; Function(s): _ListCreate -> Creates a new list ; _ListCapacity -> Gets a list size in bytes ; _ListCount -> Gets items count in list ; _ListIsFixedSize -> Get bool if list if fixed size ; _ListIsReadOnly -> Get bool if list is read only ; _ListIsSynchronized -> Get bool if list is synchronized ; _ListGetItem -> Get item on index ; _ListSetItem -> Set item on index ; ; _ListAdd -> Add item at end of list ; _ListClear -> Remove all list items ; _ListClone -> Duplicate list in new var ; _ListContains -> Get bool if item is in list ; _ListGetHashCode -> Get hash code for list ; _ListGetRange -> Get list with items between indexs ; _ListIndexOf -> Get index of item ; _ListInsert -> Insert a new item on index ; _ListInsertRange -> Insert list into list on index ; _ListLastIndexOf -> Get index last of item ; _ListRemove -> Remove first found item ; _ListRemoveAt -> Remove item in index ; _ListRemoveRange -> Remove items between indexs ; _ListReverse -> Reverse all items in list ; _ListSetRange -> Set new value for items in range ; _ListSort -> Sort items in list (speed of reading) ; _ListToString -> Get list object name ; _ListTrimToSize -> Remove unused space in list ; ; Author(s): Ascer ;=============================================================================================================== 4. Downloads
      List.au3 5. Examples
      SpeedTest _ArrayAdd vs ListAdd SpeedTest ArraySearch vs ListIndexOf Basic usage - crating guild with members  
    • FMS
      By FMS
      Hello,
      I'm trying to read a binary file to an array but couln't get it to work.
      Also I coul not find any help in the forum around this subject whish was helpfull.
      Is there any way it could be done?
      I tried a lot of ways but maybe somebody know's the right way?
      #AutoIt3Wrapper_Au3Check_Parameters=-d -w 1 -w 2 -w 3 -w 4 -w 5 -w 6 -w 7 #include <File.au3> #include <Array.au3> #include <AutoItConstants.au3> Local $in=FileOpen("TEST_labels.idx1-ubyte",16) ; 16+0=Read binary Local $data = FileRead($in) Local $FileArray = BinaryToString($data,4) ;~ $FileArray = StringSplit($BinarydData, @CRLF, 1+2) ;~ Local $FileArray = StringRegExp($BinarydData, "[^\r\n]+", 3) FileClose($in) _ArrayDisplay($FileArray,"$FileArray","",32) MsgBox($MB_SYSTEMMODAL, "", "$FileArray = " & $FileArray )  
      TEST_labels.idx1-ubyte
    • ur
      By ur
      I am reading a CSV file which is tab seperated as below.
      Local $aArray = FileReadToArray($file) And now, I am splitting this main array record wise so that Array contains internally another arrow to represent each row.
      For $i = 0 to (UBound($aArray) - 1) ;MsgBox(0,"",$aArray[$i]) $aArray[$i] = StringSplit(StringStripCR($aArray[$i]), Chr(9),2);Chr(9) for tab ;_ArrayDisplay($aArray[$i]) Next Afther that, _ArrayDIsplay is able to see the individual internal arrays.
      _ArrayDisplay($aArray[1]) But If I try to access the individual element of it as below.It is not showing any result.
      MsgBox(0,"",$aArray[1][1]) Any suggestion, below is the sample csv file.
      New Text Document.csv
    • Jibsbrown
      By Jibsbrown
      Need some help understanding why the ConsoleWrite works inside 2nd For loop but not out side. Between Audit Wiki, Help file , Forum searching (lots of code reading), and YouTube ( shout out to TutsTeach), I have not been able to find the reason why. 
      $sIniPath = "installLog.ini" ; - Get section name $iniSctionNames = IniReadSectionNames($sIniPath) ; - Get Keys and Vaules For $a = 1 to UBound($iniSctionNames) - 1 $keys = IniReadSection($sIniPath , $iniSctionNames[$a]) For $b = 1 to UBound($keys) - 1 $oldSysInfo = IniRead($sIniPath , $iniSctionNames[1], $keys[$b][0], "") $PntIPInfo = IniRead($sIniPath , $iniSctionNames[2], $keys[$b][0], "") $NewPCInfor = IniRead($sIniPath , $iniSctionNames[3], $keys[$b][0], "") ;ConsoleWrite($oldSysInfo & @LF) Next ;ConsoleWrite($oldSysInfo & @LF) Next ConsoleWrite($oldSysInfo) My intention is to use the variables later for Listboxes. Any explanation, forum post links or whatever would help. Sorry also very very new to Autoit.
      Also here's the ini file.
      [OldSysInfo] 4=192.168.0.4|DESKTOP-RDIU2SN|R90M05Q8 5=192.168.0.5|SD0123456789101|R9WGP9P 6=192.168.0.6|SD0123456789102|R9WGP9PT 3=192.168.0.3|DESKTOP-3RS4LKL|R9WGP9P 23=192.168.0.23|SD0123456789102|MXL1234P5I [PrinterIp] 50=192.168.0.50 48=192.168.0.48 47=192.168.0.47 [NewSysInfo] newPC = SD0123456789adfs|192.168.0.185|2UA1234FTR Thank you for your time.