RyukShini

2 ubound arrays wont work together

14 posts in this topic

#1 ·  Posted (edited)

#include <array.au3>
#include <file.au3>

Local $text
_FileReadToArray("text.txt", $text) ; read the list of names to array
Local $test
_FileReadToArray("test.txt", $test) ; read the list of names to array

For $u = 1 To UBound($test) - 1
For $i = 1 To UBound($text) - 1

MsgBox(4096, "Test", $text[$i] & " - " & $test[$u])
Next
    Next

When I run this only the first ubound array works, the second does not change value?
Do you have a suggestion for me.

Thanks in advance

Edited by RyukShini

Share this post


Link to post
Share on other sites
#include <array.au3>
#include <file.au3>

Local $text
Local $test
_FileReadToArray(@ScriptDir & "\text.txt", $text) ; read the list of names to array
_FileReadToArray(@ScriptDir & "\test.txt", $test) ; read the list of names to array

For $u = 1 To UBound($test) - 1
    For $i = 1 To UBound($text) - 1

        MsgBox(4096, "Test", $text[$i] & " - " & $test[$u])
    Next
Next

 

Share this post


Link to post
Share on other sites

your script works fine just need to declare $text and $test

#include <array.au3>
#include <file.au3>

Local $text
_FileReadToArray("text.txt", $text) ; read the list of names to array
Local $test
_FileReadToArray("test.txt", $test) ; read the list of names to array

For $u = 1 To UBound($test) - 1
For $i = 1 To UBound($text) - 1

MsgBox(4096, "Test", $text[$i] & " - " & $test[$u])
Next
    Next

 


ill get to that... i still need to learn and understand a lot of codes graduated.gif

Correct answer, learn to walk before you take on that marathon.

Share this post


Link to post
Share on other sites

:lol:

1 person likes this

ill get to that... i still need to learn and understand a lot of codes graduated.gif

Correct answer, learn to walk before you take on that marathon.

Share this post


Link to post
Share on other sites
1 hour ago, 232showtime said:

your script works fine just need to declare $text and $test

#include <array.au3>
#include <file.au3>

Local $text
_FileReadToArray("text.txt", $text) ; read the list of names to array
Local $test
_FileReadToArray("test.txt", $test) ; read the list of names to array

For $u = 1 To UBound($test) - 1
For $i = 1 To UBound($text) - 1

MsgBox(4096, "Test", $text[$i] & " - " & $test[$u])
Next
    Next

 

 

1 hour ago, l3ill said:
#include <array.au3>
#include <file.au3>

Local $text
Local $test
_FileReadToArray(@ScriptDir & "\text.txt", $text) ; read the list of names to array
_FileReadToArray(@ScriptDir & "\test.txt", $test) ; read the list of names to array

For $u = 1 To UBound($test) - 1
    For $i = 1 To UBound($text) - 1

        MsgBox(4096, "Test", $text[$i] & " - " & $test[$u])
    Next
Next

 

Sorry That was a mistake not to declare.
After declaring the variables it still doesn't work.
$test[$u] does not change its value, it remains the same however $text[$i] changes.
 

Share this post


Link to post
Share on other sites

What's in the test.txt file?


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

show your full script and content of the txt file, its working fine with me.

 

MSGbox.jpg


ill get to that... i still need to learn and understand a lot of codes graduated.gif

Correct answer, learn to walk before you take on that marathon.

Share this post


Link to post
Share on other sites

#9 ·  Posted (edited)

Look at my next Reply...

Edited by abdulrahmanok

Share this post


Link to post
Share on other sites

RyukShini,

You have 2 embedded loops - as a result you will get the following returns:

Line 1 of test - Line 1 of text
Line 2 of test - Line 1 of text
...                               ; And this continues until the last line of the file
Line n of test - Line 1 of text
Line 1 of test - Line 2 of text   ; Only then will the line of the outer loop change and the process repeat
Line 2 of test - Line 2 of text
...
Line n of test - Line 2 of text
Line 1 of test - Line 3 of text
Line 2 of test - Line 3 of text
...
Line n of test - Line 3 of text
...
...
Line n of test - Line n of text  ; Until we end up here at the last line of both files

So the second value will eventually change, but only every time the first one resets to the first line.

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

Hope this what you want :

#include <array.au3>
#include <file.au3>
$First = FileReadToArray(@ScriptDir & "\FirstValu.txt")
    If @error Then
    
    Else
    For $i = 0 To UBound($First,2) - 1 ; Loop through the array.
    Next

EndIf
    $Second = FileReadToArray(@ScriptDir & "\SecondValu.txt")
    If @error Then
    Else
        For $y = 0 To UBound($Second) - 1 ; Loop through the array.
        
            FileWrite(@ScriptDir & "\All.txt",$First[$i]&@CRLF)
FileWrite(@ScriptDir & "\All.txt",$Second[$y])
ExitLoop
            ; Read File To Array is Done
;~         ExitLoop  Dont exit loop unless there is an error handler
        Next
    EndIf

Tested .

Share this post


Link to post
Share on other sites
16 hours ago, RyukShini said:

 

Sorry That was a mistake not to declare.
After declaring the variables it still doesn't work.
$test[$u] does not change its value, it remains the same however $text[$i] changes.
 

well if you want $text and $test changed their values at the same time you can do like this:

#include <array.au3>
#include <file.au3>

Local $text
Local $test
_FileReadToArray(@ScriptDir & "\text.txt", $text) ; read the list of names to array
_FileReadToArray(@ScriptDir & "\test.txt", $test) ; read the list of names to array

For $u = 1 To UBound($test) - 1
        MsgBox(4096, "Test", $text[$u] & " - " & $test[$u])
Next

 


ill get to that... i still need to learn and understand a lot of codes graduated.gif

Correct answer, learn to walk before you take on that marathon.

Share this post


Link to post
Share on other sites
16 hours ago, RyukShini said:

Sorry That was a mistake not to declare.
After declaring the variables it still doesn't work.
$test[$u] does not change its value, it remains the same however $text[$i] changes.

As Melba mentioned (depending on how many strings are in text.txt) 

You wont see any change in $test[$u] until the loop has gone through all of text.txt stings. So if its a bumch it may take a while.

Make sense?

I prefer testing stuff like this with Consolewrite so the script doesn't have to stop:

#include <array.au3>
#include <file.au3>

Local $text
Local $test
_FileReadToArray(@ScriptDir & "\text.txt", $text) ; read the list of names to array
_FileReadToArray(@ScriptDir & "\test.txt", $test) ; read the list of names to array

For $u = 1 To UBound($test) - 1
    For $i = 1 To UBound($text) - 1

        ConsoleWrite("$text[$i] = " & $text[$i] & "$test[$u] = " & $test[$u])
    Next
Next

 

Share this post


Link to post
Share on other sites

Thanks a lot !
I got it to work.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now

  • Similar Content

    • ronmage
      By ronmage
      So I have a loop that keeps reading data from an array and searching it for the same value. If the value is no there it does work then adds the value to the array to prevent it from doing the same work.
      If _ArraySearch($ID,$filearray[$i]) = -1 Then Work.... _ArrayAdd($ID,$filearray[$i]) EndIf This is in a for loop hence $i
      So what is happening is the code works great for several hours. After a period of time _ArraySearch($ID,$filearray[$i]) will result in -1 even if $ID = $filearray. So it ready as if there is no data in the array. Anyone have this problem? 
       
      Also I am just running in using F5 not compiling it and running it if that makes a difference.
       
    • Ascer
      By Ascer
      1. Description.
      Udf working with MSDN System.Collections.ArrayList. Allow you to make fast operations on huge arrays, speed is even x10 better than basic _ArrayAdd.  Not prefered for small arrays < 600 items. 2. Requirements
      .NET Framework 1.1+ System Windows 3. Possibilities.
      ;=============================================================================================================== ; UDF Name: List.au3 ; ; Date: 2018-02-17, 10:52 ; Description: Simple udf to create System Collections as ArrayList and make multiple actions on them. ; ; Function(s): _ListCreate -> Creates a new list ; _ListCapacity -> Gets a list size in bytes ; _ListCount -> Gets items count in list ; _ListIsFixedSize -> Get bool if list if fixed size ; _ListIsReadOnly -> Get bool if list is read only ; _ListIsSynchronized -> Get bool if list is synchronized ; _ListGetItem -> Get item on index ; _ListSetItem -> Set item on index ; ; _ListAdd -> Add item at end of list ; _ListClear -> Remove all list items ; _ListClone -> Duplicate list in new var ; _ListContains -> Get bool if item is in list ; _ListGetHashCode -> Get hash code for list ; _ListGetRange -> Get list with items between indexs ; _ListIndexOf -> Get index of item ; _ListInsert -> Insert a new item on index ; _ListInsertRange -> Insert list into list on index ; _ListLastIndexOf -> Get index last of item ; _ListRemove -> Remove first found item ; _ListRemoveAt -> Remove item in index ; _ListRemoveRange -> Remove items between indexs ; _ListReverse -> Reverse all items in list ; _ListSetRange -> Set new value for items in range ; _ListSort -> Sort items in list (speed of reading) ; _ListToString -> Get list object name ; _ListTrimToSize -> Remove unused space in list ; ; Author(s): Ascer ;=============================================================================================================== 4. Downloads
      List.au3 5. Examples
      SpeedTest _ArrayAdd vs ListAdd SpeedTest ArraySearch vs ListIndexOf Basic usage - crating guild with members  
    • FMS
      By FMS
      Hello,
      I'm trying to read a binary file to an array but couln't get it to work.
      Also I coul not find any help in the forum around this subject whish was helpfull.
      Is there any way it could be done?
      I tried a lot of ways but maybe somebody know's the right way?
      #AutoIt3Wrapper_Au3Check_Parameters=-d -w 1 -w 2 -w 3 -w 4 -w 5 -w 6 -w 7 #include <File.au3> #include <Array.au3> #include <AutoItConstants.au3> Local $in=FileOpen("TEST_labels.idx1-ubyte",16) ; 16+0=Read binary Local $data = FileRead($in) Local $FileArray = BinaryToString($data,4) ;~ $FileArray = StringSplit($BinarydData, @CRLF, 1+2) ;~ Local $FileArray = StringRegExp($BinarydData, "[^\r\n]+", 3) FileClose($in) _ArrayDisplay($FileArray,"$FileArray","",32) MsgBox($MB_SYSTEMMODAL, "", "$FileArray = " & $FileArray )  
      TEST_labels.idx1-ubyte
    • ur
      By ur
      I am reading a CSV file which is tab seperated as below.
      Local $aArray = FileReadToArray($file) And now, I am splitting this main array record wise so that Array contains internally another arrow to represent each row.
      For $i = 0 to (UBound($aArray) - 1) ;MsgBox(0,"",$aArray[$i]) $aArray[$i] = StringSplit(StringStripCR($aArray[$i]), Chr(9),2);Chr(9) for tab ;_ArrayDisplay($aArray[$i]) Next Afther that, _ArrayDIsplay is able to see the individual internal arrays.
      _ArrayDisplay($aArray[1]) But If I try to access the individual element of it as below.It is not showing any result.
      MsgBox(0,"",$aArray[1][1]) Any suggestion, below is the sample csv file.
      New Text Document.csv
    • Jibsbrown
      By Jibsbrown
      Need some help understanding why the ConsoleWrite works inside 2nd For loop but not out side. Between Audit Wiki, Help file , Forum searching (lots of code reading), and YouTube ( shout out to TutsTeach), I have not been able to find the reason why. 
      $sIniPath = "installLog.ini" ; - Get section name $iniSctionNames = IniReadSectionNames($sIniPath) ; - Get Keys and Vaules For $a = 1 to UBound($iniSctionNames) - 1 $keys = IniReadSection($sIniPath , $iniSctionNames[$a]) For $b = 1 to UBound($keys) - 1 $oldSysInfo = IniRead($sIniPath , $iniSctionNames[1], $keys[$b][0], "") $PntIPInfo = IniRead($sIniPath , $iniSctionNames[2], $keys[$b][0], "") $NewPCInfor = IniRead($sIniPath , $iniSctionNames[3], $keys[$b][0], "") ;ConsoleWrite($oldSysInfo & @LF) Next ;ConsoleWrite($oldSysInfo & @LF) Next ConsoleWrite($oldSysInfo) My intention is to use the variables later for Listboxes. Any explanation, forum post links or whatever would help. Sorry also very very new to Autoit.
      Also here's the ini file.
      [OldSysInfo] 4=192.168.0.4|DESKTOP-RDIU2SN|R90M05Q8 5=192.168.0.5|SD0123456789101|R9WGP9P 6=192.168.0.6|SD0123456789102|R9WGP9PT 3=192.168.0.3|DESKTOP-3RS4LKL|R9WGP9P 23=192.168.0.23|SD0123456789102|MXL1234P5I [PrinterIp] 50=192.168.0.50 48=192.168.0.48 47=192.168.0.47 [NewSysInfo] newPC = SD0123456789adfs|192.168.0.185|2UA1234FTR Thank you for your time.