Question: How to Append Date/Time to File Name

[BasementDweller]

Hello,

I'm running Win7x64. I'm trying to append the system date and time to a file name (e.g., FileName.txt changed to FileNameYYYYMMDDHrMinSec.txt or similar, but time must at least include Seconds). I've search the forum and did find code that looks like it should work, though I'm not getting a result. There are no error messages. I know the path is correct because the MsgBox is displayed with the file isn't there. I hope someone can review the below and let me know what I'm missing.  Thank You!

$sPath = @ScriptDir&"\"
$tCur = _Date_Time_GetSystemTime()

If FileExists($sPath & "test.txt") Then
    FileMove ($sPath & "test.txt" , $sPath & "test" & _Date_Time_SystemTimeToDateTimeStr($tCur) & ".txt")
Else
    MsgBox (0, "Error", "No file")
EndIf

[FrancescoDiMuro]

@BasementDweller

ConsoleWrite("File_" & @YEAR & @MON & @MDAY & @HOUR & @MIN & @SEC & ".txt" & @CRLF)

Edited March 8, 2019 by FrancescoDiMuro

[BasementDweller]

@FrancescoDiMuro -- Thank you for the reply. I did write something similar to that during my testing, which does work. I was hoping to make my code Faster, Better, Stronger. If there's really no difference between the two options, I suppose I could go with the below. It would be nice to know, though, what I've done wrong in my original script.

$path = @ScriptDir&"\"

If FileExists ($path & "test.txt") Then
    FileMove ($path & "test.txt",$path & "test" & @YEAR & @MON & @MDAY & "_" & @HOUR & "." & @MIN & "." & @SEC & ".txt")  
Else
    MsgBox (0, "error", "no file")
EndIf

 

[BrewManNH]

_Date_Time_SystemTimeToDateTimeStr returns a string of mm/dd/yyyy hh:mm:ss, you can't use : or / in a file name.

[FrancescoDiMuro]

1 minute ago, BasementDweller said:

It would be nice to know, though, what I've done wrong in my original script.

You should have done something like this:

#include <Date.au3>
#include <WindowsConstants.au3>

Global $sPath = @ScriptDir&"\"
Global $tCur = _Date_Time_GetSystemTime()

MsgBox($MB_ICONINFORMATION, "", $sPath & "test" & StringRegExpReplace(_Date_Time_SystemTimeToDateTimeStr($tCur), '[/ :]', '') & ".txt")

[BasementDweller]

Quite informative answers. Much appreciated.

Thank you both!

[Bilgus]

Another option with a bit more flexibility

#include <Date.au3>
#include <WindowsConstants.au3>

Global $sPath = @ScriptDir&"\"
Global $tCur = _Date_Time_GetSystemTime()

MsgBox($MB_ICONINFORMATION, "", $sPath & "test" & _WinAPI_GetDateFormat(0, $tCur, 0, 'MM-dd-yyyy_') & _WinAPI_GetTimeFormat(0, $tCur, 0, 'HHmmss') & ".txt")