Subscript used on non-accessible variable

[badvs3vil]

Hello,

I am looking for a small bit of help.  I'm trying to get my script working in a Chrome window.  If I remove the resize code, my script will work fine and click the button that I want it to.  What I am trying to do is get it work if the window changes sizes or if the computer has a different resolution then what I created this on.  There probably is an easier way to do this but this is what I found by searching through the forums. 

When I run the code below and use my hotkey, I get this error.  Thanks in advance!!!!

"C:\Users\BaDvs3viL\Documents\asdasd.au3" (11) : ==> Subscript used on non-accessible variable.:
$return[0] = $size[1] * ($_x / $size[0])
$return[0] = $size^ ERROR

Here is my script.

HotKeySet("{1}", "Source1")

Func MsClick($tittle, $text, $controlid, $clickType, $clicks = 1, $x = 1, $y = 1)
    $coord = UiRatio($x, $y)
    ControlClick($tittle, $text, $controlid, $clickType, $clicks, $coord[0], $coord[1])
EndFunc   ;==>MsClick

Func UiRatio($_x, $_y)
    Dim $return[2]
    $size = WinGetClientSize("[CLASS:STUDIO | Producer - Google Chrome]") ; Must set so we can get windows' size
    $return[0] = $size[1] * ($_x / $size[0])
    $return[1] = $size[1] * ($_y / $size[1])
    Return $return
EndFunc   ;==>UiRatio

While 1
Sleep(100)
WEnd

Func Source1()
Opt("MouseCoordMode", 2)
MsClick("STUDIO | Producer - Google Chrome", "", "", "left", 1, 1282, 627)
MsClick("STUDIO | Producer - Google Chrome", "", "", "left", 1, 964, 312)

EndFunc

 

[BrewManNH]

It seems like WinGetClientSize can't find the window, probably because you're trying to look for the class of the window and its title at the same time. Pick one.

[badvs3vil]

You sir are correct on that.  I tested out the code using notepad instead and it worked.  I then switched back over to Chrome and now it clicks the button fine but it does not once I resize the window.  Thoughts?

 

HotKeySet("{1}", "Source1")

Func MsClick($tittle, $text, $controlid, $clickType, $clicks = 1, $x = 1, $y = 1)
    $coord = UiRatio($x, $y)
    ControlClick($tittle, $text, $controlid, $clickType, $clicks, $coord[0], $coord[1])
EndFunc   ;==>MsClick

Func UiRatio($_x, $_y)
    Dim $return[2]
    $size = WinGetClientSize("STUDIO | Producer - Google Chrome") ; Must set so we can get windows' size
    $return[0] = $size[0] * ($_x / $size[0])
    $return[1] = $size[1] * ($_y / $size[1])
    Return $return
EndFunc   ;==>UiRatio

While 1
Sleep(100)
WEnd

Func Source1()
Opt("MouseCoordMode", 2)
MsClick("STUDIO | Producer - Google Chrome", "", "", "left", 1, 1283, 628)
;MsClick("STUDIO | Producer - Google Chrome", "", "", "left", 1, 964, 312)

EndFunc

 

[BrewManNH]

21 minutes ago, badvs3vil said:

  Thoughts?

Do some error checking. Check to see if there's an error returned from WinGetClientSize before trying to return the array that isn't there.  You should do some error checking in MsClick as well in case the UIRatio function fails to find the window as well.

[badvs3vil]

@BrewManNH,

Thank you sir.  I am obvisly super new to this.  Can you give me any tips on adding in error checking?  I am looking at the documentation now.

Again, thank you.

[BrewManNH]

Every function should return either a valid return or sets the @error.

[Jojo-OP2]

9 hours ago, badvs3vil said:

@BrewManNH,

Thank you sir.  I am obvisly super new to this.  Can you give me any tips on adding in error checking?  I am looking at the documentation now.

Again, thank you.

HotKeySet("{1}", "Source1")

Func MsClick($tittle, $text, $controlid, $clickType, $clicks = 1, $x = 1, $y = 1)
    $coord = UiRatio($x, $y)
    If IsArray($coord) Then
        ControlClick($tittle, $text, $controlid, $clickType, $clicks, $coord[0], $coord[1])
    Else
        MsgBox(1, "Error", "UIRatio() didn't return an Array")
    EndIf
EndFunc   ;==>MsClick

Func UiRatio($_x, $_y)
    Dim $return[2]
    $size = WinGetClientSize("STUDIO | Producer - Google Chrome") ; Must set so we can get windows' size
    If @error Then ; If @error >= 1 then return
        Return
    Else
        $return[0] = $size[0] * ($_x / $size[0])
        $return[1] = $size[1] * ($_y / $size[1])
    EndIf
    Return $return
EndFunc   ;==>UiRatio

While 1
Sleep(100)
WEnd

Func Source1()
Opt("MouseCoordMode", 2)
MsClick("STUDIO | Producer - Google Chrome", "", "", "left", 1, 1283, 628)
;MsClick("STUDIO | Producer - Google Chrome", "", "", "left", 1, 964, 312)

EndFunc

 

When i'm inserting the code on the forum the formating doesn't look good, but if you paste it into Scite It should be fine

 

Edit : or you can be a better scripter than I am and follow BrewManNH recommandations and use SetError() to set your own error flag that you'll check after UiRatio() Returns

Edited April 22, 2019 by Jojo-OP2

[badvs3vil]

@Jojo-OP2,

So that code does indeed work and I can make it error by mistyping the title name.  However, it only clicks correctly when the window is maximized.  If I shrink the window at all, it doesn't find the new location.

Thoughts?