Need help with parameters

[Dawn99]

Hi- my current code will pull one line of engraving from the database but I need it to pull up to 2 lines. I tried changing it and got it to pull 2 lines IF there was 2 lines:

$eng2 = $engResult[2][0]
    $pieceEng &= $tag & ":font " & $font &" Line1: " & $eng & " :Line2: " & $eng2

but it was crashing if there was only one. How do I change it so it will pull as many lines as there are available? Here is what I have that pulls one line:

Func _Corel_lookup_engraving(ByRef $pieceEng, Const $pieceID, Const $tag)
    $engQuery = "SELECT engraving,Font FROM thm_layout_eng WHERE PieceID = " & $pieceID
    $engResult = _AQuery($dbConnection, $engQuery)
    If UBound($engResult)=1 Then
        Return(0)
    EndIf

    $eng = $engResult[1][0]
    $font = $engResult[1][1]
    
    ;Add a line break if previous engraving
    If StringLen($pieceEng) <> 0 Then
        $pieceEng &= @CRLF
    EndIf

    $pieceEng &= $tag & ":font " & $font &" Line1: " & $eng

    Return(0)
EndFunc

[seadoggie01]

Hi Dawn, and welcome!

You can check the length of the array returned using UBound...

; If the array has more than one row... see below
If UBound($engResult, 1) > 1 Then
    $eng2 = $engResult[2][0]
    $pieceEng &= $tag & ":font " & $font &" Line1: " & $eng & " :Line2: " & $eng2
EndIf

; Your array will look like this:
; [
;   ["line 1 cell 1", "line 1 cell 2"],
;   ["line 2 cell 1", "line 2 cell 2"]...
;]

And next time, it's helpful to put code in using our handy dandy code input tool... you'll see it looks like this <> when you're creating a post  

[Dawn99]

Thanks SeaDoggie- I changed it so it now reads:

Func _Corel_lookup_engraving(ByRef $pieceEng, Const $pieceID, Const $tag)
    ;Lookup engraving for this piece
    $engQuery = "SELECT engraving, Font FROM thm_layout_eng WHERE PieceID = " & $pieceID
    $engResult = _AQuery($dbConnection, $engQuery)
    If UBound($engResult)=1 Then
        Return(0)
    EndIf

    $eng = $engResult[1][0]
    $font = $engResult[1][1]
    
    ;Add a line break if previous engraving
    If StringLen($pieceEng) <> 0 Then
        $pieceEng &= @CRLF
    EndIf

    $pieceEng &= $tag & ": " & $eng

    If UBound($engResult, 1) > 1 Then
    $eng2 = $engResult[2][0]
    $pieceEng &= $tag & ":font " & $font &" Line1: " & $eng & " :Line2: " & $eng
    EndIf

Return(0)
EndFunc

But it crashed on the line that starts $eng2 with the error: "Array  variable has incorrect number of subscripts or subscript dimension range exceeded"

[seadoggie01]

Ooops, sorry, change the Ubound line to this: If UBound($engResult, 1) > 2 Then

I can't test the code and didn't look close enough, sorry

[Dawn99]

Thank you so muchSeadoggie!!!

I can not tell you how much time you saved me. I did have to change it a bit because it was duplicating line one so here is my final:

Func _Corel_lookup_engraving(ByRef $pieceEng, Const $pieceID, Const $tag)
    ;Lookup engraving for this piece
    $engQuery = "SELECT engraving, Font FROM thm_layout_eng WHERE PieceID = " & $pieceID
    $engResult = _AQuery($dbConnection, $engQuery)
    If UBound($engResult)=1 Then
        Return(0)
    EndIf

    $eng = $engResult[1][0]
    $font = $engResult[1][1]
    
    ;Add a line break if previous engraving
    If StringLen($pieceEng) <> 0 Then
        $pieceEng &= @CRLF
    EndIf

    $pieceEng &= $tag & ":font " & $font & ": " & $eng

    If UBound($engResult, 1) > 2 Then
    $eng2 = $engResult[2][0]
    $pieceEng &= $tag & " :Line2: " & $eng2
    EndIf

Return(0)
EndFunc

You are a life saver!