Misbehaving Do...Until loop

[leuce]

G'day everyone

I'm using Do...Until in a loop and I want the script to exit that loop when the time is ripe. However, the loop doesn't want to stop looping. Here's my code (the entire script is attached -- the additional programs in it are ResHack and XnView):

$a = 0

Do

;Some stuff here

If WinExists ("Dialog", "") Then
; Do some XYZ stuff
Else
$a = 1
EndIf

Until $a = 1

My reasoning is that once $a is 1, the Do loop should stop... right? But it doesn't. It continues even though the window "Dialog" no longer exists. Any ideas?

Thanks

Samuel

screencapscript2.zip

[SmOke_N]

You could always do it with a while/wend loop a bit different:

While 1
    If WinExists ("Dialog", "") Then
        WinActivate ("Dialog", "")
        WinWaitActive ("Dialog", "")
        Send ("!d")
        Sleep (100)
        $a = 1
    EndIf
    If Not WinExists('Dialog') And $a = 1 Then ExitLoop
WEnd

[ChrisL]

What about using a while loop

While WinExists ("Dialog", "")

;Do stuff

Wend

[theguy0000]

While WinExists("Dialog", "")
;stuff to do while the dialog exists;
WEnd

?

Edit: ChrisL beat me to it

Edited August 6, 2006 by theguy0000

[SmOke_N]

He had alot more stuff in that loop is why I suggested what I did.

[theguy0000]

He had alot more stuff in that loop is why I suggested what I did.

he's righht of course.

[PsaltyDS]

G'day everyone

I'm using Do...Until in a loop and I want the script to exit that loop when the time is ripe. However, the loop doesn't want to stop looping. Here's my code (the entire script is attached -- the additional programs in it are ResHack and XnView):

$a = 0

Do

;Some stuff here

If WinExists ("Dialog", "") Then
; Do some XYZ stuff
Else
$a = 1
EndIf

Until $a = 1

My reasoning is that once $a is 1, the Do loop should stop... right? But it doesn't. It continues even though the window "Dialog" no longer exists. Any ideas?

Thanks

Samuel

I think SmOke_N was closest, but the logic is changed my moving the $a=1. I would have dropped it completely and put:

While 1
    
    ; Other stuff from the original Do loop...

    If WinExists("Dialog", "") Then
        WinActivate("Dialog", "")
        WinWaitActive("Dialog", "")
        Send ("!d")
        Sleep (100)
    Else
        ExitLoop
    EndIf
WEnd

Allows you to check that the script gets to that code at all.

Edited August 6, 2006 by PsaltyDS