Quick question

[sunlord]

Anything wrong with this code?

;Rest of the code omitted
$MenuItem1 = GUICtrlCreateMenu("File")
$MenuItem2 = GUICtrlCreateMenuItem("Settings", $MenuItem1)
$MenuItem3 = GUICtrlCreateMenuItem("Exit", $MenuItem1)
$MenuItem4 = GUICtrlCreateMenu("&About")
GUICtrlSetState($From, $GUI_FOCUS)
Guisetonevent($GUI_EVENT_CLOSE, "Exit2")



GuiSetState(@SW_SHOW)
While 1
    $nMsg = GUIGetMsg()
        Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $MenuItem3
            RunSmtp()
            
        
    EndSwitch
    
    
        
WEnd

My menu doesn't work. If I click "Settings" under "File" its supposed to run the RunSmtp() function but nothing happens?

[BALA]

Did this help? I aligned the Switch with the EndSwitch

;Rest of the code omitted
$MenuItem1 = GUICtrlCreateMenu("File")
$MenuItem2 = GUICtrlCreateMenuItem("Settings", $MenuItem1)
$MenuItem3 = GUICtrlCreateMenuItem("Exit", $MenuItem1)
$MenuItem4 = GUICtrlCreateMenu("&About")
GUICtrlSetState($From, $GUI_FOCUS)
Guisetonevent($GUI_EVENT_CLOSE, "Exit2")



GuiSetState(@SW_SHOW)
While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $MenuItem3
            RunSmtp()
    EndSwitch
WEnd

Edited February 10, 2007 by BALA

[sunlord]

Nope......Same problem.

[BigDod]

Are you using GUISetOnEvent on the part of the script that we cant see. If so then GUIGetMsg and Switch will not work.

[sunlord]

I have these bits in the code. Do you mean one of them?

Opt("GUIOnEventMode", 1)

GUICtrlSetOnEvent($Send, "RunSmtp")

and

Guisetonevent($GUI_EVENT_CLOSE, "Exit2")

[sunlord]

^

[xcal]

Like BigDod said... "Are you using GUISetOnEvent on the part of the script that we cant see. If so then GUIGetMsg and Switch will not work."

You don't mix GUISetOnEvent and GuiGetMsg.

[sunlord]

So are you saying I'm not supposed to have this bit in the code?

Guisetonevent($GUI_EVENT_CLOSE, "Exit2")

Just that bit or anything more?

[xcal]

When you have GUIOnEventMode set to 1 (on), you can't use GuiGetMsg(). It always returns 0. Instead, you can create functions with GuiSetOnEvent($control, 'function').

You have to choose to either use GuiGetMsg() method for gui events, or GuiSetOnEvent(). Which you use depends on whether you have GuiOnEventMode on or off.

[sunlord]

Ahhhh ok. Yeah I see what you mean. That works. Thanks.

[improbability_paradox]

something that seems to have been overlooked: $MenuItem3 is the item "Exit", as per your code. You need to check if the $nMsg=$MenuItem2 ("Settings") to do anything with that menu item when it is clicked!

$MenuItem2 = GUICtrlCreateMenuItem("Settings", $MenuItem1)

$MenuItem3 = GUICtrlCreateMenuItem("Exit", $MenuItem1)

Case $MenuItem3

RunSmtp()

Edited February 10, 2007 by improbability_paradox

[sunlord]

I know , I was just testing if it actually works so I was just testing it with random functions in my script.