Help Needed! Please.

[SteveO]

Ok, i've got this posting code, that is suppose to check the GUI. It works great for the first check, but when I update the checkboxes, specifically when I uncheck a box, it still outputs the code of the unchecked section.

I have the following function set to a hotkey, so this is really the only code along with the GUI.

So basically it works when I check the boxes initially, but it doesn't work when I uncheck a box.

expandcollapse popup

Func Post()
    
        ;;Check the GUI
    $Message = GUICtrlRead($Edit1)
    $Random = GUICtrlRead($List1)
    $StartBB = GUICtrlRead($Input1)
    $EndBB = GUICtrlRead($Input2)
    $PostNumber = GUICtrlRead($Input3)
    $a1 = GUICtrlRead($Activate1)
    $a2 = GUICtrlRead($Activate2)
    $a3 = GUICtrlRead($Numberedbumps)
    
        ;; Output the correct option
    Select
    Case $a1 and $a2 and $a3 = $GUI_CHECKED
    Send($Message & "{ENTER}" & $Random  &$StartBB & " " & $PostNumber & $EndBB)
    
    Case $a1 and $a2 = $GUI_CHECKED 
    Send($Message & "{ENTER}" & $Random  )
        
    
    Case $a1 and $a3 = $GUI_CHECKED 
    Send($Message & $StartBB & " " & $PostNumber & $EndBB)
        
    
    Case $a2 and $a3 = $GUI_CHECKED 
    Send($Random & $StartBB & " " & $PostNumber & $EndBB)
        
    
    Case $a3 = $GUI_CHECKED
    Send($StartBB & $PostNumber & $EndBB)
    
    EndSelect
    
       ;;+1 to the post number
    GUICtrlSetData ($Input3, $PostNumber + 1)
EndFunc

Edited July 1, 2008 by SteveO

[dmob]

Try using this format:

CODE

Case BitAND($a1, $GUI_CHECKED) = $GUI_CHECKED

Edited July 1, 2008 by dalisuit

[SteveO]

Like this? Cause it didn't work.

Func Post()
    
    $Message = GUICtrlRead($Edit1)
    $Random = GUICtrlRead($List1)
    $StartBB = GUICtrlRead($Input1)
    $EndBB = GUICtrlRead($Input2)
    $PostNumber = GUICtrlRead($Input3)
    $a1 = GUICtrlRead($Activate1)
    $a2 = GUICtrlRead($Activate2)
    $a3 = GUICtrlRead($Numberedbumps)
    
    Select
    Case BitAND($a1 and $a2 and $a3, $GUI_CHECKED) = $GUI_CHECKED
    Send($Message & "{ENTER}" & $Random  &$StartBB & " " & $PostNumber & $EndBB)
    
    Case BitAND($a1 and $a2, $GUI_CHECKED) = $GUI_CHECKED
    Send($Message & "{ENTER}" & $Random  )
        
    Case BitAND($a1 and $a3, $GUI_CHECKED) = $GUI_CHECKED
    Send($Message & $StartBB & " " & $PostNumber & $EndBB)
        
    Case BitAND($a2 and $a3, $GUI_CHECKED) = $GUI_CHECKED
    Send($Random & $StartBB & " " & $PostNumber & $EndBB)
        
    Case BitAND($a3, $GUI_CHECKED) = $GUI_CHECKED
    Send($StartBB & $PostNumber & $EndBB)
    
    Case BitAND($a1, $GUI_CHECKED) = $GUI_CHECKED
    Send($StartBB & $PostNumber & $EndBB)
    
    EndSelect
    

    GUICtrlSetData ($Input3, $PostNumber + 1)
EndFunc

[PsaltyDS]

Please explain in plain language what you meant by this line. I suspect you misunderstand what "AND" is doing in a boolean context:

Case $a1 and $a2 and $a3 = $GUI_CHECKED

[SteveO]

Please explain in plain language what you meant by this line. I suspect you misunderstand what "AND" is doing in a boolean context:

Case $a1 and $a2 and $a3 = $GUI_CHECKED

Haha, if a1 and a2 and a3 are checked do the following.

[PsaltyDS]

Haha, if a1 and a2 and a3 are checked do the following.

I was afraid of that. What you are getting is: "If ($a1 = True) AND ($a2 = True) AND ($a3 = True) AND ($GUI_CHECKED = True) Then"

Try this instead:

If BitAND($a1, $a2, $3, $GUI_CHECKED) Then

[SteveO]

Ok, so it works to a point. The problem being since it goes down and checks the other statements, it'll output more than once for each true statement.

If BitAND($a1, $a2, $a3, $GUI_CHECKED) Then
    Send($Message & "{ENTER}" & $Random  &$StartBB & " " & $PostNumber & $EndBB)
    Endif
    
    If BitAND($a1, $a2, $GUI_CHECKED) Then
    Send($Message & "{ENTER}" & $Random  )
    Endif
    
    If BitAND($a1, $a3, $GUI_CHECKED) Then
    Send($Message & $StartBB & " " & $PostNumber & $EndBB)
    EndIf
    
    If BitAND($a2, $a3, $GUI_CHECKED) Then
    Send($Random & $StartBB & " " & $PostNumber & $EndBB)
    EndIf

    If BitAND($a3, $GUI_CHECKED) Then
    Send($StartBB & $PostNumber & $EndBB)
    EndIf

    If BitAND($a1, $GUI_CHECKED) Then
    Send($StartBB & $PostNumber & $EndBB)
    EndIf

[AdmiralAlkex]

You should use IfElse instead of multiple if's, see helpfile for examples and tell us if there is any problems!

[aslani]

Try this;

Select
    Case BitAND($a1, $a2, $a3, $GUI_CHECKED)
        Send($Message & "{ENTER}" & $Random  &$StartBB & " " & $PostNumber & $EndBB)
    
    Case BitAND($a1, $a2, $GUI_CHECKED)
        Send($Message & "{ENTER}" & $Random  )
        
    Case BitAND($a1, $a3, $GUI_CHECKED)
        Send($Message & $StartBB & " " & $PostNumber & $EndBB)
        
    Case BitAND($a2, $a3, $GUI_CHECKED)
        Send($Random & $StartBB & " " & $PostNumber & $EndBB)
        
    Case BitAND($a3, $GUI_CHECKED)
        Send($StartBB & $PostNumber & $EndBB)
        
    Case BitAND($a1, $GUI_CHECKED)
        Send($StartBB & $PostNumber & $EndBB)
EndSelect

[PsaltyDS]

Ok, so it works to a point. The problem being since it goes down and checks the other statements, it'll output more than once for each true statement.

If BitAND($a1, $a2, $a3, $GUI_CHECKED) Then
    Send($Message & "{ENTER}" & $Random  &$StartBB & " " & $PostNumber & $EndBB)
    Endif
    
    If BitAND($a1, $a2, $GUI_CHECKED) Then
    Send($Message & "{ENTER}" & $Random  )
    Endif
    
    If BitAND($a1, $a3, $GUI_CHECKED) Then
    Send($Message & $StartBB & " " & $PostNumber & $EndBB)
    EndIf
    
    If BitAND($a2, $a3, $GUI_CHECKED) Then
    Send($Random & $StartBB & " " & $PostNumber & $EndBB)
    EndIf

    If BitAND($a3, $GUI_CHECKED) Then
    Send($StartBB & $PostNumber & $EndBB)
    EndIf

    If BitAND($a1, $GUI_CHECKED) Then
    Send($StartBB & $PostNumber & $EndBB)
    EndIf

Then it did exactly what you told it to do in the code above. What did you mean for it to do, in plain language?

[aslani]

Then it did exactly what you told it to do in the code above. What did you mean for it to do, in plain language?

From what I understand he wants it to do the following;

Only If a1, a2 and a3 are checked, then send message1

Only If a1 and a2 are checked, but not a3, then send message2

Only If a1 and a3 are checked, but not a2, send message3

...

etc

That's why I offered a Select...Case...EndSelect option rather than a long If...ElseIf...Else....EndIf statement.

Edited July 1, 2008 by aslani

[SteveO]

Try this;

Select
    Case BitAND($a1, $a2, $a3, $GUI_CHECKED)
        Send($Message & "{ENTER}" & $Random  &$StartBB & " " & $PostNumber & $EndBB)
    
    Case BitAND($a1, $a2, $GUI_CHECKED)
        Send($Message & "{ENTER}" & $Random  )
        
    Case BitAND($a1, $a3, $GUI_CHECKED)
        Send($Message & $StartBB & " " & $PostNumber & $EndBB)
        
    Case BitAND($a2, $a3, $GUI_CHECKED)
        Send($Random & $StartBB & " " & $PostNumber & $EndBB)
        
    Case BitAND($a3, $GUI_CHECKED)
        Send($StartBB & $PostNumber & $EndBB)
        
    Case BitAND($a1, $GUI_CHECKED)
        Send($StartBB & $PostNumber & $EndBB)
EndSelect

Perfect. Thanks everyone for your input on this issue. =)