Help with my code

[Minikori]

I don't know why its not working, its for the next version of my keep awake script (which has so many changeable things I need to add the save function). Here's the code I have for the save parts:

EDIT: Changed the code to what you guys said and it still doesn't work.

If Not FileExists(@TempDir & "Settings.kaf") Then
    _FileCreate(@TempDir & "Settings.kaf")
    $File = FileOpen(@TempDir & "Settings.kaf", 1)
    FileWriteLine($File, "Regular")
    FileWriteLine($File, "1")
    FileWriteLine($File, "")
    FileWriteLine($File, "left")
    FileWriteLine($File, "1")
    FileWriteLine($File, "|")
    FileClose($File)
EndIf

...

If $SaveChk = $GUI_CHECKED Then
    $TimeSet = GUICtrlRead($Time)
    $CustomTimeSet = GUICtrlRead($CustomTimeInp)
    $Pixels = GUICtrlRead($UpDown)
    $KeySave = GUICtrlRead($KeyCom)
    _FileCreate(@TempDir & "Settings.kaf")
    $File = FileOpen(@TempDir & "Settings.kaf", 1)
    FileWriteLine($File, $TimeUse)
    FileWriteLine($File, $TimeSet)
    FileWriteLine($File, $CustomTimeSet)
    FileWriteLine($File, $RadSelected)
    FileWriteLine($File, $UpDown)
    FileWriteLine($File, $KeySave)
    FileClose($File)
EndIf

If you need more code to tell what I'm looking for let me know. By the way, I'm not getting AutoIt errors, it's just not saving the changes I guess.

Edited August 22, 2008 by Minikori

[billthecreator]

use iniwrite and iniread

[Minikori]

use iniwrite and iniread

I've tried the same exact code (basically) with iniwrite and iniread, it didn't work. Besides, I wanted my own file type.

[enaiman]

You need to close the file in order to see the changes.

IniRead and IniWrite works - if you haven't seen the results then you are surely make a mistake somewhere.

Another thing - your FileWriteLine calls are not correct. FileOpen returns a file handle to use later - I can't see any handle.

$MyFile = FileOpen(@TempDir & "Settings.kaf", 1)
    FileWriteLine($MyFile, "Regular")
...
FileClose($MyFile)

[Minikori]

You need to close the file in order to see the changes.

IniRead and IniWrite works - if you haven't seen the results then you are surely make a mistake somewhere.

Another thing - your FileWriteLine calls are not correct. FileOpen returns a file handle to use later - I can't see any handle.

$MyFile = FileOpen(@TempDir & "Settings.kaf", 1)
    FileWriteLine($MyFile, "Regular")
...
FileClose($MyFile)

Thank you so much!

[Minikori]

Edited the first post, please view.

[zorphnog]

Its hard to tell you whats going wrong when we don't have the full code. For instance, what is the $SaveChk variable? I assume its a handle to checkbox, but I have no idea what it truely is without the full code. Are you even sure that the If $SaveChk = $GUI_CHECKED condition is ever being met? If its a handle then you should be using If GUICtrlRead($SaveChk) = $GUI_CHECKED.

Also, you have no error checking whatsoever. You should be checking to see if the file is ever opened/created, i.e.

$File = FileOpen(@TempDir & "Settings.kaf", 2)
If $File = -1 Then ConsoleWrite("!> Error: Unable to open file (" & @TempDir & "Settings.kaf)" & @LF)

P.S. You don't have to use _FileCreate. FileOpen will create the file if it does not exist.

Edited August 22, 2008 by zorphnog

[Minikori]

Its hard to tell you whats going wrong when we don't have the full code. For instance, what is the $SaveChk variable? I assume its a handle to checkbox, but I have no idea what it truely is without the full code. Are you even sure that the If $SaveChk = $GUI_CHECKED condition is ever being met? If its a handle then you should be using If GUICtrlRead($SaveChk) = $GUI_CHECKED.

Also, you have no error checking whatsoever. You should be checking to see if the file is ever opened/created, i.e.

$File = FileOpen(@TempDir & "Settings.kaf", 2)
If $File = -1 Then ConsoleWrite("!> Error: Unable to open file (" & @TempDir & "Settings.kaf)" & @LF)

P.S. You don't have to use _FileCreate. FileOpen will create the file if it does not exist.

Thank you again, I will try this, and the $SaveChk is a GUICtrlCreateCheckBox.

[Minikori]

It works! My problem was that I need a GUICtrlRead(), thanks. but not, the $PixelSave always saves as 19, anyone know why?

EDIT: Fixed it.

Edited August 23, 2008 by Minikori