UDFs including Windows API show be modified !

[Ward]

Since AutoIt3A.exe (ANSI Version) will be removed in next release, I think that most UDFs including Windows API should be modified to use wildcard. For example, "str" -> "wstr", and SendMessage -> SendMessageW.

Why? Consider following code in WinAPI.au3:

Func _WinAPI_GetTextExtentPoint32($hDC, $sText)
    Local $tSize, $iSize, $aResult

    $tSize = DllStructCreate($tagSIZE)
    $iSize = StringLen($sText)
    $aResult = DllCall("GDI32.dll", "int", "GetTextExtentPoint32", "hwnd", $hDC, "str", $sText, "int", $iSize, "ptr", DllStructGetPtr($tSize))
    _WinAPI_Check("_WinAPI_GetTextExtentPoint32", ($aResult[0] = 0), 0, True)
    Return $tSize
EndFunc  ;==>_WinAPI_GetTextExtentPoint32

Here $iSize returned by StringLen() is count by wchar, but "GetTextExtentPoint32" is called in ANSI mode, so the result is always incorrect under DBCS systems.

The correct code should be:

$aResult = DllCall("GDI32.dll", "int", "GetTextExtentPoint32W", "hwnd", $hDC, "wstr", $sText, "int", $iSize, "ptr", DllStructGetPtr($tSize))

[Zedna]

Sounds logical.

Maybe this should be posted in Bug Track system as BUG.

Edited December 17, 2008 by Zedna

[ProgAndy]

There is no bug. The lenght of an ANSI string and an Unicode string is the same:

ANSI: 1 character: 1 TCHAR -> 1 byte

Unicode: 1 character: 1 WCHAR -> 2 bytes

--> Stringlen returns number of characters, not bytes.

so the size is correct, since the converted string has the same lengtht

"str", $sText -> string is given as ANSI

But it's a better codingstyle to use Unicode strings and functions in an Unicode application

//Edit: but i don't like the default behaviour of the WinAPI funcs uing Exit on Error. It would be better, if you could do error-handlang on your own (At least it should be possible turn off to app exit with a Global Variable.)

Edited December 17, 2008 by ProgAndy

[Ward]

There is no bug ONLY under NON-DBCS system.

In DBCS system, the same string may have different lengh returned by ANSI StringLen() or unicode StringLen().

In fact, the build-in _WinAPI_GetTextExtentPoint32() never get the correct result on my system. Furthermore, some UDF even crash the script because the buffer size of string is wrong. I always use the modified version by myself.

Edited December 18, 2008 by Ward

[ProgAndy]

Ah, OK. thought, the translation is done correctly in AutoIt...

But it's true, that GetExtendPoint won't work since Unicode characters are replaced with a placeholder wich can have an other size.