Reading file contents

[PcExpert]

The first thing I noticed is that when you go to Groepen -> Toevoegen it returns the checkboxes with texts like ' vk1' , 'vk2' and so on. It needs to have texts like 'vak1' (value read from vakken.ini'. Could you fix that for me? Thanks!

[Melba23]

PcExpert,

[rant]

As one of my American colleagues used to say: "Do you want fries with that?"!!!

In your image in Post #9 you had "vk1" etc next to your checkboxes!!!!!!!!

And in your own script in Func addvak() you have the line: $new_vak1 = "vk" & GUICtrlRead($vak1) & "," !!!!!!!!

So that is what I gave you!!!!!!!

[/rant]

Seriously, as far as I can see all you have to do is use the "Search - Replace" menu in SciTE. Make sure you have the "Match Whole Word Only" box ticked and then replace "vk" with "vak". I have looked at your script and it should hit all the right places.

M23

[PcExpert]

I'm sorry, my mistake. I solved that part now and everything seems to work OK now. Thanks for your help coding this

[Melba23]

PcExpert,

A pleasure.

M23

[PcExpert]

Its me again, I'm currently improving all my gui's. There are to many checkboxes being generated. I have this code:

expandcollapse popup

#include <GUIConstantsEx.au3>
#include <EditConstants.au3>
#include <GuiTreeView.au3>
#include <WindowsConstants.au3>

Global $CheckBox[31]

Global $top = 50
Global $left = 15
Global $count = 0
Global $vtotal = 1
Opt("GUIOnEventMode", 1)

$Gui_addgroup = GUICreate("MyGUI", 450, 275)
GUISetOnEvent($GUI_EVENT_CLOSE, "On_Exit") 
GUICtrlCreateLabel("Groepnaam:", 10, 10)
$newgroup = GUICtrlCreateInput("", 80, 7, 100, 20)
GUICtrlCreateGroup("Vakken", 10, 30, 430, 243)
GUICtrlCreateButton("OK", 350, 235, 80, 35)
GUICtrlSetOnEvent(-1, "GroupAddOK")
GUISetState(@SW_SHOW, $Gui_addgroup)

$vakken = IniRead("vakken.ini", "Algemeen", "Vakken", "")

If @error Then
    MsgBox(4096, "", "Error occurred, probably no INI file.")
Else
    
    For $i = 1 To 5
        $CheckBox[$i] = GUICtrlCreateCheckbox("vk" & $i, 45, $top, 50, 20) 
        $count += 1
        $top += 20
    Next
    $top = 50
    For $i = 6 To 10
        $CheckBox[$i] = GUICtrlCreateCheckbox("vk" & $i, 110, $top, 50, 20) 
        $count += 1
        $top += 20
    Next
    $top = 50
    For $i = 11 To 15
        $CheckBox[$i] = GUICtrlCreateCheckbox("vk" & $i, 175, $top, 50, 20) 
        $count += 1
        $top += 20
    Next
 $top = 50
    For $i = 16 To 20
        $CheckBox[$i] = GUICtrlCreateCheckbox("vk" & $i, 240, $top, 50, 20) 
        $count += 1
        $top += 20
    Next
    $top = 50
    For $i = 21 To 25
        $CheckBox[$i] = GUICtrlCreateCheckbox("vk" & $i, 305, $top, 50, 20) 
        $count += 1
        $top += 20
    Next
    $top = 50
    For $i = 26 To 30
        $CheckBox[$i] = GUICtrlCreateCheckbox("vk" & $i, 370, $top, 50, 20) 
        $count += 1
        $top += 20
    Next

 

 

    $vakken = StringReplace($vakken, "vk", "")
    $vakken_array = StringSplit($vakken, ",")
    
    For $i = 1 To 30
        If $vakken_array[$i] <> "" Then
            GUICtrlSetData($CheckBox[$i], $vakken_array[$i])
        EndIf
    Next

EndIf

While 1
    Sleep(100)
WEnd

Func On_Exit()
    ConsoleWrite("Exiting" & @CRLF)
    Exit
EndFunc

Func GroupAddOK()
    If GUICtrlRead($newgroup) = Not "" Then
        $newgr2 = ""
        For $f = $CheckBox[1] To $CheckBox[30]
            $newgr1 = BitAND(GUICtrlRead($f), $GUI_CHECKED)
            If $newgr1 = $GUI_CHECKED Then
                $newgr2 &= GUICtrlRead($f, 1) & ","
            EndIf
        Next        
        $ini_File = @ScriptDir & "\groepen\" & GUICtrlRead($newgroup) & ".ini"
        IniWrite($ini_file, "algemeen", "vakken", $newgr2)
    Else
        MsgBox(64, "Cijfer Registratie Systeem | Melding", "Vul AUB een geldige naam in voor de groep")
    EndIf
EndFunc  ;==>GroupAddOK

This code works, but it creates to many checkboxes. It has to generate the same number of checkboxes as there are professions.

Vakken.ini looks like this:

[algemeen]
vakken=vkAGF,vkSTM,vkRTF,vkMNE,vkBBK,vkCBO,vkDST,vkMEN,vkPWH,vk,vk,vk,vk,vk,vk,vk,vk,vk,vk,vk,vk,vk,



vk,vk,vk,vk,vk,vk,vk,vk,

as you can see there are 9 professions right now, for each profession it needs to create a checkbox. The problem is that it generates checkboxes also if there's no valid profession (only 'vk'). There's a maximum of 30 professions which all CAN be used, but not nessasary need to be, so the ' vk,vk,vk' entry's should stay. I just dont know how to limit the generated checkboxes so that they only create a checkbox when there's something behind the 'vk' entry.

Could you guys please help me out again?

Thanks!

P.S.

This code also changes the checkboxnames to names from the ini, finally.

Edited February 7, 2009 by PcExpert

[Melba23]

PcExpert,

Create $vakken_array before the checkboxes and the test the length of each element.

If StringLen($vakken_array[$i]) > 2 Then $CheckBox[$i] = GUICtrlCreateCheckbox(.....

Be careful to adjust the counts when you test the checkboxes in function GroupAddOK() - at the moment you just run from 1 to 30. Perhaps a counter to get the number of checkboxes you actually create:

; Before creating the checkboxes
$iCount = 0
...
If StringLen($vakken_array[$i]) > 2 Then
    $CheckBox[$i] = GUICtrlCreateCheckbox(.....
    $iCount += 1
Endif

M23

[PcExpert]

You're great! Thanks again

[Melba23]

PcExpert,

The multiple loops we came up with to create your checkboxes has been offending my programming sensibilities since the moment I saw them on screen! A little bit of thought has (I hope!) come up with a rather more elegant solution:

For $i = 1 To 30
    $CheckBox[$i] = GUICtrlCreateCheckbox"vk" & $i, 45 + 65 * Int(($i - 1)/5), 50 + 20 * Mod($i - 1, 5), 50, 20)
    $count += 1
Next

You can now delete all reference to $top.

M23