Sound volume

[Asd123456]

I've made this script but it doesn't work well. The VolumeDown function works great but VolumeUp does not, and I have no idea why.

#include <Audio.au3>

HotKeySet("^!{NumpadAdd}", "_VolumeUp")
HotKeySet("^!{NumpadSub}", "_VolumeDown")

_SoundSetMasterVolume(50)

While 1
    Sleep(1)
WEnd

Func _VolumeUp()
    $vol = _SoundGetMasterVolume()
    If Not $vol = 100 Then
        _SoundSetMasterVolume($vol + 5)
    EndIf
EndFunc   ;==>_VolumeUp

Func _VolumeDown()
    $vol = _SoundGetMasterVolume()
    If Not $vol = 0 Then
        _SoundSetMasterVolume($vol - 5)
    EndIf
EndFunc   ;==>_VolumeDown

[Melba23]

Asd123456,

It is a logic problem in your code with the Boolean NOT.

Your current code If Not $vol = 100 actually translates to If (Not $vol) = 100. As $vol is True (positive), using NOT will change it to False (zero), which is never equal to 100, and thus you never get the increase in $vol.

So change your code to If Not ($vol = 100) and all will well as you are now testing the equivalence of $vol and 100 - which is what you want. You should also change the similar line in the other function - it only works by chance because you are testing $vol against zero!

This can catch anyone out unless they are really experienced (and careful) so do not feel bad about it! >_< You need to be very particular about parentheses with Boolean operators. This topic shows how even quite experienced coders can get confused....

Personally I try to avoid using NOT in simple arithmetical expressions - in this case I would have used If $vol <> 100 instead.

M23

[Asd123456]

Asd123456,

It is a logic problem in your code with the Boolean NOT.

Your current code If Not $vol = 100 actually translates to If (Not $vol) = 100. As $vol is True (positive), using NOT will change it to False (zero), which is never equal to 100, and thus you never get the increase in $vol.

So change your code to If Not ($vol = 100) and all will well as you are now testing the equivalence of $vol and 100 - which is what you want. You should also change the similar line in the other function - it only works by chance because you are testing $vol against zero!

This can catch anyone out unless they are really experienced (and careful) so do not feel bad about it! >_< You need to be very particular about parentheses with Boolean operators. This topic shows how even quite experienced coders can get confused....

Personally I try to avoid using NOT in simple arithmetical expressions - in this case I would have used If $vol <> 100 instead.

M23

Thanks a lot M23