Error: Subscript used with non-Array variable

[ksmith247]

This is will be part of a larger script which will recursively search through directories and delete shortcuts pointing to a particular target. I do not know in which folder the shortcuts may be located (hence the recursive search) nor what they may be named (reason behind using the target path). I haven't begun to tackle the search part but am trying to get the piece to find the shortcut working.

I keep getting the error:

==> Subscript used with non-Array variable.:

If $aLinkInfo[0] = "C:\Program Files (x86)\CDBurnerXP\cdbxpp.exe" Then

If $aLinkInfo^ ERROR

I have tried several variations but can't seem to hit on the right one. Can someone please point me in teh right direction?

-Thanks.

#include <array.au3>
#include <file.au3>

$aLinkList = _FileListToArray(@DesktopCommonDir, "*.lnk")

For $link In $aLinkList
    $aLinkInfo = FileGetShortcut($link)
    If $aLinkInfo[0] = "C:\Program Files (x86)\CDBurnerXP\cdbxpp.exe" Then
        MsgBox(0, "", "Yes")
    Else
        MsgBox(0, "", "No")
    EndIf
Next

[99ojo]

This is will be part of a larger script which will recursively search through directories and delete shortcuts pointing to a particular target. I do not know in which folder the shortcuts may be located (hence the recursive search) nor what they may be named (reason behind using the target path). I haven't begun to tackle the search part but am trying to get the piece to find the shortcut working.

I keep getting the error:

==> Subscript used with non-Array variable.:

If $aLinkInfo[0] = "C:\Program Files (x86)\CDBurnerXP\cdbxpp.exe" Then

If $aLinkInfo^ ERROR

I have tried several variations but can't seem to hit on the right one. Can someone please point me in teh right direction?

-Thanks.

#include <array.au3>
#include <file.au3>

$aLinkList = _FileListToArray(@DesktopCommonDir, "*.lnk")

For $link In $aLinkList
    $aLinkInfo = FileGetShortcut($link)
    If $aLinkInfo[0] = "C:\Program Files (x86)\CDBurnerXP\cdbxpp.exe" Then
        MsgBox(0, "", "Yes")
    Else
        MsgBox(0, "", "No")
    EndIf
Next

Hi,

try this:

#include <array.au3>
#include <file.au3>

$aLinkList = _FileListToArray(@DesktopCommonDir, "*.lnk")

For $i = 1 To UBound ($aLinkList) - 1
    $aLinkInfo = FileGetShortcut(@DesktopCommonDir & "\" & $aLinkList [$i])
    If $aLinkInfo[0] = "C:\Program Files (x86)\CDBurnerXP\cdbxpp.exe" Then
        MsgBox(0, "", "Yes")
    Else
        MsgBox(0, "", "No")
    EndIf
Next

;-))

Stefan

[jvanegmond]

It is possible that FileGetShortcut fails and returns something not defined in the documentation (probably not an array, more likely number 0 or empty string). In this case it sets the @error flag to 1, you can check for this like so:

#include <array.au3>
#include <file.au3>

$aLinkList = _FileListToArray(@DesktopCommonDir, "*.lnk")

For $link In $aLinkList
    $aLinkInfo = FileGetShortcut($link)
    If Not @error Then
        If $aLinkInfo[0] = "C:\Program Files (x86)\CDBurnerXP\cdbxpp.exe" Then
            MsgBox(0, "", "Yes")
        Else
            MsgBox(0, "", "No")
        EndIf
    EndIf
Next

You have a very nice style of coding. Compliments. : )

[99ojo]

It is possible that FileGetShortcut fails and returns something not defined in the documentation (probably not an array, more likely number 0 or empty string). In this case it sets the @error flag to 1, you can check for this like so:

#include <array.au3>
#include <file.au3>

$aLinkList = _FileListToArray(@DesktopCommonDir, "*.lnk")

For $link In $aLinkList
    $aLinkInfo = FileGetShortcut($link)
    If Not @error Then
        If $aLinkInfo[0] = "C:\Program Files (x86)\CDBurnerXP\cdbxpp.exe" Then
            MsgBox(0, "", "Yes")
        Else
            MsgBox(0, "", "No")
        EndIf
    EndIf
Next

You have a very nice style of coding. Compliments. : )

Hi,

the first $link is the number of files returned by _FileListToArray.

So his FileGetShortname doesn't return an array. ==> Subscript used with non-Array variable

Also he need for FileGetShortCut the full path to lnk file. His _FileListToArray only returns filenames. ==> Subscript used with non-Array variable

-> New For Loop if he wants to use For ... In construction:

For $link In $aLinkList
    $aLinkInfo = FileGetShortcut(@DesktopCommonDir & "\" & $link)
    If IsArray ($aLinkInfo) Then
        If $aLinkInfo[0] = "C:\Program Files (x86)\CDBurnerXP\cdbxpp.exe" Then
            MsgBox(0, "", "Yes")
        Else
            MsgBox(0, "", "No")
        EndIf
    EndIf
Next

;-))

Stefan

Edited August 25, 2009 by 99ojo

[jvanegmond]

You're probably right, Stefan. I didn't analyze the full script, only cause and effect of the original problem and tried to repair that (I.E. the script I posted does not stop with array error anymore).