Jump to content

Progressbar not updating properly


Recommended Posts

Hi Guys,

I made a script that runs a loop through an excel sheet, extracts info, fills in a web page, submits. Then it extracts the results and puts it back into the spreadsheet.

I tried adding a progress bar, and it seems to update only through 100.

Meaning, if I input 5 rows, it will only show ~5% of the progress bar. If I do 300 rows, it fills the bar and continues working.

Seems like I didn't give GUICtrlSetData the right parameters.

Any suggestions is greatly appreciated.

#include <Excel.au3>
#include <IE.au3>
#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#include <Array.au3>
#include <ProgressConstants.au3>

$Form1 = GUICreate("TaxCodes", 316, 200, -1, -1, -1, BitOR($WS_EX_ACCEPTFILES, $WS_EX_WINDOWEDGE))
$Label1 = GUICtrlCreateLabel("Tax Code Retriever", 16, 16, 283, 20)
GUICtrlSetFont(-1, 12, 800, 4, "MingLiU")
$file = GUICtrlCreateInput("", 16, 56, 225, 21)
$Input2 = GUICtrlCreateInput("", 16, 107, 49, 21)
$Label2 = GUICtrlCreateLabel("Source file", 16, 39, 54, 17)
$Label3 = GUICtrlCreateLabel("Amount of rows", 17, 88, 77, 17)
$Button1 = GUICtrlCreateButton("Browse", 256, 56, 49, 25)
$Button2 = GUICtrlCreateButton("Process", 113, 105, 89, 25)
$prgrs = GUICtrlCreateProgress(20, 138, 275, 20, $PBS_SMOOTH)
$Label4 = GUICtrlCreateLabel("Tzvi Spitz - v1 - July '12", 100, 178, 115, 17)
GUICtrlSetFont(-1, 5, 400, 0, "MS Sans Serif")

While 1
$nMsg = GUIGetMsg()
Switch $nMsg
   ;Browse to select excel sheet
  Case $Button1
   $sfile = FileOpenDialog("Select enrollment file..", @WindowsDir & "\", "Excel File (*.csv;*.xlsx)", 1 + 4)
   GUICtrlSetData($file, $sfile)

  Case $Button2
   FileCopy($sfile, $sfile & ".bak", 1)
   $oIE = _IECreate(0, 0, 0)
   If $sfile = "" Then
    MsgBox(0, "", "Error!" & @CRLF & "You need to input the proper info!")
    ;open sheet read info to vars
    Local $oExcel = _ExcelBookOpen($sfile, 0)
    For $row = 2 To GUICtrlRead($Input2)
     GUICtrlSetData($prgrs, $row)
     Local $strt = _ExcelReadCell($oExcel, $row, 3)
     Local $zip = _ExcelReadCell($oExcel, $row, 6)
     Local $type = _ExcelReadCell($oExcel, $row, 16)
     ;Open IE instance, get elements
     _IENavigate($oIE, "http://www8.tax.ny.gov/UTLR/utlrHome")
     $o_form = _IEFormGetObjByName($oIE, "UTLRForm")
     $o_addr = _IEFormElementGetObjByName($o_form, "UTLR_STREETADDRESS_KEY")
     $o_zip = _IEFormElementGetObjByName($o_form, "UTLR_ZIPCODE_KEY")
     $o_type = _IEFormElementGetObjByName($o_form, "UTLR_SERVICETYPE_KEY")

     ; Set IE field values and submit the form
     _IEFormElementSetValue($o_addr, $strt)
     _IEFormElementSetValue($o_zip, $zip)
     If $type = "Commercial" Then
      _IEFormElementSetValue($o_type, "Commercial energy services")
      _IEFormElementSetValue($o_type, "Residential energy services")
     ;if not successfull
     If StringRegExp(_IEBodyReadText($oIE), 'No matches were found for the address you entered.') Then
      _ExcelWriteCell($oExcel, "ERROR", $row, 23)
     Else ;if succesfull write output to excel
      $aJurisdictionCodes = StringRegExp(_IEBodyReadText($oIE), 'Jurisdiction code:(.*)', 1)
      _ExcelWriteArray($oExcel, $row, 23, $aJurisdictionCodes, 1, 0)
      $o_form2 = _IEFormGetObjByName($oIE, "utlrHome")
   MsgBox(0, "yawn", "All done here, G'nite!")
Link to comment
Share on other sites

You need to use a percentage and not an absolute value. Try this change

Local $Percent = ($row / GUICtrlRead($Input2)) * 100 ; add this line
     GUICtrlSetData($prgrs, $Percent) ; change this line

If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Link to comment
Share on other sites

This is antiflicker optimization important especially when there are many rows (loops)

In such case there should be done updating of progressbar only when percent (round to 0) is changed:

Global $Percent, $Percent_prev

                 $Percent = Round(($row / GUICtrlRead($Input2)) * 100, 0)
                    If $Percent <> $Percent_prev Then
                        GUICtrlSetData($prgrs, $Percent)
                        $Percent_prev = $Percent
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Create New...