Sign in to follow this  
Followers 0
xuzo

How to "insert" $Countlines into a loop

8 posts in this topic

#1 ·  Posted (edited)

I'm trying to have something loop the amount of lines in the text file.

So if the text file has 3 lines, I want 3 loops etc...

I'm doing something wrong with this I think:

For $numberoflines = 1 To $numberoflines Step 1

The whole thing is this:

#include <File.au3>
#include <Clipboard.au3>
Local $CountLines = _FileCountLines(@ScriptDir & "input.txt")
$numberoflines = $CountLines; $Countlines is now $numberoflines
ShellExecute("notepad.exe", @ScriptDir & "input.html")
WinWait("input - Notepad")
ShellExecute("notepad.exe", @ScriptDir & "output.html")
WinWait("output - Notepad")
WinActivate("input - Notepad")
Send("{CtrlDown}{Home}{CtrlUp}{left}")
For $numberoflines = 1 To $numberoflines Step 1
WinActivate("input - Notepad")
Send("{SHIFTDOWN}{END}{SHIFTUP}{CTRLDOWN}c{CTRLUP}")
$sclip = ClipGet()
Send("{DOWN}{HOME}")
WinActivate("output - Notepad")
Send('<a href="' & $sclip & '">' & $sclip & "</a>{enter}")
Next
Edited by xuzo

Share this post


Link to post
Share on other sites



You're using the variable $numberoflines incorrectly.

For $numberoflines = 1 To $numberoflines Step 1

You can't use it as the loop variable AND the end of the loop at the same time, change the variable name for one of them.

Also, there's no need to use Step 1 in a For Next loop, the default is to increase by 1 already, so it's redundant.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

#3 ·  Posted (edited)

Thanks Brewman but I still don't get it...I've tried all posible combinations ;(

For $Countlines

For $Countlines = $numberoflines

For $CountLines = 1

For $CountLines = 1 to $CountLines

For $CountLines = 1 to $numberoflines

What is the correct syntax to do this?

Edited by xuzo

Share this post


Link to post
Share on other sites

xuzo,

I would name the variables more clearly.

#include <File.au3>

Local $NumOfLines = _FileCountLines(@ScriptDir & "\Test.au3") ; get number of lines
Local $Line

For $Line = 1 To $NumOfLines
; add here what to do
Next

A-Jay


Rule #1: Always do a backup         Rule #2: Always do a backup (backup of rule #1)

Share this post


Link to post
Share on other sites

#5 ·  Posted (edited)

xuzo

your last try was okay.

In the folowing example "$i" is the counting variable.

For $i = 1 To $numberoflines
        MsgBox(0,"line", "lin number: " & $i)
Next
Edited by hannes08

Regards,Hannes[spoiler]If you can't convince them, confuse them![/spoiler]

Share this post


Link to post
Share on other sites

#6 ·  Posted (edited)

Thanks Ajag, this works for me:

#include
Local $NumOfLines = _FileCountLines(@ScriptDir & "input.txt") ; get number of lines
Local $Line
For $Line = 1 To $NumOfLines
MsgBox(0, "t", "The file has 3 lines and will pop up 3 times")
Next

Could it be that my mistake was this:

Local $CountLines = _FileCountLines(@ScriptDir & "input.txt")
$numberoflines = $CountLines

Instead of this:

Local $CountLines = _FileCountLines(@ScriptDir & "input.txt")
Local $numberoflines
Edited by xuzo

Share this post


Link to post
Share on other sites

Personally I would read the file into an Array, and then manipulate the array as you need.

#include <File.au3>

Local $aArray
_FileReadToArray(@DesktopDir & "Test.txt", $aArray)

   For $i = 0 To UBound($aArray)
     MsgBox(0, "Line " & $i, "The file has " & UBound($aArray) & " lines.")
   Next

√-1 2^3 ∑ π, and it was delicious!

Share this post


Link to post
Share on other sites

Use the _FileReadToArray() method as pointed out by JLogan3o13 above and take a look at the For/In/Next method from the help file.

#include <File.au3>

Local $aArray, $Line
_FileReadToArray(@DesktopDir & "Test.txt", $aArray)
 
For $Line In $aArray
     ;; Do something here
Next

George

Question about decompiling code? Read the decompiling FAQ and don't bother posting the question in the forums.

Be sure to read and follow the forum rules. -AKA the AutoIt Reading and Comprehension Skills test.***

The PCRE (Regular Expression) ToolKit for AutoIT - (Updated Oct 20, 2011 ver:3.0.1.13) - Please update your current version before filing any bug reports. The installer now includes both 32 and 64 bit versions. No change in version number.

Visit my Blog .. currently not active but it will soon be resplendent with news and views. Also please remove any links you may have to my website. it is soon to be closed and replaced with something else.

"Old age and treachery will always overcome youth and skill!"

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0