Jewtus Posted July 1, 2014 Posted July 1, 2014 I'm working with two csv files that I'm parsing into two arrays. I'm then comparing them to find the duplication and remove them from the first array. This works great on 100 or so records, but I'm trying to compare arrays with more than 70,000 records so I wanted to add in a loading bar so I can tell how far/how much longer it will take. This is my code: ProgressSet(0,0&"%","Checking already searched") $aProcess = _ParseCSV($oOutfile,"|","",0) $aAlreadyChecked = _ParseCSV($AlreadyProcessed,"|","",0) For $a = UBound($aProcess) -1 to 0 Step -1 for $b = 0 to UBound($aAlreadyChecked) -1 if $aProcess[$a][0] = $aAlreadyChecked[$b][0] Then _ArrayDelete($aProcess, $a) MsgBox(0,"",($a-UBound($aProcess)) & @TAB & $b) ProgressSet(($b/$a),Round($b/$a)&"%","Cleaning up") ExitLoop EndIf Next Next I cannot get the percentage logic to show anything that seems rational or accurate. Does anyone know of a more efficient way of doing this or how to fix the progressset to actually show how far in the process it already is?
UEZ Posted July 1, 2014 Posted July 1, 2014 (edited) Is that working for you?expandcollapse popup#include <Array.au3> Global $array1[100000], $array2[111111], $i, $t, $fProgress ConsoleWrite("Creating test array... ") $t = TimerInit() For $i = 0 To UBound($array1) - 1 $array1[$i] = Random(0, 100000, 1) $array2[$i] = Random(0, 111111, 1) Next ConsoleWrite("done in " & Round(TimerDiff($t), 2) & " ms." & @CRLF) Global $aResult = ArrayCompare($array1, $array2) ConsoleWrite(UBound($aResult) & @CRLF) ;~ _ArrayDisplay($aResult) Func ArrayCompare(ByRef $a1, $a2) ConsoleWrite("Sorting 2nd array... ") Local $t = TimerInit() _ArraySort($a2) ConsoleWrite("done in " & Round(TimerDiff($t), 2) & " ms." & @CRLF) Local $i, $c = 0, $iUB = UBound($a1) > UBound($a2) ? UBound($a1) : UBound($a2), $aNew[$iUB], $iUB = UBound($a1) - 1 ConsoleWrite("Searching " & $iUB & " elements in " & UBound($a2) - 1 & " elements ... ") AdlibRegister("Show_Progress", 500) $fProgress = 0 ProgressOn("Progress Meter", "Be patient, searching for duplicates...", "0%") $t = TimerInit() For $i = 0 To $iUB If _ArrayBinarySearch($a2, String($a1[$i])) > -1 Then ContinueLoop Else $aNew[$c] = $a1[$i] $c += 1 EndIf $fProgress = $i / $iUB * 100 Next ReDim $aNew[$c] ConsoleWrite("done in " & Round(TimerDiff($t), 2) & " ms." & @CRLF & @CRLF) AdlibUnRegister("Show_Progress") ProgressOff() Return $aNew EndFunc Func Show_Progress() ProgressSet($fProgress, StringFormat("%.2f %", $fProgress)) EndFuncBr,UEZ Edited July 1, 2014 by UEZ JScript 1 Please don't send me any personal message and ask for support! I will not reply! Selection of finest graphical examples at Codepen.io The own fart smells best! ✌Her 'sikim hıyar' diyene bir avuç tuz alıp koşma!¯\_(ツ)_/¯ ٩(●̮̮̃•̃)۶ ٩(-̮̮̃-̃)۶ૐ
Jewtus Posted July 2, 2014 Author Posted July 2, 2014 I tried replacing the arrays but they are 2D arrays so I get an error "array variable has incorrect number of subscripts or subscript dimensions range exceeded" What would I need to do it fix that? I tried this: expandcollapse popupGlobal $i, $t, $fProgress ConsoleWrite("Creating test array... ") $t = TimerInit() Global $aResult = ArrayCompare($aProcess, $aAlreadyChecked) ConsoleWrite(UBound($aResult) & @CRLF) _ArrayDisplay($aResult) Func ArrayCompare(ByRef $a1, $a2) ConsoleWrite("Sorting 2nd array... ") Local $t = TimerInit() _ArraySort($a2) ConsoleWrite("done in " & Round(TimerDiff($t), 2) & " ms." & @CRLF) Local $i, $c = 0, $iUB = UBound($a1) > UBound($a2) ? UBound($a1) : UBound($a2), $aNew[$iUB], $iUB = UBound($a1) - 1 ConsoleWrite("Searching " & $iUB & " elements in " & UBound($a2) - 1 & " elements ... ") AdlibRegister("Show_Progress", 500) $fProgress = 0 ProgressOn("Progress Meter", "Be patient, searching for duplicates...", "0%") $t = TimerInit() For $i = 0 To $iUB If _ArrayBinarySearch($a2, String($a1[$i][0])) > -1 Then ContinueLoop Else $aNew[$c] = $a1[$i][0] $c += 1 EndIf $fProgress = $i / $iUB * 100 Next ReDim $aNew[$c] ConsoleWrite("done in " & Round(TimerDiff($t), 2) & " ms." & @CRLF & @CRLF) AdlibUnRegister("Show_Progress") ProgressOff() Return $aNew EndFunc Func Show_Progress() ProgressSet($fProgress, StringFormat("%.2f %", $fProgress)) EndFunc which seems to function, but it doesn't seem to be able to see the difference in the two files. The result array ends up being a 1D version of the first array.
kylomas Posted July 2, 2014 Posted July 2, 2014 Jewtus, I'm then comparing them to find the duplication Please define what you mean by "duplication"... kylomas Forum Rules Procedure for posting code "I like pigs. Dogs look up to us. Cats look down on us. Pigs treat us as equals." - Sir Winston Churchill
Jewtus Posted July 2, 2014 Author Posted July 2, 2014 (edited) Something that exists in both arrays EX: Array1 [1,2,3,4] Array2 [3,4,5,6] I want to remove 3 and 4 from array1 because they exist in both lists. Edited July 2, 2014 by Jewtus
kylomas Posted July 2, 2014 Posted July 2, 2014 Jewtus, These are 1D arrays. In post #3 you allude to a 2D aray. Do you want to eliminate dups anywhere they exist, or, only by column? kylomas Forum Rules Procedure for posting code "I like pigs. Dogs look up to us. Cats look down on us. Pigs treat us as equals." - Sir Winston Churchill
Jewtus Posted July 3, 2014 Author Posted July 3, 2014 I want to eliminate the entire row if there is a match in the first column I'm looking at search results and I'm comparing them to a new set of search results, but I'm trying to avoid doing more work on the results that I've already processed.
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now