Trong Posted April 13, 2015 Share Posted April 13, 2015 (edited) Please help me to convert and optimize this code: Local $sPath = 'c:\\ Aloha\Ciao \XinChao"\Hello My Friend' While 1 If ((StringInStr($sPath, " \") = 0) And (StringInStr($sPath, '"') = 0) And (StringInStr($sPath, "\\") = 0) And (StringInStr($sPath, "\ ") = 0)) Then ExitLoop $sPath = StringReplace($sPath, "\\", "\") $sPath = StringReplace($sPath, "\ ", "\") $sPath = StringReplace($sPath, " \", "\") $sPath = StringReplace($sPath, '"', '') WEnd ConsoleWrite($sPath &@CRLF) ; ; ; ; ; ; ; ; ; ; ; ; ; ; ; ; ; Edited April 13, 2015 by Trong Regards, Link to comment Share on other sites More sharing options...
iamtheky Posted April 13, 2015 Share Posted April 13, 2015 (edited) $sPath = 'c:\\ Aloha\Ciao \XinChao"\Hello' msgbox(0, '' , stringreplace(stringreplace(stringstripws($sPath , 8) , '"' , "") , "\\" , "\")) Edited April 13, 2015 by boththose Trong 1 ,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-. |(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/ (_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_) | | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) ( | | | | |)| | \ / | | | | | |)| | `--. | |) \ | | `-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_| '-' '-' (__) (__) (_) (__) Link to comment Share on other sites More sharing options...
Trong Posted April 13, 2015 Author Share Posted April 13, 2015 (edited) Thanks boththose, but, stringstripws is not allowed to use for paths. Edited April 13, 2015 by Trong Regards, Link to comment Share on other sites More sharing options...
BrewManNH Posted April 13, 2015 Share Posted April 13, 2015 Thanks boththose, but, stringstripws is not allowed to use for paths. Who says so? Did you even TRY to run the code posted? If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
iamtheky Posted April 13, 2015 Share Posted April 13, 2015 (edited) shellexecute("c:\temp \test") ;~ is the same As shellexecute("c:\temp\test") but trailing spaces dont matter at all, and you care about those? @Brewman, I think he was just saying I would bone paths that had spaces in the middle of a directory (of which there were none in the example). I forget about that routinely because I usually 8.3 everything first. Edited April 13, 2015 by boththose ,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-. |(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/ (_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_) | | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) ( | | | | |)| | \ / | | | | | |)| | `--. | |) \ | | `-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_| '-' '-' (__) (__) (_) (__) Link to comment Share on other sites More sharing options...
Trong Posted April 13, 2015 Author Share Posted April 13, 2015 (edited) @BrewManNH Someone or myself ^^. Of course. I've tried. Path include spaces, Remove space => Error. Right? @boththose I tried to fix the wrong path! shellexecute("c:\temp \test You") ;~ is the same As ???? shellexecute("c:\temp\testYou") Edited April 13, 2015 by Trong Regards, Link to comment Share on other sites More sharing options...
iamtheky Posted April 13, 2015 Share Posted April 13, 2015 (edited) $sPath = 'c:\\ Alo ha\Ciao \XinChao"\Hello' $aPath = stringsplit($sPath , "\" , 2) $sOut = $aPath[0] For $i = 1 to ubound($aPath) - 1 If stringlen($aPath[$i]) > 1 Then $sOut &= "\" & stringregexpreplace(stringstripws($aPath[$i] , 3) , '\\|\/|\:|\*|\?|\"|\<|\>|\||' , "") Next msgbox(0, '' , $sOut) If you want all the rules, i think you may have to bust it up first. At least until a regex wizard shows up. And I was just showing that your stringreplace that handled trailing spaces was unnecessary. Edited April 13, 2015 by boththose Trong 1 ,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-. |(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/ (_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_) | | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) ( | | | | |)| | \ / | | | | | |)| | `--. | |) \ | | `-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_| '-' '-' (__) (__) (_) (__) Link to comment Share on other sites More sharing options...
BrewManNH Posted April 13, 2015 Share Posted April 13, 2015 Where are these paths coming from that they're so F'd up? I'd start with the source rather than trying to fix something that poorly formatted in a script. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
jchd Posted April 13, 2015 Share Posted April 13, 2015 E.g. "C:Program Files (x86)", "C:WindowsDownloaded Program Files" and so many others. This wonderful site allows debugging and testing regular expressions (many flavors available). An absolute must have in your bookmarks.Another excellent RegExp tutorial. Don't forget downloading your copy of up-to-date pcretest.exe and pcregrep.exe hereRegExp tutorial: enough to get startedPCRE v8.33 regexp documentation latest available release and currently implemented in AutoIt beta. SQLitespeed is another feature-rich premier SQLite manager (includes import/export). Well worth a try.SQLite Expert (freeware Personal Edition or payware Pro version) is a very useful SQLite database manager.An excellent eBook covering almost every aspect of SQLite3: a must-read for anyone doing serious work.SQL tutorial (covers "generic" SQL, but most of it applies to SQLite as well)A work-in-progress SQLite3 tutorial. Don't miss other LxyzTHW pages!SQLite official website with full documentation (may be newer than the SQLite library that comes standard with AutoIt) Link to comment Share on other sites More sharing options...
BrewManNH Posted April 13, 2015 Share Posted April 13, 2015 I was referring to the path in the OP, not in general. Obviously I know that there are paths with spaces in them, just not as poorly formatted as the one in the OP. That path has to be coming from somewhere, because that isn't a valid Windows path. Trong 1 If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
kylomas Posted April 13, 2015 Share Posted April 13, 2015 another way... local $op = 'c:\\ Alo ha\Ciao \Xi nChao"\ Hello' local $np = stringregexpreplace(stringregexpreplace($op,'\\ +| +\\','\\'),'\\+','\\') ConsoleWrite($op & @LF & $np & @CRLF) kylomas Trong 1 Forum Rules Procedure for posting code "I like pigs. Dogs look up to us. Cats look down on us. Pigs treat us as equals." - Sir Winston Churchill Link to comment Share on other sites More sharing options...
mikell Posted April 13, 2015 Share Posted April 13, 2015 kylomas, you forgot the " $sPath = 'c:\\ Alo ha\Ciao \XinChao"\Hello' msgbox(0, '' , stringregexpreplace($sPath, '(\\?"?\s*\\\s*)', "\\")) Trong 1 Link to comment Share on other sites More sharing options...
Solution jguinch Posted April 13, 2015 Solution Share Posted April 13, 2015 @Mikell : yours works because the " is just before a StringReplace( StringRegExpReplace($sPath, '\h*\\+\h*', '\\'), '"', '') ) Trong 1 Spoiler Network configuration UDF, _DirGetSizeByExtension, _UninstallList Firefox ConfigurationArray multi-dimensions, Printer Management UDF Link to comment Share on other sites More sharing options...
kylomas Posted April 13, 2015 Share Posted April 13, 2015 (edited) mikell - What do you mean? It picked up the quote when I tested it... Nevermind, missed the fact that the OP wanted to get rid of the quote... Edited April 13, 2015 by kylomas Trong 1 Forum Rules Procedure for posting code "I like pigs. Dogs look up to us. Cats look down on us. Pigs treat us as equals." - Sir Winston Churchill Link to comment Share on other sites More sharing options...
Trong Posted April 14, 2015 Author Share Posted April 14, 2015 Thanks @kylomas, @mikell, @jguinch and @BrewManNHWhere can I find documentation for RegExp AutoIT? Regards, Link to comment Share on other sites More sharing options...
jguinch Posted April 14, 2015 Share Posted April 14, 2015 @Trong : the help file is good, and the forum too. There are a lot of websites with examples and tools to help with regex. These two websites should help you : - http://www.rexegg.com/ - https://regex101.com/ Trong 1 Spoiler Network configuration UDF, _DirGetSizeByExtension, _UninstallList Firefox ConfigurationArray multi-dimensions, Printer Management UDF Link to comment Share on other sites More sharing options...
mikell Posted April 14, 2015 Share Posted April 14, 2015 May I add this must third one : http://www.regular-expressions.info/ Trong 1 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now