VIP

Help optimize and convert code to StringRegExpReplace

17 posts in this topic

#1 ·  Posted (edited)

Please help me to convert and optimize this code:

 

Local $sPath = 'c:\\ Aloha\Ciao \XinChao"\Hello My Friend'
    While 1
        If ((StringInStr($sPath, " \") = 0) And (StringInStr($sPath, '"') = 0) And (StringInStr($sPath, "\\") = 0) And (StringInStr($sPath, "\ ") = 0)) Then ExitLoop
        $sPath = StringReplace($sPath, "\\", "\")
        $sPath = StringReplace($sPath, "\ ", "\")
        $sPath = StringReplace($sPath, " \", "\")
        $sPath = StringReplace($sPath, '"', '')
    WEnd
    ConsoleWrite($sPath &@CRLF)
;
;
;
;
;
;
;
;
;
;
;
;
;
;
;
;
;
Edited by Trong

Regards,
 

Share this post


Link to post
Share on other sites



#2 ·  Posted (edited)

$sPath = 'c:\\ Aloha\Ciao \XinChao"\Hello'
msgbox(0, '' , stringreplace(stringreplace(stringstripws($sPath , 8) , '"' , "") , "\\" , "\"))

Edited by boththose
1 person likes this

,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites

#3 ·  Posted (edited)

Thanks boththose,
but, stringstripws  is not allowed to use for paths.

Edited by Trong

Regards,
 

Share this post


Link to post
Share on other sites

Thanks boththose,

but, stringstripws  is not allowed to use for paths.

Who says so?

Did you even TRY to run the code posted?


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

#5 ·  Posted (edited)

shellexecute("c:\temp     \test")

;~ is the same As

shellexecute("c:\temp\test") 

but trailing spaces dont matter at all, and you care about those?

 

 

@Brewman,   I think he was just saying I would bone paths that had spaces in the middle of a directory (of which there were none in the example).  I forget about that routinely because I usually 8.3 everything first.

 

Edited by boththose

,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites

#6 ·  Posted (edited)

@BrewManNH
Someone or myself ^^.
Of course. I've tried.

Path include spaces, Remove space => Error. Right?


@boththose
I tried to fix the wrong path!

shellexecute("c:\temp     \test You")

;~ is the same As ????

shellexecute("c:\temp\testYou")
Edited by Trong

Regards,
 

Share this post


Link to post
Share on other sites

#7 ·  Posted (edited)

$sPath = 'c:\\ Alo ha\Ciao \XinChao"\Hello'


$aPath = stringsplit($sPath , "\" , 2)

$sOut = $aPath[0]

For $i = 1 to ubound($aPath) - 1
    If stringlen($aPath[$i]) > 1 Then $sOut &= "\" & stringregexpreplace(stringstripws($aPath[$i] , 3) , '\\|\/|\:|\*|\?|\"|\<|\>|\||' , "")
Next

msgbox(0, '' , $sOut)

If you want all the rules, i think you may have to bust it up first.  At least until a regex wizard shows up. 

 

And I was just showing that your stringreplace that handled trailing spaces was unnecessary.

Edited by boththose
1 person likes this

,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites

Where are these paths coming from that they're so F'd up? I'd start with the source rather than trying to fix something that poorly formatted in a script.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

E.g. "C:Program Files (x86)", "C:WindowsDownloaded Program Files" and so many others.


This wonderful site allows debugging and testing regular expressions (many flavors available). An absolute must have in your bookmarks.
Another excellent RegExp tutorial. Don't forget downloading your copy of up-to-date pcretest.exe and pcregrep.exe here
RegExp tutorial: enough to get started
PCRE v8.33 regexp documentation latest available release and currently implemented in AutoIt beta.

SQLitespeed is another feature-rich premier SQLite manager (includes import/export). Well worth a try.
SQLite Expert (freeware Personal Edition or payware Pro version) is a very useful SQLite database manager.
An excellent eBook covering almost every aspect of SQLite3: a must-read for anyone doing serious work.
SQL tutorial (covers "generic" SQL, but most of it applies to SQLite as well)
A work-in-progress SQLite3 tutorial. Don't miss other LxyzTHW pages!
SQLite official website with full documentation (may be newer than the SQLite library that comes standard with AutoIt)

Share this post


Link to post
Share on other sites

I was referring to the path in the OP, not in general. Obviously I know that there are paths with spaces in them, just not as poorly formatted as the one in the OP. That path has to be coming from somewhere, because that isn't a valid Windows path.

1 person likes this

If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

another way...

local $op = 'c:\\ Alo ha\Ciao \Xi    nChao"\       Hello'

local $np = stringregexpreplace(stringregexpreplace($op,'\\ +| +\\','\\'),'\\+','\\')

ConsoleWrite($op & @LF & $np & @CRLF)

kylomas

1 person likes this

Forum Rules         Procedure for posting code

"I like pigs.  Dogs look up to us.  Cats look down on us.  Pigs treat us as equals."

- Sir Winston Churchill

Share this post


Link to post
Share on other sites

kylomas, you forgot the "   :)

$sPath = 'c:\\ Alo ha\Ciao \XinChao"\Hello'

msgbox(0, '' , stringregexpreplace($sPath, '(\\?"?\s*\\\s*)', "\\"))
1 person likes this

Share this post


Link to post
Share on other sites

#14 ·  Posted (edited)

mikell - What do you mean?  It picked up the quote when I tested it...

Nevermind, missed the fact that the OP wanted to get rid of the quote...

Edited by kylomas
1 person likes this

Forum Rules         Procedure for posting code

"I like pigs.  Dogs look up to us.  Cats look down on us.  Pigs treat us as equals."

- Sir Winston Churchill

Share this post


Link to post
Share on other sites

Thanks @kylomas, @mikell, @jguinch and @BrewManNH

Where can I find documentation for RegExp AutoIT?


Regards,
 

Share this post


Link to post
Share on other sites

@Trong : the help file is good, and the forum too. There are a lot of websites with examples and tools to help with regex.

These two websites should help you :

 - http://www.rexegg.com/

 - https://regex101.com/

1 person likes this

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now