Milas

gui function wonte delete files until gui closes

3 posts in this topic

Hello,

     I am working on a GUI that will perform some reg query and wmic cmds for some of our tier 1 techs. everything so far works well except for my function to get mapped printers from a remote computer. I have the function outputting the list of printers to a text file in the temp folder. at the end of the function its suppose to delete the file and that is where my issue lies. The gui wont delete the file until the GUI itself closes. this is causing an issue where if I want to run the function again the gui shuts down on me.

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <StaticConstants.au3>
#include <WindowsConstants.au3>
#include <inet.au3>
#include <Constants.au3>
#RequireAdmin

#cs
    Program: Phone Tech utilitly tool
    Purpose: Assist phone techs and others with different wmic and reg query cmds to gain information from remote computers
    Creator: Salim C. Proctor
    Co-creator/Editor: John Ennis
    Date Created: 2 Feb 2016
    Last Edited: 16 Feb 2016
    Verion 1.0
#ce


#Region ### START Koda GUI section ### Form=
$Form1 = GUICreate("Form1", 627, 459, 192, 114)
$Tab1 = GUICtrlCreateTab(0, 0, 625, 457)

$TabSheet1 = GUICtrlCreateTabItem("Main")
$User = GUICtrlCreateButton("Who's Logged On", 8, 40, 147, 41)
$Host = GUICtrlCreateButton("Get Hostname", 8, 96, 147, 41)
$Acc = GUICtrlCreateButton("User Account Info", 440, 40, 139, 41)
$MAC = GUICtrlCreateButton("Get MAC Address", 8, 152, 147, 41)
$nPrinter = GUICtrlCreateButton("Mapped Printers", 8, 208, 147, 41)
$sUser = GUICtrlCreateInput("", 168, 48, 249, 21)
$sHost = GUICtrlCreateInput("", 168, 104, 249, 21)
$IP = GUICtrlCreateInput("Enter IP/Hostname", 8, 424, 161, 21)
$plist = GUICtrlCreateEdit("", 168, 208, 249, 162)
$sMAC = GUICtrlCreateInput("", 168, 160, 249, 21)
$Ping = GUICtrlCreateButton("Ping", 208, 408, 163, 41)
$mDrive = GUICtrlCreateButton("Remote C$", 440, 408, 147, 41)

$TabSheet2 = GUICtrlCreateTabItem("Program Version")
$search = GUICtrlCreateButton("Search", 8, 32, 147, 41)
$program = GUICtrlCreateInput("Enter Program Name", 176, 40, 321, 21)
$prog_list = GUICtrlCreateEdit("", 8, 96, 609, 318)

GUICtrlSetData(-1, "")
GUISetState(@SW_SHOW)
#EndRegion ### END Koda GUI section ###

While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $User
            remote_user()
        Case $Host
            remote_host()
        Case $MAC
            remote_Mac()
        Case $search
            remote_program()
        Case $Ping
            ping_customer()
        Case $mDrive
            map_drive()
        Case $nPrinter
            get_printers()
        Case $Acc
            Account()
        Case $GUI_EVENT_CLOSE
            Exit

    EndSwitch
WEnd

Func remote_user()
    $pid = Run(@ComSpec & " /c wmic /node:" & GUICtrlRead($IP) & " computersystem get username", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    Local $line
    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop

    WEnd
    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop

    WEnd
    $split = StringSplit($line, @CRLF)
    GUICtrlSetData($sUser, $split[4])

EndFunc   ;==>remote_user

Func remote_host()
    $pid = Run(@ComSpec & " /c wmic /node:" & GUICtrlRead($IP) & " computersystem get name", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)
    Local $line
    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop
    WEnd
    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop
    WEnd
    $split = StringSplit($line, @CRLF)
    GUICtrlSetData($sHost, $split[4])

EndFunc   ;==>remote_host

Func remote_Mac()
    $pid = Run(@ComSpec & " /c getmac /nh /s " & GUICtrlRead($IP), @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    Local $line
    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop

    WEnd
    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop

    WEnd
    $split = StringSplit($line, @CRLF)
    $2ndSplit = StringSplit($split[3], "\")

    GUICtrlSetData($sMAC, $2ndSplit[1])



EndFunc   ;==>remote_Mac

Func remote_program()

    Local $fProgram, $nkey, $1position[33], $2position[33]
    Local $pid, $line1[33], $line, $array_size
    GUICtrlSetData($prog_list, "")
    GUICtrlSetState($search, $gui_disable)
    $fProgram = GUICtrlRead($program)
    $pid = Run(@ComSpec & ' /c reg query \\' & GUICtrlRead($IP) & '\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall /s /f ' & $fProgram & ' /d| findstr "{"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)


    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop
    WEnd
    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop
    WEnd

    $nkey = StringSplit($line, @CRLF & @CRLF)
    $array_size = UBound($nkey)
    ReDim $1position[$array_size]
    ReDim $line1[$array_size]


    For $i = 1 To $array_size - 1
        $1position[$i] = StringLen($nkey[$i])

        If $1position[$i] < 132 Then
            $pid = Run(@ComSpec & ' /c reg query \\' & GUICtrlRead($IP) & '\' & $nkey[$i] & '| findstr /i "displayname displayversion"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)


            While 1
                $line1[$i] &= StdoutRead($pid)

                If @error Then ExitLoop
            WEnd

            GUICtrlSetData($prog_list, $line1[$i] & @CRLF & "~", "~")

        EndIf

        $i = $i + 1

    Next

    GUICtrlSetState($search, $gui_enable)
EndFunc   ;==>remote_program

Func ping_customer()
    Local $error

    If GUICtrlRead($IP) <> "" Then
        $pError = RunWait("ping.exe -n 1 " & GUICtrlRead($IP), "", @SW_HIDE)

        Switch $pError
            Case 0
                MsgBox(0, "Successfull", "Operation was a success!")
            Case 1
                MsgBox(48, "ERROR CODE: 001", "Host/IP is not reachable")
        EndSwitch
    Else
        MsgBox(48, "ERROR CODE: 005", "No input detected")
    EndIf
EndFunc   ;==>ping_customer

Func map_drive()
    ShellExecute("C:\Users\Salim.Proctor\Desktop\GUI\john project\c$ remote.exe")
EndFunc   ;==>map_drive

Func get_printers()
    Local $pid, $sid, $sid2, $hfileopen, $sfileread, $line, $exit, $ip45, $user45

    ;disables map printer button in gui
    GUICtrlSetState($nPrinter, $gui_disable)

    ;clears any previous data in the printer edit box
    GUICtrlSetData($plist, " ")
    
    ;reads ip address user entered
    $ip45 = GUICtrlRead($IP)
    
    ;reads the user name from the sUser input box
    $x = GUICtrlRead($sUser)
    
    ;splits the data to remove domainname\
    $y = StringSplit($x, "\")
    
    ;removes a space value from the data
    $user45 = StringSplit($y[2], " ")

    ;queries the remote users registry to find thier sid
    $pid = Run(@ComSpec & ' /c reg query "\\' & $ip45 & '\hklm\software\microsoft\windows nt\currentversion\profilelist" /s /f "' & $user45[1] & '"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    ;reads the standard ouput from the reg query
    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop
    WEnd
    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop
    WEnd
    ;string splits to remove all unneeded data and get only the sid
    $sid = StringSplit($line, "\")
    $sid2 = StringSplit($sid[7], @CRLF)

    ;queries the remote users registry using the newly obtained sid and writes it out to a text file
    $pid = Run(@ComSpec & ' /c reg query \\' & $ip45 & '\hkey_users\' & $sid2[1] & '\Printers\Connections > c:\temp\printer_list.txt', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    ;pause program to give it time to create the file
    Sleep(1000)

    ;opens the file so that it can be read
    If FileExists("c:\temp\printer_list.txt") Then
        FileWriteLine("c:\temp\printer_list.txt", "1\2\3\4\end of list")
        $hfileopen = FileOpen("c:\temp\printer_list.txt")
    EndIf

    $exit = " "
    $i = 2

    ;output the data into the gui until it reaches the end of the list
    Do
        $exit = FileReadLine("c:\temp\printer_list.txt", $i)
        $printer_string = StringSplit($exit, "\")
        GUICtrlSetData($plist, $printer_string[5] & @CRLF & "~", "~")
        $i = $i + 1

    Until $exit = "1\2\3\4\end of list"

    ;reeneables the gui map printer button
    GUICtrlSetState($nPrinter, $gui_enable)

    ;delete the text file that is created by the command line
    If FileExists("c:\temp\printer_list.txt") Then
        FileClose("c:\temp\printer_list.txt")
        FileDelete("c:\temp\printer_list.txt")

    EndIf

EndFunc   ;==>get_printers

Func Account()
    Local $line
    $split = StringSplit(GUICtrlRead($sUser), "\")

    $pid = Run(@ComSpec & " /c net user " & $split[2] & " /domain", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop

    WEnd

    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop

    WEnd
    MsgBox(0, "STDOUT read:", $line)
EndFunc   ;==>Account

just to reiterate the function im having issue with is func get_printers

Share this post


Link to post
Share on other sites

Line 247, FileOpen is blocking the deletion, and handle is never used.

1 person likes this

Share this post


Link to post
Share on other sites

autoBert

it is just as you said. thank you! I cant believe I didn't see that.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now

  • Similar Content

    • computergroove
      By computergroove
      I've made a form in Koda where I make a list of 3 user definable elements that I want to be able to replicate with a button press so a user can add data that can be used as part of the program. 
      #include <ButtonConstants.au3> #include <EditConstants.au3> #include <GUIConstantsEx.au3> #include <StaticConstants.au3> #include <WindowsConstants.au3> #Region ### START Koda GUI section ### Form=D:\Carbonite Important\0 - Programing\Scite and Autoit\Koda 1.7.3.0\Forms\Mileage Estimator.kxf $Form1 = GUICreate("Save Project", 614, 1126, 298, 141) $Location = GUICtrlCreateInput("Location", 40, 112, 345, 21) $Distance = GUICtrlCreateInput("Distance", 400, 112, 89, 21) $AddLocation = GUICtrlCreateButton("AddLocation", 288, 80, 97, 25) $Label1 = GUICtrlCreateLabel("Location", 40, 88, 45, 17) $Label2 = GUICtrlCreateLabel("Distance", 400, 88, 46, 17) $HomeBase = GUICtrlCreateInput("HomeBase", 312, 32, 121, 21) $LeapYear = GUICtrlCreateCheckbox("LeapYear", 464, 32, 17, 17) $Label3 = GUICtrlCreateLabel("Leap Year?", 488, 32, 59, 17) $Variance = GUICtrlCreateInput("Variance", 504, 112, 81, 21) $Label4 = GUICtrlCreateLabel("Variance", 504, 88, 46, 17) $Label5 = GUICtrlCreateLabel("Home Base", 312, 8, 59, 17) $Button1 = GUICtrlCreateButton("Button1", 144, 56, 1, 57) $Save = GUICtrlCreateButton("Save Project", 40, 16, 121, 25) $Load = GUICtrlCreateButton("Load Project", 176, 16, 121, 25) GUISetState(@SW_SHOW) #EndRegion ### END Koda GUI section ### While 1 $nMsg = GUIGetMsg() Switch $nMsg Case $GUI_EVENT_CLOSE Exit Case $Form1 Case $AddLocation EndSwitch WEnd I want to press the "add location" button and have the fields {Location, Distance and variance} create a new blank record located under the existing 3 input boxes. Since the fields can number over 30 locations in some examples I am thinking about having these items in a scrolling window. What is the best way to do this and can auto it add a variable while running by pressing a button?
    • XaelloNegative
      By XaelloNegative
      Hi,
      I made a small blunder with my code. I created the GUI under 1920x1080 resolution however, my user is configured to ONLY 1080x720 and cannot go any further than that.
      What do you guys think is the best way to correct this one? Resolution mathematics is something that came to mind however I do not have access to his PC to check  from time to time if  my estimation is correct and the resolution on my PC doesn't go down to 1080x720.
      Please help.
      ~XN~
    • davidacrozier
      By davidacrozier
      Hello all ~
      I am running an autoit script on Windows 10 inside VMware Workstation 12 Pro version 12.5.2.  Technically I am remoting into ESXi which has a Domain Controller (DC), WebServer, FilServer, Windows 10, etc.  Using the GUI (i.e. running explorer.exe) I am able to open several different folders successfully.  The desktop, documents, USB external all open without issue.  The network share opening gives me issues.  Whenever I attempt to open \\filserver\users\user\sharedfolder I get the documents folder instead.  I understand that the documents folder is the default for explorer.  I have also attempted to use the letter drive mapped to the network share (Z:) and receive the same result.  When I run this script on Windows 10 alone without  the VM or the ESXi I am able to open the network share without problems.  I have tried to use the net use command to designate a letter M: to the network share folder prior to running the script.  This did not work for me.  
      One additional avenue I think might work is to use the systreeview321 and _GUICtrlTreeView_FindItem to step through the tree looking for the network share.  Once found,  double click on it and see if that opens the shared network folder.  I can click inside the VM with my mouse on the network share and it opens just fine.  Not sure if running up against GUI issues, or permission issues, or what?
      Thanks in advance,
      Davida Crozier
      TestNetworkShare.au3
      This script is a subset of a much larger program, but it illustrates what I am dealing with.

    • superflq
      By superflq
      Hi everyone,
      GUICtrlSetState Function example ,i found $GUI_DROPACCEPTED isn't working in windows10 x64(windows_10_enterprise_2016_ltsb_x64).
      if the example put to windows10 x86 or windows xp, the $GUI_DROPACCEPTED is effective,
      the AutoIt Edition is v3.3.14.2.
      any ideas? thanks you.
       
      #include <GUIConstantsEx.au3> #include <StaticConstants.au3> #include <WindowsConstants.au3> Example() Func Example() ; Create a GUI with various controls. Local $hGUI = GUICreate("Example", 420, 200, -1, -1, -1, $WS_EX_ACCEPTFILES) ; Create a label and set the state as drop accepted. Local $idLabel = GUICtrlCreateLabel("Drop a file on this label.", 10, 10, 400, 40, $WS_BORDER) GUICtrlSetState($idLabel, $GUI_DROPACCEPTED) ; Create an input and set the state as drop accepted. Local $idInput = GUICtrlCreateInput("", 10, 60, 400, 22) GUICtrlSetState($idInput, $GUI_DROPACCEPTED) Local $idOK = GUICtrlCreateButton("OK", 310, 170, 85, 25) ; Display the GUI. GUISetState(@SW_SHOW, $hGUI) While 1 Switch GUIGetMsg() Case $GUI_EVENT_CLOSE, $idOK ExitLoop Case $GUI_EVENT_DROPPED ; If the value of @GUI_DropId is $idLabel, then set the label of the dragged file. If @GUI_DropId = $idLabel Then GUICtrlSetData($idLabel, @GUI_DragFile) EndSwitch WEnd ; Delete the previous GUI and all controls. GUIDelete($hGUI) EndFunc ;==>Example  
    • MrCheese
      By MrCheese
      Hey Guys,
       
      So, the functions work, where primarygui() accurately determines the evaluation of the status of the checkboxes - the msgbox picks this up.
       
      However, later on, when we re-enter a 'for $i = 0 to ubound($checkbox)' loop, then in the 'batchinitial' function it doesn't picked up that the status&$i = 1, so it jumps out, then within the While 1 loop, it exits the loop in the first row, again because the status& $i= 0
      The "assign" line within the primarygui funtion, is this only a local assignment? if so, how can I make it cross function?
       
      Thank in adv for your help
       
       
      Func excelsheetlist() $i = 0 Global $aWorkSheets = _Excel_SheetList($oWorkbook1) If @error Then Exit MsgBox($MB_SYSTEMMODAL, "Excel UDF: _Excel_SheetList Example 1", "Error listing Worksheets." & @CRLF & "@error = " & @error & ", @extended = " & @extended) ;_ArrayDisplay($aWorkSheets, "Excel UDF: _Excel_SheetList Example 1") ;_ArrayDisplay($aWorkSheets, "Array") Global $iRows = UBound($aWorkSheets, $UBOUND_ROWS) ; Total number of rows. In this example it will be 10. Global $iCols = UBound($aWorkSheets, $UBOUND_COLUMNS) ; Total number of columns. In this example it will be 20. Global $iDimension = UBound($aWorkSheets, $UBOUND_DIMENSIONS) ; The dimension of the array e.g. 1/2/3 dimensional. MsgBox($MB_SYSTEMMODAL, "", "The array is a " & $iDimension & " dimensional array with " & _ $iRows & " row(s) & " & $iCols & " column(s).") Dim $checkbox[$iRows] EndFunc ;==>excelsheetlist Func primarygui() ; Create a GUI with various controls. Local $hGUI = GUICreate("Script Controller", 300, ($iRows * 24)) ; Create a checkbox control. ;Local $idCheckbox = GUICtrlCreateCheckbox("Standard Checkbox", 10, 10, 185, 25) Local $Button2 = GUICtrlCreateButton("Close", 210, 200, 85, 25) Local $Button3 = GUICtrlCreateButton("Run", 210, 170, 85, 25) Local $Button1 = GUICtrlCreateButton("Discharge", 210, 140, 85, 25) For $i = 0 To UBound($checkbox) - 1 $checkbox[$i] = GUICtrlCreateCheckbox($aWorkSheets[$i][0], 8, 0 + ($i * 24)) ;, 81, 17) Next ; Display the GUI. GUISetState(@SW_SHOW, $hGUI) ; Loop until the user exits. While 1 $nMsg = GUIGetMsg() Select Case $nMsg = $GUI_EVENT_CLOSE Exit Case $nMsg = $Button2 ;Close Exit Case $nMsg = $Button1 MsgBox(0, "Discharge Button not configured", "Now Exiting") Exit Case $nMsg = $Button3 ;Run $fSelection = False For $i = 0 To UBound($checkbox) - 1 If BitAND(GUICtrlRead($checkbox[$i]), $GUI_CHECKED) Then $fSelection = True ExitLoop EndIf Next If $fSelection Then For $i = 0 To UBound($checkbox) - 1 Assign("status" & $i, GUICtrlRead($checkbox[$i])) Next $batchcount = 0 For $i = 0 To UBound($checkbox) - 1 If Eval("status" & $i) = 1 Then $batchcount = $batchcount + 1 ;Call ("o" & $i & "copy") ; if you want to call the functions directly, remove ; before the call and comment or delete the following DirCopy statement MsgBox(0, "Checking", "Checking that: " & $checkbox[$i] & " no, with title: " & $aWorkSheets[$i][0] & " was selected, Batch count: " & $batchcount) ; if you need only the DirCopy EndIf Next ExitLoop Else MsgBox(48, 'No Items Selected', 'You have not selected any Patients to Load, Please select from the list') EndIf EndSelect WEnd ; Delete the previous GUI and all controls. GUIDelete($hGUI) EndFunc ;==>primarygui Func _IsChecked($idControlID) Return BitAND(GUICtrlRead($idControlID), $GUI_CHECKED) = $GUI_CHECKED EndFunc ;==>_IsChecked Func batchinitial() If Eval("status" & $i) = 1 Then debugbox() $oWorkbook1.Sheets(1).Activate $bigloop = $bigloop + 1 $sheet = $aWorkSheets[$i][0] $oWorkbook1.Sheets($sheet).Activate debugbox() EndIf EndFunc ;==>batchinitial OpenExcel() excelsheetlist() primarygui() For $i = 0 To UBound($checkbox) - 1 batchinitial() While 1 If Eval("status" & $i) = 0 Then ExitLoop ;all the rest of my script loops etc WEnd Next