gui function wonte delete files until gui closes

3 posts in this topic


     I am working on a GUI that will perform some reg query and wmic cmds for some of our tier 1 techs. everything so far works well except for my function to get mapped printers from a remote computer. I have the function outputting the list of printers to a text file in the temp folder. at the end of the function its suppose to delete the file and that is where my issue lies. The gui wont delete the file until the GUI itself closes. this is causing an issue where if I want to run the function again the gui shuts down on me.

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <StaticConstants.au3>
#include <WindowsConstants.au3>
#include <inet.au3>
#include <Constants.au3>

    Program: Phone Tech utilitly tool
    Purpose: Assist phone techs and others with different wmic and reg query cmds to gain information from remote computers
    Creator: Salim C. Proctor
    Co-creator/Editor: John Ennis
    Date Created: 2 Feb 2016
    Last Edited: 16 Feb 2016
    Verion 1.0

#Region ### START Koda GUI section ### Form=
$Form1 = GUICreate("Form1", 627, 459, 192, 114)
$Tab1 = GUICtrlCreateTab(0, 0, 625, 457)

$TabSheet1 = GUICtrlCreateTabItem("Main")
$User = GUICtrlCreateButton("Who's Logged On", 8, 40, 147, 41)
$Host = GUICtrlCreateButton("Get Hostname", 8, 96, 147, 41)
$Acc = GUICtrlCreateButton("User Account Info", 440, 40, 139, 41)
$MAC = GUICtrlCreateButton("Get MAC Address", 8, 152, 147, 41)
$nPrinter = GUICtrlCreateButton("Mapped Printers", 8, 208, 147, 41)
$sUser = GUICtrlCreateInput("", 168, 48, 249, 21)
$sHost = GUICtrlCreateInput("", 168, 104, 249, 21)
$IP = GUICtrlCreateInput("Enter IP/Hostname", 8, 424, 161, 21)
$plist = GUICtrlCreateEdit("", 168, 208, 249, 162)
$sMAC = GUICtrlCreateInput("", 168, 160, 249, 21)
$Ping = GUICtrlCreateButton("Ping", 208, 408, 163, 41)
$mDrive = GUICtrlCreateButton("Remote C$", 440, 408, 147, 41)

$TabSheet2 = GUICtrlCreateTabItem("Program Version")
$search = GUICtrlCreateButton("Search", 8, 32, 147, 41)
$program = GUICtrlCreateInput("Enter Program Name", 176, 40, 321, 21)
$prog_list = GUICtrlCreateEdit("", 8, 96, 609, 318)

GUICtrlSetData(-1, "")
#EndRegion ### END Koda GUI section ###

While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $User
        Case $Host
        Case $MAC
        Case $search
        Case $Ping
        Case $mDrive
        Case $nPrinter
        Case $Acc
        Case $GUI_EVENT_CLOSE


Func remote_user()
    $pid = Run(@ComSpec & " /c wmic /node:" & GUICtrlRead($IP) & " computersystem get username", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    Local $line
    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop

    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop

    $split = StringSplit($line, @CRLF)
    GUICtrlSetData($sUser, $split[4])

EndFunc   ;==>remote_user

Func remote_host()
    $pid = Run(@ComSpec & " /c wmic /node:" & GUICtrlRead($IP) & " computersystem get name", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)
    Local $line
    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop
    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop
    $split = StringSplit($line, @CRLF)
    GUICtrlSetData($sHost, $split[4])

EndFunc   ;==>remote_host

Func remote_Mac()
    $pid = Run(@ComSpec & " /c getmac /nh /s " & GUICtrlRead($IP), @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    Local $line
    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop

    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop

    $split = StringSplit($line, @CRLF)
    $2ndSplit = StringSplit($split[3], "\")

    GUICtrlSetData($sMAC, $2ndSplit[1])

EndFunc   ;==>remote_Mac

Func remote_program()

    Local $fProgram, $nkey, $1position[33], $2position[33]
    Local $pid, $line1[33], $line, $array_size
    GUICtrlSetData($prog_list, "")
    GUICtrlSetState($search, $gui_disable)
    $fProgram = GUICtrlRead($program)
    $pid = Run(@ComSpec & ' /c reg query \\' & GUICtrlRead($IP) & '\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall /s /f ' & $fProgram & ' /d| findstr "{"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop
    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop

    $nkey = StringSplit($line, @CRLF & @CRLF)
    $array_size = UBound($nkey)
    ReDim $1position[$array_size]
    ReDim $line1[$array_size]

    For $i = 1 To $array_size - 1
        $1position[$i] = StringLen($nkey[$i])

        If $1position[$i] < 132 Then
            $pid = Run(@ComSpec & ' /c reg query \\' & GUICtrlRead($IP) & '\' & $nkey[$i] & '| findstr /i "displayname displayversion"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

            While 1
                $line1[$i] &= StdoutRead($pid)

                If @error Then ExitLoop

            GUICtrlSetData($prog_list, $line1[$i] & @CRLF & "~", "~")


        $i = $i + 1


    GUICtrlSetState($search, $gui_enable)
EndFunc   ;==>remote_program

Func ping_customer()
    Local $error

    If GUICtrlRead($IP) <> "" Then
        $pError = RunWait("ping.exe -n 1 " & GUICtrlRead($IP), "", @SW_HIDE)

        Switch $pError
            Case 0
                MsgBox(0, "Successfull", "Operation was a success!")
            Case 1
                MsgBox(48, "ERROR CODE: 001", "Host/IP is not reachable")
        MsgBox(48, "ERROR CODE: 005", "No input detected")
EndFunc   ;==>ping_customer

Func map_drive()
    ShellExecute("C:\Users\Salim.Proctor\Desktop\GUI\john project\c$ remote.exe")
EndFunc   ;==>map_drive

Func get_printers()
    Local $pid, $sid, $sid2, $hfileopen, $sfileread, $line, $exit, $ip45, $user45

    ;disables map printer button in gui
    GUICtrlSetState($nPrinter, $gui_disable)

    ;clears any previous data in the printer edit box
    GUICtrlSetData($plist, " ")
    ;reads ip address user entered
    $ip45 = GUICtrlRead($IP)
    ;reads the user name from the sUser input box
    $x = GUICtrlRead($sUser)
    ;splits the data to remove domainname\
    $y = StringSplit($x, "\")
    ;removes a space value from the data
    $user45 = StringSplit($y[2], " ")

    ;queries the remote users registry to find thier sid
    $pid = Run(@ComSpec & ' /c reg query "\\' & $ip45 & '\hklm\software\microsoft\windows nt\currentversion\profilelist" /s /f "' & $user45[1] & '"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    ;reads the standard ouput from the reg query
    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop
    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop
    ;string splits to remove all unneeded data and get only the sid
    $sid = StringSplit($line, "\")
    $sid2 = StringSplit($sid[7], @CRLF)

    ;queries the remote users registry using the newly obtained sid and writes it out to a text file
    $pid = Run(@ComSpec & ' /c reg query \\' & $ip45 & '\hkey_users\' & $sid2[1] & '\Printers\Connections > c:\temp\printer_list.txt', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    ;pause program to give it time to create the file

    ;opens the file so that it can be read
    If FileExists("c:\temp\printer_list.txt") Then
        FileWriteLine("c:\temp\printer_list.txt", "1\2\3\4\end of list")
        $hfileopen = FileOpen("c:\temp\printer_list.txt")

    $exit = " "
    $i = 2

    ;output the data into the gui until it reaches the end of the list
        $exit = FileReadLine("c:\temp\printer_list.txt", $i)
        $printer_string = StringSplit($exit, "\")
        GUICtrlSetData($plist, $printer_string[5] & @CRLF & "~", "~")
        $i = $i + 1

    Until $exit = "1\2\3\4\end of list"

    ;reeneables the gui map printer button
    GUICtrlSetState($nPrinter, $gui_enable)

    ;delete the text file that is created by the command line
    If FileExists("c:\temp\printer_list.txt") Then


EndFunc   ;==>get_printers

Func Account()
    Local $line
    $split = StringSplit(GUICtrlRead($sUser), "\")

    $pid = Run(@ComSpec & " /c net user " & $split[2] & " /domain", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)

    While 1
        $line &= StdoutRead($pid)
        If @error Then ExitLoop


    While 1
        $line &= StderrRead($pid)
        If @error Then ExitLoop

    MsgBox(0, "STDOUT read:", $line)
EndFunc   ;==>Account

just to reiterate the function im having issue with is func get_printers

Share this post

Link to post
Share on other sites

Line 247, FileOpen is blocking the deletion, and handle is never used.

1 person likes this

Share this post

Link to post
Share on other sites


it is just as you said. thank you! I cant believe I didn't see that.

Share this post

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • Skeletor
      By Skeletor
      MS Splash Screens
      The office 2016/17 office suite has made many people turn heads with its functions and especially their splash screen.
      I now present to you, the MS Style Splash Screen. For Rookies, Novices and anyone who wants a ready made splash screen for your gui application.

      You can now download it and also try it out yourself.
      You have three colors to choose from:
      All three colours are from the famous programs.
      I also included the KODA form to you can have freedom with this splash screen.
      Note: the KODA form does not have the three colours as well as the correct blue. 

      Have fun and enjoy.
      I will update the splash to add the automated 3 dots animation at a later stage. 
    • Skeletor
      By Skeletor
      A gui splash screen. Themed after the famous MS Office Suite.
      Three colours to choose from, Red, Blue and Green.
      You can change the labels to your own application.

      Also bundled with this is the KODA form. So you can open up and see the basic structure of this splash screen.
      Splash Screen
    • BlazerV60
      By BlazerV60
      Hello all,
      I've been trying to figure out how to launch Google Chrome in the background (hidden) but it doesn't seem possible. I've tried the following methods:
      ShellExecute("C:\Program Files (x86)\Google\Chrome\Application\chrome.exe", "", "", "", @SW_HIDE) Also I've tried:
      ShellExecute(@ComSpec, "/c start chrome.exe","","",@SW_HIDE) Lastly I tried:
      RunWait('"'&@ProgramFilesDir&'\Google\Chrome\Application\chrome.exe" --silent-launch',@ScriptDir)  
      But all of them launch my chrome browser without hiding it. Does anyone know a workaround for this or if AutoIT just can't Chrome? 
      Bonus points if you know how to make it launch chrome hidden and make it go to
      Thank you,
    • SteveJM
      By SteveJM
      I have a working program currently driven largely through menu selections. I would like to add a toolbar where most of the tollbar button actions are basically the same as menu items, but quicker to access. I have been wading around in toolbar examples, MSDN pages etc, it's clearly going to be a bit of a slog to get everything right, including tooltips etc. I thought I would start with something simple to prove the principle.
      Using bits from the help file examples I have a small program that successfully displays a toolbar. However, what seemed like the most elegant way to deal with the button commands does not seem to work. My understanding was that a toolbar button fires a WM_COMMAND message, with the command Id set by the second parameter in the call to
      _GUICtrlToolbar_AddButton ( $hWnd, $iID, $iImage)
      so I though it would be a good idea to set this Id to the same value as my menu item Id; then it would run the same task which is what I wanted. This did not work. I am using message loop mode and would like to stick with this because some of my scripts run hardware at the same time as the gui; it is easier if I don't have to worry about code being interrupted with the hardware in an unknown state . So I added a handler for WM_COMMAND, with some cribbed display code to try and see why. The toolbar button defintely fired a WM_COMMAND message and the Id looked the same, so no explanation there.
      I guess the issue is with GUIGetMsg() which may be constructed to ignore all but a limited number of control handles, i.e. those made with the GuiCtrlCreate... commands; this is speculation.
      I would dearly love to find a tidy way to get around this. Having some controls handled in the message loop and some in a WM_COMMAND handler, performing the same task, feels ugly. I would be very grateful for further insight from someone experienced with handling a toolbar. Perhaps I should be trying to fire the menu item. I have attached a code snippet to try and illustrate the issue.
    • XinYoung
      By XinYoung
      Hello all,
      I've been working on 4 standalone scripts. They each have their own GUI and are now independent .exe's. But instead of having 4 separate icons on my computer, is it possible to put them all together into one .exe?
      What I want is one interface with tabs. Each script's GUI would be on their own respective tab. Is this possible?
      The different scripts don't need to communicate with one another. I just want them all in one .exe.
      I can't find this anywhere... Any help would be greatly appreciated. Thank you!