Wicked_Caty

GUI behaves strangely

5 posts in this topic

#1 ·  Posted (edited)

A function is started and creates a GUI with two buttons. If either of those are pressed, the function will return a value, which will be used to start another function. However, only one of those two buttons works.

Local $gui = GUICreate("Crypt", 120, 130)
   Local $button0 = GUICtrlCreateButton("Encrypt", 10, 10, 100, 50)
   Local $button1 = GUICtrlCreateButton("Decrypt", 10, 70, 100, 50)
   GUISetState(@SW_SHOW, $gui)

   While 1

      If GUIGetMsg() = $button0 Then
         GUISetState(@SW_HIDE, $gui)
         GUIDelete($gui)
         Return 1
      ElseIf GUIGetMsg() = $button1 Then
         GUISetState(@SW_HIDE, $gui)
         GUIDelete($gui)
         Return 2
      ElseIf GUIGetMsg() = $GUI_EVENT_CLOSE Then
         GUISetState(@SW_HIDE, $gui)
         GUIDelete($gui)
         Return 0
      EndIf

   WEnd

The If works as expected, but the two ElseIf don't work at all. No matter how hard or how often I hit that $button1 or click that X in the top-right of the GUI.

Maybe I haven't had enough coffee today, who knows, but I'm stuck right now...

Thanks - complete source-code is attached

_Crypt.au3

Edited by Wicked_Caty
Grammar, spelling, formatting

Share this post


Link to post
Share on other sites



#2 ·  Posted (edited)

I'd suggest organizing your code a bit better and probably not jumping multiple functions that are pretty related (Creating a gui for login then trapping the execution in the login function, then a gui for mode and trapping your execution for mode). Anyways, the solution is to store the GUIGetMsg() in a variable or use it as the expression in a switch statement.

 

Edited by InunoTaishou

Share this post


Link to post
Share on other sites

In other words, you are calling GUIGetMsg() too many times in you While.. loop, and your program would be eating up too much memory, and most likely giving you a timing issue. Inserting a Sleep(50) every loop might help too.

Like Inuno said, use a variable, etc.

While 1
    $msg = GUIGetMsg()
      If $msg = $button0 Then
         GUISetState(@SW_HIDE, $gui)
         GUIDelete($gui)
         Return 1
      ElseIf $msg = $button1 Then
         GUISetState(@SW_HIDE, $gui)
         GUIDelete($gui)
         Return 2
      ElseIf $msg = $GUI_EVENT_CLOSE Then
         GUISetState(@SW_HIDE, $gui)
         GUIDelete($gui)
         Return 0
      EndIf
    ;Sleep(50)
   WEnd

Like he also said though, you would be better off using the traditional Switch method.

Haven't looked at the rest of your code or tried my improvement, but that misuse of memory stood out.


AutoIt.4.Life Clubrooms - Life is like a Donut (secret key)

Make sure brain is in gear before opening mouth!
Remember, what is not said, can be just as important as what is said.

Spoiler

What is the Secret Key? Life is like a Donut

If I put effort into communication, I expect you to read properly & fully, or just not comment.
Ignoring those who try to divert conversation with irrelevancies.
If I'm intent on insulting you or being rude, I will be obvious, not ambiguous about it.
I'm only big and bad, to those who have an over-active imagination.

I may have the Artistic Liesense ;) to disagree with you. TheSaint's Toolbox (be advised many downloads are not working due to ISP screwup with my storage)

userbar.png

Share this post


Link to post
Share on other sites
Quote

I'd suggest organizing your code a bit better and probably not jumping multiple functions that are pretty related (Creating a gui for login then trapping the execution in the login function, then a gui for mode and trapping your execution for mode). Anyways, the solution is to store the GUIGetMsg() in a variable or use it as the expression in a switch statement.

How am I supposed to do that? I don't know the "guildelines" or the "rulebook" :/

Share this post


Link to post
Share on other sites

There's no rule book for it, it's just a suggestion. You could do something like this (I didn't do all of it, just the login and crypt gui)

#include <MsgBoxConstants.au3>
#include <GUIConstants.au3>
#include <FileConstants.au3>
#include <StringConstants.au3>
#include <Array.au3>

Global $frmLogin = 1
Global $inpUsername
Global $inpPassword
Global $btnLogin
Global $btnExit
Global $frmCrypt = 1
Global $btnEncrypt
Global $btnDecrypt
Global Const $user = "Caty"
Global Const $pass = 1234

Main()

Func CreateLoginGUI()
    $frmLogin = GUICreate("Crypt", 220, 110)
    $inpUsername = GUICtrlCreateInput("Username:", 10, 10, 200, 20)
    $inpPassword = GUICtrlCreateInput("Password:", 10, 40, 200, 20)
    $btnLogin = GUICtrlCreateButton("Log in", 10, 70, 95, 30)
    $btnExit = GUICtrlCreateButton("Exit", 115, 70, 95, 30)
    GUISetState(@SW_SHOW, $frmLogin)
EndFunc   ;==>Login

Func CreateCryptGUI()
    $frmCrypt = GUICreate("Crypt", 120, 130)
    $btnEncrypt = GUICtrlCreateButton("Encrypt", 10, 10, 100, 50)
    $btnDecrypt = GUICtrlCreateButton("Decrypt", 10, 70, 100, 50)
    GUISetState(@SW_SHOW, $frmCrypt)
EndFunc   ;==>Mode

Func Encryption()

    Local $gui = GUICreate("Crypt", 200, 140)
    Local $ctrl0 = GUICtrlCreateInput("Filename", 10, 10, 180, 30)
    Local $ctrl1 = GUICtrlCreateInput("Text", 10, 50, 180, 30)
    Local $button = GUICtrlCreateButton("Encrypt", 10, 90, 180, 40)
    GUISetBkColor(0xFF8811, $gui)
    GUISetState(@SW_SHOW, $gui)

    While 1

        If GUIGetMsg() = $button Then
            ExitLoop
        Else
            Sleep(25)
        EndIf

    WEnd

    Local $f = FileOpen("D:\documents\coding\Crypt\" & GUICtrlRead($ctrl0), $FO_APPEND)
    Local $text = StringSplit(GUICtrlRead($ctrl1), '', 2)

    Local $len = UBound($text)
    Local $tmp = ""

    FileWrite($f, $len & @CRLF)

    For $i = 0 To $len - 1

        $tmp = ""
        $tmp = AscW($text[$i])
        $tmp = $tmp * 29212
        $tmp = $tmp / 18108
        $tmp = $tmp * 14481
        $tmp = $tmp / 10857
        $tmp = $tmp * 31627
        $tmp = $tmp / 24087
        $tmp = $tmp * 15835
        $tmp = $tmp / 25878
        $tmp = $tmp * 11957
        $tmp = $tmp / 27520
        $tmp = $tmp * 01324

        FileWrite($f, $tmp & @CRLF)

    Next

    GUISetBkColor(0x11FF88, $gui)

    FileClose($f)
    GUISetState(@SW_HIDE, $gui)
    GUIDelete($gui)
    Return True

EndFunc   ;==>Encryption

Func Decryption()

    Local $gui = GUICreate("Crypt", 200, 140)
    Local $ctrl0 = GUICtrlCreateInput("Encrypted", 10, 10, 180, 30)
    Local $ctrl1 = GUICtrlCreateInput("Decrypted", 10, 50, 180, 30)
    Local $button = GUICtrlCreateButton("Decrypt", 10, 90, 180, 40)
    GUISetBkColor(0xFF8811, $gui)
    GUISetState(@SW_SHOW, $gui)

    While 1

        If GUIGetMsg() = $button Then
            ExitLoop
        Else
            Sleep(25)
        EndIf

    WEnd

    Local $fin = FileOpen("D:\documents\coding\Crypt\" & GUICtrlRead($ctrl0), $FO_APPEND)
    Local $len = Number(FileReadLine($fin, 1))
    Local $tmp0, $tmp1, $tmp2

    For $i = 0 To $len - 1

        $tmp0 = ""
        $tmp1 = ""
        $tmp0 = Dec(Number(FileReadLine($fin, $i + 1)))
        $tmp0 = $tmp0 / 01324
        $tmp0 = $tmp0 * 27520
        $tmp0 = $tmp0 / 11957
        $tmp0 = $tmp0 * 25878
        $tmp0 = $tmp0 / 15835
        $tmp0 = $tmp0 * 24087
        $tmp0 = $tmp0 / 31627
        $tmp0 = $tmp0 * 10857
        $tmp0 = $tmp0 / 14481
        $tmp0 = $tmp0 * 18108
        $tmp0 = $tmp0 / 29212
        $tmp0 = ChrW($tmp0)
        $tmp1 = String($tmp1) + String($tmp0)

    Next

    GUISetBkColor(0x11FF88, $gui)

    FileClose($fin)
    Local $fou = FileOpen("D:\documents\coding\Crypt\" & GUICtrlRead($ctrl1), $FO_APPEND)
    FileWrite($fou, $tmp2)
    FileClose($fou)
    GUISetState(@SW_HIDE, $gui)
    GUIDelete($gui)
    Return True

EndFunc   ;==>Decryption

Func Main()
    Local $att = 3
    CreateLoginGUI()

    While (True)
        Local $nMsg = GUIGetMsg(1)
        Switch ($nMsg[1])
            Case $frmLogin
                Switch ($nMsg[0])
                    Case $GUI_EVENT_CLOSE, $btnExit
                        GUIDelete($frmLogin)
                        Exit 0
                    Case $btnLogin
                        If GUICtrlRead($inpUsername) = $user And GUICtrlRead($inpPassword) = $pass Then
                            GUIDelete($frmLogin)
                            CreateCryptGUI()
                        Else
                            If $att = 3 Then
                                GUISetBkColor(0xFF9911, $frmLogin)
                            ElseIf $att = 2 Then
                                GUISetBkColor(0xFF6611, $frmLogin)
                            ElseIf $att = 1 Then
                                GUISetBkColor(0xFF3311, $frmLogin)
                            Else
                                GUIDelete($frmLogin)
                                Exit -1
                            EndIf
                            $att -= 1
                        EndIf
                EndSwitch
            Case $frmCrypt
                Switch ($nMsg[0])
                    case $GUI_EVENT_CLOSE
                        GUIDelete($frmCrypt)
                        Return 0
                    Case $btnEncrypt
                        Encryption()
                    Case $btnDecrypt
                        Decryption()
                EndSwitch
        EndSwitch
    WEnd
EndFunc   ;==>Main

Call a function that creates the corresponding GUI but the execution stays in Main() and using the advanced mode in GUIGetMsg, since we'll be working with multiple GUIs.

If it's too complicated then GUIOnEventMode might be easier.

#include <MsgBoxConstants.au3>
#include <GUIConstants.au3>
#include <FileConstants.au3>
#include <StringConstants.au3>
#include <Array.au3>

Opt("GUIOnEventMode", 1)

Global $frmLogin
Global $inpUsername
Global $inpPassword
Global $btnLogin
Global $btnExit
Global $frmCrypt
Global $btnEncrypt
Global $btnDecrypt
Global Const $user = "Caty"
Global Const $pass = 1234


CreateLoginGUI()

While (True)
    Sleep(100)
WEnd

Func Close()
    If ($frmLogin) Then GUIDelete($frmLogin)
    If ($frmCrypt) Then GUIDelete($frmCrypt)
    Exit 0
EndFunc   ;==>Close

Func btnLogin()
    Local Static $att = 3
    If (GUICtrlRead($inpUsername) = $user And GUICtrlRead($inpPassword) = $pass) Then
        GUIDelete($frmLogin)
        CreateCryptGUI()
    Else
        If $att = 3 Then
            GUISetBkColor(0xFF9911, $frmLogin)
        ElseIf $att = 2 Then
            GUISetBkColor(0xFF6611, $frmLogin)
        ElseIf $att = 1 Then
            GUISetBkColor(0xFF3311, $frmLogin)
        Else
            GUIDelete($frmLogin)
            Exit -1
        EndIf
        $att -= 1
    EndIf
EndFunc   ;==>btnLogin

Func CreateLoginGUI()
    $frmLogin = GUICreate("Crypt", 220, 110)
    $inpUsername = GUICtrlCreateInput("Username:", 10, 10, 200, 20)
    $inpPassword = GUICtrlCreateInput("Password:", 10, 40, 200, 20)
    $btnLogin = GUICtrlCreateButton("Log in", 10, 70, 95, 30)
    $btnExit = GUICtrlCreateButton("Exit", 115, 70, 95, 30)

    GUICtrlSetOnEvent($btnLogin, "btnLogin")
    GUICtrlSetOnEvent($btnExit, "Close")
    GUISetOnEvent($GUI_EVENT_CLOSE, "Close")
    GUISetState(@SW_SHOW, $frmLogin)
EndFunc   ;==>CreateLoginGUI

Func CreateCryptGUI()
    $frmCrypt = GUICreate("Crypt", 120, 130)
    $btnEncrypt = GUICtrlCreateButton("Encryption", 10, 10, 100, 50)
    $btnDecrypt = GUICtrlCreateButton("Decryption", 10, 70, 100, 50)

    GUICtrlSetOnEvent($btnEncrypt, "Encryption")
    GUICtrlSetOnEvent($btnDecrypt, "Decryption")
    GUISetOnEvent($GUI_EVENT_CLOSE, "Close")
    GUISetState(@SW_SHOW, $frmCrypt)
EndFunc   ;==>CreateCryptGUI

Func Encryption()

    Local $gui = GUICreate("Crypt", 200, 140)
    Local $ctrl0 = GUICtrlCreateInput("Filename", 10, 10, 180, 30)
    Local $ctrl1 = GUICtrlCreateInput("Text", 10, 50, 180, 30)
    Local $button = GUICtrlCreateButton("Encrypt", 10, 90, 180, 40)
    GUISetBkColor(0xFF8811, $gui)
    GUISetState(@SW_SHOW, $gui)

    While 1

        If GUIGetMsg() = $button Then
            ExitLoop
        Else
            Sleep(25)
        EndIf

    WEnd

    Local $f = FileOpen("D:\documents\coding\Crypt\" & GUICtrlRead($ctrl0), $FO_APPEND)
    Local $text = StringSplit(GUICtrlRead($ctrl1), '', 2)

    Local $len = UBound($text)
    Local $tmp = ""

    FileWrite($f, $len & @CRLF)

    For $i = 0 To $len - 1

        $tmp = ""
        $tmp = AscW($text[$i])
        $tmp = $tmp * 29212
        $tmp = $tmp / 18108
        $tmp = $tmp * 14481
        $tmp = $tmp / 10857
        $tmp = $tmp * 31627
        $tmp = $tmp / 24087
        $tmp = $tmp * 15835
        $tmp = $tmp / 25878
        $tmp = $tmp * 11957
        $tmp = $tmp / 27520
        $tmp = $tmp * 01324

        FileWrite($f, $tmp & @CRLF)

    Next

    GUISetBkColor(0x11FF88, $gui)

    FileClose($f)
    GUISetState(@SW_HIDE, $gui)
    GUIDelete($gui)
    Return True

EndFunc   ;==>Encryption

Func Decryption()

    Local $gui = GUICreate("Crypt", 200, 140)
    Local $ctrl0 = GUICtrlCreateInput("Encrypted", 10, 10, 180, 30)
    Local $ctrl1 = GUICtrlCreateInput("Decrypted", 10, 50, 180, 30)
    Local $button = GUICtrlCreateButton("Decrypt", 10, 90, 180, 40)
    GUISetBkColor(0xFF8811, $gui)
    GUISetState(@SW_SHOW, $gui)

    While 1

        If GUIGetMsg() = $button Then
            ExitLoop
        Else
            Sleep(25)
        EndIf

    WEnd

    Local $fin = FileOpen("D:\documents\coding\Crypt\" & GUICtrlRead($ctrl0), $FO_APPEND)
    Local $len = Number(FileReadLine($fin, 1))
    Local $tmp0, $tmp1, $tmp2

    For $i = 0 To $len - 1

        $tmp0 = ""
        $tmp1 = ""
        $tmp0 = Dec(Number(FileReadLine($fin, $i + 1)))
        $tmp0 = $tmp0 / 01324
        $tmp0 = $tmp0 * 27520
        $tmp0 = $tmp0 / 11957
        $tmp0 = $tmp0 * 25878
        $tmp0 = $tmp0 / 15835
        $tmp0 = $tmp0 * 24087
        $tmp0 = $tmp0 / 31627
        $tmp0 = $tmp0 * 10857
        $tmp0 = $tmp0 / 14481
        $tmp0 = $tmp0 * 18108
        $tmp0 = $tmp0 / 29212
        $tmp0 = ChrW($tmp0)
        $tmp1 = String($tmp1) + String($tmp0)

    Next

    GUISetBkColor(0x11FF88, $gui)

    FileClose($fin)
    Local $fou = FileOpen("D:\documents\coding\Crypt\" & GUICtrlRead($ctrl1), $FO_APPEND)
    FileWrite($fou, $tmp2)
    FileClose($fou)
    GUISetState(@SW_HIDE, $gui)
    GUIDelete($gui)
    Return True

EndFunc   ;==>Decryption

Main() isn't even needed for this one. We're going to create the login GUI then wait until they click one of the buttons, or close. The corresponding functions for the buttons take care of the sequential order of the script, moving on to the next part.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now

  • Similar Content

    • t0nZ
      By t0nZ
      Hello to all, my problem is to have in the same gui buttons (static and dinamically generated ones) and an edit control.
      The gui also adjust its height in function of button number.
      Below you see an ugly interface and the long buttons at the bottom are dinamically generated reading from a txt file.

      Because I have "static" buttons and dynamically generated ones it's not workin' well your method, also the EDIT area is updated (is a live log) and this is detected as GUI events, and this makes the guigetmsg() "dirty".
      Have you any ideas to make it work in better way ?  I only think about creating two different GUIs to not interfere one with the other one.
      My code is this
      While 1 $nMsg = GUIGetMsg() Switch $nMsg Case $GUI_EVENT_CLOSE GOLLOG("<<<< STOP <<<<") Exit #cs ; test 1 Case $iStart To $iEnd ; <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< gollog(GUICtrlRead($nMsg) & ' ' & 'was pressed' & @CRLF) $iValueToWorkWith = $nMsg - $iStart ; Adjust as required gollog($iValueToWorkWith) ;ExitLoop #ce Case $buttonarray[1] To $buttonarray[UBound($buttonarray) - 1] $UMDguimsg = GUICtrlRead($nMsg) If $UMDguimsg <> 0 Then GOLLOG("ButtonText=[" & $UMDguimsg & "] was clicked") EndIf Case $Bcerca If BitAND(GUICtrlRead($idradio1), $GUI_CHECKED) = $GUI_CHECKED Then Multisearch("username-machinedescription") If BitAND(GUICtrlRead($idradio2), $GUI_CHECKED) = $GUI_CHECKED Then Multisearch("machinename-username") ;Multisearch("username-machinedescription") Case $Block lock() Case $Busergroups usergroups() Case $Bvnc VNC() Case $Icercato If BitAND(GUICtrlRead($idradio1), $GUI_CHECKED) = $GUI_CHECKED Then Multisearch("username-machinedescription") If BitAND(GUICtrlRead($idradio2), $GUI_CHECKED) = $GUI_CHECKED Then Multisearch("machinename-username") #CS Multisearch("username-machinedescription") Case Else msgbox(64,"test",GUIGetMsg()) $UMDguimsg = GUICtrlRead(GUIGetMsg()) If $UMDguimsg <> $salvaUMDguimsg Then MsgBox(64, "test2", $UMDguimsg) $salvaUMDguimsg = $UMDguimsg #CE EndIf EndSwitch WEnd Thank you , cheers,
    • XaelloNegative
      By XaelloNegative
      Hi,
      I made a small blunder with my code. I created the GUI under 1920x1080 resolution however, my user is configured to ONLY 1080x720 and cannot go any further than that.
      What do you guys think is the best way to correct this one? Resolution mathematics is something that came to mind however I do not have access to his PC to check  from time to time if  my estimation is correct and the resolution on my PC doesn't go down to 1080x720.
      Please help.
      ~XN~
    • davidacrozier
      By davidacrozier
      Hello all ~
      I am running an autoit script on Windows 10 inside VMware Workstation 12 Pro version 12.5.2.  Technically I am remoting into ESXi which has a Domain Controller (DC), WebServer, FilServer, Windows 10, etc.  Using the GUI (i.e. running explorer.exe) I am able to open several different folders successfully.  The desktop, documents, USB external all open without issue.  The network share opening gives me issues.  Whenever I attempt to open \\filserver\users\user\sharedfolder I get the documents folder instead.  I understand that the documents folder is the default for explorer.  I have also attempted to use the letter drive mapped to the network share (Z:) and receive the same result.  When I run this script on Windows 10 alone without  the VM or the ESXi I am able to open the network share without problems.  I have tried to use the net use command to designate a letter M: to the network share folder prior to running the script.  This did not work for me.  
      One additional avenue I think might work is to use the systreeview321 and _GUICtrlTreeView_FindItem to step through the tree looking for the network share.  Once found,  double click on it and see if that opens the shared network folder.  I can click inside the VM with my mouse on the network share and it opens just fine.  Not sure if running up against GUI issues, or permission issues, or what?
      Thanks in advance,
      Davida Crozier
      TestNetworkShare.au3
      This script is a subset of a much larger program, but it illustrates what I am dealing with.

    • superflq
      By superflq
      Hi everyone,
      GUICtrlSetState Function example ,i found $GUI_DROPACCEPTED isn't working in windows10 x64(windows_10_enterprise_2016_ltsb_x64).
      if the example put to windows10 x86 or windows xp, the $GUI_DROPACCEPTED is effective,
      the AutoIt Edition is v3.3.14.2.
      any ideas? thanks you.
       
      #include <GUIConstantsEx.au3> #include <StaticConstants.au3> #include <WindowsConstants.au3> Example() Func Example() ; Create a GUI with various controls. Local $hGUI = GUICreate("Example", 420, 200, -1, -1, -1, $WS_EX_ACCEPTFILES) ; Create a label and set the state as drop accepted. Local $idLabel = GUICtrlCreateLabel("Drop a file on this label.", 10, 10, 400, 40, $WS_BORDER) GUICtrlSetState($idLabel, $GUI_DROPACCEPTED) ; Create an input and set the state as drop accepted. Local $idInput = GUICtrlCreateInput("", 10, 60, 400, 22) GUICtrlSetState($idInput, $GUI_DROPACCEPTED) Local $idOK = GUICtrlCreateButton("OK", 310, 170, 85, 25) ; Display the GUI. GUISetState(@SW_SHOW, $hGUI) While 1 Switch GUIGetMsg() Case $GUI_EVENT_CLOSE, $idOK ExitLoop Case $GUI_EVENT_DROPPED ; If the value of @GUI_DropId is $idLabel, then set the label of the dragged file. If @GUI_DropId = $idLabel Then GUICtrlSetData($idLabel, @GUI_DragFile) EndSwitch WEnd ; Delete the previous GUI and all controls. GUIDelete($hGUI) EndFunc ;==>Example  
    • MrCheese
      By MrCheese
      Hey Guys,
       
      So, the functions work, where primarygui() accurately determines the evaluation of the status of the checkboxes - the msgbox picks this up.
       
      However, later on, when we re-enter a 'for $i = 0 to ubound($checkbox)' loop, then in the 'batchinitial' function it doesn't picked up that the status&$i = 1, so it jumps out, then within the While 1 loop, it exits the loop in the first row, again because the status& $i= 0
      The "assign" line within the primarygui funtion, is this only a local assignment? if so, how can I make it cross function?
       
      Thank in adv for your help
       
       
      Func excelsheetlist() $i = 0 Global $aWorkSheets = _Excel_SheetList($oWorkbook1) If @error Then Exit MsgBox($MB_SYSTEMMODAL, "Excel UDF: _Excel_SheetList Example 1", "Error listing Worksheets." & @CRLF & "@error = " & @error & ", @extended = " & @extended) ;_ArrayDisplay($aWorkSheets, "Excel UDF: _Excel_SheetList Example 1") ;_ArrayDisplay($aWorkSheets, "Array") Global $iRows = UBound($aWorkSheets, $UBOUND_ROWS) ; Total number of rows. In this example it will be 10. Global $iCols = UBound($aWorkSheets, $UBOUND_COLUMNS) ; Total number of columns. In this example it will be 20. Global $iDimension = UBound($aWorkSheets, $UBOUND_DIMENSIONS) ; The dimension of the array e.g. 1/2/3 dimensional. MsgBox($MB_SYSTEMMODAL, "", "The array is a " & $iDimension & " dimensional array with " & _ $iRows & " row(s) & " & $iCols & " column(s).") Dim $checkbox[$iRows] EndFunc ;==>excelsheetlist Func primarygui() ; Create a GUI with various controls. Local $hGUI = GUICreate("Script Controller", 300, ($iRows * 24)) ; Create a checkbox control. ;Local $idCheckbox = GUICtrlCreateCheckbox("Standard Checkbox", 10, 10, 185, 25) Local $Button2 = GUICtrlCreateButton("Close", 210, 200, 85, 25) Local $Button3 = GUICtrlCreateButton("Run", 210, 170, 85, 25) Local $Button1 = GUICtrlCreateButton("Discharge", 210, 140, 85, 25) For $i = 0 To UBound($checkbox) - 1 $checkbox[$i] = GUICtrlCreateCheckbox($aWorkSheets[$i][0], 8, 0 + ($i * 24)) ;, 81, 17) Next ; Display the GUI. GUISetState(@SW_SHOW, $hGUI) ; Loop until the user exits. While 1 $nMsg = GUIGetMsg() Select Case $nMsg = $GUI_EVENT_CLOSE Exit Case $nMsg = $Button2 ;Close Exit Case $nMsg = $Button1 MsgBox(0, "Discharge Button not configured", "Now Exiting") Exit Case $nMsg = $Button3 ;Run $fSelection = False For $i = 0 To UBound($checkbox) - 1 If BitAND(GUICtrlRead($checkbox[$i]), $GUI_CHECKED) Then $fSelection = True ExitLoop EndIf Next If $fSelection Then For $i = 0 To UBound($checkbox) - 1 Assign("status" & $i, GUICtrlRead($checkbox[$i])) Next $batchcount = 0 For $i = 0 To UBound($checkbox) - 1 If Eval("status" & $i) = 1 Then $batchcount = $batchcount + 1 ;Call ("o" & $i & "copy") ; if you want to call the functions directly, remove ; before the call and comment or delete the following DirCopy statement MsgBox(0, "Checking", "Checking that: " & $checkbox[$i] & " no, with title: " & $aWorkSheets[$i][0] & " was selected, Batch count: " & $batchcount) ; if you need only the DirCopy EndIf Next ExitLoop Else MsgBox(48, 'No Items Selected', 'You have not selected any Patients to Load, Please select from the list') EndIf EndSelect WEnd ; Delete the previous GUI and all controls. GUIDelete($hGUI) EndFunc ;==>primarygui Func _IsChecked($idControlID) Return BitAND(GUICtrlRead($idControlID), $GUI_CHECKED) = $GUI_CHECKED EndFunc ;==>_IsChecked Func batchinitial() If Eval("status" & $i) = 1 Then debugbox() $oWorkbook1.Sheets(1).Activate $bigloop = $bigloop + 1 $sheet = $aWorkSheets[$i][0] $oWorkbook1.Sheets($sheet).Activate debugbox() EndIf EndFunc ;==>batchinitial OpenExcel() excelsheetlist() primarygui() For $i = 0 To UBound($checkbox) - 1 batchinitial() While 1 If Eval("status" & $i) = 0 Then ExitLoop ;all the rest of my script loops etc WEnd Next