Sign in to follow this  
Followers 0
harvester2001

Refresh array after one loop

11 posts in this topic

#1 ·  Posted (edited)

Hi

I need some help.

I try ping computers from targets.txt (I have computer name in lines) if they ping I want do something and after that remove pc name from targets.txt. It`s working but problem is when I put this inside loop, because I need run script until all computers will not be removed from the list (targets.txt). I don`t know how to "refresh" array :(

Please help :)

#include <File.au3>
#include <Array.au3>
#include <MsgBoxConstants.au3>

Local $PC_list = "\targets.txt"
Local $bTargets = FileReadToArray(@ScriptDir& $PC_list)

Do
   _check_ping()
   ;count_lines
   Local $file_count_lines = _FileCountLines(@ScriptDir& $PC_list)
   $i = $file_count_lines
   ConsoleWrite("na liście "&$i & @CRLF)
Until $i = 0
; IF &i = 0 then show MsgBox
MsgBox(1, "xXx", "Finish")

;PING
Func _check_ping()
   For $sPC In $bTargets
   $var = Ping($sPC, 250)
      If $var Then
         ConsoleWrite($sPC &"online"& @CRLF)
         ;Do something

         ;Delete $sPC from targets.txt
         Local $_Array
         _FileReadToArray ( @ScriptDir& "\targets.txt", $_Array )
         $_Array = _DeleteArrayElementWithStringInstr ( $_Array, $sPC )
         _FileWriteFromArray ( @ScriptDir& "\targets.txt", $_Array, 1 )
         Sleep(200)
      Else
         ConsoleWrite($sPC &"offline"& @CRLF)
      EndIf
   Next
EndFunc

;DELETE LINE FROM TXT
Func _DeleteArrayElementWithStringInstr ( $_Array, $_String )
    Local $_Item
    For $_Element In $_Array
        If StringInStr ( $_Element, $_String ) <> 0 Then
            _ArrayDelete ( $_Array, $_Item )
        Else
            $_Item+=1
        EndIf
    Next
    Return ( $_Array )
EndFunc ;==> _DeleteArrayElementWithStringInstr ( )

 

Edited by harvester2001

Share this post


Link to post
Share on other sites



If you don't really need to destroy your "targets.txt" file, then you could use an array to track what's going on, keeping your file safe instead.

Something like this should work (not tested)

Local $PC_list = "\targets.txt"
Local $aTargets = FileReadToArray(@ScriptDir & $PC_list)
If @error Then
    MsgBox(0, "Error", "Error on reading file.")
    Exit
EndIf

Local $iToBePinged = UBound($aTargets) ; total nr of pc to ping
Local $aIndex[$iToBePinged + 1] = [$iToBePinged] ; counter in element [0]

; initialize index
For $i = 1 To $aIndex[0]
    $aIndex[$i] = $i - 1
Next

Do
    For $i = $aIndex[0] To 1 Step -1 ; scans all remaining pc
        If Ping($aTargets[$aIndex[$i]], 250) Then
            ConsoleWrite($aTargets[$aIndex[$i]] & " online" & @CRLF)
            ; Do something

            ; adjust indexes
            $aIndex[$i] = $aIndex[$aIndex[0]]
            $aIndex[0] -= 1
        Else
            ; ConsoleWrite($aTargets[$aIndex[$i]] & " offline" & @CRLF)

        EndIf
    Next
Until Not $aIndex[0]

MsgBox(0, "xXx", "Finish")

 


small minds discuss people average minds discuss events great minds discuss ideas.... and use AutoIt....

Share this post


Link to post
Share on other sites

Work like a charm, thank you very much :)

Share this post


Link to post
Share on other sites

#4 ·  Posted (edited)

But this work wery unstable. The loop works, after a few runs exit code. No specific error.

Any ideas how to improve?

 

This is all code, maybe somebody need this.

Script read information about configuration from computers in network.

 

P.S.

I somebody know how to get display resolution (from remote computer) plz give me know :)

#include <MsgBoxConstants.au3>
#include <WinAPIFiles.au3>
#include <FileConstants.au3>
#include <File.au3>
#include <Array.au3>
#include <Date.au3>

Local $PC_list = "\targets.txt"
Local $log_success = "\success.txt"
Local $log_error = "\error.txt"


Local $aTargets = FileReadToArray(@ScriptDir & $PC_list)
If @error Then
    MsgBox(0, "Error", "Error on reading file targets.txt")
    Exit
EndIf

Local $iToBePinged = UBound($aTargets) ; total nr of pc to ping
Local $aIndex[$iToBePinged + 1] = [$iToBePinged] ; counter in element [0]

; initialize index
For $i = 1 To $aIndex[0]
    $aIndex[$i] = $i - 1
Next

Do
    For $i = $aIndex[0] To 1 Step -1 ; scans all remaining pc
        If Ping($aTargets[$aIndex[$i]], 250) Then
            ConsoleWrite($aTargets[$aIndex[$i]] & " online" & @CRLF)
            ; Do something
               czytam_zdalny_pc()
               Sleep(200)
            ; adjust indexes
            $aIndex[$i] = $aIndex[$aIndex[0]]
            $aIndex[0] -= 1
            ConsoleWrite($i & " remained " & @CRLF)
        Else
            ConsoleWrite($aTargets[$aIndex[$i]] & " offline" & @CRLF)
            Sleep(100)
        EndIf
    Next
Until Not $aIndex[0]

MsgBox(0, "INWENTARYZATOR", "Finished gathering information ")


Func czytam_zdalny_pc()

   $objWMIService = ObjGet("winmgmts:{impersonationLevel=Impersonate}!\\" & $aTargets[$aIndex[$i]] & "\root\cimv2")
   If IsObj($objWMIService) Then
         ;Get System
         $colItem = $objWMIService.ExecQuery ("SELECT * FROM Win32_OperatingSystem")
         For $objItem in $colItem
             ;ConsoleWrite( $objItem.CSName & " " & $objItem.Caption & " " & $objItem.Version & @CRLF)
             Local $systemOS = $objItem.CSName & " " & $objItem.Caption & " " & $objItem.Version
         Next

         ;ConsoleWrite(@CRLF)

         ;Get Ram
         $colItem = $objWMIService.ExecQuery ("SELECT * FROM Win32_ComputerSystem")
         For $objItem in $colItem
             ;ConsoleWrite( "Total RAM " & $objItem.TotalPhysicalMemory & @CRLF)
             Local $RAM = Int($objItem.TotalPhysicalMemory /1048576)
         Next

         ;Get PC Model
         $colItem = $objWMIService.ExecQuery ("SELECT * FROM Win32_ComputerSystemProduct")
         For $sOS in $colItem
             ;ConsoleWrite(" Vendor: " & $sOS.Vendor & " SN: " & $sOS.IdentifyingNumber & " Name: " & $sOS.Name & @CRLF)
         Next

         ;ConsoleWrite(@CRLF)

         ; Wpisuje do pliku
         FileWriteLine(@ScriptDir & $log_success, $aTargets[$aIndex[$i]] & _
         " Vendor: " & $sOS.Vendor & " SN: " & $sOS.IdentifyingNumber & " Name: " & $sOS.Name & _
         " System: " & $systemOS & " RAM: " & $RAM &" mb "& _
         @CRLF)


         ;console log
         ConsoleWrite($aTargets[$aIndex[$i]] & " I read data" & @CRLF)
       Else
           ;Msgbox($MB_OK,"WMI Output","No WMI Objects Found for class: " & "Win32_ComputerSystemProduct" )
           ConsoleWrite($aTargets[$aIndex[$i]] & " No WMI Objects Found" & @CRLF)
       Endif
EndFunc

 

Edited by harvester2001

Share this post


Link to post
Share on other sites

Help me plz.

I do something like that, its stable but one problem, its not delete last row and loop never end.

I need loop working until last localization answer for ping.

#include <File.au3>
#include <Array.au3>


For $i = 0 to _FileCountLines(@ScriptDir& "\targets.txt")
   Dim $array = FileReadToArray(@ScriptDir& "\targets.txt")
   For $i = UBound($array) -1 To 0 Step -1
      Sleep(200)
      If Ping($array[$i], 250) Then
         ;ONLINE
         ConsoleWrite($array[$i] & "online" & @CRLF)
         Sleep(200)
         $iIndex = _ArraySearch($array, $array[$i], 1, 0, 0, 1)
         Sleep(200)
         ; And if found - delete
         If Not @error Then
             _ArrayDelete($array, $iIndex)
          EndIf
          Sleep(200)
          _FileWriteFromArray(@ScriptDir& "\targets.txt", $array, 1)
      Else
         ;OFFLINE
         ConsoleWrite($array[$i] & "offline" & @CRLF)
         Sleep(200)
      EndIf
   Next
Next

 

Share this post


Link to post
Share on other sites

Maybe this?

#include <File.au3>
#include <Array.au3>
Dim $array = FileReadToArray(@ScriptDir & "\targets.txt")
For $i = UBound($array) - 1 To 0 Step -1
    Sleep(200)
    If Ping($array[$i], 250) Then
        ;ONLINE
        ConsoleWrite($array[$i] & "online" & @CRLF)
        Sleep(200)
        ; And if found - delete
        If Not @error Then
            _ArrayDelete($array, $i)
        EndIf
        Sleep(200)
    Else
        ;OFFLINE
        ConsoleWrite($array[$i] & "offline" & @CRLF)
        Sleep(200)
    EndIf
Next
_FileWriteFromArray(@ScriptDir & "\targets.txt", $array)

In your script you were reusing the $i variable in the second loop, so the value never gets updated for the first loop.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

Thx, but  loop end when check all locations from list.

I need loop to working untill  locations respond successfully to ping.

If  location is offline loop should check another locations and after finish, check again locations which were offline.

In brief: I want send something for this locations, but if they offline this aplications should wait until they will be online.

Sorry for my english.

Share this post


Link to post
Share on other sites

Try this.

#include <File.au3>
#include <Array.au3>
Dim $array = FileReadToArray(@ScriptDir & "\targets.txt")
Global $ReadError = @error
While $ReadError = 0
    For $i = UBound($array) - 1 To 0 Step -1
        Sleep(200)
        If Ping($array[$i], 250) Then
            ;ONLINE
            ConsoleWrite($array[$i] & "online" & @CRLF)
            Sleep(200)
            ; And if found - delete
            If Not @error Then
                _ArrayDelete($array, $i)
            EndIf
            Sleep(200)
        Else
            ;OFFLINE
            ConsoleWrite($array[$i] & "offline" & @CRLF)
            Sleep(200)
        EndIf
    Next
    If UBound($array) > 0 Then
        _FileWriteFromArray(@ScriptDir & "\targets.txt", $array)
    Else
        ExitLoop
    EndIf
    $array = FileReadToArray(@ScriptDir & "\targets.txt")
    $ReadError = @error
WEnd

If FileReadToArray reads an empty file it will set the @error macro and the While loop will end. If the $array array is empty, it exits the loop as well, which would only happen if all the Pings return as valid.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

#10 ·  Posted (edited)

harvester2001,

Another way to look at the problem.  The loop is controlled by a switch and the source file is not altered.

#include <array.au3>
#include <date.au3>

Local $aPingList = StringSplit(FileRead(@ScriptDir & '\targets.txt'), @CRLF, 3), $again = True

While $again

    $again = False

    For $1 = 0 To UBound($aPingList) - 1

        If $aPingList[$1] = '' Then ContinueLoop
        Ping($aPingList[$1], 250)
        If @error Then
            ConsoleWrite('!  ' & StringFormat('%10s %30s was not reachable', _Now(), $aPingList[$1]) & @CRLF)
            $again = True ; loop again
        Else
            ConsoleWrite('>  ' & StringFormat('%10s %30s was     reachable', _Now(), $aPingList[$1]) & @CRLF)
            ;
            ; go do your other stuff
            ;
            $aPingList[$1] = '' ;   clear entry
        EndIf

    Next
WEnd

kylomas

Edited by kylomas

Forum Rules         Procedure for posting code

"I like pigs.  Dogs look up to us.  Cats look down on us.  Pigs treat us as equals."

- Sir Winston Churchill

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • 31290
      By 31290
      Hi guys, 
      Hope you are fine today
      I'm trying to restart a function by calling it back in the script:
      Here's my code so far:
      Func f_VPN() $iInputBox = InputBox("Password", "Please Enter the User's password.") If @Error = 1 Then GUICtrlSetState($fVPN, $GUI_UNCHECKED) Else ShellExecute("C:\Program Files (x86)\Cisco\Cisco AnyConnect Secure Mobility Client\vpnui.exe") $hVPN = WinWait("Cisco AnyConnect Secure Mobility Client", "Ready to connect") ControlClick($hVPN, "", "Button1") $hVPN1 = WinWait("Cisco AnyConnect | SEE VPN", "Cancel") ControlSetText($hVPN1, "", "Edit2", @Username) Sleep(250) ControlSetText($hVPN1, "", "Edit3", $iInputBox) Sleep(250) ControlClick($hVPN1, "", "Button1") Sleep(5000) If ControlGetText("Cisco AnyConnect Secure Mobility Client", "", "Static2") = "Login Failed" Then ControlClick("Cisco AnyConnect Secure Mobility Client", "", "Button4") WinClose($hVPN) f_VPN() Else ShellExecute("C:\Program Files (x86)\Cisco\Cisco AnyConnect Secure Mobility Client\vpnui.exe") If ControlGetText("Cisco AnyConnect Secure Mobility Client", "", "Static2") = "Connected To SEE VPN." Then ControlClick("Cisco AnyConnect Secure Mobility Client", "", "Button1") Sleep(1000) WinClose("Cisco AnyConnect Secure Mobility Client", "") ProcessClose("vpnui.exe") ; ProcessClose("explorer.exe") <<< TO UNCOMMENT IniWrite($oIniFile, "LaptopChkBox", "VPN", "1") EndIf EndIf EndFunc I'd like to the function to be restarted in the case the password provided is not correct. 
      I've googled many things but nothing very relevant.
      Any ideas over here?
      Thanks
      -31290
       
    • StillLearningThisStuff
      By StillLearningThisStuff
      Hello all,
      Summary: I have a basic piece of code that is to be a part of a much larger project; I just can't seem to get the right output. I'm retrieving two lots of powershell data into 2 x 1d arrays and trying to add them into a single 2d array. Retrieving the data together into the 2d array seemed harder, due to the application names varying too much to string split. Data being pulled is application name and GUID. From here I will use this info in a drop down box and an uninstall button to run the required command to remove the selected software (have this sorted already).
      Problem: When I merge the data it doesn't put the application name and GUID on the same row in differing columns eg. my test box has 24 applications plus some superfluous data from Powershell to be cleaned up by the _arraydeletes. Instead I end up with an array with 58 rows and 2 columns; whereas my temp 1d arrays have 28 rows. As you can see I've tried both _ArrayInsert and _ArrayAdd but I still get the same result.
      Question: Is there something that I'm doing wrong in putting the data into the 2d array or do I just need to do some more post processing to tidy it up and align the names and GUIDs?
      Code:
      #include <Array.au3> $Cmd1 = (" /c Powershell.exe " & Chr(34) & "Get-WmiObject -Class win32reg_addremoveprograms | where {$_.ProdID -like " & Chr(34) & Chr(123) & Chr(42) & Chr(125) & Chr(34) & "} | select DisplayName" & Chr(34)) $Cmd2 = (" /c Powershell.exe " & Chr(34) & "Get-WmiObject -Class win32reg_addremoveprograms | where {$_.ProdID -like " & Chr(34) & Chr(123) & Chr(42) & Chr(125) & Chr(34) & "} | select ProdID" & Chr(34)) Global $aNameGUID[1][2] ;_ArrayDisplay($aNameGUID) ReadApps($Cmd1,0) ;_ArrayDisplay($aNameGUID) ReadApps($Cmd2,1) _ArrayDisplay($aNameGUID) Terminate() Func ReadApps($Command,$col) $DOS = Run(@ComSpec & $Command, "", @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) ProcessWaitClose($DOS) $DOSOut = StdoutRead($DOS) ;MsgBox(0,"Data",$DOSOut) ;Show the line items that we want in the array Local $tmpArray = StringSplit(StringTrimRight(StringStripCR($DOSOut), StringLen(@CRLF)), @CRLF) If @error Then MsgBox(0,"FAIL","I failed to find objects") Exit Else _ArrayDisplay($tmpArray) EndIf ;_ArrayDelete($tmpArray, 3) ;_ArrayDelete($tmpArray, 2) ;_ArrayDelete($tmpArray, 1) ;$tmpArray[0] = $tmpArray[0] - 3 For $i = 0 To UBound($tmpArray) - 1 ;_ArrayAdd($aNameGUID, $tmpArray[$i], $col) _ArrayInsert($aNameGUID, 0, $tmpArray[$i], $col) Next $tmpArray = 0 EndFunc ;==>ReadApps While 1 Sleep(1500) WEnd Func Terminate() Exit 0 EndFunc ;==>Terminate Thanks in advance,
      Luxyboy
    • j0kky
      By j0kky
      Hi guys,
      talking about array in array, I would like to directly assign a value to an element in an array contained in another array.
      While it is quite simple to access the value if it is already setted:
      Local $a[3] = [1, 2], $b[2] = [3, 4] $a[2] = $b ConsoleWrite(($a[2])[0] & " " & ($a[2])[1] & @CRLF) If I try to write directly to the element, I get an error:
      Local $a[3] = [1, 2] Local $b[2] $a[2] = $b ($a[2])[0] = 1 Is assigning first every value of the contained array and then including it in the container the only way?
    • harvester2001
      By harvester2001
      Hi
      I need help, I found script to check computer model. I want use it in loop to chceck multiple pc`s (targets.txt with computer names).
      But when i try use inside loop i get error: Variable must be of type "Object" and I dont know how to fix this
      Plz help
       
      Local $targets = @ScriptDir& "\targets.txt" Local $log_name = "\scan.log" $msgBox = MsgBox(4, "Scan", "need tergets.txt") Example() Func Example() If $msgBox = 7 Then exit EndIf If Not FileExists($targets) Then MsgBox($MB_SYSTEMMODAL, "", "File: targets.txt - no exist !") Exit EndIf FileOpen($targets, 0) Global $arr[1000] ReDim $arr[_FileCountLines($targets)+1] For $i = 1 to _FileCountLines($targets) $line = FileReadLine($targets, $i) $arr[$i] = $line ; chceck if pc is online Local $iPing = Ping($arr[$i], 250) If $iPing Then ; ONLINE Local $strComputer = $arr[$i] $colItems = "" $Output="" $Output = $Output & "Computer: " & $strComputer & @CRLF $Output = $Output & "==========================================" & @CRLF $objWMIService = ObjGet("winmgmts:\\" & $strComputer & "\root\CIMV2") $colItems = $objWMIService.ExecQuery("SELECT * FROM Win32_ComputerSystemProduct", "WQL", _ "0x10" + "0x20") If IsObj($colItems) then For $objItem In $colItems $Output = $Output & "Vendor: " & $objItem.Vendor & @CRLF $Output = $Output & "SN: " & $objItem.IdentifyingNumber & @CRLF $Output = $Output & "Name: " & $objItem.Name & @CRLF $Output = $Output & "UUID: " & $objItem.UUID & @CRLF if Msgbox(1,"WMI Output",$Output) = 2 then ExitLoop $Output="" Next Else Msgbox(0,"WMI Output","No WMI Objects Found for class: " & "Win32_ComputerSystemProduct" ) Endif Else ;OFFLINE _FileWriteLog(@ScriptDir & $log_name, $arr[$i]&" OFFLINE") EndIf Next EndFunc  
       
    • SorryButImaNewbie
      By SorryButImaNewbie
      Hello all!
      I wrote a little script to automate some of my work (for which I'm greatfull).
      I have little problem now. My script get data of currency values from specified time period. The problem, if XY day is a holiday or something, then the bank doesn't have new values for that day, thus my script can ask for "till that date" if there is only data for "till that date-1".
      I should be done with this for tomorrow and I should learn for my test paper tomorrow, make a genetic algorhytm homework, and at least look at a ppt...
      So here is my code, pleas ask if you need more information!
      InternetRead2() ;Creating Date and Arfolyam arrays, using DateInterval read from above (_ArraysDisplayed and function is "tested") ;Calculate and write HUF*OSSZEG Do Local $SZAMLATELJOlvaso = _Excel_RangeRead($ExcelObject, Default, $SZAMLATELJoszlop & $CellaOlvasoSzamlalo) Local $Time = StringTrimRight($SZAMLATELJOlvaso, 6) $DateArrayTimeIndex = _ArraySearch($DateArray, $Time, 0, 0, 0, 0, 1) ;MsgBox(64, "Értesítés", $DateArrayTimeIndex) If @error = 6 Then $DateArrayTimeIndex = _ArraySearch($DateArray, $Time-1, 0, 0, 0, 0, 1) ;MsgBox(64, "Értesítés", $DateArrayTimeIndex) EndIf If @error = 6 Then $DateArrayTimeIndex = _ArraySearch($DateArray, $Time-2, 0, 0, 0, 0, 1) ;MsgBox(64, "Értesítés", $DateArrayTimeIndex) EndIf If @error = 6 Then $DateArrayTimeIndex = _ArraySearch($DateArray, $Time-3, 0, 0, 0, 0, 1) ;MsgBox(64, "Értesítés", $DateArrayTimeIndex) EndIf If @error = 6 Then $DateArrayTimeIndex = _ArraySearch($DateArray, $Time-4, 0, 0, 0, 0, 1) ;MsgBox(64, "Értesítés", $DateArrayTimeIndex) EndIf $DateArrayTimeIndex = $DateArrayTimeIndex+1 ;Egyébként arraysearch -1et ad vissza, 0nál. Passz Sleep(200) If Not $SZAMLATELJOlvaso = "" Then _Excel_RangeWrite($ExcelObject, $ExcelObject.Activesheet, "=" & $OSSZEGoszlop & $CellaOlvasoSzamlalo & "*" & String($ArfolyamArray[$DateArrayTimeIndex]) & "", String($sHUFBeszurOszlop) & $CellaOlvasoSzamlalo) If @error Then _Excel_RangeWrite($ExcelObject, $ExcelObject.Activesheet, "=" & $OSSZEGoszlop & $CellaOlvasoSzamlalo & "*" & String($ArfolyamArray[$oXML_Node.Length]) & "", String($sHUFBeszurOszlop) & $CellaOlvasoSzamlalo) MsgBox(64, "Értesítés", "Valamilyen okból, nem találok az adott dátumhoz árfolyamot, a keresési idők közül a legutolsó árfolyammal töltöttem ki!" & @CRLF & Number($oXML_Node_Datum)) EndIf EndIf $CellaOlvasoSzamlalo = $CellaOlvasoSzamlalo + 1 Until $SZAMLATELJOlvaso = "" also my internetread2 function :
      Func InternetRead2() ;ezt használja az excelmove ;----------------------------------- ;Original Source: https://www.autoitscript.com/forum/topic/184884-solved-basic-com-help-working-on-string-returned-from-api-mi-doing-this-okey/ ;by Genius257 ;TO DO: Some error handling maybe: what if there is no $MinTime/$MaxTime? ;Read the returns in to array for future use --> Right now, 2 arrays one with the dates and one with the exchangerates ;----------------------------------- ;Globals decleared to avoid warnings Global $MinTime ;20160601000000 Global $MaxTime ;20160610000000 Global $MinTimeFormated = StringTrimRight($MinTime, 6) Global $MaxTimeFormated = StringTrimRight($MaxTime, 6) $oHTTP = ObjCreate("WinHttp.WinHttpRequest.5.1") If $MaxTimeFormated = "" and $MinTimeFormated = "" Then MsgBox(64, "Értesítés", "Nincsenek beolvasott dátumok a memóriában, dummy dátumokat adok meg!" & @CRLF & "20160901, 20160910") $MinTimeFormated = "20160901" $MaxTimeFormated = "20160905" EndIf $oHTTP.Open("GET", "http://api.napiarfolyam.hu/?bank=mnb&valuta=eur&datum="&$MinTimeFormated&"&datumend="&$MaxTimeFormated&"", False) $oHTTP.Send() $sXML = $oHTTP.responseText Global $oXML = ObjCreate("Microsoft.XMLDOM") $oXML.loadXML( $sXML ) $oXML_Nodes = $oXML.SelectNodes("./arfolyamok/deviza/item") Global $ArfolyamArray[$oXML_Nodes.Length] ;MsgBox(64, "Title", "" & $oXML_Nodes.Length & "") ;_ArrayDisplay($ArfolyamArray) Global $DateArray[$oXML_Nodes.Length] For $i=0 To $oXML_Nodes.Length-1 Global $oXML_Node = $oXML_Nodes.Item($i) $oXML_Node_Bank = $oXML_Node.SelectNodes("./bank") $oXML_Node_Bank = $oXML_Node_Bank.Length>0?$oXML_Node_Bank.Item(0).text:"" Global $oXML_Node_Datum = $oXML_Node.SelectNodes("./datum") $oXML_Node_Datum = $oXML_Node_Datum.Length>0?$oXML_Node_Datum.Item(0).text:"" $oXML_Node_Penznem = $oXML_Node.SelectNodes("./penznem") $oXML_Node_Penznem = $oXML_Node_Penznem.Length>0?$oXML_Node_Penznem.Item(0).text:"" $oXML_Node_Kozeps = $oXML_Node.SelectNodes("./kozep") $oXML_Node_Kozep01 = $oXML_Node_Kozeps.Length>0?$oXML_Node_Kozeps.Item(0).text:"" $oXML_Node_Kozep02 = $oXML_Node_Kozeps.Length>1?$oXML_Node_Kozeps.Item(1).text:"" $ArfolyamArray[$i] = $oXML_Node_Kozep01 $DateArray[$i] = StringTrimRight(StringReplace($oXML_Node_Datum, "-", ""), 8) ConsoleWrite( "Match [" & StringFormat("%02i", $i+1) & "]:"&@CRLF& _ @TAB&"Bank: "&@TAB&$oXML_Node_Bank&@CRLF& _ @TAB&"Datum: "&@TAB&$oXML_Node_Datum&@CRLF& _ @TAB&"Penznem: "&@TAB&$oXML_Node_Penznem&@CRLF& _ @TAB&"Kozep01: "&@TAB&$oXML_Node_Kozep01&@CRLF& _ @TAB&"Kozep02: "&@TAB&$oXML_Node_Kozep02&@CRLF _ ) Next ;_ArrayDisplay($ArfolyamArray) ;_ArrayDisplay($DateArray) EndFunc My problem is that I have dates in my excel till 2016.10.30, but I only have dates till 28.
      (see the api, according to aoutit console, I have the same data: http://api.napiarfolyam.hu/?bank=mnb&valuta=eur&datum=20161001&datumend=20161030 )
      My idea/goal (with the If @error then... after @SZAMLATELJolvaso part) is that if this happens, I want it to automaticly jump to the last date of the array (I will be able to write something more elaborate, but for now thats my goal, to save the sinking ship )
      Thank yu for your help and insight!