Combo Box Read Value Bugging

[anub13]

Hi,

I am having difficulties wondering why my code bugging like this,
the symptom : I have a form with combo box, and details in bottom of the app, when user choose another option the details changes immediately but when I go to details, it goes up and down endlessly

here is the code

 

expandcollapse popup

Global $cChkPatrol, $YES= "YES", $NO = "NO"

if GUICtrlRead($combo1) = "YES" Then
    $cChkPatrol = $YES
Else
    $cChkPatrol = $NO
EndIf

func StartForm()

    GUICtrlSetData($txtInfo,"ADDITIONAL INFORMATION THAT WILL BE SENT WITH THE MESSAGE:" & @CRLF & asdfgSystemInfo())
    GUISetState(@SW_SHOW)
    AdlibRegister("_CheckPatrol")
    While 1
        $nMsg = GUIGetMsg()
        Select
            case $nMsg = $txtEmailAddress
                GUICtrlSetData($txtInfo,"ADDITIONAL INFORMATION THAT WILL BE SENT WITH THE MESSAGE:" & @CRLF & asdfgSystemInfo())
            case $nMsg = $txtPhone
                GUICtrlSetData($txtInfo,"ADDITIONAL INFORMATION THAT WILL BE SENT WITH THE MESSAGE:" & @CRLF & asdfgSystemInfo())

            case $nMsg = $txtFullName
                GUICtrlSetData($txtInfo,"ADDITIONAL INFORMATION THAT WILL BE SENT WITH THE MESSAGE:" & @CRLF & asdfgSystemInfo())

            case $nMsg = $cChkPatrol
                GUICtrlSetData($txtInfo,"ADDITIONAL INFORMATION THAT WILL BE SENT WITH THE MESSAGE:" & @CRLF & asdfgSystemInfo())
            case $nMsg = $cmdScreenShot
                $gScreenShotFile =  SaveScreenShot()

            case $nMsg = $cmdSubmit
                if ValidateForm() then
                    if asdfgSubmit() Then
                        UpdateStatus("Your request has been sent successfully")
                        MsgBox(0,"Help Requested","Your request has been sent successfully")
                        ExitLoop
                    Else

                        MsgBox(0,"Help Failed","Something is wrong you request was not sent, please try again")

                    Endif
                endIf
            case $nMsg = $cmdAttach
                $gAttachFile = AttachFile()

            Case $nMsg = $GUI_EVENT_CLOSE
                ExitLoop
        EndSelect
    WEnd
    AdlibUnRegister("_CheckPatrol")
EndFunc

func asdfgSystemInfo()

    dim $asdfgInfo
    $asdfgInfo = ""  & @CRLF

    if $isAdminVersion=1 then
        $asdfgInfo = $asdfgInfo & @CRLF & " Ticket Tags:" & @CRLF
        $asdfgInfo = $asdfgInfo & "~#userphone='" & GUICtrlRead($txtPhone) & "'" & @CRLF
        $asdfgInfo = $asdfgInfo & "~#submitterphone='" & GUICtrlRead($txtPhone) & "'" & @CRLF
        dim $MachineID
        $MachineID = KaseyaIni($gKIniFile,"SERVER COMMUNICATIONS","User_Name","NotFound")
        $asdfgInfo = $asdfgInfo & "~#machineid='" & $MachineID & "'" & @CRLF

        dim $OrgGroups
        $OrgGroups= StringSplit($MachineID,".")

        dim $OrgGroupIndex
        $OrgGroupIndex = UBound($OrgGroups) - 1
        $asdfgInfo = $asdfgInfo & "~#organization='" & $OrgGroups[$OrgGroupIndex] & "'" & @CRLF

        dim $EmailUser
        $EmailUser = GUICtrlRead($txtEmailAddress)
        $EmailUser = StringMid($EmailUser,1,StringInStr($EmailUser,"@") - 1)  & @CRLF  & @CRLF


        $asdfgInfo = $asdfgInfo & "~#username='" & $EmailUser & "'" & @CRLF

        ;dim
        ;Call("isChecked")
        ;$categ = GUICtrlRead($chkPatrol)
        ;$asdfgInfo = $asdfgInfo & "-#category='" & $categ & "'" & @CRLF

    EndIf

    $asdfgInfo = $asdfgInfo & "Email:" & GUICtrlRead($txtEmailAddress) & @CRLF & @CRLF
    $asdfgInfo = $asdfgInfo & "Full Name:" & GUICtrlRead($txtFullName) & @CRLF & @CRLF
    $asdfgInfo = $asdfgInfo & "Phone:" & GUICtrlRead($txtPhone) & @CRLF & @CRLF


    $asdfgInfo = $asdfgInfo & "DateTime:" & _Now() & @CRLF
    $asdfgInfo = $asdfgInfo & "MachineName:" & @ComputerName & @CRLF
    $asdfgInfo = $asdfgInfo & "UserName:" & @UserName & @CRLF
    $asdfgInfo = $asdfgInfo & "OS:" & @OSType & " " & @OSVersion & @CRLF
    $asdfgInfo = $asdfgInfo & "LogonDomain:" & @OSType & " " & @LogonDomain & @CRLF
    $asdfgInfo = $asdfgInfo & "LogonDNSDomain:" & @OSType & " " & @LogonDNSDomain & @CRLF
    $asdfgInfo = $asdfgInfo & "OS:" & @OSType & " " & @OSVersion & @CRLF

    $asdfgInfo = $asdfgInfo & "IP Address:" & @IPAddress1  & @CRLF
    $asdfgInfo = $asdfgInfo & "Public IP Address:" & GetPublicIP() &@CRLF
    ;$asdfgInfo = $asdfgInfo & "Public IP Address:" & _GetIP () &@CRLF

    $asdfgInfo = $asdfgInfo & "OS:" & NetAdapterInfo()

    $asdfgInfo = $asdfgInfo & "KaseyaInstalled:" & KaseyaInstalled() & @CRLF
    $asdfgInfo = $asdfgInfo & "KaseyaRunning:" & KaseyaRunning() & @CRLF
    $asdfgInfo = $asdfgInfo & "KaseyaAgentGUID:" & KaseyaIni($gKIniFile,"SERVER COMMUNICATIONS","Agent_Guid","NotFound") & @CRLF
    $asdfgInfo = $asdfgInfo & "asdfgPaid:" & isasdfgIDPaid() & @CRLF

    if $isAdminVersion=0 then
        $asdfgInfo = $asdfgInfo & @CRLF & " Ticket Tags:" & @CRLF
        $asdfgInfo = $asdfgInfo & "~userphone='" & GUICtrlRead($txtPhone) & "'" & @CRLF
        $asdfgInfo = $asdfgInfo & "~submitterphone='" & GUICtrlRead($txtPhone) & "'" & @CRLF

        dim $MachineID
        $MachineID = KaseyaIni($gKIniFile,"SERVER COMMUNICATIONS","User_Name","NotFound")
        $asdfgInfo = $asdfgInfo & "~machineid='" & $MachineID & "'" & @CRLF

        dim $OrgGroups
        $OrgGroups= StringSplit($MachineID,".")

        dim $OrgGroupIndex
        $OrgGroupIndex = UBound($OrgGroups) - 1
        $asdfgInfo = $asdfgInfo & "~organization='" & $OrgGroups[$OrgGroupIndex] & "'" & @CRLF

        dim $EmailUser
        $EmailUser = GUICtrlRead($txtEmailAddress)
        $EmailUser = StringMid($EmailUser,1,StringInStr($EmailUser,"@") - 1)

        $asdfgInfo = $asdfgInfo & "~username='" & $EmailUser & "'" & @CRLF

        dim $categ
        $categ = $chkPatrol
        $asdfgInfo = $asdfgInfo & "~category='" & $categ & "'" & @CRLF

        dim $track
        $track = $cChkPatrol
        $asdfgInfo = $asdfgInfo & "~test='" & $cChkPatrol & "'" & @CRLF

        $asdfgInfo = $asdfgInfo & "~afterhour='" & $AfterHour & "'" & @CRLF
    endif

    Return $asdfgInfo

endFunc

 

Yes it was same app as previous post in the forum I asked, I also having experience this happening before but I fail to understand the reason why this is happening. Thanks in advance.

ButtonSupport - Copy.au3

[BrewManNH]

35 minutes ago, anub13 said:

when user choose another option the details changes immediately but when I go to details, it goes up and down endlessly

What exactly do you mean by this? You're only reading the combobox in one place, and then you never read from it again.

[anub13]

6 minutes ago, BrewManNH said:

What exactly do you mean by this? You're only reading the combobox in one place, and then you never read from it again.

please find attached files for the img

when I change the option to YES, ADDITIONAL INFORMATION ........

when the cursor goes to that area, and scroll it down, always back to up I can't go down at all.

Edited April 26, 2017 by anub13
typos

[BrewManNH]

There's no way for me to run this because of the internet connection test you have in it, and I'm not going to go through the effort to make it runnable.

 

[anub13]

5 minutes ago, BrewManNH said:

There's no way for me to run this because of the internet connection test you have in it, and I'm not going to go through the effort to make it runnable.

 

Here I edited the code, now should be running without internet connection.

ButtonSupport - Copy.au3

[BrewManNH]

I still had to heavily modify it to get it to run.

The problem is caused in 2 places.

1. Your function _CheckPatrol is constantly reloading the information in the edit box, for no good reason that I can see.
2. You have a line in your GUI message handler looking at the variable $cChkPatrol, this isn't a control on your GUI, it's just a variable that contains Yes or No, and it's getting processed every time the loop runs. Delete this section, as it's unnecessary as it's written.

   case $nMsg = $cChkPatrol
       GUICtrlSetData($txtInfo,"ADDITIONAL INFORMATION THAT WILL BE SENT WITH THE MESSAGE:" & @CRLF & asdfgSystemInfo())

   You might want to consider moving the GUICtrlSetData inside your If statements in _CheckPatrol and see if that eliminates some of the excessive rewriting of the edit box.

[anub13]

17 minutes ago, BrewManNH said:

I still had to heavily modify it to get it to run.

The problem is caused in 2 places.

1. Your function _CheckPatrol is constantly reloading the information in the edit box, for no good reason that I can see.
2. You have a line in your GUI message handler looking at the variable $cChkPatrol, this isn't a control on your GUI, it's just a variable that contains Yes or No, and it's getting processed every time the loop runs. Delete this section, as it's unnecessary as it's written.

   case $nMsg = $cChkPatrol
       GUICtrlSetData($txtInfo,"ADDITIONAL INFORMATION THAT WILL BE SENT WITH THE MESSAGE:" & @CRLF & asdfgSystemInfo())

   You might want to consider moving the GUICtrlSetData inside your If statements in _CheckPatrol and see if that eliminates some of the excessive rewriting of the edit box.

sorry about it, I thought I ran it well in here

OK will try as you said and be right back.

[anub13]

@BrewManNH

Still need some time... at the moment still figuring out to solve it.

Thanks for responding.

EDIT:

Sorry for double post.

EDIT 2: 

@BrewManNH

just complete the code, put simple code 

Func checkCombo()
    if GUICtrlRead($combo1) = "YES" Then
        $chkTrack = $YES
    Else
        $chkTrack = $NO
    EndIf
EndFunc

and called it on here

case $nMsg = $combo1
checkCombo()
GUICtrlSetData($txtInfo,"ADDITIONAL INFORMATION THAT WILL BE SENT WITH THE MESSAGE:" & @CRLF & TCDSystemInfo())

 thanks for your help

Edited April 27, 2017 by anub13
typos