SampleControls.au3 in Dark Mode

[WildByDesign]

There seems to be a bug with the custom tab control drawing in _WinProc. It randomly erases whatever content is in the tab during the custom drawing. For example, in example script without any modifications, the label with the text Sample Tab gets erased on GUI startup approx. 20% of the time. Also, when switching back and forth from either tab Two or Three back to tab One, the label is also getting erased in that scenario as well approx. 20% of the time.

I haven't been able to figure out the root cause but it seems mostly to be a timing issue.

EDIT: I also tried modifying the code slightly by adding a simple checkbox in the tab and the checkbox randomly gets erased as well. At first I was thinking maybe the issue was related to the label coloring. But it definitely has to be the custom tab drawing causing the contents of the tab to be erased.

Edited February 23 by WildByDesign

[UEZ]

The problem was that the entired tab client area was overwritten in _WinProc -> WM_PAINT section by _WinAPI_BitBlt. I exluded that client area.

I added also a repaint when minimized GUI was restored again and added a checkbox on 2nd tab. Should work now - please test (see 1st post).

[WildByDesign]

3 hours ago, UEZ said:

The problem was that the entired tab client area was overwritten in _WinProc -> WM_PAINT section by _WinAPI_BitBlt. I exluded that client area.

I added also a repaint when minimized GUI was restored again and added a checkbox on 2nd tab. Should work now - please test (see 1st post).

I got a chance to test the fix now and it works perfectly. Thank you.

[UEZ]

I created a fake DateTimePicker control. Does anyone know in which DLL or other file the original icon is hidden?

 

[WildByDesign]

Here is the closest that I could find. This is in shell32.dll.mun

[WildByDesign]

I have a couple of suggestions if you are interested. I noticed that you implemented some of the newer Win11 DarkMode_DarkTheme stuff. They have a really nice dark mode progress theme now as well.

Case "msctls_progress32"
    _WinAPI_SetWindowTheme($hCtrl, "DarkMode_CopyEngine", "Progress")

I really like your idea for drawing the dark mode checkboxes for the TreeView control. Just some suggestions to match the regular checkbox control:

• The black showing on the outside of the checkbox rectangle should be transparent. The black is also covering up part of the TreeView item selection rectangle. Transparency on the outside of the checkbox rectangle would fix that also.
• The fill color on the inside of the unchecked checkbox is 0x242424 (on the regular dark mode checkbox)

Keep up the fantastic work. I have learned so much from you.

[WildByDesign]

I noticed a bug with _WM_INITMENUPOPUP last week but I forgot to mention. Basically, I don't think it is working at all and may not be necessary. System menu, top menus and context menu all trigger your _WM_INITMENUPOPUP which is good.

However, I think that the problem is that _WinAPI_GetForegroundWindow is not capable of detecting #32768 and it never gets past there.

The only way that I was able to successfully get these #32768 handles was with a WinEventHook. But _WinAPI_GetForegroundWindow does not seem to get them. With or without the sleep timer, it does not seem to matter.

Here is your function with a few ConsoleWrites to see how far it makes it:

expandcollapse popup

Func _WM_INITMENUPOPUP($hWnd, $iMsg, $wParam, $lParam)
    ; wParam = HMENU of the popup, lParam = position/index - not needed here
    ; A small delay sometimes helps to ensure the popup window exists
    ConsoleWrite("_WM_INITMENUPOPUP initial trigger." & @CRLF)
    Sleep(100)

    ; The foreground window is most likely the new menu popup
    Local $hPopup = _WinAPI_GetForegroundWindow()
    If Not $hPopup Then Return $GUI_RUNDEFMSG
    ConsoleWrite("_WM_INITMENUPOPUP after _WinAPI_GetForegroundWindow." & @CRLF)

    Local $sCls = StringLower(_WinAPI_GetClassName($hPopup))
    If $sCls <> "#32768" And $sCls <> "popupmenu" Then
        ; if no menu popup is detected -> do nothing
        Return $GUI_RUNDEFMSG
    EndIf

    ; Set Theme + AllowDarkMode on the popup itself
    _WinAPI_SetWindowTheme($hPopup, "DarkMode_Explorer", "")
    _WinAPI_AllowDarkModeForWindow($hPopup, True)

    ConsoleWrite("_WM_INITMENUPOPUP coloring." & @CRLF)

    ; Also apply the theme to all child windows of the popup (e.g., scrollbars)
    Local $hChild = _WinAPI_GetWindow($hPopup, $GW_CHILD)
    While $hChild
        Local $sChildCls = StringLower(_WinAPI_GetClassName($hChild))
        ; apply theme specifically for scrollbars, UpDown, etc.
        If $sChildCls = "scrollbar" Or $sChildCls = "msctls_updown32" Or $sChildCls = "traynotifywnd" Then
            _WinAPI_SetWindowTheme($hChild, "DarkMode_Explorer", "")
            _WinAPI_AllowDarkModeForWindow($hChild, True)
        Else
            ; try generically
            _WinAPI_SetWindowTheme($hChild, "DarkMode_Explorer", "")
            _WinAPI_AllowDarkModeForWindow($hChild, True)
        EndIf
        $hChild = _WinAPI_GetWindow($hChild, $GW_HWNDNEXT)
    WEnd

    ; Force refresh so the change is visible immediately
    _WinAPI_FlushMenuThemes()
    _WinAPI_RefreshImmersiveColorPolicyState()
    _WinAPI_RedrawWindow($hPopup, 0, 0, BitOR($RDW_INVALIDATE, $RDW_UPDATENOW))

    Return $GUI_RUNDEFMSG
EndFunc   ;==>_WM_INITMENUPOPUP

 

[UEZ]

_WM_INITMENUPOPUP() is useless and can be removed.