Could this be better

[danzar 0]

i am new but real excited about the use of this program. i would like some feedback on this rough but runable script. i just tring to learn from more experince people.

thanks

danzar

CODE

Global $mob

Opt("MouseCoordMode", 0)

Opt("PixelCoordMode", 0)

Opt("MouseClickDelay", 0)

Opt("MouseClickDownDelay", 0)

Global $Paused

HotKeySet("{HOME}", "Terminate") ;

HotKeySet("{Pause}", "TogglePause");

HotKeySet("{ESC}", "Terminate");

;starts here

Opt("WinTitleMatchMode", 4)

WinWait("RF Online","")

ControlClick("RF Online","","D3D Window0")

while 1

call("lookingfor")

WEnd

func lookingfor()

$findmob = pixelgetcolor(445,54)

if $findmob <> 16250863 Then

call("targetbrutal")

Else

sleep(0)

EndIf

EndFunc

func targetbrutal()

$rand = Random(1,2,1)

switch $rand

Case 1

Opt("SendKeyDownDelay", 10)

send("{d}")

$mob = PixelSearch(0,0,800,600,0x381E0A,1,1)

if not @error Then

MouseClick("left", $mob[0],$mob[1])

send("{SPACE}")

EndIf

CASE 2

ContinueCase

EndSwitch

EndFunc

Func TogglePause()

$Paused = NOT $Paused

While $Paused

sleep(100)

ToolTip('Script is "Paused"',0,0)

WEnd

EndFunc

Func Terminate()

Exit 0

EndFunc

[PaulIA 1]

Good start. Some general comments:

1. Group your Opts and Globals together.

2. Use mixed case letters in all names. All lower case/upper case is hard to read.

3. Use the "MustDeclareVars" option so that you force yourself to declare local/global variables.

4. Don't use Call() as it has very specific uses.

expandcollapse popup

Opt("MouseClickDelay", 0)
Opt("MouseClickDownDelay", 0)
Opt("MouseCoordMode", 0)
Opt("MustDeclareVars", 1)
Opt("PixelCoordMode", 0)
Opt("SendKeyDownDelay", 10)
Opt("WinTitleMatchMode", 4)

Global $Mob
Global $Paused

HotKeySet("{HOME}", "Terminate") ;
HotKeySet("{Pause}", "TogglePause");
HotKeySet("{ESC}", "Terminate");

;
; Main
;
WinWait("RF Online", "") ; <-- Might want to use WinWaitActive here
ControlClick("RF Online", "", "D3D Window0")

While 1
  if PixelGetColor(445, 54) <> 16250863 Then
    if Random(1, 2, 1) = 1 then
      Send("{d}")    
      $Mob = PixelSearch(0, 0, 800, 600, 0x381E0A, 1, 1)
      if not @error Then
        MouseClick("left", $Mob[0], $Mob[1])
        Send("{SPACE}")
      EndIf
    EndIf
  EndIf
  Sleep(100)
WEnd

;
; TogglePause
;
Func TogglePause()
  $Paused = Not $Paused
  While $Paused
    Sleep(100)
    ToolTip('Script is "Paused"', 0, 0)
  WEnd
EndFunc

;
; Terminate
;
Func Terminate()
  Exit
EndFunc

Edit: Took a little more liberty with the original code

Edited December 21, 2006 by PaulIA

[theguy0000 2]

Unnecessary use of Call

call("lookingfor")oÝ÷ ÙƧë-m殶­sfÆöö¶ævf÷"oÝ÷ ٩ݲ'jwp+ay)^zrÛ²¢ç;¬¶Ö¤z­¶°^[rV®±æ®¶­sdgVæ2Æöö¶ætf÷"¢b33c´fæDÖö"ÒVÆvWF6öÆ÷"CCRÃSB¢bb33c´fæDÖö"fÇC²fwC²c#Sc2FVà¢F&vWD''WF¢VÇ6R¢6ÆVW²fÇC²ÒÒ6ÆVWð¢VæD`¤VæDgVæ0

Edited December 21, 2006 by theguy0000

[theguy0000 2]

Oh, and please use Tidy on your code. it is a great tool.

[Thatsgreat2345 0]

wow theguy those were so beautiful code/autoit tags

[theguy0000 2]

wow theguy those were so beautiful code/autoit tags

[danzar 0]

Thank you for your time and imput