StringFormat bug?

[Xand3r]

Here are some examples...

$ss="test"
MsgBox(0 , "" , StringFormat("add % done",$ss))
MsgBox(0 , "" , StringFormat("add %",$ss))
MsgBox(0 , "" , StringFormat("add % n done",$ss))

the output will be:

add 0one
add add
autoit crash(not error... crash)

[GaryFrost]

Here are some examples...

$ss="test"
MsgBox(0 , "" , StringFormat("add % done",$ss))
MsgBox(0 , "" , StringFormat("add %",$ss))
MsgBox(0 , "" , StringFormat("add % n done",$ss))oÝ÷ ÚØ^¢ëiºÜ"VÞr^i×t¢wuÖu«­¢+­«!ãIèµê뢷+jÈx×÷(uïêº^2(!·§¶Ú%¢.¥+kx¢¹¶)íè^(¶­Ê®±è­rëyËeÈÚ-i» jëh×6$ss="test"
MsgBox(0 , "" , StringFormat("add %s done",$ss))
MsgBox(0 , "" , StringFormat("add %s",$ss))
MsgBox(0 , "" , StringFormat("add %s n done",$ss))

[GaryFrost]

Even tho it was used improperly it should still not crash Autoit. I would think it would throw an error tho.

[Richard Robertson]

If AutoIt is using the low level format function, then it would have to perform it's own validation of the input format before calling the format function.

[Authenticity]

These kind of thing is called logical errors and not the function, nor the compiler need to assume or handle it differently. If the compiler for example is able to see:

int nNum = 5/0;

then it can output to the console an error or a warning message depending on the user preferred restrictions. But if it's something like:

int main()
{
    int nNum1, nNum2;
    float fRes;
    cout << "Enter 2 numbers to divide separated by space: ";
    cin >> nNum1 >> nNum2;
    fRes = nNum1 / nNum2;
    cout << "The result is: " << fRes;
   
    return 0;
}

you'll get a run-time error because you didn't check the divisor is not 0. For that reason there is the if(...) ... else(...)... structure or the better C++ or Microsoft SEH structure __try(...)...__except(...)/__finally(...)...

Heh, it's not necessary in AutoIt but it'll be nice to have __try....__finally structure, otherwise, If...EndIf is enough but the scripter has to be more cautious.

Edited May 24, 2009 by Authenticity

[Valik]

AutoIt should never crash, period (DllCall() excluded). That right there is enough to say there is a bug.

Edit: Just to be more clear. There should never be a situation where a crash happens. AutoIt should not crash with the the error dialog from Windows unless it's from DllCall(). AutoIt should never throw an AutoIt error for any run-time event except out-of-memory. AutoIt should not throw an error for properly written script code.

Edited May 24, 2009 by Valik

[MrCreatoR]

It's strange, it's crashed only(?) when %n used and there is Type/Precision character in the format after that:

StringFormat("%n f", 1)

[Valik]

We know why it happens. We have a private thread where it's discussed.

[Xand3r]

Might want to look up StringFormat in the help so that you use it correctly. Not a bug.

yeah... lol i know how to use it... but it was just a typo in a 4000 line script and the stringformat had about 30 vars...

[Jon]

Things should be improved in the beta I just released.