10 replies to this topic

[RazerM]

I made file renaming easier

AutoIt        expandcollapse  popup

;===============================================================================
;
; Function Name:   _FileRename
; Description:: Renames a file
; Parameter(s): $s_file - File to be renamed
;                  $s_name - New filename (e.g. 'newfilename' NO extensions)
; Requirement(s):  #Include <file.au3> and AutoIt Beta > v3.1.1.76
; Return Value(s): 0 - File Error
;                  1 - Success
; Author(s):       RazerM
;
;===============================================================================
;
Func _FileRename($s_file, $s_name)
    If Not FileExists($s_file) Then Return 0
    Local $szDrive, $szDir, $szFName, $szExt
    $a_SplitFile = _PathSplit($s_file, $szDrive, $szDir, $szFName, $szExt)
    $s_renamed = $a_SplitFile[1] & $a_SplitFile[2] & $s_name & $a_SplitFile[4]
    If Not FileMove($a_SplitFile[0], $s_renamed) Then Return 0
    If Not FileExists($s_renamed) Then Return 0
    If FileExists($s_file) Then FileDelete($s_file)
    Return 1
EndFunc

Edited by RazerM, 19 May 2006 - 03:30 PM.

[RazerM]

i thought some people would like this

[SmOke_N]

i thought some people would like this

Doesn't FileMove() do this already?

Edit:

FileMove("C:\foo.au3", "C:\bak.au3", 1)

Although, it doesn't delete it I'm sure, and you do have to re-write the path I suppose, so this could be useful.

Edited by SmOke_N, 20 April 2006 - 03:32 PM.

[RazerM]

I just thought this was easier

[SmOke_N]

I just thought this was easier

There's an error with your code with _PathSplit()... it is supposed to return an array but you didin't define it... I took the liberty of playing with it a bit.

#include <file.au3>

_FileRename(@DesktopDir & '\Test.txt', 'RenamedThisFile')

Func _FileRename($s_file, $s_name)
    If Not FileExists($s_file) Then Return -1
    Local $szDrive, $szDir, $szFName, $szExt
    $a_SplitFile = _PathSplit($s_file, $szDrive, $szDir, $szFName, $szExt)
    $s_renamed = $a_SplitFile[1] & $a_SplitFile[2] & $s_name & $a_SplitFile[4]
    If Not FileMove($a_SplitFile[0], $s_renamed) Then Return -1
    If Not FileExists($s_renamed) Then Return -1
    If FileExists($s_file) Then FileDelete($s_file)
    Return 1
EndFunc

Edit:
Actually, looking at it, you didn't need to make it a variable I guess... I dunno, but hope it helps anyway.

Edited by SmOke_N, 20 April 2006 - 03:50 PM.

[MHz]

Perhaps an extra requirement?

; Requirement(s): #Include file.au3 and AutoIt Beta > v3.1.1.76

I would rather see 0 being returned on failure. It would make the UDF usable as a boolean.

[SmOke_N]

Perhaps an extra requirement?

I would rather see 0 being returned on failure. It would make the UDF usable as a boolean.

This is true, didn't think of that ...

But @ RazerM, I'm sure it will come in handy .

[RazerM]

ok it returns 0 on failure, which makes more sense i suppose

Plain Text        expandcollapse  popup

;===============================================================================
;
; Function Name:   _FileRename
; Description:: Renames a file
; Parameter(s): $s_file - File to be renamed
;                  $s_name - New filename (e.g. 'newfilename' NO extensions)
; Requirement(s):  #Include <file.au3> and AutoIt Beta > v3.1.1.76
; Return Value(s): 0 - File Error
;                  1 - Success
; Author(s):       RazerM
;
;===============================================================================
;
Func _FileRename($s_file, $s_name)
    If Not FileExists($s_file) Then Return 0
    Local $szDrive, $szDir, $szFName, $szExt
    $a_SplitFile = _PathSplit($s_file, $szDrive, $szDir, $szFName, $szExt)
    $s_renamed = $a_SplitFile[1] & $a_SplitFile[2] & $s_name & $a_SplitFile[4]
    If Not FileMove($a_SplitFile[0], $s_renamed) Then Return 0
    If Not FileExists($s_renamed) Then Return 0
    If FileExists($s_file) Then FileDelete($s_file)
    Return 1
EndFunc

[SmOke_N]

Good Deal... This

Func _FileRename($s_file, $s_name)
    If Not FileExists($s_file) Then Return 0
    Local $szDrive, $szDir, $szFName, $szExt
    $a_SplitFile = _PathSplit($s_file, $szDrive, $szDir, $szFName, $szExt)
    $s_renamed = $a_SplitFile[1] & $a_SplitFile[2] & $s_name & $a_SplitFile[4]
    If Not FileMove($a_SplitFile[0], $s_renamed) Then Return 0
    If Not FileExists($s_renamed) Then Return 0
    If FileExists($s_file) Then FileDelete($s_file)
    Return 1
EndFunc

Looks more effective than the original...

Func _FileRename($s_file, $s_name)
    If FileExists($s_file) = 0 Then Return -1
    Dim $szDrive, $szDir, $szFName, $szExt
    _PathSplit($s_file, $szDrive, $szDir, $szFName, $szExt)
    $s_tempfile = @TempDir & "\" & $szFName & $szExt
    $s_renamed = $szDrive & $szDir & $s_name & $szExt
    If FileCopy($s_file, $s_tempfile, 9) = 0 Then Return -1
    If FileMove($s_tempfile, $szDrive & $szDir & $s_name & $szExt) = 0 Then Return -1
    If FileExists($s_renamed) = 1 Then
        FileDelete($s_file)
        FileDelete($s_tempfile)
    ElseIf FileExists($s_renamed) = 0 Then
        Return -1
    EndIf
    Return 1
EndFunc

Already put it to use in one of my scripts .

[RazerM]

its basically just the one you posted changed a bit:D

[MHz]

Nice update.