SetParent Wrapper UDF

[NELyon]

This is a small UDF i whipped up because the DLLCall for SetParent was something i needed on hand, and didn't want to type out all the time, so i made a small wrapper.

expandcollapse popup

#cs ----------------------------------------------------------------------------
    
    AutoIt Version: 3.2.4.9
    Author:         Senton-Bomb
    
        $TitleP: The title of the parent window
        $TitleC: The title of the child window
        
        If a window doesn't exist, It returns -1, otherwise it returns 1
    
    Script Function:
    Wrapper for the "SetParent" dllcall + Example.
    
#ce ----------------------------------------------------------------------------

; Script Stizzle - Add your codeizzle

Func _SetParent($TitleP, $TitleC)
    If WinExists($TitleP) Then
        If WinExists($TitleC) Then
            $HwndP = WinGetHandle($TitleP)
            $HwndC = WinGetHandle($TitleC)
            $user32 = DllOpen("user32.dll")
            DllCall($user32, "str", "SetParent", "HWnd", $HwndP, "HWnd", $HwndC)
            Return 1
        Else
            Return -1
        EndIf
    Else
        Return -1
    EndIf
EndFunc   ;==>_SetParentƒoÝŠ÷ Ù@ÅjëhŠ×6Opt("WinTitleMatchMode", 2)

$p = _SetParent("- SciTE", "Mozilla Firefox")

If $p = -1 Then
    MsgBox(0, "", "One or more windows don't exist")
EndIf

^^Example: Open SciTe and Firefox to see the effect.

Comments? Questions? Insults? Anybody??

Edited October 22, 2007 by Senton-Bomb

[NELyon]

Nobody uh-like my wuurk?

[RazerM]

Just found this.. Good UDF but in the SetParent func the first parameter is the child, but you pass $hwndP

Edit: I'm not sure but shouldn't DllClose be called?

Edited August 19, 2007 by RazerM

[Celeri]

Nobody uh-like my wuurk?

Good timing!

I was looking for something like this!

I'll test it this week and come back to you.

P.S.: A lot of people here just download and go, they don't bother to comment. Don't despair there's still a few good guys (and gals) around to help you out and comment.

[Celeri]

Allright just a fast reply ... since I read the code (didn't run it yet).

You should declare all variables Local

Local $HwndP, $HwndC, $user32

For quickness and standardisation, on error you should return 1, on no error you should return 0

Why?

If _SetParent("- SciTE", "Mozilla Firefox") Then MsgBox(0,,"","Big ERROR")

You save a few lines of code also.

If NOT _SetParent(...

will do something if there is no error BTW. Edited August 19, 2007 by Celeri

[Celeri]

I'd also combine both verifications:

If WinExists($TitleP) And WinExists($TitleC) Then

And add

Opt("WinTitleMatchMode", 2)

into the function

Now it's looking good too

Edited August 19, 2007 by Celeri

[cppman]

Nice little function

Just found this.. Good UDF but in the SetParent func the first parameter is the child, but you pass $hwndP

Edit: I'm not sure but shouldn't DllClose be called?

eh, DLLOpen() shouldn't have even been called inside the function.

#cs ----------------------------------------------------------------------------
    
    AutoIt Version: 3.2.4.9
    Author:         Senton-Bomb
    
        $TitleP: The title of the parent window
        $TitleC: The title of the child window
        
        If a window doesn't exist, It returns -1, otherwise it returns 1
    
    Script Function:
    Wrapper for the "SetParent" dllcall + Example.
    
#ce ----------------------------------------------------------------------------

; Script Stizzle - Add your codeizzle
Func _SetParent($TitleP, $TitleC)
    If WinExists($TitleP) Then
        If WinExists($TitleC) Then
            $HwndP = WinGetHandle($TitleP)
            $HwndC = WinGetHandle($TitleC)
            DllCall("user32.dll", "hwnd", "SetParent", "hwnd", $HwndC, "hwnd", $HwndP)
            Return 1
        Else
            Return -1
        EndIf
    Else
        Return -1
    EndIf
EndFunc   ;==>_SetParent

Edited August 19, 2007 by chris95219

[cppman]

For quickness and standardisation, on error you should return 1, on no error you should return 0

Why?

If _SetParent("- SciTE", "Mozilla Firefox") Then MsgBox(0,,"","Big ERROR")

You save a few lines of code also.

If NOT _SetParent(...

will do something if there is no error BTW.

If you return 1 when there is an error, than this will happen:

if (_SetParent(...)) Then
       ;an error occurred
EndIf

Usually it should return 0(false) if an error occurred and a non-zero (true) value if an error didn't occurr.

[NELyon]

I'm re-writing the function now.

Thanks for everything you guys pointed out. I just took a 5 mile bike ride and am thinking clearer now!

[NELyon]

{Post reserved for release of code}

[Celeri]

Usually it should return 0(false) if an error occurred and a non-zero (true) value if an error didn't occurr.

Not sure.

Let me quote the help file for Set Error:

RETURN VALUE: By default, none, however if the optional return value argument is passed, then the function will return that value.

SO unless I read wrong, no error, no returned value. If error, than a value that correspond to a specific error.

Per example, error 1 would be "One of the windows does not exist".

Error 2 could be error returned by RunDll, the extended code could be that error #.

BTW I'm a complete dork with DllCalls so you got me there

[cppman]

Not sure.

Let me quote the help file for Set Error:

SO unless I read wrong, no error, no returned value. If error, than a value that correspond to a specific error.

Per example, error 1 would be "One of the windows does not exist".

Error 2 could be error returned by RunDll, the extended code could be that error #.

BTW I'm a complete dork with DllCalls so you got me there

You can call SetError before you return, and call @Error if the function failed

if (not _SetParent(...)) Then
   MsgBox(0, "", @error)
endif

This is just my personal opinion though

It makes it easier when calling a function because you can simply have a 1 liner..

if (not _SetParent(...)) Then blah...

Edited August 20, 2007 by chris95219

[Celeri]

You can call SetError before you return, and call @Error if the function failed

if (not _SetParent(...)) Then
   MsgBox(0, "", @error)
endif

This is just my personal opinion though

It makes it easier when calling a function because you can simply have a 1 liner..

if (not _SetParent(...)) Then blah...

Ok, I don't want to pick a fight (ahahahah)

Anyways we almost agree

So here's my take on this.

Take a smal program that checks a filename (hey I'm working on that!)

Here's what can go wrong:

1. Does it contain illegal characters?

2. Is it null ""?

3. Is it too long?

4. Does it contain too many wildcards? ("*" and "?")

So in fact there are at least 4 different types of error here.

There is only one instance where there is no error and that's when all the four previous checks are ok.

So it makes more sense if the returned values are:

0. No problemo

1. Invalid characters

2. Null string

3. String too long

4. Too many wildcards.

In any case we usually check to see if there is an error rather than the reverse.

So ...

If _CheckMyFilename("Celeri_?????_with_his_RunDLL_Calls.bak") Then ConsoleWrite("I made a boo-boo")

makes perfect sense.

However

If _CheckMyFilename("Celeri_?????_with_his_RunDLL_Calls.bak") Then ConsoleWrite("Wow you made it!")

is not quite as practical.

Oh well, to each is own I guess

[DirtDBaK]

i think this is what i have been looking for forever!! glad to find it

ever noticed the cpu power this needs??

Edited October 21, 2007 by DBak

[NELyon]

Func _SetParent($TitleC, $TitleP)
    If WinExists($TitleC) And WinExists($TitleP) Then
        $HwndC = WinGetHandle($TitleC)
        $HwndP = WinGetHandle($TitleP)
        DLLCall("user32.dll", "str", "SetParent", "HWnd", $HWndP, "HWnd", $HWndC)
        If @error then
            return 0
        EndIf
        
        Return 1
    EndIf
EndFunc

New version, no DLLopen, slimmed down, returns 0 on failure, 1 on execution, and switched the Parent and Child windows around. I ask for someone to test, because i cannot.

[DirtDBaK]

ok cool hope it works faster ill test it out for you in a few hours when i get home

Thanks for all the great work!

[James]

Very good. But I lost my window. Anyway of fixing this?

[DirtDBaK]

Orignal was tested and works fine

I dont know about the new one

Show the code, maybe i can help, i use this function a lot...

Check my sig for an example

Edited November 30, 2007 by DBak

[grham]

very good!!!!

I have this because of my curiosity. I'm still looking for

the scite window after minimizing it within the firefox window.

jaja

Edited December 31, 2007 by grham

[James]

I lost my window the first time I ran this.