Help with shortening code? :)

[Damein]

Alright, so I have this website with radio dramas that are updated weekly, where one is added and one is removed. So, I know the number of episodes there will be.

I created a script to pull the links, but my problem is I can tell how long the script is going to be the way I am going to do it.

Here's what I have:

#include <IE.au3>

Global $Count

$file = "Linkss.txt"

$oIE = _IECreate ("http://www.oneplace.com/ministries/paws-and-tales/listen/broadcast-archives.html")
$oLinks = _IELinkGetCollection ($oIE)
$iNumLinks = @extended
For $oLink In $oLinks
    $Count += 1
    If $Count = 23 Then
        FileWriteLine($file, $oLink.href)
    EndIf
    If $Count = 24 Then
        FileWriteLine($file, $oLink.href)
        EndIf
Next

So, the way I know how to do it I am going to need to write 52 If statements. And that is going to take a lot of space and I'm sure theres a better/cleaner way to do this.

I am going to look into atm, but I was wondering if anyone could lend a hand to make it go quicker!

Thanks!

[kaotkbliss]

I'm not sure exactly what you mean, but it looks like these 2 lines are exactly the same:

If $Count = 23 Then

FileWriteLine($file, $oLink.href)

EndIf

If $Count = 24 Then

FileWriteLine($file, $oLink.href)

EndIf

If these are the lines you are going to repeat, just incrimenting (24, 25, 26 etc.) 52 times, then why not a single line that says

If $Count > 22 Then

FileWriteLine($file, $oLink.href)

EndIf

*edit to include 23 in the if statement*

Edited October 20, 2010 by kaotkbliss

[jlarson]

Would this work?

#include <IE.au3>

Global $Count

$file = "Linkss.txt"

$oIE = _IECreate ("http://www.oneplace.com/ministries/paws-and-tales/listen/broadcast-archives.html")
$oLinks = _IELinkGetCollection ($oIE)
$iNumLinks = @extended
$id = 23
$cout = 0
For $oLink In $oLinks
    $Count += 1
    Do
        FileWriteLine($file, $oLink.href)
        $cout += 1
    Until $cout = 52
Next

[Tvern]

Is this short enough for you?

#include <file.au3>
_FileWriteFromArray("Linkss.txt",StringRegExp(BinaryToString(InetRead("http://www.oneplace.com/ministries/paws-and-tales/listen/broadcast-archives.html")),'(?i)(?s)<h5><a href="(.*?)">',3))

Couldn't resist. This would have been usefull in the other topic btw. It allows you to properly get the titles.

Edit:

This will add any links that are not in the file yet to the existing file:

#include <array.au3>
#include <file.au3>
Global $aFile, $aLinks
Global $sFilePath, $sSource
$sFilePath = "Linkss.txt"
$sSource = BinaryToString(InetRead("http://www.oneplace.com/ministries/paws-and-tales/listen/broadcast-archives.html")) ;download the page source
$aLinks = StringRegExp($sSource,'(?i)(?s)<h5><a href="(.*?)">',3) ;put all matching links in an array
If Not IsArray($aLinks) Then ;check if links where found
    MsgBox(0,"error","No links found!")
    Exit
EndIf
_FileReadToArray($sFilePath,$aFile) ;load the file you already have
If IsArray($aFile) Then ;check if anything is loaded
    For $i = 0 To UBound($aLinks) -1 ;loop through each link in the array
        _ArraySearch($aFile,$aLinks[$i],1) ;check if it already exists
        If @error = 6 Then ;if the link was not found in the file array
            _ArrayAdd($aFile,$aLinks[$i]) ;add the link to the file array
        EndIf
    Next
    _FileWriteFromArray($sFilePath,$aLinks,1) ;write the new array back to the file
Else
    _FileWriteFromArray($sFilePath,$aLinks) ;if there is no file array, create the file with the links we found
EndIf

Edited October 22, 2010 by Tvern