joining multiple functions

[demonachize 0]

I have a need to look for a pixel color in one place while it doesn't exist in two other places. I am trying to use:

While PixelGetColor(1579, 546) = 0xFFDE4B and not PixelGetColor(1820, 735) = 0xFFDE4B or not PixelGetColor(1819, 767) = 0xFFDE4B
MouseCLick ( "primary", 1579, 546, 1, 1)
WEnd

This is clearly not working and I am confused as to how to join multiple statements using operators. The end result would be that I want to ensure that a certain button is pushed that stays visible in the background while a new window in the foreground pops up and then another pops up after that. I know of a different way to approach it that I will probably use but I still would like to know how to do it this way for my own knowledge.

[JohnOne 1,590]

I'd probably do something like this.

While PixelGetColor(1579, 546) = 0xFFDE4B
    If PixelGetColor(1820, 735) <> 0xFFDE4B And  PixelGetColor(1819, 767) <> 0xFFDE4B
        Then
    MouseCLick ( "primary", 1579, 546, 1, 1)
    EndIf
WEnd

Edited January 8, 2011 by JohnOne

[Melba23 2,832]

demonachize,

When you use multiple logical operators you need to be very careful - especially if you use any Not operators in there as well.

Top Tip 1: Do not use multiple logical operators - split your line into 2:

While PixelGetColor(1579, 546) = 0xFFDE4B
    If PixelGetColor(1820, 735) <> 0xFFDE4B Or PixelGetColor(1819, 767) <> 0xFFDE4B Then
        MouseCLick ( "primary", 1579, 546, 1, 1)
    EndIf
WEnd

Top Tip 2: If you want to keep it on one line, then use parentheses to carefully delineate the separate sections and to define the scope of the Not operator.

Look at this small test script which replicates your basic logic:

expandcollapse popup

; True, True, True -> True And (Not(True) Or Not(True))
;                  -> True And (False Or False)
;                  -> True And False
;                  -> False
;                  -> Exit Loop

; True, False, True -> True And (Not(False) Or Not(True))
;                   -> True And (True Or False)
;                   -> True And True
;                   -> True
;                   -> Stay in loop

; True, True, False -> True And (Not(True) Or Not(False))
;                   -> True And (False Or True)
;                   -> True And True
;                   -> True
;                   -> Stay in loop

; True, False, False -> True And (Not(False) Or Not(False))
;                    -> True And (True Or True)
;                    -> True And True
;                    -> True
;                    -> Stay in loop

; False, Any, Any -> False And (Not even evaluated)
;                 -> False
;                 -> Stay in loop
;                 -> Exit Loop

$fWanted = True
$fUnwanted_1 = True
$fUnwanted_2 = False

$iBegin = TimerInit()
While $fWanted And (Not($fUnwanted_1) Or Not($fUnwanted_2))
    If TimerDiff($iBegin) > 100 Then
        ConsoleWrite("Still In Here!" & @CRLF)
        Exit
    EndIf
    Sleep(10)
WEnd
ConsoleWrite("Out!" & @CRLF)

See how I have set the parentheses to limit the scope of the 2 Not operators and also to make sure the Or pair are always evaluated together. By changing the values of the 3 variables you can see how the While line reacts.

So I would suggest going with this for your script:

While (PixelGetColor(1579, 546) = 0xFFDE4B) And (Not (PixelGetColor(1820, 735) = 0xFFDE4B) Or Not ( PixelGetColor(1819, 767) = 0xFFDE4B))
    MouseCLick ( "primary", 1579, 546, 1, 1)
WEnd

And you might want to add a Sleep(10) as well to keep the CPU cool in a tight loop like that.

M23

Edit: Wrong button, too soon!

Edited January 8, 2011 by Melba23

[demonachize 0]

Thanks to both of you. This makes perfect sense now. I appreciate that you took the time to give me those pointers.