Jump to content
megaservo

Problem with DirMove all subdirectories within a windows users profile folder like Desktop

Recommended Posts

megaservo

Hi All, 

I'm making a stage 1 preparation script to apply to target worksation Win 7 and Win 8.1 machines -in preparation to running a separate batch script later (stage 2) within our Windows Server with "netdom.exe move" xxxxxxxx

Stage 1 Script Tasks: 

1. delete some common shortcuts

2. Then move all files within common user profile backup locations - including any files in the sub-directories of the common backups locations within each users profile folder. 

Stage 1 Script Purpose: 

Make it easy for staff to grab files and folders from one C:\_Backup directory

Stage 1 Script PROBLEM:

The script successfully removes the desired shortcuts - that part works well.
Problem is it only copies files in root directory of each users common folder (eg: Desktop) but doesn't move all the sub-directories and its files and move it to the corresponding backup directory. I've searched the whole AutoIT forum domain for ideas but I've hit a dead end. 

 

Here is the code: 

;START TASKS--------------------------------------------------------------------------
#include <FileConstants.au3>
$ccsystem32 = @SystemDir ;define C:\Windows\System32 folder
$ccdesktop = @DesktopCommonDir ;define all users desktop location
;rename CompanyName Remote Desktop shortcut
FileCopy($ccdesktop&"\Remote Desktop.rdp", $ccdesktop&"\Company Remote Desktop.rdp", 0)
;delete copies of "SHIP", "eKeySilent", "eKey Manual Login", "eKey Admin" and "ConnX Login" from every profile, adds a copy ot each Desktop folder.
$folder = StringLeft(@UserProfileDir,StringInStr(@UserProfileDir,"\",0,-1))
$search = FileFindFirstFile($folder&"*")
While 1
    $profile = FileFindNextFile($search)
    If @error Then ExitLoop
    If FileExists($folder&$profile&"\desktop\SHIP.url") Then
        FileDelete($folder&$profile&"\desktop\SHIP.url")
    EndIf
    If FileExists($folder&$profile&"\desktop\ekeySilent.lnk") Then
        FileDelete($folder&$profile&"\desktop\ekeySilent.lnk")
    EndIf
    If FileExists($folder&$profile&"\desktop\eKey Manual Login.url") Then
        FileDelete($folder&$profile&"\desktop\eKey Manual Login.url")
    EndIf
    If FileExists($folder&$profile&"\desktop\ConnX Login.lnk") Then
        FileDelete($folder&$profile&"\desktop\ConnX Login.lnk")
    EndIf
    If FileExists($folder&$profile&"\desktop\eKey Admin.url") Then
        FileDelete($folder&$profile&"\desktop\eKey Admin.url")
    EndIf
    If FileExists($folder&$profile&"\desktop\Remote Desktop.rdp") Then
        FileDelete($folder&$profile&"\desktop\Remote Desktop.rdp")
    EndIf
    ;backup desktop folder of each user
    If FileExists($folder&$profile&"\desktop\"&"*.*") Then
        FileMove($folder&$profile&"\desktop\"&"*.*", "C:\_Backup\"&$profile&"\Desktop\", 9) ;flag combining overwrite existing files & create destination structure
    EndIf
    ;backup downloads folder of each user
    If FileExists($folder&$profile&"\downloads\"&"*.*") Then
        FileMove($folder&$profile&"\downloads\"&"*.*", "C:\_Backup\"&$profile&"\Downloads\", 9) ;flag combining overwrite existing files & create destination structure
    EndIf
    ;backup Documents folder of each user
    If FileExists($folder&$profile&"\documents\"&"*.*") Then
        FileMove($folder&$profile&"\documents\"&"*.*", "C:\_Backup\"&$profile&"\Documents\", 9) ;flag combining overwrite existing files & create destination structure
    EndIf
    ;backup pictures folder of each user
    If FileExists($folder&$profile&"\pictures\"&"*.*") Then
        FileMove($folder&$profile&"\pictures\"&"*.*", "C:\_Backup\"&$profile&"\Pictures\", 9) ;flag combining overwrite existing files & create destination structure
    EndIf
    ;backup music folder of each user
    If FileExists($folder&$profile&"\music\"&"*.*") Then
        FileMove($folder&$profile&"\music\"&"*.*", "C:\_Backup\"&$profile&"\Music\", 9) ;flag combining overwrite existing files & create destination structure
    EndIf
    ;backup videos folder of each user
    If FileExists($folder&$profile&"\videos\"&"*.*") Then
        FileMove($folder&$profile&"\videos\"&"*.*", "C:\_Backup\"&$profile&"\Videos\", 9) ;flag combining overwrite existing files & create destination structure
    EndIf
    ;backup IEfavorites folder of each user
    If FileExists($folder&$profile&"\favorites\"&"*.*") Then
        FileMove($folder&$profile&"\favorites\"&"*.*", "C:\_Backup\"&$profile&"\IEFavorites\", 9) ;flag combining overwrite existing files & create destination structure
    EndIf
WEnd
FileClose($search)
;end of deletion of old shortcuts and copying of user files in backup directories.

I tried DirMove but I can confirm that windows wont let me move the whole eg: Desktop folder as its read only and I obviously dont want to screw up that account as well (in case we need to log into it) - so I don't want to for example delete the actual Desktop directory. Just move  

I dont know how to move only all the sub-directories of all the above folders eg: Desktop - and not move the directory eg: Desktop itself. is it 2 problems?

  • sub-directories are read only?
  • DirMove is not allowed to copy any sub-directories? 

Reason why I was asked to use FileMove and DirMove is that we are concerned of running out of C drive space if we use FileCopy and DirCopy (works on eg: Desktop dir)

How file structure of C:\_Backup should look like on each target workstation system:

  • but it should not move the for eg: C:\Users\Admin\Desktop but should move all of its files and folders.
  • Why move not copy? C drive space is limited on each workstation, so I don't want to create double the files. 
Example of Desired File structure of backup directory: C:\_Backup\

C:\_Backup\Admin\
                    .\Desktop\*  (includes all files & subdirectories)
                    .\Documents\*  (includes all files & subdirectories)
                    .\Downloads\*  (includes all files & subdirectories)
                    .\IEFavorites\*  (includes all files & subdirectories)
                    .\Music\*  (includes all files & subdirectories)
                    .\Pictures\*  (includes all files & subdirectories)
                    .\Vidoes\*  (includes all files & subdirectories)
C:\_Backup\Administrator\
                    .\Desktop\*  (includes all files & subdirectories)
                    .\Documents\*  (includes all files & subdirectories)
                    .\Downloads\*  (includes all files & subdirectories)
                    .\IEFavorites\*  (includes all files & subdirectories)
                    .\Music\*  (includes all files & subdirectories)
                    .\Pictures\*  (includes all files & subdirectories)
                    .\Vidoes\*  (includes all files & subdirectories)
C:\_Backup\Administrator.DomainName\
                    .\Desktop\*  (includes all files & subdirectories)
                    .\Documents\*  (includes all files & subdirectories)
                    .\Downloads\*  (includes all files & subdirectories)
                    .\IEFavorites\*  (includes all files & subdirectories)
                    .\Music\*  (includes all files & subdirectories)
                    .\Pictures\*  (includes all files & subdirectories)
                    .\Vidoes\*  (includes all files & subdirectories)
C:\_Backup\Default\
                    .\Desktop\*  (includes all files & subdirectories)
                    .\Documents\*  (includes all files & subdirectories)
                    .\Downloads\*  (includes all files & subdirectories)
                    .\IEFavorites\*  (includes all files & subdirectories)
                    .\Music\*  (includes all files & subdirectories)
                    .\Pictures\*  (includes all files & subdirectories)
                    .\Vidoes\*  (includes all files & subdirectories)
C:\_Backup\Default User\
                    .\Desktop\*  (includes all files & subdirectories)
                    .\Documents\*  (includes all files & subdirectories)
                    .\Downloads\*  (includes all files & subdirectories)
                    .\IEFavorites\*  (includes all files & subdirectories)
                    .\Music\*  (includes all files & subdirectories)
                    .\Pictures\*  (includes all files & subdirectories)
                    .\Vidoes\*  (includes all files & subdirectories)
C:\_Backup\User1
                    .\Desktop\*  (includes all files & subdirectories)
                    .\Documents\*  (includes all files & subdirectories)
                    .\Downloads\*  (includes all files & subdirectories)
                    .\IEFavorites\*  (includes all files & subdirectories)
                    .\Music\*  (includes all files & subdirectories)
                    .\Pictures\*  (includes all files & subdirectories)
                    .\Vidoes\*  (includes all files & subdirectories)
C:\_Backup\Public\
                    .\Desktop\*  (includes all files & subdirectories)
                    .\Documents\*  (includes all files & subdirectories)
                    .\Downloads\*  (includes all files & subdirectories)
                    .\IEFavorites\*  (includes all files & subdirectories)
                    .\Music\*  (includes all files & subdirectories)
                    .\Pictures\*  (includes all files & subdirectories)
                    .\Vidoes\*  (includes all files & subdirectories)

Anybody has any ideas or assistance? 

Might be a really simple thing that I missed. o:)

Something missing to the while loop? Maybe the whole while loop needs to be redesigned? ???

 

Edited by megaservo
removed a nonessential sentence

in process of thinking....

Share this post


Link to post
Share on other sites
megaservo

I tried this: 

;-----take from the above script------
    ;backup desktop folder of each user
    If FileExists($folder&$profile&"\desktop\"&"*.*") Then
        ;FileMove($folder&$profile&"\desktop\"&"*.*", "C:\_Backup\"&$profile&"\Desktop\", 9) ;flag combining overwrite existing files & create destination structure
        DirMove($folder&$profile&"\Desktop\", "C:\_Backup\"&$profile&"\Desktop", 1)
    EndIf

DirMove worked this time for Desktop directory, but it moved the entire Desktop directory for every Desktop folder for each user profile

I just want to move files and subdirectories within Desktop directory of each user profile. 

Currently im not achieving the goal. 

Edited by megaservo
explain not working

in process of thinking....

Share this post


Link to post
Share on other sites
megaservo

This seems to have worked. 

I also added #RequireAdmin at the top

and added this: 

;backup desktop folder of each user  --------
    If FileExists($folder&$profile&"\Desktop\"&"*.*") Then
        DirCopy($folder&$profile&"\Desktop\", "C:\_Backup\"&$profile&"\Desktop", 1)
    EndIf
    If FileExists($folder&$profile&"\Desktop\"&"*.*") Then
        FileRecycle($folder&$profile&"\Desktop\"&"*")
    EndIf
    If FileExists("C:\_Backup\"&$profile&"\Desktop"&"*.*") Then
        FileRecycleEmpty()
    EndIf

Seems to have worked. 

Need to do further testing. 

Is there a better way? 


in process of thinking....

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • MFrancisca
      By MFrancisca
      Hello everyone,
      I'm trying to make a script that renames a file. I'm using FileMove but I'm really confused.
      The name change is on the EXTENSION, not on the file name itself. I need to change it from ".exe_" to "exe".
      FileMove is returning a 0 value and the file is clearly not renamed. Here is the relevant code.
      For $index = 1 to (UBound($file_array) - 1) $new_file_name = StringTrimRight($file_array[$index], 1) FileMove($dir & "\" & $file_array[$index], $dir & "\" & $new_file_name) Next  some context notes: 
      $file_array is the output of _FileListtoArray, and it has the correct values.  $dir is known, and the script is detecting it without problem I've checked that the script is finding the correct files, and that TrimRight is working. All variables have the correct values. I've checked the file attributes, the are set to "A". Are those the correct attributes? I've tried setting the flag of FileMove to 1, 8 and 9 with the same results This was working fine 2 weeks ago when I did the last run,  and I've made no changes.  (I don't know why the syntax highlighting is messed, quotes are paired correctly) 
       
      I know that the help file says that FileMove will not succeed if the destination already exist... my question is, does FileMove count extensions? 
      Thank you!  
    • 232showtime
      By 232showtime
      hi im stuck with this I want to transfer the correct file in the existing folder
      #include <File.au3> #include <AutoItConstants.au3> #include <Array.au3> $Read = "C:\New folder (3)" $FLFiles1 = _FileListToArrayRec($Read, "*.xlsx", $FLTAR_FILES, $FLTAR_NORECUR, $FLTAR_SORT, $FLTAR_NOPATH) _ArrayDisplay($FLFiles1) For $i = 0 To UBound($FLFiles1) - 1 $STR = StringTrimRight($FLFiles1[$i], 5) ConsoleWrite($STR & @CRLF) $dirS = DirGetSize($Read & "\" & $STR) If $dirS = -1 Then MsgBox(16, $STR, $dirS) Else FileMove($Read, $Read & "\" & $STR & "\" & $STR & ".xlsx") EndIf next I have 3 folders under "C:\New folder (3)" and I have 5 excel files:
      folders:
      C:\New folder (3)\1
      C:\New folder (3)\3
      C:\New folder (3)\5
      excel files:
      1.xlsx (value of column A are all 1)
      2.xlsx (value of column A are all 2)
      3.xlsx (value of column A are all 3)
      4.xlsx (value of column A are all 4)
      5.xlsx (value of column A are all 5)
       
       I run the above script and those excel file 1, 3, 5 was transfered in the 1, 3, and 5 folders but the value of transfered file in Column A are  different and file no. 4 and 5 still remains in the folder "C:\New folder (3)".... ???
      whats wrong with the script???
       
       
    • copyleft
      By copyleft
      I am trying to create a script to clean up users' desktops by moving all desktop folders and files (except the two hidden "desktop.ini" files and a MyDesktop.lnk shortcut) to a different folder. The script below will move files but not folders. The other issue with the script is that it doesn't seem to execute from a location other than the user's desktop. I would appreciate any suggestions.
      #include <File.au3> MsgBox(64, "Desktop", "Cleaning up Desktop. This box will close in 4 seconds.", 4) $Files = _FileListToArray(@DesktopDir,"*",1) For $Index = 1 To $Files[0] If StringRight($Files[$Index],4) <> ".ini, MyDesktop.lnk" Then FileMove($Files[$Index],'F:\HOME\Desktop') EndIf Next  
    • XinYoung
      By XinYoung
      Hello again,
      I'm trying to use the FileMove function to rename a bunch of text files.
      Some of the files have "_1" at the end of their name, for example, "File123_1.txt". I want to remove the "_1" so it would become "File123.txt".
      What I currently have...
              FileMove($sSource & "\*_1.txt", $sDestination & "\*.txt")
      But since I'm using a wildcard, it doesn't appear to be working. I think it's just replacing .txt with .txt. Am I going about this the wrong way? How can I use wildcards and still accomplish this?
      Any help is greatly appreciated ^__^
    • ALIENQuake
      By ALIENQuake
      Hi,
      from the DirMove page we have:
      I'm facing exactly the same issue and I need a simplest way to fix it. Could somebody take look at this code:
      Func _Extract_MoveMod($p_Dir) Local $Success=0 $Files=_FileSearch($g_GameDir & '\' & $p_Dir, '*') For $f=1 to $Files[0] If StringInStr(FileGetAttrib($g_GameDir & '\' & $p_Dir & '\' & $Files[$f]), "D") Then $Success = DirMove($g_GameDir & '\' & $p_Dir & '\' & $Files[$f], $g_GameDir, 1) Else $Success = FileMove($g_GameDir & '\' & $p_Dir & '\' & $Files[$f], $g_GameDir & '\', 1) EndIf If $Success = 0 Then Return 0 Next $Success = DirRemove($g_GameDir & '\' & $p_Dir, 1) Return $Success EndFunc ;==>_Extract_MoveMod and tell me how I can fix this inside that function?
      P.S. Why DirMove act such way is beyond my reason, especially as default and there is no flag to change it.
×