Jump to content
supersonic

Looking for very fast StringReplace

Recommended Posts

supersonic

Hello -

For a SQLite insert statement I'm passing a 2D array through two For/Next loops -  code snippet:

Local $sInsertInto2 = ""


For $i = 0 To $iCount - 1
    
    $sInsertInto2 &= "  ("
    
    For $j = 0 To UBound($aTmp, 2) - 2
        $sInsertInto2 &= "'" & StringReplace($aTmp[$i][$j], "'", "''") & "', "
    Next
    
    $sInsertInto2 &= "'" & StringReplace($aTmp[$i][$j], "'", "''") & "')" & ((($iCount - 1) = $i) ? (";") : ("," & @CRLF))
Next

This works great but due to StringReplace() it is very slow. StringReplace() is used to "escape" single quotes (') and it is only required if a single quote actually is present...

Somewhere on the forum there is a faster example by UEZ but I can't find it...

Anyone any idea?

Edited by supersonic

Share this post


Link to post
Share on other sites
supersonic

Input: "'AutoIt'Is'Great!'"

Output: "'AutoIt''Is''Great!'"

This is not the whole SQLite statement but it is the way a string is transformed IF there is a single quote (red text)...

Edited by supersonic

Share this post


Link to post
Share on other sites
supersonic

A 2D array is about [40000+][100+]...

 

Share this post


Link to post
Share on other sites
Chimp
1 hour ago, supersonic said:

.....  due to StringReplace() it is very slow. StringReplace() is used to "escape" single quotes (') and it is only required if a single quote actually is present ....

have a look to the _SQLite_FastEscape() function instead

 

P.S.

1 hour ago, supersonic said:

Somewhere on the forum there is a faster example by UEZ but I can't find it...

Anyone any idea?

maybe you mean this link?


small minds discuss people average minds discuss events great minds discuss ideas.... and use AutoIt....

Share this post


Link to post
Share on other sites
Chimp

deleted a duplicated post

Edited by Chimp
deleted a duplicated post

small minds discuss people average minds discuss events great minds discuss ideas.... and use AutoIt....

Share this post


Link to post
Share on other sites
Juvigy

Use  StringRegExpReplace() and StringRegExp()

Share this post


Link to post
Share on other sites
supersonic

Chimp & Juvigy, thank you. The UDF _SQLite_FastEscape() uses StringReplace() w/ case-sense. Using case-sense speeds up things a little bit (22s : 16s). Using SRER seems to as fast as SR w/ case-sense (17s). Using ASM from UEZ is very slow due to DllCall()... With other words: Still any chance to speed it up?

Edited by supersonic

Share this post


Link to post
Share on other sites
iamtheky

Lets see the ASM.

All tests, everywhere in the forum, except for the one you just ran, have ASM winning by a large margin.


,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites
jchd
4 hours ago, supersonic said:

A 2D array is about [40000+][100+]...

A really large number of columns!

Are you using a transaction to group your inserts?

If that isn't good enough, you can try binding values (but then again 100s of DllCalls)

Then if the source is a text file, try escaping the whole file first!

If the source is a [valid] .csv, use the CLI (sqlite3.exe) to import it.


This wonderful site allows debugging and testing regular expressions (many flavors available). An absolute must have in your bookmarks.
Another excellent RegExp tutorial. Don't forget downloading your copy of up-to-date pcretest.exe and pcregrep.exe here
RegExp tutorial: enough to get started
PCRE v8.33 regexp documentation latest available release and currently implemented in AutoIt beta.

SQLitespeed is another feature-rich premier SQLite manager (includes import/export). Well worth a try.
SQLite Expert (freeware Personal Edition or payware Pro version) is a very useful SQLite database manager.
An excellent eBook covering almost every aspect of SQLite3: a must-read for anyone doing serious work.
SQL tutorial (covers "generic" SQL, but most of it applies to SQLite as well)
A work-in-progress SQLite3 tutorial. Don't miss other LxyzTHW pages!
SQLite official website with full documentation (may be newer than the SQLite library that comes standard with AutoIt)

Share this post


Link to post
Share on other sites
supersonic

jchd,

yes, many columns... It is a script to import tables from a Progress DB. I fetch the data via ODBC in steps (e. g. 1000). This works really fine. And I use transaction which greatly improves performance.

Parsing through the source data array index by index seems to be always slow. So the next thing I try is to put the SQLite statement together and afterwards double the single quotes for char. escaping.

Share this post


Link to post
Share on other sites
supersonic

jchd,

first putting together the SQLite insert/replace statement and afterwards escaping the single quotes (StringReplace w/ case-sense) helped me out. Thank you.

Share this post


Link to post
Share on other sites
jguinch

You can also put the whole content in a variable and process the replacement in one shot (with a few steps) :

Local $sInsertInto2 = ""

For $i = 0 To $iCount - 1
    $sInsertInto2 &= "  (" & @CRLF
    For $j = 0 To UBound($aTmp, 2) - 1
        $sInsertInto2 &= $aTmp[$i][$j] & @CRLF
    Next
    $sInsertInto2 &= ")" & @CRLF
Next

$sInsertInto2 = StringReplace($sInsertInto2, "'", "''")
$sInsertInto2 = StringRegExpReplace($sInsertInto2, "\R\K(?!\h*[()])(\V+)", "'$1'")
$sInsertInto2 = StringRegExpReplace($sInsertInto2, "'\K\R(?=')", ", ")
$sInsertInto2 = StringReplace($sInsertInto2, @CRLF, "")
$sInsertInto2 = StringRegExpReplace($sInsertInto2, "\)\K(?=\h+\()", ", " & @CRLF)
$sInsertInto2 &= ";"
ConsoleWrite($sInsertInto2 & @CRLF)

 

Share this post


Link to post
Share on other sites
supersonic

jguinch,

that's nearly how I did it:

For $i = 0 To $iCount - 1
    $sInsertInto2 &= "  ("
    For $j = 0 To UBound($aTmp, 2) - 2
        $sInsertInto2 &= "`" & $aTmp[$i][$j] & "`, "
    Next
    $sInsertInto2 &= "`" & $aTmp[$i][$j] & "`)" & ((($iCount - 1) = $i) ? (";") : ("," & @CRLF))
Next


$sInsertInto2 = StringReplace($sInsertInto2, "'", "''", 0, 1)
$sInsertInto2 = StringReplace($sInsertInto2, "`", "'", 0, 1)

That's about 4-5 times faster. Setting StringReplace() to case-sensitive also speeds things up. Good enough :lol:

Thank you.

 

Edited by supersonic

Share this post


Link to post
Share on other sites
supersonic

I'll give it a try...

Share this post


Link to post
Share on other sites
supersonic

jguinch,

indeed, ternary ops consume some time... Like running afterwards some SRs / SRERs :) At the end there is a difference of about +/- 0,1-0,2 seconds...

Share this post


Link to post
Share on other sites
dmob
10 hours ago, jguinch said:

You can speed up the script by removing the ternary operator

I thought ternary operator is faster than If.. Else.. EndIf?? :blink:

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • FrancescoDiMuro
      By FrancescoDiMuro
      Good evening everyone
      I am building a management for the company I work with, and I just imported a real amount of rows ( about 29000 ), in my SQLite DB.
      The thing I am not understanding, is the time that the script takes to build this amount of rows in the ListView.
      I didn't measure it, but I think it took 2 minutes or so to create each ListView item...
      It is normal that it takes so much time?
      What can I do to improve the creation of the items?

      Here's the code I am using to query and to create ListView items...
      ; Articles ListView: Global $lvwArticles = GUICtrlCreateListView("ID|Fornitore|Codice|Descrizione|EU|Prezzo|Sconto Applicato|Note", 14, 87, 1507, 660, BitOR($GUI_SS_DEFAULT_LISTVIEW,$LVS_SORTASCENDING,$LVS_SORTDESCENDING), BitOR($WS_EX_CLIENTEDGE,$LVS_EX_GRIDLINES,$LVS_EX_FULLROWSELECT)) ; Query $strQuery = "SELECT * FROM ARTICOLI;" ; Query Execution _SQLite_GetTable2d($objDatabase, $strQuery, $arrResult, $intRows, $intColumns) If @error Then ; Error Handling Else ; Cleaning the ListView _GUICtrlListView_DeleteAllItems($lvwArticles) If @error Then ; Error Handling Else ; No records in the Table If UBound($arrResult) < 2 Then ; Error Handling Else _GUICtrlListView_BeginUpdate($lvwArticles) For $intCounter = 1 To UBound($arrResult) - 1 $strListViewItem = $arrResult[$intCounter][0] & "|" & _ $arrResult[$intCounter][1] & "|" & _ $arrResult[$intCounter][2] & "|" & _ $arrResult[$intCounter][3] & "|" & _ $arrResult[$intCounter][4] & "|" & _ $arrResult[$intCounter][5] & "|" & _ $arrResult[$intCounter][6] & "|" & _ $arrResult[$intCounter][7] $objListViewItem = GUICtrlCreateListViewItem($strListViewItem, $lvwArticles) Next _GUICtrlListView_EndUpdate($lvwArticles) EndIf EndIf EndIf Thanks in advance


      Best Regards.
    • dangr82
      By dangr82
       
      I have created this function for a database, but I can not make it work. I always have two error messages: "not an error" ... and the file created, in the script directory, does not contain anything.
      Global $sDBName = "Hen.db" Func DatabaseTable() Local $sConnDB _SQLite_Startup() If @error Then MsgBox($MB_SYSTEMMODAL, "SQLite Error", "SQLite.dll Can't be Loaded!") Exit -1 EndIf $sConnDB = _SQLite_Open($sDBName) If @error Then MsgBox($MB_SYSTEMMODAL, "SQLite Error", "Can't Load Database!") Exit -1 EndIf If Not _SQLite_Exec($sDBName, 'CREATE TABLE Animal ("Name", "Age");') = $SQLITE_OK Then MsgBox($MB_SYSTEMMODAL, "SQLite Error", _SQLite_ErrMsg()) If Not _SQLite_Exec($sDBName, 'INSERT INTO Animale VALUES ("Charlie","5");') = $SQLITE_OK Then MsgBox($MB_SYSTEMMODAL, "SQLite Error", _SQLite_ErrMsg()) _SQLite_Close($sConnDB) _SQLite_Shutdown() EndFunc  
    • Eminence
      By Eminence
      Hello,
      I've been searching on how to select the first row in my database which includes a time column based on the latest start_time date for today's date.
      This is my current code:
      Local $iCurrentDate = _Now() Local $sqlHandle = _dbOpen($sDbPath) Local $aResult, $iRows, $iCols _SQLite_GetTable2d($sqlHandle, "SELECT start_time FROM " & $srawDb & " ORDER BY datetime(start_time) DESC LIMIT 1", $aResult, $iRows, $iCols) _ArrayDisplay($aResult) _dbClose($sDbpath) What it does is it gets the first row entry in the database however it does not select the latest start_time entry in the database, it always select the first row. I've tried changing DESC to ASC to see if that will do it but the issue still remains. Any thoughts on this? Thanks in advance.
       
      *EDIT
      The date format in the database is by MM/DD/YYYY HH:MM:SS.
    • Seminko
      By Seminko
      In my recent project I'm downloading a bunch of data, so I decided to store it in a SQLite database. NOTE: I'm using sqlite3_x64.dll
      Everything is working just fine but I'm struggling with getting the Median value. SQLite has an Average function but not a Median one.
      I googled but all of the provided solutions are way above my pay-grade. After some more searching I found 'extension-functions.c' on the SQLite site where Median is included. After almost an hour of struggling I was able to successfully compile it into a DLL.
      So I downloaded @jchd's SQLiteExtLoad.au3 as seen here:
      But I'm getting these errors:
      "Path\SQLiteExtLoad.au3"(21,40) : warning: $g_hDll_SQLite: possibly used before declaration. Local $RetVal = DllCall($g_hDll_SQLite, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ "Path\SQLiteExtLoad.au3"(21,40) : error: $g_hDll_SQLite: undeclared global variable. Local $RetVal = DllCall($g_hDll_SQLite, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ So I tried, copying the function to my file and changing the DLL variable ($g_hDll_SQLite) directly to the DLL location (C:\...\.. .dll), but now this error fires
      If __SQLite_hChk($hConn, 1) Then Return SetError(@error, 0, $SQLITE_MISUSE) To be honest, I don't know what to use as the $hConn - handle of connection.
      I would appreciate any help, be it getting the median using SQLite queries or getting the DLL extension loaded using AutoIt.
      Thanks, S.
       
      EDIT: well, I suspect the $hConn variable refers to the return value of the _SQLite_Open function. Well, at least now _SQLite_EnableExtensions doesn't give errors. Now I run into problems with _SQLite_LoadExtension, which gives error -1, and extended 1. Apparently the 1 constant is a generic error where other error do not apply.
      BTW, anybody knows whether I need to compile the extension DLL "into" x64 when I use a x64 SQLite? That might be the problem...
       
      EDIT2: I recompiled the dll and tried it using the SQLite3.exe and it works, so I'm confident the extension DLL has been created correctly

    • AdamUL
      By AdamUL
      I have been testing AutoIt 3.3.14.3 with SQLite, and the Help File examples.  The examples that I have tested are throwing errors or not doing anything.  I have sqlite3.dll, sqlite3_x64.dll, and sqlite3.exe in the directories with the testing script.  I am copying the examples directly from the help file into a test script for testing with no edits.  The _SQLite_GetTable2d example is returning an error ("Library used incorrectly") with each _SQLite_Exec command.  The _SQLite_FastEncode example returns an empty dialog box.  The _SQLite_Exec example only prints out the SQLite version, and nothing else in the SciTE console.  Currently, I'm still searching for what is causing this issue.  I'm on Windows 7 Enterprise 64-bit.  Is anyone else having this issue?  
       
      Adam
       
×