Secure password generator

[goldenix]

will this do or should i try make it better?

Btw does it mater if i have 100 key files or 10 key files in terms of security?

$string = "!'#$%&/()+,-.:;\@[]" & "^{" & "|}~" & '"'

For $a=1 To 9999

    $upper = Chr(Random(Asc("A"), Asc("z"), 1))

    $lower = Random(1,9,1)

    If Random() < 0.5 Then  ; Returns a value between 0 and 1.
        ConsoleWrite($upper)
        
    ElseIf Random() > 0.5 Then 
        ConsoleWrite($lower)
        
    ElseIf Random() > 0.9 Then
        ConsoleWrite(' ')
        
    Else
        ConsoleWrite(StringMid($string,Random(1,25),1))     
    Endif
    

Next

ConsoleWrite(@CRLF)

Edited November 19, 2008 by goldenix

[theyranos]

You might want to seed your random number generator with something difficult to predict first.

local $seed = TimerInit()
for $ii = 0 to 100
  ToolTip("Move the mouse around to generate randomness")
  $seed = BitRotate(BitXOR($seed, MouseGetPos(0) * MouseGetPos(1)), 1, "D")
  sleep(10)
next
ToolTip("")
SRandom($seed)

I'm sure there's a better way, but I'm not sure what it would be.

Edit: Revised the code to make the mouse motion have more of an effect on the randomness

Edited November 20, 2008 by theyranos