Issue getting the correct STDOUT everytime

[CartoonDragon]

Hi everyone,

I'm having issues getting the correct answer back from stdout which makes my program unstable, here is a double example because i've tried both, can someone help with a good idea to get the correct answer everytime?

expandcollapse popup

For $i = 1 to 100 step +1
_Writelog($i & " " & _RunStdOutRead("hostname"))
Next

For $i = 1 to 100 step +1
_Writelog($i & " " & _RunStdOutRead2("hostname"))
Next
Exit

Func _RunStdOutRead($sRunCmd)
Local $iPID = Run(@ComSpec & ' /c ' & $sRunCmd, @ScriptDir, @SW_HIDE, 4 + 2)
Local $sStdOutRead = ""

While ProcessExists($iPID)
$sStdOutRead &= StdoutRead($iPID)
WEnd

Return $sStdOutRead
EndFunc

Func _RunStdOutRead2($sRunCmd)
Local $foo = Run(@ComSpec & ' /c ' & $sRunCmd, @ScriptDir, @SW_HIDE, 4 + 2)
Local $line = ""
While 1
$line &= StdoutRead($foo)
If @error Then ExitLoop
WEnd
;~ MsgBox(0, "STDOUT read:", $line)
Return $line
EndFunc

Func _Writelog($Write)
Local $file = FileOpen("MultiRuntest.txt", 1)
If $file = -1 Then
MsgBox(0, "Error", "Unable to open file.")
Exit
EndIf
FileWriteLine($file, $Write)
FileClose($file)
EndFunc

Edited November 26, 2012 by CartoonDragon

[BrewManNH]

Here's how I'd do it.

expandcollapse popup

Local $file = FileOpen("MultiRuntest.txt", 1)
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file.")
    Exit
EndIf
For $i = 1 To 10
    _Writelog($i & " " & _RunStdOutRead("hostname"))
Next

For $i = 1 To 10
    _Writelog($i & " " & _RunStdOutRead2("hostname"))
Next
FileClose($file)
Exit

Func _RunStdOutRead($sRunCmd)
    Local $iPID = Run(@ComSpec & ' /c ' & $sRunCmd, @ScriptDir, @SW_HIDE, 4 + 2)
    Local $sStdOutRead = ""

    While ProcessExists($iPID)
        Sleep(100)
    WEnd

    Return StdoutRead($iPID)
EndFunc ;==>_RunStdOutRead

Func _RunStdOutRead2($sRunCmd)
    Local $foo = Run(@ComSpec & ' /c ' & $sRunCmd, @ScriptDir, @SW_HIDE, 4 + 2)
    Local $line = ""
    While 1
        $line &= StdoutRead($foo)
        If @error Then ExitLoop
    WEnd
;~ MsgBox(0, "STDOUT read:", $line)
    Return $line
EndFunc ;==>_RunStdOutRead2

Func _Writelog($Write)
    FileWriteLine($file, $Write)
EndFunc ;==>_Writelog

Edited November 26, 2012 by BrewManNH

[hannes08]

In this very special example you might use the macro @ComputerName to get the local hostname.

Anyway I don't see where your script might fail.

[CartoonDragon]

Thanks a lot BrewmanNH that worked perfectly!