Sign in to follow this  
Followers 0
Inververs

binarymid unbelievable low speed

11 posts in this topic

#1 ·  Posted (edited)

Try to read binary file by byte, and found that binarymid function is impossibly slow. Function is so slow that quickly create byte structure and extract data from.
 

$file = @WindowsDir & '\notepad.exe'
$data = FileRead($file)
$blen = BinaryLen($data)
$timer = TimerInit()
For $i = 1 To $blen
$byte = BinaryMid($data,$i,1)
Next
ConsoleWrite(TimerDiff($timer) & @LF)
;~ >Exit code: 0 Time: 126.831

$timer = TimerInit()
$t = DllStructCreate('BYTE[' & $blen & ']')
DllStructSetData($t,1,$data)
For $i = 1 To $blen
$byte = DllStructGetData($t,1 ,$i)
Next
ConsoleWrite(TimerDiff($timer) & @LF)
;~ >Exit code: 0 Time: 1.832

Why is this happening, and can improve the function?

Edited by Inververs

Share this post


Link to post
Share on other sites

#2 ·  Posted (edited)

Open the file in binary mode before reading and using binarymid, might help.

EDIT:

$file = @WindowsDir & '\notepad.exe'
$open = FileOpen($file, 16)
$data = FileRead($open)
$blen = BinaryLen($data)
$timer = TimerInit()
For $i = 1 To $blen
    $byte = BinaryMid($data, $i, 1)
Next
ConsoleWrite(TimerDiff($timer) & @LF)
;~ >Exit code: 0 Time: 126.831

$timer = TimerInit()
$t = DllStructCreate('BYTE[' & $blen & ']')
DllStructSetData($t, 1, $data)
For $i = 1 To $blen
    $byte = DllStructGetData($t, 1, $i)
Next
ConsoleWrite(TimerDiff($timer) & @LF)
Edited by JohnOne

AutoIt Absolute Beginners    Require a serial    Pause Script    Video Tutorials by Morthawt   ipify 

Monkey's are, like, natures humans.

Share this post


Link to post
Share on other sites

and? binarymid still  26 times slower...

Share this post


Link to post
Share on other sites

And your problem is?


This wonderful site allows debugging and testing regular expressions (many flavors available). An absolute must have in your bookmarks.
Another excellent RegExp tutorial. Don't forget downloading your copy of up-to-date pcretest.exe and pcregrep.exe here
RegExp tutorial: enough to get started
PCRE v8.33 regexp documentation latest available release and currently implemented in AutoIt beta.

SQLitespeed is another feature-rich premier SQLite manager (includes import/export). Well worth a try.
SQLite Expert (freeware Personal Edition or payware Pro version) is a very useful SQLite database manager.
An excellent eBook covering almost every aspect of SQLite3: a must-read for anyone doing serious work.
SQL tutorial (covers "generic" SQL, but most of it applies to SQLite as well)
A work-in-progress SQLite3 tutorial. Don't miss other LxyzTHW pages!
SQLite official website with full documentation (may be newer than the SQLite library that comes standard with AutoIt)

Share this post


Link to post
Share on other sites

may be it is a bug, and developers do not know :)

Share this post


Link to post
Share on other sites

#7 ·  Posted (edited)

try this modifications (use FileRead from file instead of BinaryMid)

$file = @WindowsDir & '\notepad.exe'
$data = FileRead($file)
$myfile = FileOpen($file, 16) ; open file in binary mode
FileSetPos($myfile, 0, 2) ; position "cursor" to last byte in file
$blen = FileGetPos($myfile) ; read actual "cursor" position (last byte in this case)
; $blen = BinaryLen($data)

$timer = TimerInit()
FileSetPos($myfile, 0, 0) ; position "cursor" to first byte in file
For $i = 1 To $blen
    ; $byte = BinaryMid($data,$i,1)
    $byte = FileRead($myfile, 1) ; read 1 byte and autoincrement position
Next
ConsoleWrite(TimerDiff($timer) & @LF)


$timer = TimerInit()
$t = DllStructCreate('BYTE[' & $blen & ']')
DllStructSetData($t, 1, $data)
For $i = 1 To $blen
    $byte = DllStructGetData($t, 1, $i)
Next
ConsoleWrite(TimerDiff($timer) & @LF)
Edited by PincoPanco

small minds discuss people average minds discuss events great minds discuss ideas.... and use AutoIt....

Share this post


Link to post
Share on other sites

Thanks, PincoPanco, code really fast. But I did not need help, this topic was moved here moderators, unnecessarily I originally created itin the section Developer Chat. I just want that AutoIt got better. And maybe developers could improve the function binarymid.

Share this post


Link to post
Share on other sites

#9 ·  Posted (edited)

opss....   sorry. :)

Edited by PincoPanco

small minds discuss people average minds discuss events great minds discuss ideas.... and use AutoIt....

Share this post


Link to post
Share on other sites

Inververs,

If you wanted the thread to remain in Dev Chat then you should have make that clear in the OP. Just posting it as you did makes it look like a request for help in speeding up the code - which is exactly what everyone else who has seen it since it was move also thought. ;)

If you want to bring a problem to the attention of the developers, open a Trac ticket. :)

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

Thank you. Next time I'll put it more correctly

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0