ChooseFileFolder - Interim Version 11 Mar 21

[kosamja]

Hi Melba23, mine is just original idea (treeview explorer without current selection highlight), but code is from a friend who recently joined forum (Nikola)

[Melba23]

kosamja,

Thanks for that - I will get in touch with him if I make progress.

M23

[oIo]

is it possible with ChooseFileFolder to start adding new items immediately after clicking +, like in example in page 15 (https://www.autoitscript.com/forum/topic/125293-choosefilefolder-new-version-16-feb-17/?do=findComment&comment=1431811)?

----------------------------------------------------------------------------------

Edited page 15 example to work without objects, but still too slow...

File and Folder TreeView.au3

Edited October 17, 2019 by oIo

[Deye]

As a pending Question to melba  

I hope you won't mind me bringing up this Question as it isn't directly related to the UDF @OP   (not yet anyways) 

but if you expand the "C:\Users\Public" directory when using kosamja's example posted here it seems impossible to expand folders under that Dir 

To start i have replaced this line:

If Not FileExists($sTreeViewItemPath) Then Return SetError(3, 0, False)

With 

If Not FileExists($sTreeViewItemPath) Then
        If StringInStr($sTreeViewItemPath, "Public ") Then
            $sTreeViewItemPath = StringReplace($sTreeViewItemPath, "Public ", "")
            If Not FileExists($sTreeViewItemPath) Then Return SetError(3, 0, False)
        EndIf
    EndIf

Which turns those folders to become available as seen but still not expandable yet!

As I'm not sure what try next, TIA for any ideas

Deye

Edit :  I wasn't  paying attention to whats for it in _AddFolderContentToTreeView()

Partly Fixed by replacing:

If Not FileExists($sParentTreeViewItemPath) Then Return SetError(2, 0, False)

with:    

If Not FileExists($sParentTreeViewItemPath) Then
        If StringInStr($sParentTreeViewItemPath, "Public ") Then
            $sParentTreeViewItemPath = StringReplace($sParentTreeViewItemPath, "Public ", "")
            If Not FileExists($sParentTreeViewItemPath) Then Return SetError(2, 0, False)
        EndIf
    EndIf

pending : to  rid  the extra  Public Account Pictures dir

Thanks

Edited September 29, 2019 by Deye

[Melba23]

NEW VERSION 03 Mar 20

New:

    - UDF should now work correctly when #AutoIt3Wrapper_UseX64=Y directive is set.

    - Refreshing drive list possible when option selected in $iDisplay and no specific path has been set: 

        CFF_Choose: Cancel button has dropdown style with "Refresh" selection. _CFF_Refresh function can also refresh drive list via HotKey

        CFF_Embed: Available via HotKey only

    - $iDisplay option 3 has been removed. The new display options work as follows: 

        Option    Display                   Selectable               Action when folder double-clicked

        0              Folders and files   Files only                Folder expands/contracts
        1              Files only                Files only                N/A
        2              Folders only           Folders only          Selects folder

       +16          Folders and files   Folders and files    Selects folder
                       only when using option 0

    There is also one small change for consistency: pressing the {ENTER} key when in single selection mode now selects the highlighted (highlit?)  item in both _Choose and _Embed - it did not do so in _Choose before. 

Fixed: Bug in _Embed which could freeze UDF.

New UDF and examples in first post o fthe thread.

M23

[MrCreatoR]

Really helpful udf, just was looking for something like that.

Just few notes...

If $hParent set, you should disable the window.

If $hParent Then
    WinSetState($hParent, '', @SW_DISABLE)
EndIf

and enable it before GUIDelete:

If $hParent Then
    WinSetState($hParent, '', @SW_ENABLE)
EndIf

 

And what about icons for the items?

And i suggest to add expansion for checked items (if checkboxes used) that stored in subfolders.

I mean when using:

_CFF_SetPreCheck($aCheckList, False)
_CFF_Choose('Select:', 300, 400, -1, -1, $sRoot, Default, 16, -1, $hParent)

 

Edited April 5, 2020 by MrCreatoR

[MrCreatoR]

For icons make something like this:

;Set once
$hImageList = _GUIImageList_Create(16, 16, 5, 1)
_GUIImageList_AddIcon($hImageList, @SystemDir & '\shell32.dll', 3) ;Folder
_GUICtrlTreeView_SetNormalImageList($hTreeView, $hImageList)

;Then for each item inserted:
$hIcon = _WinAPI_ShellExtractAssociatedIcon($sFile, 1)
$iImage = _GUIImageList_ReplaceIcon($hImageList, -1, $hIcon)

_GUICtrlTreeView_AddChild($hTreeView, $hParentItem, $sItem, $iImage, $iImage)

_WinAPI_DestroyIcon($hIcon)

 

[Melba23]

MrCreatoR,

Thanks for the comments. But I have not added automatic disabling of the parent GUI - I leave that up to the user to do if they feel it necessary as I can think of occasions when I personally would not wish it to be automatic. And I am afraid that I am not expanding (pun intended) the auto-expanding features - they are complicated enough already.

However, your the icon code suggestions are most welcome and I have incorporated them in this new Beta: 

Looking for testers please.

M23

Edited June 14, 2020 by Melba23
Removed beta code

[MrCreatoR]

3 hours ago, Melba23 said:

I leave that up to the user to do if they feel it necessary

So at least an option, because a user should not mess with UDF code )). I did the change on my side, but what will happen now once you updated the UDF, how should i replace it? I will have to make my changes again.

But i think if user specified $hParent he expect it to be attached to this window, otherwise i don't see a reason for this parameter, if you want to be able to handle the parent window, do not use this parameter.

 

4 hours ago, Melba23 said:

icon code suggestions are most welcome and I have incorporated them in this new Beta

Thanks, will test it...

[Melba23]

MrCreatoR,

There is no need to "mess with UDF code" - if you want the main GUI disabled during the "choosing", just bracket the function call in the calling script:

GUISetState(@SW_DISABLE, $hParent)

_CFF_Choose ($sTitle, Default, Default, Default, Default, "", "*", 0, True, $hParent)

GUISetState(@SW_ENABLE, $hParent)

As I mentioned earlier, in the past I have found the need to leave the main GUI responsive while the UDF was running - so it is a design choice on my part not to make the disabling automatic.

M23

[MrCreatoR]

2 hours ago, Melba23 said:

There is no need to "mess with UDF code" - if you want the main GUI disabled during the "choosing", just bracket the function call in the calling script:

It's a wrong usage, the disable/enable sequence must be preserved (Disable + Show/Create --> Enable + Hide/Delete), otherwise in this case it can lead to minimization of the main GUI.

Bad example (Main GUI window get minimized after child GUI closes):

#include <GUIConstantsEx.au3>

$hGUI = GUICreate('Test Script', 300, 200)
GUISetState(@SW_SHOW, $hGUI)

GUISetState(@SW_DISABLE, $hGUI)
_Child($hGUI)
GUISetState(@SW_ENABLE, $hGUI)

Do
Until GUIGetMsg() = $GUI_EVENT_CLOSE

Func _Child($hParent)
    $hChild = GUICreate('', 100, 100, -1, -1, -1, -1, $hParent)
    GUISetState(@SW_SHOW, $hChild)
    
    Do
    Until GUIGetMsg() = $GUI_EVENT_CLOSE
    
    GUIDelete($hChild)
EndFunc

 

Good example (disable/enable sequence preserved):

#include <GUIConstantsEx.au3>

$hGUI = GUICreate('Test Script', 300, 200)
GUISetState(@SW_SHOW, $hGUI)

_Child($hGUI)

Do
Until GUIGetMsg() = $GUI_EVENT_CLOSE

Func _Child($hParent)
    GUISetState(@SW_DISABLE, $hParent)
    
    $hChild = GUICreate('', 100, 100, -1, -1, -1, -1, $hParent)
    GUISetState(@SW_SHOW, $hChild)
    
    Do
    Until GUIGetMsg() = $GUI_EVENT_CLOSE
    
    GUISetState(@SW_ENABLE, $hParent)
    GUIDelete($hChild)
EndFunc

 

2 hours ago, Melba23 said:

As I mentioned earlier, in the past I have found the need to leave the main GUI responsive

So in that case user should not use $hParent parameter, it's that simple.

[Melba23]

MrCreatoR,

Quote

user should not use $hParent parameter, it's that simple

The use of the parameter is to prevent the CFF dialog icon being added to the taskbar when the UDF is running, so I have to dispute that comment.

But you make a good point about the need to always re-enable the parent before deleting the child - I had forgotten about that little glitch. Although I would point out that the parent GUI is not minimised but simply not reactivated and so becomes hidden behind any other existing GUIs.

Although any controls on the parent GUI will not fire events when the UDF dialog is open (they are "swallowed"by the UDF's internal GUIGetMsg loop) I do accept that the main GUI events are still active - so here is a version with an option to disable/enable the parent (there is an additional parameter added to the _CFF_Choose function call). I am not that happy about adding yet another parameter to add the functionality. I did try playing with the $hParent handle to act as a flag, but I either got no effect or an invalid handle! So if you, or anyone else reading, has a suggestion of how that parameter could be modified to indicate the new functionality I would love to hear it.

To trigger the disable/enable of the parent, you need to concatenate any non-digit to the parent handle (e.g. $hParent & "*"):

See new version below

 

M23

Edited April 12, 2020 by Melba23
Removed beta code

[Danyfirex]

@Melba23 I think You could probably check if  hParent IsHwnd. If it is not a window handle create a hidden windows to avoid taskbar icon using as a parent. that way you can leave it responsive if you don't pass a window handle also hide taskbar icon, or auto enable/disable if you pass a valid window handle. No more parameters just do all based in IsHwnd.

 

Saludos

[Melba23]

Danyfirex,

I like that idea - although i would probably use the hidden AutoIt GUI as parent rather then create another one. Let me play around with it for a bit - I have 30 mins before I start cooking Easter lunch.

M23

[Melba23]

Danyfirex,

Try this version and see what you think: 

M23 

Edited April 12, 2020 by Melba23
Beta code removed

[MrCreatoR]

3 hours ago, Melba23 said:

The use of the parameter is to prevent the CFF dialog icon being added to the taskbar when the UDF is running

Use $WS_EX_TOOLWINDOW then.

But as i see it, if $hParent defined, it should be attached to that window, if not - show it normally, without hiding from taskbar.

Edited April 12, 2020 by MrCreatoR

[Melba23]

MrCreatoR,

Which is what the version I posted above does. Please try it and see if it meets your requirements.

M23

[MrCreatoR]

37 minutes ago, Melba23 said:

Please try it and see if it meets your requirements

 It's not my requirements, i just want to contribute for improvements.

I tested the new version...

* Icons displayed good.

* On expansion there is no subitems, only one empty item. Sorry forgot to use _CFF_RegMsg.

* Disable parent issue not solved for all cases (it should be re-enabled before each GUIDelete call).

Edited April 12, 2020 by MrCreatoR

[MrCreatoR]

About the icons, there is a problem when selecting item, it became Folder icon when selected:

#include 'ChooseFileFolder_Icon_Disable.au3'

_CFF_RegMsg()

Local $sRoot = @AutoItExe & '\..'
Local $aCheckList = StringSplit($sRoot & '\AutoIt3.exe' & @LF & $sRoot & '\AutoIt3_x64.exe', @LF, 2)

_CFF_SetPreCheck($aCheckList, False)
_CFF_Choose('Test', 300, 400, -1, -1, $sRoot, '*', BitOR(16, 2048), -1)

 

To fix it add _GUICtrlTreeView_SetSelectedImageIndex after each _GUICtrlTreeView_SetImageIndex usage.

Edited April 12, 2020 by MrCreatoR

[Melba23]

MrCreatoR,

Quote

It's not my requirements, i just want to contribute for improvements

I know - i was just teasing! Thank you very much for your suggestions.

Added parent re-enable code after each GUIDelete (in my defence I was cooking lunch at the same time!) and added the _GUICtrlTreeView_SetSelectedImageIndex lines (I can see why they are needed now). All good now?

M23

 

P.S. No need for BitOR when setting the $iDisplay parameter - simple addition will suffice.

Edited April 13, 2020 by Melba23
Beta code removed