C to AutoIt conversion

[FredAI]

Hi.

Can someone tell me if there's something wrong with this conversion?

C code:

//Allocate memory.
    Buffer = (PBYTE)calloc(HashSize, 1);


    //Actually calculate the hash
    if( !CryptCATAdminCalcHashFromFileHandle(FileHandle, &HashSize, Buffer, 0) )
    {
        CryptCATAdminReleaseContext(Context, 0);
        free(Buffer);
        CloseHandle(FileHandle);
        return FALSE;
    }

    //Convert the hash to a string.
    MemberTag = (PWCHAR)calloc((HashSize * 2) + 1, sizeof(WCHAR));
    for( unsigned int i = 0; i < HashSize; i++ )
    {
        swprintf(&MemberTag[i * 2], L"%02X", Buffer[i ]);
    }

My AutoIt code:

; Allocate memory.
Local $Buffer = DllStructCreate('BYTE['&$HashSize&']')
$pBuffer = DllStructGetptr($Buffer,1)


; Actually calculate the hash
$aRet = DllCall('Wintrust.dll','BOOL','CryptCATAdminCalcHashFromFileHandle','HANDLE',$FileHandle,'DWORD*',$HashSize,'ptr',$pBuffer,'DWORD',0)
If Not $aRet[0] Then
  DllCall('Wintrust.dll','BOOL','CryptCATAdminReleaseContext','Handle',$Context,'DWORD',0)
  FileClose($FileHandle);
  $Buffer = 0
  Return False
EndIf
Local $Str = BinaryToString(DllStructGetData($Buffer,1))
Local $sMemberTag = DllStructCreate('WCHAR['&StringLen($Str)+1&']')
DllStructSetData($sMemberTag,1,$Str)
$pMemberTag = DllStructGetPtr($sMemberTag,1)

Thanks.

Fred.

[Ascend4nt]

Main problem I see is you're using AutoIt's built-in FileClose() function which probably means you are using FileOpen() to get the handle. These handles are generic. You'll need to look at _WinAPI_CreateFile and _WinAPI_CloseHandle. Not sure where '$Context' is coming from either.

[FredAI]

Thanks for your reply , Ascend4nt.

No, in fact I'm opening the file with FileCreateW()

Here's the code:

; Open a file
$aRet = DllCall('Kernel32.dll','HANDLE','CreateFileW','Wstr',$File,'DWORD',0x80000000,'DWORD',7, _
'ptr',0,'DWORD',3,'DWORD',0,'HANDLE',0)
$FileHandle = $aRet[0]

I just assumed that Fileclose() also closes the returned handle. Doesn't it?

The full code I'm converting is here:

http://forum.sysinternals.com/howto-verify-the-digital-signature-of-a-file_topic19247.html

Now I'm very happy because I've just made the function fully work!

It was working fine for common files, but always returned $TRUST_E_NOSIGNATURE (0x800B0100) which means "No signature found" for windows files.

The problem was in the statement WintrustStructure.dwStateAction = WTD_STATEACTION_VERIFY;

It must be WintrustStructure.dwStateAction = WTD_STATEACTION_AUTO_CACHE_FLUSH;

Now it's giving the same results as sigcheck or signtool, but works much faster! YES!!!

Thanks again.

[Factfinder]

  On 11/7/2011 at 11:46 AM, FredAI said:

Now it's giving the same results as sigcheck or signtool, but works much faster! YES!!!

I see many developers have tried to do something similar with autoit with no success. Looking at your creations, specially great SetAcl permissions UDF, it could be nice if the UDF could be made public.