Jump to content
Sign in to follow this  
RickB75

Please tell me where to place this at in this script or if it's wrong

Recommended Posts

RickB75

Guys, I been looking and trying to find a FTP script that will work for and I found this on another website here. It should do what I need it to do from looking at it but I'm having trouble placing my server info in it to test it. I don't know where to put the info. I think this is what is suppose to go somewhere

$CmdLine[5]= ["my server info", "my user name", "my password","my dir","my file"]

But it keeps breaking. Any help is always greatly appreciated!!

;
; FTP-Uploader with error correction and notification
;
; @author petzoldj
; @version 0.1
;

#include ;
#include ;
#include ;


; Functions

Func uploadFile($ftp, $server, $user, $password, $dir, $file)
$con = _FTP_Connect($ftp, $server, $user, $password);
$put = _FTP_ProgressUpload($con, $file, $dir & "/" & $file);
Return $con;
EndFunc

Func checkFile($ftp, $con, $dir, $file)
Dim $success = false;
$size = _FTP_FileGetSize($con, $dir & "/" & $file);

If $size > 0 Then
$success = true;
EndIf

Return $success;
EndFunc

Func sendMail($file)
Dim $date = _NowDate();
Dim $time = _NowTime();
Dim $smtp = "MY_SMTP_MAIL_SERVER";
Dim $from = "MY_SENDER";
Dim $sender = "MY_SENDER_MAIL@HOST.COM";
Dim $recipient = "MY_RECIPIENT_MAIL@HOST.COM";
Dim $subject = "MY_SUBJECT";

Dim $body[2];
$body[0] = "MY_MESSAGE_LINE_1";
$body[1] = "MY_MESSAGE_LINE_2";

$mail = _INetSmtpMail($smtp, $from, $sender, $recipient, $subject, $body, @ComputerName, -1);
;$err = @error
;If $mail = 1 Then
; MsgBox(0, "Success!", "Mail sent")
;Else
; MsgBox(0, "Error!", "Mail failed with error code " & $err)
;EndIf
EndFunc

Func init($errorCounter, $ftp, $server, $user, $password, $dir, $file)
$con = uploadFile($ftp, $server, $user, $password, $dir, $file);
$check = checkFile($ftp, $con, $dir, $file);

If $check = false Then
$errorCounter = $errorCounter + 1;
If $errorCounter > 3 Then
;MsgBox(0, "Critical Error", "Upload failes multiple times - terminating");
$mail = sendMail($dir & "/" & $file);
$bye = _FTP_Close($ftp);
Exit;
Else
;MsgBox(0, "Error", "Upload failed - " & $errorCounter & ". attempt");
init($errorCounter, $ftp, $server, $user, $password, $dir, $file);
EndIf
Else
;MsgBox(0, "Finished", "Upload was successful");
EndIf
EndFunc

; Workflow

If $CmdLine[0] < 5 Then
Exit;
EndIf

Const $server = $CmdLine[1];
Const $user = $CmdLine[2];
Const $password = $CmdLine[3];
Const $dir = $CmdLine[4];
Const $file = $CmdLine[5];
Dim $errorCounter = 0;

$ftp = _FTP_Open("FTP Control");
$upload = init($errorCounter, $ftp, $server, $user, $password, $dir, $file);
$bye = _FTP_Close($ftp);

Share this post


Link to post
Share on other sites
RickB75

john,

Thank you for your reply! I opened the help file and I did find the Command Lind Parameters section. I don't understand it. I'm really green at this. I'm just wondering how I could try this ftp script and see if it would work for me. My goal is to add the FTP portion into a loop in my main script and as a file gets saved locally it then FTPs the file to my server. Right now I'm having to use an external program "FileZilla" to FTP them.

Share this post


Link to post
Share on other sites
FireFox

I did find the Command Lind Parameters section. I don't understand it.

Make a google search with the keywords "command line parameters", it's not something specific to autoit.

Edit:

;Replace this:
If $CmdLine[0] < 5 Then
Exit;
EndIf

Const $server = $CmdLine[1];
Const $user = $CmdLine[2];
Const $password = $CmdLine[3];
Const $dir = $CmdLine[4];

;With this:
Global Const $server = "my server info"
Global Const $user = "my user name"
Global Const $password = "my password"
Global Const $dir = "my dir"

Br, FireFox.

Edited by FireFox

 

OS : Win XP SP2 (32 bits) / Win 7 SP1 (64 bits) / Win 8 (64 bits) | Autoit version: latest stable / beta.
Hardware : Intel(R) Core(TM) i5-2400 CPU @ 3.10Ghz / 8 GiB RAM DDR3.

My UDFs : Skype UDF | TrayIconEx UDF | GUI Panel UDF | Excel XML UDF | Is_Pressed_UDF

My Projects : YouTube Multi-downloader | FTP Easy-UP | Lock'n | WinKill | AVICapture | Skype TM | Tap Maker | ShellNew | Scriptner | Const Replacer | FT_Pocket | Chrome theme maker

My Examples : Capture toolIP Camera | Crosshair | Draw Captured Region | Picture Screensaver | Jscreenfix | Drivetemp | Picture viewer

My Snippets : Basic TCP | Systray_GetIconIndex | Intercept End task | Winpcap various | Advanced HotKeySet | Transparent Edit control

 

Share this post


Link to post
Share on other sites
RickB75

Thank you guys so much for your help. I did change the lines like you suggested Firefox and the script is running it's course but with no luck on the file up load. For the life of me, I can't figure out why I can't get this FTP piece to work. I've tried other scripts and they failed as well. I know the server, User Name and password info is correct. It just won't FTP.

Share this post


Link to post
Share on other sites
FireFox

Try the simpliest code possible then, without progress etc and debug it (check the functions return value/@error macro).

Br, FireFox.

Edited by FireFox

 

OS : Win XP SP2 (32 bits) / Win 7 SP1 (64 bits) / Win 8 (64 bits) | Autoit version: latest stable / beta.
Hardware : Intel(R) Core(TM) i5-2400 CPU @ 3.10Ghz / 8 GiB RAM DDR3.

My UDFs : Skype UDF | TrayIconEx UDF | GUI Panel UDF | Excel XML UDF | Is_Pressed_UDF

My Projects : YouTube Multi-downloader | FTP Easy-UP | Lock'n | WinKill | AVICapture | Skype TM | Tap Maker | ShellNew | Scriptner | Const Replacer | FT_Pocket | Chrome theme maker

My Examples : Capture toolIP Camera | Crosshair | Draw Captured Region | Picture Screensaver | Jscreenfix | Drivetemp | Picture viewer

My Snippets : Basic TCP | Systray_GetIconIndex | Intercept End task | Winpcap various | Advanced HotKeySet | Transparent Edit control

 

Share this post


Link to post
Share on other sites
RickB75

This is the piece that was recommended I use a couple of months ago.

$host = "my server" ; Hostname of the webserver (Can be a domain name or an IP)
$user = "xxxxxxxxxx" ; FTP Username
$pass = "xxxxxxxxxxx" ; FTP Password
$folder = "/windowsticker" ; This is the folder where your files will upload to

$myFile = "C:\UCC\100.png"
_DebugSetup("Debug", True,2)

$open = _FTP_Open("Myftp")
_DebugOut("FTP Open Return:"&$open)
$conn = _FTP_Connect($open, $host, $user, $pass)
_DebugOut("FTP Connect Return:"&$conn)
;_FTP_Connect($open, $host, $user, $pass,0,0) ;### Debug MSGBOX
$result=_FTP_FilePut($conn, $myFile,"/windowsticker")
_DebugOut("FTP FilePut Return:"&$result&" - Error:"&@error)
_FTP_Close($open)

and this is what I get written back

AutoIt:3.3.8.1 AdminMode (Os:WIN_XP/SP3/X86 OSLang:0409 MUILang:0000 CPUArch:X64)

FTP Open Return:0x00CC0004

FTP Connect Return:0x00CC0008

FTP FilePut Return:0 - Error:-1

+>17:24:01 AutoIT3.exe ended.rc:0

Share this post


Link to post
Share on other sites
RickB75

BTW, that /100.png is a thumbnail image. very small.

Share this post


Link to post
Share on other sites
RickB75

I thought it may have been an issue with the firewall but, I can use Filezilla and in the network connections, i can also transfer files from there. I stumped!!

Share this post


Link to post
Share on other sites
JohnOne

Is the full path to your ftp folder "my server/windowsticker"

I never use ftp, but it looks like that might be the problem.

Do you need those double slashes perhaps "my server//windowsticker"

Maybe trailing slashes "my server//windowsticker//" or "my server/windowsticker/"

  • Like 1

AutoIt Absolute Beginners    Require a serial    Pause Script    Video Tutorials by Morthawt   ipify 

Monkey's are, like, natures humans.

Share this post


Link to post
Share on other sites
FireFox

Two things :

-Check if your image full path is correct (FileExists function)

-Try to upload to the root folder: /

After that if it does not work, play with the flags of the function...

Br, FireFox.


 

OS : Win XP SP2 (32 bits) / Win 7 SP1 (64 bits) / Win 8 (64 bits) | Autoit version: latest stable / beta.
Hardware : Intel(R) Core(TM) i5-2400 CPU @ 3.10Ghz / 8 GiB RAM DDR3.

My UDFs : Skype UDF | TrayIconEx UDF | GUI Panel UDF | Excel XML UDF | Is_Pressed_UDF

My Projects : YouTube Multi-downloader | FTP Easy-UP | Lock'n | WinKill | AVICapture | Skype TM | Tap Maker | ShellNew | Scriptner | Const Replacer | FT_Pocket | Chrome theme maker

My Examples : Capture toolIP Camera | Crosshair | Draw Captured Region | Picture Screensaver | Jscreenfix | Drivetemp | Picture viewer

My Snippets : Basic TCP | Systray_GetIconIndex | Intercept End task | Winpcap various | Advanced HotKeySet | Transparent Edit control

 

Share this post


Link to post
Share on other sites
kylomas

RickB75,

If "windowsticker" is a directory then your _ftp_fileput stmt should look more like this:

$result=_FTP_FilePut($conn, $myFile,"/windowsticker/" & $my_remote_filename)

where: $my_remote_filename is the name of the file at the remote site

kylomas

Edited by kylomas

Forum Rules         Procedure for posting code

"I like pigs.  Dogs look up to us.  Cats look down on us.  Pigs treat us as equals."

- Sir Winston Churchill

Share this post


Link to post
Share on other sites
RickB75

Here is an example file that I uploaded using Filezilla.

http://www.beaman-auto.com/windowsticker/JTEBU5JR9D5131553.pdf

I need to upload into the windowsticker directory.

Is this right?

$result=_FTP_FilePut($conn, $myFile,"/windowsticker/")

Share this post


Link to post
Share on other sites
RickB75

ok... This is what I got so far. I did this

$result=_FTP_FilePut($conn, $myFile,"/windowsticker/"&"100.png")

and it did try to upload the image but it has 0 bytes. Any idea why it would do this?

Share this post


Link to post
Share on other sites
JohnOne

Here is an example file that I uploaded using Filezilla.

http://www.beaman-auto.com/windowsticker/JTEBU5JR9D5131553.pdf

I need to upload into the windowsticker directory.

Is this right?

$result=_FTP_FilePut($conn, $myFile,"/windowsticker/")

Try this

$result=_FTP_FilePut($conn, $myFile,"/windowsticker/100.png")


AutoIt Absolute Beginners    Require a serial    Pause Script    Video Tutorials by Morthawt   ipify 

Monkey's are, like, natures humans.

Share this post


Link to post
Share on other sites
RickB75

It is trying to upload but with each file it has 0 bytes in size. do you think it could be a directory issue on my PC? How would I get / find the true directory for the file I'm trying to upload. right now I'm right clicking on the file and going to the properties and getting it that way. Any ideas?

Share this post


Link to post
Share on other sites
RickB75

John,

I tried it and getting the same result. It's weird. I'm not doing anything different with the path than when I'm using other scripts.

BTW guys, I just want to thank you for helping me and being patient. It is truly appreciated!

Share this post


Link to post
Share on other sites
RickB75

I have some scripts that will call data files using the path names and I've never had an issue. It very well could be something on the server side. This is what I get back when I log in using Filezilla.

Status: Resolving address of beaman-auto.com

Status: Connecting to xxx.xxx.xx.xxx.xxxx...

Status: Connection established, waiting for welcome message...

Response: 220---------- Welcome to Pure-FTPd [privsep] [TLS] ----------

Response: 220-You are user number 13 of 500 allowed.

Response: 220-Local time is now 18:08. Server port: 21.

Response: 220-This is a private system - No anonymous login

Response: 220 You will be disconnected after 3 minutes of inactivity.

Command: USER xxxxxxxx

Response: 331 User xxxxxxxx OK. Password required

Command: PASS xxxxxxxx

Response: 230 OK. Current restricted directory is /

Command: SYST

Response: 215 UNIX Type: L8

Command: FEAT

Response: 211-Extensions supported:

Response: EPRT

Response: IDLE

Response: MDTM

Response: SIZE

Response: MFMT

Response: REST STREAM

Response: MLST type*;size*;sizd*;modify*;UNIX.mode*;UNIX.uid*;UNIX.gid*;unique*;

Response: MLSD

Response: AUTH TLS

Response: PBSZ

Response: PROT

Response: TVFS

Response: ESTA

Response: PASV

Response: EPSV

Response: SPSV

Response: ESTP

Response: 211 End.

Status: Server does not support non-ASCII characters.

Status: Connected

Status: Retrieving directory listing...

Command: CWD /windowsticker

Response: 250 OK. Current directory is /windowsticker

Command: PWD

Response: 257 "/windowsticker" is your current location

Command: TYPE I

Response: 200 TYPE is now 8-bit binary

Command: PASV

Response: 227 Entering Passive Mode (50,63,80,1,197,54)

Command: MLSD

Response: 150 Accepted data connection

Response: 226-Options: -a -l

Response: 226 4941 matches total

Status: Directory listing successful

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

  • Similar Content

    • Carm01
      By Carm01
      Hello,
      I am attempting to pull a list of the directory structure from a public FTP where no username or password is required i.e:
      ftp://ftp.adobe.com/pub/adobe/
      Now I have looked all over the place and have failed find anything to accomplish, and if I found some, and the documentation is rather bleak for example;
      it does show something I am looking for, but there is no ftp.au3, and the usage and examples of what i want to do seems to elude me on this and it may not even apply to what I am trying to accomplish?
      I want to avoid using things with Internet explorer , and I have done some google searches. However nothing seems to help
      the documentation surrounding : _FTP_DirGetCurrent  references _FTP_Connect , and then references _FTP_Open , and regardless what I try I cannot get it to pull a list of directorys of files as a list.
       
      Any help is appreciated
       
       
       
    • Jemboy
      By Jemboy
      Hi,
      Ones(some times twice) a month I get an e-mail with zip file, which has price updates from a supplier.
      I have to upload the file to an FTP to get it processed.
      When uploading the file, it will get "timestamped" with the time and date at which time the file was uploaded.
      Normally this is fine, because I mostly upload the file the same day.
      Sometimes it may take 1 or 2 days before I can upload the file.
      For historical purpose, I would like to have the file timestamped with the original date.
      I have tried using:  _FTP_Command ( $hFTPSession, "MFCT YYYYMMDDHHMMSS path") 
      however this command does not work or change the timestamp as I expected.
      Does anyone now a way how I can change the timestamp of a FTP-file?
    • Sally1801
      By Sally1801
      Hello,
      i need help in deleting files from a server. The function "_FTP_DirDelete" only deletes a directory when its empty. I need to delete a non empty directory. I also can not delete the files in this directory first, because the files are PAG and DIR files in a .DAV directory and FTPEx.au3 doesnt like a directory starting with a ".".
      Any ideas?
      Thx, Sally
    • CharlieH
      By CharlieH
      Hi,
       
      I have written a small script to read a file from an FTP server and check its contents. This can be re-run by the press of a button, however, if the file is deleted from the ftp server between runs (with the .exe still live), the file is still "read" and written locally, which then passes the check.
       
      If I run it initially without the file, it correctly fails and pops up my error message, but if the file is then added, it then seemingly gets cached (or similar) so that the app then always reports a success.
       
      The below code snippet is just the function run when the "test" button is pressed. It includes a load of debug message boxes, and from that I think I've gathered a few (possibly) interesting/relevant things:
      $Open and $Conn are 8 byte values, which increments (not by 1) when the FTP connection is not closed, but if the connection is closed, they stick at the value (presumably windows can re-use that session id if it's been closed e.g:
      1st run (file not present) $Open -> 0x00CC0004 $Conn -> 0x00CC0008
      2nd run (file not present) $Open -> 0x00CC0010 $Conn -> 0x00CC0014
      3rd run (file now present) $Open -> 0x00CC001C $Conn -> 0x00CC0020
      4th run (file still present) $Open -> 0x00CC001C $Conn -> 0x00CC0020
      $Ftp = _FTP_FileGet.... returns a 1 when file not present (in a run after it was present) and "test_transfer.txt" does get created and does contain the correct string This is the key bit I dont understand, I dont know how/where it is getting the data to write this file when it literally no longer exists on the target FTP server...
      resetting every variable used in the function each time it's run does work (in that they become 0), but it doesn't affect the putcome I had thought perhaps some key values were being stored in the variables, but this doesn't seem to be the case
       
       
      Is there any concept of clearing a cache when closing an ftp session? Or deleting any unknown temporary files windows might make?
       
      Thanks all
       
      Func Transfer() Local $connected = 0 $Ftpp = 0 ;Trying to reset these every time function is called $file = 0 $Open = 0 $Conn = 0 $Ftpc = 0 ;Make a new "connecting..." window so that the user has feedback that a transfer is attempting to take place ;Otherwise it just runs in the background and there's no indication its doing anything $connection_window = GUICreate ("Ethernet Switch Test" , 300 , 160 , -1 , -1 , -1 , -1 , 0) GUISetBkColor(0xFFFFFF) GUISetFont(10 * _GDIPlus_GraphicsGetDPIRatio()[0], 400, Default, "Sans Serif") $connecting_label = GUICtrlCreateLabel("Connecting to board...", 0, 25, 300, -1, $SS_Center, "") GUISetState(@SW_SHOW, $connection_window) Sleep(100) ;Connect ;MsgBox(0, "DEBUG", "1" & $Conn) While $connected = 0 $Open = _FTP_Open($count) ;MsgBox(0, "DEBUG", "open " & $Open) $Conn = _FTP_Connect($Open, $server, $username, $password) ;MsgBox(0, "DEBUG", "2" & $Conn) If $Conn = 0 then Local $retry = Msgbox(65, 'FTP Transfer', 'Connection failed' & @CRLF & "Retry?") If $retry = 2 Then MsgBox(0, "FTP Transfer", "Operation aborted") GUISetState(@SW_HIDE, $connection_window) Return EndIf Else $connected_label = GUICtrlCreateLabel("Connected!", 0, 45, 300, -1, $SS_Center, "") $connected = 1 MsgBox(0, "DEBUG", "3" & $connected) Sleep(100) endIf WEnd $transfering_label = GUICtrlCreateLabel("Reading file....", 0, 45, 300, -1, $SS_Center, "") ;Read file from server ;MsgBox(0, "DEBUG", "5" & $Ftpp) ;MsgBox(0, "DEBUG", "flie " & $file) $Ftpp = _FTP_FileGet($Conn, 'test/test.txt', 'test_transfer.txt') ;MsgBox(0, "DEBUG", "6" & $Ftpp) If ($Ftpp) then $transfered_label = GUICtrlCreateLabel("Transfered, checking...", 0, 65, 300, -1, $SS_Center, "") ;MsgBox(0, "DEBUG", "flie " & $file) $file = FileRead("test_transfer.txt") ;MsgBox(0, "DEBUG", "flie " & $file) If Not StringInStr($file, 'this is a test string 12345') Then MsgBox(0, "File check", "Received file incorrect, test failed!") GUISetState(@SW_HIDE, $connection_window) Return Else $tested_label = GUICtrlCreateLabel("Tested and Passed!", 0, 85, 300, -1, $SS_Center, "") $Ftpc = _FTP_Close($Open) ;MsgBox(0, "DEBUG", "close" & $Ftpc) ;$count = $count+1 $ok_button = GUICtrlCreateButton("OK", 125, 105, 50, -1) While 1 Local $pressed = GUIGetMsg() If ($pressed = $ok_button) Then FileDelete("test_transfer.txt") GUISetState(@SW_HIDE, $connection_window) ;$connection_window = 0 Return EndIf WEnd EndIf Else MsgBox(0, "Transfer", "Could not read file " & @error) GUISetState(@SW_HIDE, $connection_window) Return EndIf EndFunc  
    • Sigmac
      By Sigmac
      I have used this code for a long time, but for a week or 2 it stopped working?
      Connection is ok, the put create the file on server if I delete it on the FTP server, but the file is empty and after 30 secondees the function return 0
      I have tested on 2 machines, Filezilla FTP client have no issue to the server.
      Firewall is disabled under test.
        If $writeFTP = True Then
            $Open=_FTPOpen('MyFTP Control')
            $Conn=_FTPConnect($Open, $destinationServer, $destinationUsername, $destinationPass)
       MsgBox(0,"start","start")
            $Ftpp=_FtpPutFile($Conn, $filePath&$name&".json", "httpdocs/p_calender/" & $name & ".json")
      MsgBox(0,"return","return"&$Ftpp)
      Exit
            $Ftpc=_FTPClose($Open)
           EndIf
       
      From the Lib:
      Func _FTPPutFile($l_FTPSession, $s_LocalFile, $s_RemoteFile, $l_Flags = 0, $l_Context = 0)
          Local $ai_FTPPutFile = DllCall('wininet.dll', 'int', 'FtpPutFile', 'long', $l_FTPSession, 'str', $s_LocalFile, 'str', $s_RemoteFile, 'long', $l_Flags, 'long', $l_Context)
          If @error OR $ai_FTPPutFile[0] = 0 Then
              SetError(-1)
              Return 0
          EndIf
          Return $ai_FTPPutFile[0]
      EndFunc ;==> _FTPPutFile()
       
×