Jump to content
Sign in to follow this  
matwachich

Need advise on my WSA TCP functions [C]

Recommended Posts

matwachich

Hi everybody!

I wanted to learn winsockets, and for this, I try to reproduce AutoIt's TCP functions.

My code is working pretty good!

I juste want somebody, an AutoIt dev, to look my code and tell me if I'm doing something wrong, or something need to be done differently.

Another problem, is that when I close a socket on one side of a connection, the recv functions in the other side doesn't detect the close action! (like TCPRecv would return an @error)

Thanks in advance!

(I compile it with GCC 4x)

Here is the code

#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif

#define WINVER 0x0501
#define _WIN32_WINNT 0x0501

#include <windows.h>

#include <winsock2.h>
#include <ws2tcpip.h>
#include <iphlpapi.h>

#include <stdio.h>
#include <stdlib.h>

/* -------------------------------------------------------------------------- */

#define SIMPLE_TCP_BUILD_DLL
#include "simpletcp.h"

/* -------------------------------------------------------------------------- */

#define CHECK_INIT if (_global_ == NULL) return;
#define CHECK_INIT_RET(ret) if (_global_ == NULL) return ret;

#define SET_ERR(func) sprintf(_global_->err_func, "%s", func); _global_->err = WSAGetLastError();
#define UNSET_ERR sprintf(_global_->err_func, "%s", ""); _global_->err = 0;

/* -------------------------------------------------------------------------- */

typedef struct {
    WSADATA wsaData;
    char err_func[20];
    int err;
} simple_tcp_t;

simple_tcp_t* _global_ = NULL;

/* -------------------------------------------------------------------------- */
/* Standard functions */

/** \brief
 *
 * \return
 */
int     SIMPLE_TCP  TCPStartup ()
{
    if (_global_ != NULL) { return 1; }

    _global_ = malloc(sizeof(simple_tcp_t));
    if (_global_ == NULL) { return 0; }

    if (WSAStartup(MAKEWORD(2, 2), &_global_->wsaData) != 0) {
        free(_global_);
        _global_ = NULL;
        return 0;
    }

    UNSET_ERR

    return 1;
}


/** \brief
 *
 * \return
 */
void    SIMPLE_TCP  TCPShutdown ()
{
    if (_global_ == NULL) { return; }

    WSACleanup();
    free(_global_);
    _global_ = NULL;
}


/** \brief
 *
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPGetError (char* err_func, const size_t err_func_len)
{
    CHECK_INIT_RET(0)
    int err = _global_->err;
    if (err_func != NULL && err_func_len > 0) {
        snprintf(err_func, err_func_len, "%s", _global_->err_func);
    }
    UNSET_ERR
    return err;
}


/** \brief
 *
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPConnect (const char* host, const char* port)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    struct addrinfo hints, *result = NULL;
    ZeroMemory(&hints, sizeof(hints));

    hints.ai_family = AF_INET; // IP v4
    hints.ai_socktype = SOCK_STREAM; // Stream socket
    hints.ai_protocol = IPPROTO_TCP; // TCP

    if (getaddrinfo(host, port, &hints, &result) != 0) {
        SET_ERR("getaddrinfo")
        return 0;
    }

    SOCKET ConnectSocket = INVALID_SOCKET;
    ConnectSocket = socket(result->ai_family, result->ai_socktype, result->ai_protocol);
    if (ConnectSocket == INVALID_SOCKET) {
        freeaddrinfo(result);
        SET_ERR("socket")
        return 0;
    }

    if (connect(ConnectSocket, result->ai_addr, (int)result->ai_addrlen) != 0) {
        freeaddrinfo(result);
        SET_ERR("connect")
        return 0;
    }
    freeaddrinfo(result);

    unsigned long mode = 1;
    if (ioctlsocket(ConnectSocket, FIONBIO, &mode) != 0) {
        SET_ERR("ioctlsocket")
        return 0;
    }

    return ConnectSocket;
}


/** \brief
 *
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPListen (const char* port)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    struct addrinfo hints, *result = NULL;
    ZeroMemory(&hints, sizeof(hints));

    hints.ai_family = AF_INET; // IP v4
    hints.ai_socktype = SOCK_STREAM; // Stream socket
    hints.ai_protocol = IPPROTO_TCP; // TCP
    hints.ai_flags = AI_PASSIVE; // this + node = NULL => local host IP

    if (getaddrinfo(NULL, port, &hints, &result) != 0) {
        SET_ERR("getaddrinfo")
        return 0;
    }

    SOCKET ListenSocket = INVALID_SOCKET;
    ListenSocket = socket(result->ai_family, result->ai_socktype, result->ai_protocol);
    if (ListenSocket == INVALID_SOCKET) {
        freeaddrinfo(result);
        SET_ERR("socket")
        return 0;
    }

    unsigned long mode = 1;
    if (ioctlsocket(ListenSocket, FIONBIO, &mode) != 0) {
        freeaddrinfo(result);
        SET_ERR("ioctlsocket")
        return 0;
    }

    if (bind(ListenSocket, result->ai_addr, (int)result->ai_addrlen) != 0) {
        freeaddrinfo(result);
        SET_ERR("bind")
        return 0;
    }
    freeaddrinfo(result);

    if (listen(ListenSocket, SOMAXCONN) != 0) {
        SET_ERR("listen")
        return 0;
    }

    return ListenSocket;
}


/** \brief
 *
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPAccept (int socket)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    int err;
    SOCKET ClientSocket = INVALID_SOCKET;

    ClientSocket = accept(socket, NULL, NULL);
    err = WSAGetLastError();

    if (ClientSocket == INVALID_SOCKET && err != WSAEWOULDBLOCK) {
        SET_ERR("accept")
        return INVALID_SOCKET;
    }

    if (ClientSocket != INVALID_SOCKET) {
        unsigned long mode = 1;
        if (ioctlsocket(ClientSocket, FIONBIO, &mode) != 0) {
            SET_ERR("ioctlsocket")
            return INVALID_SOCKET;
        }
    }

    return ClientSocket;
}


/** \brief
 *
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPCloseSocket (int socket)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    if (shutdown(socket, SD_BOTH) != 0) {
        SET_ERR("shutdown")
        return 0;
    }

    if (closesocket(socket) != 0) {
        SET_ERR("closesocket")
        return 0;
    }

    return 1;
}


/** \brief
 *
 * \param
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPSend (int socket, const char* data, const size_t data_len)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    int ret = send(socket, data, data_len, 0);
    if ((ret == SOCKET_ERROR || ret == 0) && WSAGetLastError() != WSAEWOULDBLOCK) {
        SET_ERR("send")
        return 0;
    }

    return ret;
}


/** \brief
 *
 * \param
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPRecv (int socket, char* data, const size_t data_len)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    int ret = recv(socket, data, data_len, 0);
    if ((ret == 0 || ret == SOCKET_ERROR) && WSAGetLastError() != WSAEWOULDBLOCK) {
        SET_ERR("recv")
        return 0;
    }

    return ret;
}


/** \brief
 *
 * \param
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPNameToIP (const char* name, char* ip, const size_t ip_len)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    struct addrinfo hints, *result = NULL;
    ZeroMemory(&hints, sizeof(hints));

    hints.ai_family = AF_INET; // IP v4
    hints.ai_socktype = SOCK_STREAM; // Stream socket
    hints.ai_protocol = IPPROTO_TCP; // TCP

    if (getaddrinfo(name, NULL, &hints, &result) != 0) {
        SET_ERR("getaddrinfo")
        return 0;
    }

    if (result->ai_family != AF_INET || result->ai_addrlen != sizeof(struct sockaddr_in)) {
        SET_ERR("bad address family")
        freeaddrinfo(result);
        return 0;
    }

    struct sockaddr_in* addr = (struct sockaddr_in*)result->ai_addr;
    char* ret = inet_ntoa(addr->sin_addr);

    snprintf(ip, ip_len, "%s", ret);
    freeaddrinfo(result);

    return 1;
}


/** \brief
 *
 * \param
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPSocketToIP (int socket, char* ip, const size_t ip_len)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    struct sockaddr_in addr_in;
    int len = sizeof(addr_in);

    if (getpeername(socket, (struct sockaddr*)&addr_in, &len) != 0) {
        SET_ERR("getpeername")
        return 0;
    }

    char* ret = inet_ntoa(addr_in.sin_addr);
    if (ret == NULL) {
        SET_ERR("inet_ntoa")
        return 0;
    }

    snprintf(ip, ip_len, "%s", ret);

    return 1;
}

and the header

#ifndef __SIMPLE_TCP_H__
#define __SIMPLE_TCP_H__

#ifdef SIMPLE_TCP_BUILD_DLL
#define SIMPLE_TCP __stdcall __declspec(dllexport)
#else
#define SIMPLE_TCP __stdcall __declspec(dllimport)
#endif

/* -------------------------------------------------------------------------- */
/* Standard functions */

int     SIMPLE_TCP  TCPStartup ();
void    SIMPLE_TCP  TCPShutdown ();

int     SIMPLE_TCP  TCPGetError (char* err_func, const size_t err_func_len);

int     SIMPLE_TCP  TCPConnect (const char* ip, const char* port);
int     SIMPLE_TCP  TCPListen (const char* port);
int     SIMPLE_TCP  TCPAccept (int socket);
int     SIMPLE_TCP  TCPCloseSocket (int socket);

int     SIMPLE_TCP  TCPSend (int socket, const char* data, const size_t data_len);
int     SIMPLE_TCP  TCPRecv (int socket, char* data, const size_t data_len);

int     SIMPLE_TCP  TCPNameToIP (const char* name, char* ip, const size_t ip_len);
int     SIMPLE_TCP  TCPSocketToIP (int socket, char* ip, const size_t ip_len);

#endif // __SIMPLE_TCP_H__

Share this post


Link to post
Share on other sites
funkey

As far as I see you are just missing some timeouts.

I wrapped some C functions in AutoIt to extend the TCP functions of AutoIt.

#include "socket_UDF.au3"

_WSAStartup()

Global $iSock = _socket($AF_INET, $SOCK_STREAM, $IPPROTO_TCP)
ConsoleWrite("Socket: " & $iSock & @CRLF)

Global $tTimeVal = DllStructCreate("DWORD timeout")
DllStructSetData($tTimeVal, "timeout", 200) ; Timeout 200ms

$iSockError = _setsockopt($iSock, $SOL_SOCKET, $SO_RCVTIMEO, $tTimeVal) ; set Timeout for recv
If $iSockError Then
    ConsoleWrite("SetSockOpt error setting recv timeout!. Windows Sockets Error Codes: " & _WSAGetLastError() & @CRLF)
    _closesocket($iSock)
    TCPShutdown() ;WSACleanup
EndIf

Global $iBind = _bind($iSock, @IPAddress1, 20000) ;local IP-Address and port to use
ConsoleWrite("Bind error: " & $iBind & @CRLF) ; 0 is OK

Global $iConnect = _connect($iSock, "10.1.6.51", 80)
ConsoleWrite("Connect error: " & $iConnect & @CRLF) ; 0 is OK

If $iConnect Then
    ConsoleWrite("Windows Sockets Error Codes: " & _WSAGetLastError() & @CRLF)
    _closesocket($iSock)
    TCPShutdown() ;WSACleanup
EndIf

Global $sToSend = "GET /input1?PW=?"
Global $tSendBuffer = DllStructCreate("char[" & StringLen($sToSend) & "]")
DllStructSetData($tSendBuffer, 1, $sToSend)

Global $iSend = _send($iSock, $tSendBuffer)
ConsoleWrite("Bytes sent: " & $iSend & @CRLF)

Global $tRecvBuffer = DllStructCreate("char[64]")
Global $iRecv = _recv($iSock, $tRecvBuffer)
ConsoleWrite("Bytes received: " & $iRecv & @CRLF)

ConsoleWrite("Data received: " & DllStructGetData($tRecvBuffer, 1) & @CRLF) ;input1;OFF

_closesocket($iSock)
_WSACleanup()
 

socket_UDF.au3


Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the Universe
trying to produce bigger and better idiots.
So far, the Universe is winning.

Share this post


Link to post
Share on other sites
matwachich

Thanks for the answer!

Adding a timeout will not solve the problem, since my sockets are asynchronous.

I think it hase something to do with to SO_KEEPALIVE options, but I don't very well understand how it works or how to use it.

Edited by matwachich

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

  • Similar Content

    • ufukreis1212
      By ufukreis1212
      Hello, I am new members. Help me please. I want vbs convert to au3 .
      This vbs code : 
      'deneme Set SystemSet = GetObject("winmgmts:").InstancesOf ("Win32_OperatingSystem") strOSArch = GetObject("winmgmts:root\cimv2:Win32_OperatingSystem=@").OSArchitecture Set objNetwork = CreateObject("Wscript.Network") Set wshShell = CreateObject( "WScript.Shell" ) strComputerName = wshShell.ExpandEnvironmentStrings( "%COMPUTERNAME%" ) Set oShell = WScript.CreateObject("WScript.Shell") proc_arch = oShell.ExpandEnvironmentStrings("%PROCESSOR_ARCHITECTURE%") Set oEnv = oShell.Environment("SYSTEM") strComputer = "." Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\CIMV2") Set colMB = objWMIService.ExecQuery("Select * from Win32_BaseBoard") Set colCSes = objWMIService.ExecQuery("SELECT * FROM Win32_ComputerSystem") Set colProcessors = objWMIService.ExecQuery("Select * from Win32_Processor") Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\CIMV2") Set colItemsx = objWMIService.ExecQuery( _ "SELECT * FROM Win32_VideoController",,48) '------------------------------------------------------------------- Set obj = GetObject("winmgmts:").InstancesOf("Win32_PhysicalMemory") i = 1 For Each obj2 In obj memTmp1 = obj2.capacity / 1024 / 1024 TotalRam = TotalRam + memTmp1 i = i +1 Next '-------------------------------------------------------------------- Dim objWMIService : Set objWMIService = GetObject("winmgmts:\\.\root\cimv2") Set colItems = objWMIService.ExecQuery("Select Architecture from Win32_Processor") For Each objItem in colItems if objItem.Architecture = 0 then strArchitecture = "x86" end if if objItem.Architecture = 9 then strArchitecture = "x64" end if next '-------------------------------------------------------------------- strComputer = "." ' Local computer strMemory = "" i = 1 set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2") set colItems = objWMIService.ExecQuery("Select * from Win32_PhysicalMemory") For Each objItem In colItems if strMemory <> "" then strMemory = strMemory & vbcrlf strMemory = strMemory & "Bank" & i & " : " & (objItem.Capacity /1024 /1024) & " Mb" i = i + 1 Next installedModules = i - 1 Set colItems = objWMIService.ExecQuery("Select * from Win32_PhysicalMemoryArray") For Each objItem in colItems totalSlots = objItem.MemoryDevices Next '---------------------------------------------------------------------- Set objWMISvc = GetObject( "winmgmts:\\.\root\cimv2" ) Set colItems = objWMISvc.ExecQuery( "Select * from Win32_ComputerSystem" ) For Each objItem in colItems strComputerDomain = objItem.Domain Next for each System in SystemSet For Each objItem in colItemsx For Each objProcessor in colProcessors For Each bbType In colMB MbVendor = bbType.Manufacturer MbModel = bbType.Product MsgBox "İşletim Sistemi : " & System.Caption & vbNewLine & _ "İşletim Sistemi Versionu : " & + System.Version & vbNewLine & _ "Windows Mimari Yapısı: " & strOSArch & vbNewLine & _ "Kullanıcı isminiz: " & objNetwork.UserName & vbNewLine & _ "Bilgisayar ismi: " & strComputerName & vbNewLine & _ "Çalışma Grubu: " & strComputerDomain & vbNewLine & _ "--------------------------------------" & vbNewLine & _ "Anakart: " & MbVendor & " " & "[" & MbModel & "]" & vbNewLine & _ "--------------------------------------" & vbNewLine & _ "Grafik Kartı: " & objItem.Caption & vbNewLine & _ "Driver Version: " & objItem.DriverVersion & vbNewLine & _ "--------------------------------------" & vbNewLine & _ "İşlemci Üreticisi: " & objProcessor.Manufacturer & vbNewLine & _ "İşlemci İsmi: " & objProcessor.Name & vbNewLine & _ "CPU Mimarisi: " & strArchitecture & vbNewLine & _ "İşlemci Çekirdek sayısı: " & oEnv("NUMBER_OF_PROCESSORS") & vbNewLine & _ "--------------------------------------" & vbNewLine & _ "Toplam RAM: " & TotalRam & " MB" & vbNewLine & _ "Toplam Slot: " & totalSlots & vbNewLine & _ "Boş Slot: " & (totalSlots - installedModules) & vbNewLine & _ "Ramlerin bulunduğu slotlar:" & vbcrlf & strMemory,0,"deneme" Next Next Next Next please help me , thanks.
    • JuanFelipe
      By JuanFelipe
       
      Hello friends, I have a query, it happens that I have a matrix nxn, the first column of this contains each cell a number with 21 digits, when I pass this matrix to Excel I obviously write that number as 1,10016E + 20, I solved it by adding a * at the end of each cell, but I want it to be written as a text so that I do not have to remove that *, I searched in Google but could not find an effective solution, thanks in advance. 
    • Puls3
      By Puls3
      Hi, This is my first post on the AutoIt Forums, I most of the time was able to get help from this community by merely searching though google and have been able to solve hundreds of problems this way, though in this case I was incapable of finding a solution to my problem. I am quite confident that it is a user error (And my fault) but I haven't been able to determine what I did wrong, any and all help would be greatly appreciated! I have uploaded my whole script pardon passwords to provide as much information as possible.
      I declared a global array at the top of the script and am having issues when I try to set it's value, and I fail to understand why.
      Error Message:
      "D:\Projects\AutoIt\Arena\Base.au3" (270) : ==> Subscript used on non-accessible variable.:
      $ExpMax[$i] = IniRead($TempSavePath, "Combatant" & $i, "ExpMax", $ExpMax[0])
      $ExpMax^ ERROR
      ConsoleWrite Log:
      Ran.
      Checking launch parameters.
      No launch parameters.
      Initiating load.
      Checking for save file.
      Save file not found.
      Load canceled.
      Loading or creating Combatant 1
      Base.au3
    • RamDemon
      By RamDemon
      Hi,
      Did anyone tried to  use Redis  with AutoIT as store DB ?
       Redis <-- more about it
      Mladen
    • nooneclose
      By nooneclose
      Hey. I'm working on a new project and was wondering if there is a better way to "update" my Column E array. 
      Here is my code: 
      Local $nI  = 0                                                            ;Creates a name index of 0: nI = Name index Local $nII = 1                                                            ;Creates a name index of 1 for second loop: nII = Name Index 2 For    $iN = 0 To $IndexRows Step 1                                       ;Checks the roster for any names that appear twice      For $iN2 = 0 To $IndexRows Step 1          if $d_Names[$nI] == $d_Names[$nII] And $d_Names[$nII] <> "" Then              Local $timeSheetName = _ArraySearch($e_Names, $d_Names[$nI], 0, 0, 0, 0, 1)              ;MsgBox($MB_SYSTEMMODAL, "Found it", $d_Names[$nI] & " In column E on Row " & $timeSheetName)              Local $eI  = $timeSheetName + 1              ;ConsoleWrite($timeSheetName & @CRLF)              ;ConsoleWrite($eI & @CRLF)              ;ConsoleWrite(@CRLF)              _Excel_RangeInsert($OpenWorkbook.ActiveSheet, "E" & $eI & ":F" & $eI, $xlShiftDown)                                                                          ;Inserts a empty cell in columns E and F.              _Excel_RangeWrite($OpenWorkbook, $OpenWorkbook.ActiveSheet, $d_Names[$nII], "E" & $eI)                                                                         ;Fills the empty cell in columns E with the doubled name              $aArray_Index = 2                                           ;Array element counter              For $Index = 2 To $IndexRows Step 1                        ;Loops through every row in the Excel file unto no rows are found or a null row is found                  $Array_Value_E = _Excel_RangeRead($OpenWorkbook, Default, "E"&$Index)                  $e_names[$aArray_Index] = $Array_Value_E                ;While the code loops every value in column E is stored in the E array (updating the array)                  $aArray_Index += 1              Next              ExitLoop          EndIf      Next      $nI  += 1      $nII += 1 Next Basically, It checks a roster for people whose name appears twice then inserts a new "row" for that person because they work in two different departments.
      I have to find that name however in Column E if two appear in column D. My code works but I think it is not as efficient as it could be. 
      Any ideas on how to improve the "update" for my array?
      (once it finds the double names in Column D it then searches for that name by going name by name in the Column E array and once it finds it inserts a new row. However, the E array doesn't have that new row stored in it so I have to "update" the array to properly find the next name)
      Any and all tips would be greatly appreciated. 
       
      NOTE: Just assume I'm opening the excel file properly please do not add that code in, it only complicates your answer. 
×