Jump to content
Sign in to follow this  
matwachich

Need advise on my WSA TCP functions [C]

Recommended Posts

matwachich

Hi everybody!

I wanted to learn winsockets, and for this, I try to reproduce AutoIt's TCP functions.

My code is working pretty good!

I juste want somebody, an AutoIt dev, to look my code and tell me if I'm doing something wrong, or something need to be done differently.

Another problem, is that when I close a socket on one side of a connection, the recv functions in the other side doesn't detect the close action! (like TCPRecv would return an @error)

Thanks in advance!

(I compile it with GCC 4x)

Here is the code

#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif

#define WINVER 0x0501
#define _WIN32_WINNT 0x0501

#include <windows.h>

#include <winsock2.h>
#include <ws2tcpip.h>
#include <iphlpapi.h>

#include <stdio.h>
#include <stdlib.h>

/* -------------------------------------------------------------------------- */

#define SIMPLE_TCP_BUILD_DLL
#include "simpletcp.h"

/* -------------------------------------------------------------------------- */

#define CHECK_INIT if (_global_ == NULL) return;
#define CHECK_INIT_RET(ret) if (_global_ == NULL) return ret;

#define SET_ERR(func) sprintf(_global_->err_func, "%s", func); _global_->err = WSAGetLastError();
#define UNSET_ERR sprintf(_global_->err_func, "%s", ""); _global_->err = 0;

/* -------------------------------------------------------------------------- */

typedef struct {
    WSADATA wsaData;
    char err_func[20];
    int err;
} simple_tcp_t;

simple_tcp_t* _global_ = NULL;

/* -------------------------------------------------------------------------- */
/* Standard functions */

/** \brief
 *
 * \return
 */
int     SIMPLE_TCP  TCPStartup ()
{
    if (_global_ != NULL) { return 1; }

    _global_ = malloc(sizeof(simple_tcp_t));
    if (_global_ == NULL) { return 0; }

    if (WSAStartup(MAKEWORD(2, 2), &_global_->wsaData) != 0) {
        free(_global_);
        _global_ = NULL;
        return 0;
    }

    UNSET_ERR

    return 1;
}


/** \brief
 *
 * \return
 */
void    SIMPLE_TCP  TCPShutdown ()
{
    if (_global_ == NULL) { return; }

    WSACleanup();
    free(_global_);
    _global_ = NULL;
}


/** \brief
 *
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPGetError (char* err_func, const size_t err_func_len)
{
    CHECK_INIT_RET(0)
    int err = _global_->err;
    if (err_func != NULL && err_func_len > 0) {
        snprintf(err_func, err_func_len, "%s", _global_->err_func);
    }
    UNSET_ERR
    return err;
}


/** \brief
 *
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPConnect (const char* host, const char* port)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    struct addrinfo hints, *result = NULL;
    ZeroMemory(&hints, sizeof(hints));

    hints.ai_family = AF_INET; // IP v4
    hints.ai_socktype = SOCK_STREAM; // Stream socket
    hints.ai_protocol = IPPROTO_TCP; // TCP

    if (getaddrinfo(host, port, &hints, &result) != 0) {
        SET_ERR("getaddrinfo")
        return 0;
    }

    SOCKET ConnectSocket = INVALID_SOCKET;
    ConnectSocket = socket(result->ai_family, result->ai_socktype, result->ai_protocol);
    if (ConnectSocket == INVALID_SOCKET) {
        freeaddrinfo(result);
        SET_ERR("socket")
        return 0;
    }

    if (connect(ConnectSocket, result->ai_addr, (int)result->ai_addrlen) != 0) {
        freeaddrinfo(result);
        SET_ERR("connect")
        return 0;
    }
    freeaddrinfo(result);

    unsigned long mode = 1;
    if (ioctlsocket(ConnectSocket, FIONBIO, &mode) != 0) {
        SET_ERR("ioctlsocket")
        return 0;
    }

    return ConnectSocket;
}


/** \brief
 *
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPListen (const char* port)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    struct addrinfo hints, *result = NULL;
    ZeroMemory(&hints, sizeof(hints));

    hints.ai_family = AF_INET; // IP v4
    hints.ai_socktype = SOCK_STREAM; // Stream socket
    hints.ai_protocol = IPPROTO_TCP; // TCP
    hints.ai_flags = AI_PASSIVE; // this + node = NULL => local host IP

    if (getaddrinfo(NULL, port, &hints, &result) != 0) {
        SET_ERR("getaddrinfo")
        return 0;
    }

    SOCKET ListenSocket = INVALID_SOCKET;
    ListenSocket = socket(result->ai_family, result->ai_socktype, result->ai_protocol);
    if (ListenSocket == INVALID_SOCKET) {
        freeaddrinfo(result);
        SET_ERR("socket")
        return 0;
    }

    unsigned long mode = 1;
    if (ioctlsocket(ListenSocket, FIONBIO, &mode) != 0) {
        freeaddrinfo(result);
        SET_ERR("ioctlsocket")
        return 0;
    }

    if (bind(ListenSocket, result->ai_addr, (int)result->ai_addrlen) != 0) {
        freeaddrinfo(result);
        SET_ERR("bind")
        return 0;
    }
    freeaddrinfo(result);

    if (listen(ListenSocket, SOMAXCONN) != 0) {
        SET_ERR("listen")
        return 0;
    }

    return ListenSocket;
}


/** \brief
 *
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPAccept (int socket)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    int err;
    SOCKET ClientSocket = INVALID_SOCKET;

    ClientSocket = accept(socket, NULL, NULL);
    err = WSAGetLastError();

    if (ClientSocket == INVALID_SOCKET && err != WSAEWOULDBLOCK) {
        SET_ERR("accept")
        return INVALID_SOCKET;
    }

    if (ClientSocket != INVALID_SOCKET) {
        unsigned long mode = 1;
        if (ioctlsocket(ClientSocket, FIONBIO, &mode) != 0) {
            SET_ERR("ioctlsocket")
            return INVALID_SOCKET;
        }
    }

    return ClientSocket;
}


/** \brief
 *
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPCloseSocket (int socket)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    if (shutdown(socket, SD_BOTH) != 0) {
        SET_ERR("shutdown")
        return 0;
    }

    if (closesocket(socket) != 0) {
        SET_ERR("closesocket")
        return 0;
    }

    return 1;
}


/** \brief
 *
 * \param
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPSend (int socket, const char* data, const size_t data_len)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    int ret = send(socket, data, data_len, 0);
    if ((ret == SOCKET_ERROR || ret == 0) && WSAGetLastError() != WSAEWOULDBLOCK) {
        SET_ERR("send")
        return 0;
    }

    return ret;
}


/** \brief
 *
 * \param
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPRecv (int socket, char* data, const size_t data_len)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    int ret = recv(socket, data, data_len, 0);
    if ((ret == 0 || ret == SOCKET_ERROR) && WSAGetLastError() != WSAEWOULDBLOCK) {
        SET_ERR("recv")
        return 0;
    }

    return ret;
}


/** \brief
 *
 * \param
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPNameToIP (const char* name, char* ip, const size_t ip_len)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    struct addrinfo hints, *result = NULL;
    ZeroMemory(&hints, sizeof(hints));

    hints.ai_family = AF_INET; // IP v4
    hints.ai_socktype = SOCK_STREAM; // Stream socket
    hints.ai_protocol = IPPROTO_TCP; // TCP

    if (getaddrinfo(name, NULL, &hints, &result) != 0) {
        SET_ERR("getaddrinfo")
        return 0;
    }

    if (result->ai_family != AF_INET || result->ai_addrlen != sizeof(struct sockaddr_in)) {
        SET_ERR("bad address family")
        freeaddrinfo(result);
        return 0;
    }

    struct sockaddr_in* addr = (struct sockaddr_in*)result->ai_addr;
    char* ret = inet_ntoa(addr->sin_addr);

    snprintf(ip, ip_len, "%s", ret);
    freeaddrinfo(result);

    return 1;
}


/** \brief
 *
 * \param
 * \param
 * \param
 *
 * \return
 */
int     SIMPLE_TCP  TCPSocketToIP (int socket, char* ip, const size_t ip_len)
{
    CHECK_INIT_RET(0)
    UNSET_ERR

    struct sockaddr_in addr_in;
    int len = sizeof(addr_in);

    if (getpeername(socket, (struct sockaddr*)&addr_in, &len) != 0) {
        SET_ERR("getpeername")
        return 0;
    }

    char* ret = inet_ntoa(addr_in.sin_addr);
    if (ret == NULL) {
        SET_ERR("inet_ntoa")
        return 0;
    }

    snprintf(ip, ip_len, "%s", ret);

    return 1;
}

and the header

#ifndef __SIMPLE_TCP_H__
#define __SIMPLE_TCP_H__

#ifdef SIMPLE_TCP_BUILD_DLL
#define SIMPLE_TCP __stdcall __declspec(dllexport)
#else
#define SIMPLE_TCP __stdcall __declspec(dllimport)
#endif

/* -------------------------------------------------------------------------- */
/* Standard functions */

int     SIMPLE_TCP  TCPStartup ();
void    SIMPLE_TCP  TCPShutdown ();

int     SIMPLE_TCP  TCPGetError (char* err_func, const size_t err_func_len);

int     SIMPLE_TCP  TCPConnect (const char* ip, const char* port);
int     SIMPLE_TCP  TCPListen (const char* port);
int     SIMPLE_TCP  TCPAccept (int socket);
int     SIMPLE_TCP  TCPCloseSocket (int socket);

int     SIMPLE_TCP  TCPSend (int socket, const char* data, const size_t data_len);
int     SIMPLE_TCP  TCPRecv (int socket, char* data, const size_t data_len);

int     SIMPLE_TCP  TCPNameToIP (const char* name, char* ip, const size_t ip_len);
int     SIMPLE_TCP  TCPSocketToIP (int socket, char* ip, const size_t ip_len);

#endif // __SIMPLE_TCP_H__

Share this post


Link to post
Share on other sites
funkey

As far as I see you are just missing some timeouts.

I wrapped some C functions in AutoIt to extend the TCP functions of AutoIt.

#include "socket_UDF.au3"

_WSAStartup()

Global $iSock = _socket($AF_INET, $SOCK_STREAM, $IPPROTO_TCP)
ConsoleWrite("Socket: " & $iSock & @CRLF)

Global $tTimeVal = DllStructCreate("DWORD timeout")
DllStructSetData($tTimeVal, "timeout", 200) ; Timeout 200ms

$iSockError = _setsockopt($iSock, $SOL_SOCKET, $SO_RCVTIMEO, $tTimeVal) ; set Timeout for recv
If $iSockError Then
    ConsoleWrite("SetSockOpt error setting recv timeout!. Windows Sockets Error Codes: " & _WSAGetLastError() & @CRLF)
    _closesocket($iSock)
    TCPShutdown() ;WSACleanup
EndIf

Global $iBind = _bind($iSock, @IPAddress1, 20000) ;local IP-Address and port to use
ConsoleWrite("Bind error: " & $iBind & @CRLF) ; 0 is OK

Global $iConnect = _connect($iSock, "10.1.6.51", 80)
ConsoleWrite("Connect error: " & $iConnect & @CRLF) ; 0 is OK

If $iConnect Then
    ConsoleWrite("Windows Sockets Error Codes: " & _WSAGetLastError() & @CRLF)
    _closesocket($iSock)
    TCPShutdown() ;WSACleanup
EndIf

Global $sToSend = "GET /input1?PW=?"
Global $tSendBuffer = DllStructCreate("char[" & StringLen($sToSend) & "]")
DllStructSetData($tSendBuffer, 1, $sToSend)

Global $iSend = _send($iSock, $tSendBuffer)
ConsoleWrite("Bytes sent: " & $iSend & @CRLF)

Global $tRecvBuffer = DllStructCreate("char[64]")
Global $iRecv = _recv($iSock, $tRecvBuffer)
ConsoleWrite("Bytes received: " & $iRecv & @CRLF)

ConsoleWrite("Data received: " & DllStructGetData($tRecvBuffer, 1) & @CRLF) ;input1;OFF

_closesocket($iSock)
_WSACleanup()
 

socket_UDF.au3


Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the Universe
trying to produce bigger and better idiots.
So far, the Universe is winning.

Share this post


Link to post
Share on other sites
matwachich

Thanks for the answer!

Adding a timeout will not solve the problem, since my sockets are asynchronous.

I think it hase something to do with to SO_KEEPALIVE options, but I don't very well understand how it works or how to use it.

Edited by matwachich

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

  • Similar Content

    • gahhon
      By gahhon
      Hi,
      I have a program that is read data from the .txt file, since the .txt file is only readable, viewable and editable for the admin user.
      But how could I lock it with password, or some other technique that can helps to achieve this?
      Thanks for the advanced information.
    • gahhon
      By gahhon
      Hi,
      How can I the trigger the another button functions without waiting the previous function to finish execute?
      Any advise?
      I couldn't find any relevant topics via google.
      Thanks a lot.
    • SharpDressedMan
      By SharpDressedMan
      Hi all,
      I need to use ControlMove() on some controls of a hidden GUI window.
      This works properly on a GUI window created with default style, but does not work on a GUI window created with style $WS_OVERLAPPEDWINDOW
      func GUItest($bOverlapped) $m = GUICreate("test", 200, 100, -1, -1, $bOverlapped ? $WS_OVERLAPPEDWINDOW : -1) $g = GUICtrlCreateButton("test", 0, 0) ControlMove($m, "", $g, 30, 30) GUISetState() endfunc GuiTest(false) ; button 'test' properly moved to (30,30) GuiTest(true) ; button 'test' not moved and still sitting at (0,0) Any reason for this unexpected behavior ?
      Any workaround to fix this ?
      Thanks for any help
    • 2Toes
      By 2Toes
      Hi all..
      I'm having slight issue that has be a bit puzzled.
      I have an Input control.. After a certain function runs, it Disables that Input control, and sets it to ReadOnly.
      When running another certain function, it re-Enables that Input control, and sets the style back to Default.
      Which does work, however, when typing into the Input control after re-Enabling it, the text appears as a light gray color, rather than its original black color.
      I'm sure there's a simple solution here.. But what that is, appears to be beyond me.
      Here is a simplified example code:
      #include <ButtonConstants.au3> #include <EditConstants.au3> #include <GUIConstantsEx.au3> #include <WindowsConstants.au3> #Region ### START Koda GUI section ### Form= Global $Form1 = GUICreate("Form1", 245, 215, 192, 124) Global $disableBTN = GUICtrlCreateButton("Disable", 32, 64, 75, 25) Global $enableBTN = GUICtrlCreateButton("Enable", 128, 64, 75, 25) Global $Input1 = GUICtrlCreateInput("", 32, 120, 169, 21) GUISetState(@SW_SHOW) #EndRegion ### END Koda GUI section ### While 1 $nMsg = GUIGetMsg() Switch $nMsg Case $GUI_EVENT_CLOSE Exit Case $disableBTN disable() Case $enableBTN enable() EndSwitch WEnd Func disable() GUICtrlSetState($Input1, $GUI_DISABLE) GUICtrlSetStyle($Input1, $ES_READONLY) EndFunc Func enable() GUICtrlSetState($Input1, $GUI_ENABLE) GUICtrlSetStyle($Input1, $GUI_SS_DEFAULT_INPUT) EndFunc  
      Any help would be greatly appreciated
      Thank you in advance!
    • jantograaf
      By jantograaf
      Hi all,
      I'm trying to create a script that runs a JSON-query and then can retrieve some variables out of the returned, decoded object using JSON.au3. I have tried some other examples on this forum, but I'm stuck at one point. My query works perfectly and gets loaded into the variable $data. Then, decoding $data to $object seems to work as well. But then I can't get the date-field out of this JSON-structure with my script.
      The JSON-structure returned looks like this:
      { "content": [ { "id": "451ec583-8f27-4926-82a3-a2d85e57a110", "createdDate": "2018-08-08T08:40:57.449004Z", "updatedDate": "2018-08-08T08:40:57.449004Z", "lastOpenedDate": "2018-08-08T08:40:57.449004Z", "date": "2018-04-26T00:00:00", "description": "X-Ray Exam", "patient": { "id": "f857238a-c75d-4760-b8d1-8f50f8f9bbfa", "createdDate": "2018-08-08T08:40:37.623976Z", "updatedDate": "2018-08-08T08:40:37.623976Z", "lastOpenedDate": "2018-08-08T08:40:37.623976Z", "name": "Fuerstonia", "birthDate": "2014-06-08", "breed": "", "chip": "", "color": "", "damsire": "", "sire": "", "neutered": false, "orthancUuid": "", "sex": "U", "species": "Paard", "ueln": "De 431310762114", "pmsReference": "", "origin": "" }, "type": "study", "accessionNumber": "KME201806960467", "instanceUid": null, "orthancUuid": "", "sent": false, "seriesCount": 0, "modalityType": "RX", "typeAndModality": "study RX", "client": { "id": "be627195-8458-4927-8446-f1ef37b917a4", "createdDate": "2018-08-08T08:40:31.433968Z", "updatedDate": "2018-08-08T08:40:31.433968Z", "lastOpenedDate": "2018-08-08T09:26:49.512298Z", "via": "", "extraInfo": "", "pmsReference": "", "contact": { "id": "406cc555-c491-4c29-b6bb-8d903f0e35a9", "createdDate": "2018-08-08T08:40:31.428968Z", "updatedDate": "2018-08-08T08:40:31.428968Z", "lastName": "Client 1", "firstName": "", "company": "", "email": "", "language": "nl", "phone": "", "address": { "id": "6fc7703c-137a-4e0a-ba96-8c7f38f2044b", "city": "", "country": "", "line": "", "postalCode": "" } } } }, My script looks like this:
      #RequireAdmin #include <json.au3> #include <inet.au3> #include <File.au3> ;Create a handle to a logfile (will be created if it doesnt exist) Global $logfile = FileOpen("C:\VSOL\VSTK\Logs\MigrationFix\MigrationFix.log",9) FileWriteLine($logfile,"Start script") ;Create the URL with the JSON-query $URL = "http://localhost:8080/v0/studies/?seriesCount=1" ;Catch the query output into a variable $data = _INetGetSource($URL) ;Check if there is any data at all in this variable, if not, exit If Not $data Then MsgBox(1,"Error","No answer. Server is probably not running.") Exit EndIf ;For debugging purposes FileWriteLine($logfile,$data) ;Decode the JSON_string into a useable object $object = Json_Decode($data,1000) If @error Then FileWriteLine($logfile,"Error decoding JSON") Exit EndIf Local $i = 0 ;Start a loop to retrieve the study date of each study... While 1 $study_date = json_get($object,'[' & $i & '].date') If @error Then FileWriteLine($logfile,"Study-Date retrieval error") ExitLoop EndIf $i = $i + 1 WEnd ;Close the logfile FileWriteLine($logfile,"Stop script") FileClose($logfile) ;Open the logfile for quick reference ShellExecute("C:\VSOL\VSTK\Logs\MigrationFix\MigrationFix.log") If believe it has something to do with my json_get($object...)-command. Anyone who can point me in the right direction?
      Thanks in advance!
      Kind regards
×