_RegExistKey function error

[copyleft]

Trying to create a script to toggle my desktop text size. 7But I'm getting an error on the first "If Not" declaration.

#RequireAdmin
#include <MsgBoxConstants.au3>

If Not _RegExistKey('HKCU\Control Panel\Desktop', 'LogPixels') Then
MsgBox($MB_SYSTEMMODAL, "DPI", "Click to increase text size")
    RegWrite('HKCU\Control Panel\Desktop', 'LogPixels','REG_DWORD',Number('113'))
Else
    MsgBox($MB_SYSTEMMODAL, "DPI", "Click to restore default text size")
    RegDelete('HKCU\Control Panel\Desktop', 'LogPixels')

EndIf

Func _RegExists($sKeyname, $sValueName = "")
    Local $iRet
    RegRead($sKeyName, $sValueName)
    Return ( $svalueName = "" ? @error <= 0 : @error = 0 )
EndFunc

[Nine]

The name of the function do not correspond to the function you are calling....

[Subz]

Also a blank value doesn't necessarily mean its an error, you would  just use the @error to determine if it exists or not, example:

Func _RegValueExists($_sRegPath, $_sRegKey)
    RegRead($_sRegPath, $_sRegKey)
    Return @error ? @error : 0
EndFunc

 

[Nine]

@Subz  Agree. But there is no need to use ternary.  Return @error is just fine, no ?

Edited August 2, 2021 by Nine

[Subz]

@nine - true, having a brain fade 

[copyleft]

OK. I guess I'm on my way to getting flamed here. But fixed spelling of fuction. Still get error.

#RequireAdmin
#include <MsgBoxConstants.au3>

If Not _RegValueExist ('HKCU\Control Panel\Desktop', 'LogPixels') Then
MsgBox($MB_SYSTEMMODAL, "DPI", "Click to increase text size")
    RegWrite('HKCU\Control Panel\Desktop', 'LogPixels','REG_DWORD',Number('113'))
Else
    MsgBox($MB_SYSTEMMODAL, "DPI", "Click to restore default text size")
    RegDelete('HKCU\Control Panel\Desktop', 'LogPixels')

EndIf

Func _RegValueExists($_sRegPath, $_sRegKey)
    RegRead($_sRegPath, $_sRegKey)
    Return @error ? @error : 0
EndFunc

; end
Exit

 

[Nine]

@copyleft  Have you got your eyes examined recently ?  

You sure spelling is right ???

Edited August 2, 2021 by Nine

[copyleft]

Wow. Too much coffee. Thanks. Solution found!👍

[Nine]

3 hours ago, copyleft said:

Too much coffee.

Or not enough 

[JockoDundee]

12 hours ago, copyleft said:

Solution found!

Still you need to change  the ternary statement from:

Return @error ? @error : 0

to just

Return @error

as pointed out by @Nine.

Not because it doesn’t work, but because it does work.  

And therefore you might use it all the time, out of habit.

Next thing you know, you become a highly regarded AutoIt influencer.

Pretty soon everybody’s using the subz error return method just to mess with the noobs.

On second thought, just leave it