Active Directory UDF

[water]

So this means it only takes 1.5 seconds. How do you think it takes 30 seconds?

[jazzyjeff]

We have 3 DNS servers, 250+ security groups, and about 11,000 user accounts.

All DC's are Windows 2008.

[water]

I think 1.5 seconds isn't too bad.

Did you test with a group that usually takes 30 seconds?

[jazzyjeff]

:-) I think it takes that long, because when I count the time difference between the GUI label changing that tell me it's on one section to get to the next section, it's about 30 seconds.

Are you thinking the code is executing, but something else in the script is delaying the process?

It seems from this test though, that I probably have some things I need to fix in the login script. Maybe the scrolling marquee progress bar is causing a delay...

[jazzyjeff]

I did use a security group that is causing the issue. 1.5 seconds is excellent! :-) I'll be pleased if I can get that working.

[water]

Yes, I think checking the group membership is quite fast. So there might be another problem.

[jazzyjeff]

Thanks Water. I'll look elsewhere to find the problem.

[water]

At least we have found a bug in the AD UDF.

Thanks for that!

[denisaurus]

The new 1.4 function _AD_AddUserToGroup is not working properly with AutoIt 3.3.10.2, it reports that user is added successfully but nothing's changed in Active Directory. I've tested this without proper credentials to see if it will return correct value, it should not return 1. Please, can you fix this?

[water]

Welcome to Autoit and the forum!

Did it work with an older version of the AD UDF and/or and older version of AutoIt? If yes, which one?

[denisaurus]

It worked with 3.3.8.1 and AD.AU3 1.2.2... I didn't test any other functions that are supposed to change attributes yet but reading (even attribute arrays) seems ok.

The function is working, I can with proper credentials add user to groups but it returns 1 even if it fails to add user to a group due to insufficient permissions.

[water]

I just compared version 1.2.2.0 and 1.4.0.0 of the UDF. I don't see a bug.

Did you use the _AD_AddUserToGroup.au3 example script or something you coded yourself?

[water]

I think I found the problem.

It's an unhandled error condition.

Please change the function as follows:

Func _AD_AddUserToGroup($sGroup, $sUser)

    If Not _AD_ObjectExists($sGroup) Then Return SetError(1, 0, 0)
    If Not _AD_ObjectExists($sUser) Then Return SetError(2, 0, 0)
    If _AD_IsMemberOf($sGroup, $sUser) Then Return SetError(3, 0, 0)
    If StringMid($sGroup, 3, 1) <> "=" Then $sGroup = _AD_SamAccountNameToFQDN($sGroup) ; sAMACccountName provided
    If StringMid($sUser, 3, 1) <> "=" Then $sUser = _AD_SamAccountNameToFQDN($sUser) ; sAMACccountName provided
    Local $oUser = __AD_ObjGet("LDAP://" & $sAD_HostServer & "/" & $sUser) ; Retrieve the COM Object for the user
    Local $oGroup = __AD_ObjGet("LDAP://" & $sAD_HostServer & "/" & $sGroup) ; Retrieve the COM Object for the group
    $oGroup.Add($oUser.AdsPath)
    If @error <> 0 Then Return SetError(@error, 0, 0) ; <==== ADD THIS LINE!
    $oGroup.SetInfo
    If @error <> 0 Then Return SetError(@error, 0, 0)
    Return 1

EndFunc   ;==>_AD_AddUserToGroup

[denisaurus]

Great! Now It's working as it should... Really fast response! 

[water]

[denisaurus]

Sorry to bug you but there is a similar problem with _AD_RemoveUserFromGroup function. I know how to fix this thanks to your advice but I think that you just might want to know that.

[water]

Thanks a lot for this information!

Looks like the modifications done in 3.3.10.x to the COM error handler now show a lot of bugs in the AD UDF

I think I'll need to release a 1.4.1.0 version quite soon

Edited February 17, 2014 by water

[water]

Version 1.4.1.0 (Bug fix) of the UDF has been released.

Only runs with AutoIt 3.3.10.2 and later.

Please test before using in production!

For download please see my signature.

[zolive]

Hello,
I just downloaded your include for autoit which have awesome.
But I have the read me file it asks me to AD.AU3 in the% ProgramFiles% AutoIt3 Include c it is good but I can not find the files and au3.user.calltips.api au3.userudfs.properties .
For help in autoit.
You can put in download or tell me how to find them. thank you
Excuse my english I'm french

[water]

Bon jour et Welcome to Autoit and the forum!

My bad, I didn't include the latest Readme.txt with the 1.4.1.0 version of the UDF.

There is no need to add the UDF to %ProgramFiles%... any more.

The Readme.txt now describes what has to be done:

How to "install" the Active Directory UDF            2014-02-08
--------------------------------------------------------------------------

This step is mandatory
* Copy AD.au3 into the %ProgramFiles%AutoIt3Include, the AutoIt User Includes directory or the directory
  where your script is located

For SciTE integration (user calltips and syntax highlighting)
* Run the User CallTip Manager from SciTE Config tool, tab Other Tools.
  For details please check: http://www.autoitscript.com/wiki/Adding_UDFs_to_AutoIt_and_SciTE

Help files and examples
* Copy the *.htm and the remaining *.au3 files to any directory you like.
  You can't call the help and example scripts from the AutoIt help at the moment