Enhance _Singleton - Trac Ticket #2108

[water]

I just noticed that Trac ticket #2108 was closed as "No bug".

I understand that the code as it is now might already be broken because it does more than originally intended.

On the other hand the change smartee proposed solved my problem (described ). I implemented and tested smartees code and it now allows to sequentially run compiled scripts an application I can't control starts in a bunch.

I think every code change that enhances the functionality of AutoIt should be welcome. In particular when its jut 2 lines of code and the risk of side effects is minimal.

I vote for implementing smartees change.

Just my 2 cents.

[Valik]

Does more than originally intended? Yeah, it completely breaks the pattern it was designed to implement.

If that function gets touched it will be to remove the stupid behavior it should never have had. It will not receive additions to further take the function away from the singleton pattern. If you wish to implement other logic that relies on synchronization objects to limit simultaneous processes you are no longer meeting the singleton pattern and thus _Singleton() is not the right tool for the job.

I don't know why this is so hard to understand.

[ProgAndy]

If you have a resource that is required by multiple jobs, you should use the API directly and maybe consider semaphores for synchronization:

http://msdn.microsoft.com/en-us/library/windows/desktop/ms682438%28v=vs.85%29.aspx

_Singelton is designed to ensure only one instance is running and is not meant for waiting.

Edited January 31, 2012 by ProgAndy

[water]

I don't need the resource in my scripts. It's just used by _Singleton to do what it was designed for. I inserted the two lines to release the handle if the resource is already in use and now this modified version of _Singleton exactly does what I need.

I don't care if this breaks the intended design - I had a problem and this modification solved the problem.

I just thought this "enhancement" could be useful for others too.

[Valik]

Whether it is useful or not is irrelevant. It's inappropriate for it to be in that function.

[water]

That's fine for me - you are the boss.

[Richard Robertson]

You know you can always include your own files with your own versions of functions.

[water]

That's exactly what I do now.