If Object Exists in OU

[ReitzelTechnology]

Don't get what you mean.

Can you post a screenshot?

this is what it gives. nothing else and it writes to the log it moved the computer (which it should not)

[water]

Ok, that's easy. Each property is returned ina separate row. I assumed each had it's own column. The properties are returned in alphabetical order. So the code should now look like:

If _AD_ObjectExists(@ComputerName & "$") Then
     $aResult = _AD_GetObjectProperties(@ComputerName & "$", "distinguishedname,cn")
     If @error then Exit MsgBox(... handle the error here ...)
     $sOU = StringMid($aResult[2][1], StringLen($aResult[1][1])+4)
     If $sOU = ... ; for the OUs being equal
EndIf

But that's something you could have found yourself.

Edited February 4, 2012 by water

[BrewManNH]

How do you manage getting 2 machine accounts with the same name in AD?

[water]

The sAMAccountName attribute of any object is unique in a domain.

[BrewManNH]

The sAMAccountName attribute of any object is unique in a domain.

That's my point, how do you manage to get 2 computers with the same computer name in the same domain? I've never been able to do it, so I'm wondering how he can be moving a computer to an OU that contains that computer name already, unless he's going across domains. It doesn't appear that he's changing the name of the computer unless I missed something.

[ReitzelTechnology]

Ok, that's easy. Each property is returned ina separate row. I assumed each had it's own column. The properties are returned in alphabetical order. So the code should now look like:

If _AD_ObjectExists(@ComputerName & "$") Then
     $aResult = _AD_GetObjectProperties(@ComputerName & "$", "distinguishedname,cn")
     If @error then Exit MsgBox(... handle the error here ...)
     $sOU = StringMid($aResult[2][1], StringLen($aResult[1][1])+4)
     If $sOU = ... ; for the OUs being equal
EndIf

But that's something you could have found yourself.

This is what we have right now and it is not doing anything.

Func _WorkstationMove()
 Global $iResult, $sAD_OU = "OU=Workstations,OU=Reitzel_Technology,DC=ReitzelTechnology,DC=int"
 ; Open Connection to the Active Directory
 _AD_Open($sAD_UserIdParam, $sAD_PasswordParam)
 If _AD_ObjectExists(@ComputerName & "$") Then
  $aResult = _AD_GetObjectProperties(@ComputerName & "$", "distinguishedname, cn")
  If @error then Exit MsgBox(0, "Error", "error" & @error & ", @extended = " & @extended)
  $sOU = StringMid($aResult[2][1], StringLen($aResult[1][1])+4)
  If $sOU = $sAD_OU Then
   _FileWriteLog($sLogPath, "Computer Exists in target OU", -1)
   Exit
  EndIf
  If Not $sOU = $sAD_OU Then
   AD_MoveObject($sAD_OU, @ComputerName & "$")
   _FileWriteLog($sLogPath, "Computer moved to:" & $sAD_OU, -1)
  EndIf
 EndIf
 _AD_Close()
EndFunc   ;==>_WorkstationMove

[water]

Why do you use a second comparison? A simple If/Then/Else should be all you need:

Func _WorkstationMove()
Global $iResult, $sAD_OU = "OU=Workstations,OU=Reitzel_Technology,DC=ReitzelTechnology,DC=int"
; Open Connection to the Active Directory
_AD_Open($sAD_UserIdParam, $sAD_PasswordParam)
If _AD_ObjectExists(@ComputerName & "$") Then
  $aResult = _AD_GetObjectProperties(@ComputerName & "$", "distinguishedname, cn")
  If @error then Exit MsgBox(0, "Error", "error" & @error & ", @extended = " & @extended)
  $sOU = StringMid($aResult[2][1], StringLen($aResult[1][1])+4)
  If $sOU = $sAD_OU Then
   _FileWriteLog($sLogPath, "Computer Exists in target OU", -1)
   Exit
  Else
   AD_MoveObject($sAD_OU, @ComputerName & "$")
   _FileWriteLog($sLogPath, "Computer moved to:" & $sAD_OU, -1)
  EndIf
EndIf
_AD_Close()
EndFunc   ;==>_WorkstationMove

Edited February 5, 2012 by water

[water]

That's my point, how do you manage to get 2 computers with the same computer name in the same domain? I've never been able to do it, so I'm wondering how he can be moving a computer to an OU that contains that computer name already, unless he's going across domains. It doesn't appear that he's changing the name of the computer unless I missed something.

You can't.

The OP wants to make sure that the computer account is in the right OU. So he checks the target OU for this computer. If it doesn't exist in this OU the computer is moved from whatever OU the computer is in to the target OU.

[ReitzelTechnology]

Why do you use a second comparison? A simple If/Then/Else should be all you need:

Func _WorkstationMove()
Global $iResult, $sAD_OU = "OU=Workstations,OU=Reitzel_Technology,DC=ReitzelTechnology,DC=int"
; Open Connection to the Active Directory
_AD_Open($sAD_UserIdParam, $sAD_PasswordParam)
If _AD_ObjectExists(@ComputerName & "$") Then
  $aResult = _AD_GetObjectProperties(@ComputerName & "$", "distinguishedname, cn")
  If @error then Exit MsgBox(0, "Error", "error" & @error & ", @extended = " & @extended)
  $sOU = StringMid($aResult[2][1], StringLen($aResult[1][1])+4)
  If $sOU = $sAD_OU Then
   _FileWriteLog($sLogPath, "Computer Exists in target OU", -1)
   Exit
  Else
   AD_MoveObject($sAD_OU, @ComputerName & "$")
   _FileWriteLog($sLogPath, "Computer moved to:" & $sAD_OU, -1)
  EndIf
EndIf
_AD_Close()
EndFunc   ;==>_WorkstationMove

because it was a test to see if the OU of the computer was being returned to see if it is in the target ou. somewhere it isn't returning the OU to the = sign and it would automaically do the "else" command.

[water]

Ok, this code should work (at elast it works here):

#include <ad.au3>
_WorkstationMove()
Exit

Func _WorkstationMove()
    Global $iResult, $sAD_OU = "OU=Workstations,OU=Reitzel_Technology,DC=ReitzelTechnology,DC=int"
    ; Open Connection to the Active Directory
    _AD_Open()
    $sComputer = @ComputerName
    If _AD_ObjectExists($sComputer & "$") Then
        $aResult = _AD_GetobjectsInOU($sAD_OU, "(name=" & $sComputer & ")", 1)
        If @error = 0 Then
            MsgBox(0, "Info", "Computer: " & $sComputer & " is already defined in OU: " & $sAD_OU)
        ElseIf @error = 3 Then
            MsgBox(0, "Info", "Computer: " & $sComputer & " is not defined in OU: " & $sAD_OU & " and has to be moved!")
        Else
            MsgBox(0, "Error", "An error occurred when calling function _AD_GetobjectsInOU: @error = " & @error & ", @extended = " & @extended)
        EndIf
    EndIf
    _AD_Close()
EndFunc   ;==>_WorkstationMove

Edited February 6, 2012 by water

[ReitzelTechnology]

Ok, this code should work (at elast it works here):

#include <ad.au3>
_WorkstationMove()
Exit

Func _WorkstationMove()
    Global $iResult, $sAD_OU = "OU=Workstations,OU=Reitzel_Technology,DC=ReitzelTechnology,DC=int"
    ; Open Connection to the Active Directory
    _AD_Open()
    $sComputer = @ComputerName
    If _AD_ObjectExists($sComputer & "$") Then
        $aResult = _AD_GetobjectsInOU($sAD_OU, "(name=" & $sComputer & ")", 1)
        If @error = 0 Then
            MsgBox(0, "Info", "Computer: " & $sComputer & " is already defined in OU: " & $sAD_OU)
        ElseIf @error = 3 Then
            MsgBox(0, "Info", "Computer: " & $sComputer & " is not defined in OU: " & $sAD_OU & " and has to be moved!")
        Else
            MsgBox(0, "Error", "An error occurred when calling function _AD_GetobjectsInOU: @error = " & @error & ", @extended = " & @extended)
        EndIf
    EndIf
    _AD_Close()
EndFunc   ;==>_WorkstationMove

Houston, we have lift off.

That version works!!! I modified it to write to the log after verifiying it with your dialogs. Moves and everything.

[water]

hard piece of work but I'm glad we got the problem solved