script opens the excel file again and again

[aviv9]

Hello my friends,

I wrote a simple script that writes a column in excel to a web page. But the script opens the excel again and again for no reason

This is my script:

Local $oExcel = _ExcelBookOpen(//here I put the excel path)

Global $aArray = _ExcelReadSheetToArray($oExcel)

MouseClick("left",$start_pos_web_x,$start_pos_web_y,1,0)

For $i = 1 To 5

Send($aArray[$i][1])

Send("{TAB}")

Send("{TAB}")

Next

I want to paste the array items in the web page (first I go to the first form-which is done with the mouseClick function, and then I skip the forms with 2 tabs).

I don't understand why it opens the excel each time (its not even in a loop).

[water]

Is this the whole script?

[aviv9]

this is most of the script.

This is the full one:

#include <Array.au3>

#include <Excel.au3>

HotKeySet("t","doWork")

HotKeySet("{ESC}", "Terminate")

While 1

Sleep(100)

WEnd

Func doWork()

Const $sFilePath1 = "//my excel file"

Global $oExcel = _ExcelBookOpen($sFilePath1)

Const $start_pos_web_x=890,$start_pos_web_y=287

If @error = 1 Then

MsgBox(0, "Error!", "Unable to Create the Excel Object")

Exit

ElseIf @error = 2 Then

MsgBox(0, "Error!", "File does not exist - Shame on you!")

Exit

EndIf

Global $aArray = _ExcelReadSheetToArray($oExcel)

MouseClick("left",$start_pos_web_x,$start_pos_web_y,1,0)

For $i = 1 To 5

Send($aArray[$i][1])

Send("{TAB}")

Send("{TAB}")

Next

EndFunc

Func Terminate()

Exit

EndFunc

[FireFox]

Hi,

The HotKeySet function calls your function until you release the key.

Add this in your function to avoid the overlapping :

Func doWork()
   Local Static $blFuncFinished = True
   If Not $blFuncFinished Then Return ;void
   $blFuncFinished = False

   ;doWork here

    $blFuncFinished = True
EndFunc

Br, FireFox.

[aviv9]

Thanks a lot that solved the problem.

Edited March 16, 2013 by aviv9

[FireFox]

Oh and please use the autoit tags to post your code

Edited March 16, 2013 by FireFox

[water]

A few suggestions on how to improve your script:

• Always check for errors immediately after a function call e.g. after _ExcelBookOpen
• Don't use screen coordinates to click on buttons or enter data. They depend ons creen resolution and position of the window you try to automate
• Use the IE UDF to enter data into web form fields (if you use the Internet Explorer)