kylomas Posted February 17, 2014 Share Posted February 17, 2014 (edited) Yes it is...Error = 1 means that you are not passing an array to _ExcelReadSheetToArray. Check what the value of $xlsServices is. edit: The code is setup to read the spreadsheet from whatever directory the script is run out of. Edited February 17, 2014 by kylomas Forum Rules Procedure for posting code "I like pigs. Dogs look up to us. Cats look down on us. Pigs treat us as equals." - Sir Winston Churchill Link to comment Share on other sites More sharing options...
kylomas Posted February 17, 2014 Share Posted February 17, 2014 (edited) Added some error checking to see what is failing... expandcollapse popup#include <Excel.au3> #include <Array.au3> #include <MsgBoxConstants.au3> #include <GUIConstantsEx.au3> #AutoIt3Wrapper_Add_Constants=n Local $xlsServices = @ScriptDir & '\warranty_services.xls' Local $gui010 = GUICreate('', 500, 200) Local $aSize = WinGetClientSize($gui010) Local $readSN = GUICtrlCreateInput('', 20, 20, 400, 20) Local $servicebox = GUICtrlCreateLabel('', 20, 50, 400, 250) GUISetState() While 1 Switch GUIGetMsg() Case $GUI_EVENT_CLOSE Exit Case $readSN SearchForService(StringStripWS(GUICtrlRead($readSN), 3)) EndSwitch WEnd Func SearchForService($str) $oxlsServices = _ExcelBookOpen($xlsServices, 0) ; Open xls file if $oxlsServices = 0 then ConsoleWrite('Error opening spreadsheet = ' & @error & @LF) Exit endif Local $XlsArray = _ExcelReadSheetToArray($oxlsServices, 8, 2, 0, 8) ;make an array from excel if @error <> 0 then ConsoleWrite('Error creating array = ' & @error & @LF) Exit endif local $snpos = _ArraySearch($XlsArray, $str) ; searching for SN switch @error case 1,2,3,4,7 GUICtrlSetData($servicebox, "Parameter Error - See Help File for @error = "& @error) case 6 GUICtrlSetData($servicebox, "SN: " & $str & ' - no service found in the "Warranty_services.xls" file') case 0 GUICtrlSetData($servicebox, "SN:" & $str & " has a service: " & @CRLF & _ $XlsArray[$snPos][3] & @CRLF & _ "PN: " & $XlsArray[$snPos][1] & @CRLF & _ "Warranty from: " & $XlsArray[$snPos][7] & @CRLF & _ "Warranty to: " & $XlsArray[$snPos][8] & @CRLF & _ "RF LOT NR: " & $XlsArray[$snPos][4] & @CRLF & _ "Project name: " & $XlsArray[$snPos][5] & @CRLF & _ "Contract Nr: " & $XlsArray[$snPos][6] & @CRLF) endswitch _ExcelBookClose($oxlsServices, 0, 0) EndFunc ;==>SearchForService Edited February 17, 2014 by kylomas Forum Rules Procedure for posting code "I like pigs. Dogs look up to us. Cats look down on us. Pigs treat us as equals." - Sir Winston Churchill Link to comment Share on other sites More sharing options...
broliukaz Posted February 18, 2014 Author Share Posted February 18, 2014 The value of $xlsServices is script folder with xls file. I try to copy this value and paste to explorer, it opens xls file. So this value is ok. the $oxlsServices value is empty (not 0), it could not open the file? console write: Error creating array = 3 Link to comment Share on other sites More sharing options...
water Posted February 18, 2014 Share Posted February 18, 2014 (edited) @error 3 means: Count parameter out of range $oxlsServices is an object so comparing to 0 is not sensible. Please try: expandcollapse popup#include <Excel.au3> #include <Array.au3> #include <MsgBoxConstants.au3> #include <GUIConstantsEx.au3> #AutoIt3Wrapper_Add_Constants=n Local $xlsServices = @ScriptDir & '\warranty_services.xls' Local $gui010 = GUICreate('', 500, 200) Local $aSize = WinGetClientSize($gui010) Local $readSN = GUICtrlCreateInput('', 20, 20, 400, 20) Local $servicebox = GUICtrlCreateLabel('', 20, 50, 400, 250) GUISetState() While 1 Switch GUIGetMsg() Case $GUI_EVENT_CLOSE Exit Case $readSN SearchForService(StringStripWS(GUICtrlRead($readSN), 3)) EndSwitch WEnd Func SearchForService($str) $oxlsServices = _ExcelBookOpen($xlsServices, 0) ; Open xls file if @error <> 0 then ConsoleWrite('Error opening spreadsheet = ' & @error & @LF) Exit endif Local $XlsArray = _ExcelReadSheetToArray($oxlsServices, 8, 2, 0, 8) ;make an array from excel if @error <> 0 then ConsoleWrite('Error creating array = ' & @error & @LF) Exit endif local $snpos = _ArraySearch($XlsArray, $str) ; searching for SN switch @error case 1,2,3,4,7 GUICtrlSetData($servicebox, "Parameter Error - See Help File for @error = "& @error) case 6 GUICtrlSetData($servicebox, "SN: " & $str & ' - no service found in the "Warranty_services.xls" file') case 0 GUICtrlSetData($servicebox, "SN:" & $str & " has a service: " & @CRLF & _ $XlsArray[$snPos][3] & @CRLF & _ "PN: " & $XlsArray[$snPos][1] & @CRLF & _ "Warranty from: " & $XlsArray[$snPos][7] & @CRLF & _ "Warranty to: " & $XlsArray[$snPos][8] & @CRLF & _ "RF LOT NR: " & $XlsArray[$snPos][4] & @CRLF & _ "Project name: " & $XlsArray[$snPos][5] & @CRLF & _ "Contract Nr: " & $XlsArray[$snPos][6] & @CRLF) endswitch _ExcelBookClose($oxlsServices, 0, 0) EndFunc ;==>SearchForService Edited February 18, 2014 by water My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
broliukaz Posted February 18, 2014 Author Share Posted February 18, 2014 The same error: Error creating array = 3 Link to comment Share on other sites More sharing options...
Solution water Posted February 18, 2014 Solution Share Posted February 18, 2014 There is something really strange with your workbook I tried with the rewritten Excel UDF and this works: #include <Excel Rewrite.au3> #include <Array.au3> Global $sWorkbook = "C:\temp\warranty_services.xlsx" Global $oExcel = _Excel_Open() If @error Then Exit ConsoleWrite('Error opening Excel = ' & @error & @LF) Global $oWorkbook = _Excel_BookOpen($oExcel, $sWorkbook) If @error Then Exit ConsoleWrite('Error opening Workbook = ' & @error & @LF) Global $iRows = $oWorkbook.Activesheet.Usedrange.Rows.Count Global $aArray = _Excel_RangeRead($oWorkbook, $oWorkbook.ActiveSheet, "B8:I" & $iRows, 1, True) If @error Then Exit ConsoleWrite('Error reading Range = ' & @error & @LF) _ArrayDisplay($aArray) _Excel_Close($oWorkbook, False) If @error Then Exit ConsoleWrite('Error closing Excel = ' & @error & @LF) My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
broliukaz Posted February 18, 2014 Author Share Posted February 18, 2014 There is something really strange with your workbook I tried with the rewritten Excel UDF and this works: #include <Excel Rewrite.au3> #include <Array.au3> Global $sWorkbook = "C:\temp\warranty_services.xlsx" Global $oExcel = _Excel_Open() If @error Then Exit ConsoleWrite('Error opening Excel = ' & @error & @LF) Global $oWorkbook = _Excel_BookOpen($oExcel, $sWorkbook) If @error Then Exit ConsoleWrite('Error opening Workbook = ' & @error & @LF) Global $iRows = $oWorkbook.Activesheet.Usedrange.Rows.Count Global $aArray = _Excel_RangeRead($oWorkbook, $oWorkbook.ActiveSheet, "B8:I" & $iRows, 1, True) If @error Then Exit ConsoleWrite('Error reading Range = ' & @error & @LF) _ArrayDisplay($aArray) _Excel_Close($oWorkbook, False) If @error Then Exit ConsoleWrite('Error closing Excel = ' & @error & @LF) Thank you water! This works for me too. But now there is another error: Error closing Excel = 1 and excel does not closing... Link to comment Share on other sites More sharing options...
water Posted February 18, 2014 Share Posted February 18, 2014 My bad Should be: _Excel_Close($oExcel, False) My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
broliukaz Posted February 18, 2014 Author Share Posted February 18, 2014 Thanks everyone! Link to comment Share on other sites More sharing options...
kylomas Posted February 18, 2014 Share Posted February 18, 2014 Any idea why the code that I posted works for me...?? Running Win7, Office/XP, AutoIT 3.3.10.2 Forum Rules Procedure for posting code "I like pigs. Dogs look up to us. Cats look down on us. Pigs treat us as equals." - Sir Winston Churchill Link to comment Share on other sites More sharing options...
water Posted February 18, 2014 Share Posted February 18, 2014 I'm running AutoIt 3.3.10.2, Windows 7 (64 bit) and Office 2010 (32 bit). Looks like the only difference is Office. Maybe the old version is less picky? My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
kylomas Posted February 18, 2014 Share Posted February 18, 2014 Correction: My Win7 box is FUBAR...running on a Vista system. It seems that the difference must be environmental. I was suprised as hell when the OP said that it did not work. Forum Rules Procedure for posting code "I like pigs. Dogs look up to us. Cats look down on us. Pigs treat us as equals." - Sir Winston Churchill Link to comment Share on other sites More sharing options...
water Posted February 18, 2014 Share Posted February 18, 2014 It's very strange but I think the problem is caused by the format of the Excel file. I was not able to deactivate the filters etc. which led me to use the rewrite of the UDF. My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now