Problem using _ArrayAdd

[Riviera_Phill]

Hi,

I've written a script which reads a log file, identifies particular errors and then extracts the message IDs (it's a mail archiving server) and writes these to an SQL script file.

In order to do this I need to move the data between 3 different arrays, but I seem to be having an issue creating the second one in the chain $aAllMsgIDs, the scrip compiles OK but I get "Error: Subscript used with non-Array variable" when I run it:

Please can someone take a look at the code below and see if they can spot the error? I'm pretty sure its something to do with how I've used _ArrayAdd but I can't see what.

expandcollapse popup

Dim $aEASIndexerLog, $aAllMsgIDs, $aUniqueMsgIDs, $LogEntry, $MsgID, $file1, $LastEntry, $ErrorMsg, $NewLastEntry

#Include <Array.au3>
#Include <File.au3>
#include <String.au3>

; Read contents of EASIndexer.log into an array
If Not _FileReadToArray('d:\easlog\EASIndexer.log', $aEASIndexerLog) Then
    ; If failed to open PSTList write an error and exit
    WriteToErrorLog('Unable to open EASIndexer.log')
    Exit
EndIf

; Create Script file to write too (any existing file will be deleted)
$file1 = FileOpen('d:\BadMsgIDs\BadMsgIDs.sql', 10)
; Write 1st line of SQL code
FileWriteLine($file1, "update ft_notify set typefld ='Z' where msgid in (")

;_ArrayDisplay($aEASIndexerLog)

;do for each line in the array
For $x = 1 to $aEASIndexerLog[0] Step 1
    ; Load the log entry from the array
    $LogEntry = StringStripWS($aEASIndexerLog[$x],2)
    If StringInStr($LogEntry,'openMsg: Error working with MsgID=') <> 0 Then
        $MsgID=StringLeft(StringRight($LogEntry,129),8)
        _ArrayAdd($aAllMsgIDs, $MsgID)
    Else
        ContinueLoop
    EndIf
Next

_ArrayDisplay($aAllMsgIDs)

$aUniqueMsgIDs = _ArrayUnique($aAllMsgIDs)

_ArrayDisplay($aUniqueMsgIDs)

For $x = 1 to $aUniqueMsgIDs[0] Step 1
    FileWriteLine($file1, $aUniqueMsgIDs[$x] & ',')
Next

FileWriteLine($file1, $MsgID & ')')

FileClose($file1)
Exit

Many thanks in adavance,

Phill.

[SmOke_N]

You never declared $aAllMsgIDs as an array.

Dim $aEASIndexerLog, $aAllMsgIDs[], $aUniqueMsgIDs, $LogEntry, $MsgID, $file1, $LastEntry, $ErrorMsg, $NewLastEntry

 

Edit:

BTW, what version of autoit are you using?

Edited February 4, 2015 by SmOke_N

[Riviera_Phill]

Hi,

Many thanks for your reply.

Tried the fix, got a sytax error when compiling, checked the version, I was on 3.3.8.1 so updated to 3.3.12.0, recompiled with no errors, but I now get a run error "Line 5....Error: Variable subscript badly formatted" not sure what's causing this now.

expandcollapse popup

Dim $aEASIndexerLog[], $aAllMsgIDs[], $aUniqueMsgIDs[], $LogEntry, $MsgID, $file1, $LastEntry, $ErrorMsg, $NewLastEntry

#Include <Array.au3>
#Include <File.au3>
#include <String.au3>

; Read contents of EASIndexer.log into an array
If Not _FileReadToArray('d:\easlog\EASIndexer.log', $aEASIndexerLog) Then
    ; If failed to open PSTList write an error and exit
    WriteToErrorLog('Unable to open EASIndexer.log')
    Exit
EndIf

; Create Script file to write too (any existing file will be deleted)
$file1 = FileOpen('d:\BadMsgIDs\BadMsgIDs.sql', 10)
; Write 1st line of SQL code
FileWriteLine($file1, "update ft_notify set typefld ='Z' where msgid in (")

_ArrayDisplay($aEASIndexerLog)

;do for each line in the array
For $x = 1 to $aEASIndexerLog[0] Step 1
    ; Load the log entry from the array
    $LogEntry = StringStripWS($aEASIndexerLog[$x],2)
    If StringInStr($LogEntry,'openMsg: Error working with MsgID=') <> 0 Then
        $MsgID=StringLeft(StringRight($LogEntry,129),8)
        _ArrayAdd($aAllMsgIDs, $MsgID)
    Else
        ContinueLoop
    EndIf
Next

_ArrayDisplay($aAllMsgIDs)

$aUniqueMsgIDs = _ArrayUnique($aAllMsgIDs)

_ArrayDisplay($aUniqueMsgIDs)

For $x = 1 to $aUniqueMsgIDs[0] Step 1
    FileWriteLine($file1, $aUniqueMsgIDs[$x] & ',')
Next

FileWriteLine($file1, $MsgID & ')')

FileClose($file1)
Exit

Thanks,

Phill.

[water]

Don't use Dim, try Global:

Global $aEASIndexerLog[], $aAllMsgIDs[], $aUniqueMsgIDs[], $LogEntry, $MsgID, $file1, $LastEntry, $ErrorMsg, $NewLastEntry

[Riviera_Phill]

Humm, looks like quite a bit changed between versions, I think I'm going to have to re-write this from the ground up rather than trying to edit it.

Thanks for your help guys.

Phill.

[water]

To see what has changed I suggest to have a look at the Changelog in the help file. There you'll find a link to the script breaking changes. This are the areas where you need to brush up your scripts

[Riviera_Phill]

These changes have cost me a days work so far

OK, I cant figure out how to change the loop so that it executes once per row of the array, the old code looked like this:

For $x = 1 to $aEASIndexerLog[0] Step 1
    ; Load the log entry from the array
    $LogEntry = StringStripWS($aEASIndexerLog[$x], $STR_STRIPTRAILING)
    If StringInStr($LogEntry, "openMsg: Error working with MsgID=") <> 0 Then
        $MsgID=StringLeft(StringRight($LogEntry,129),8)
        _ArrayAdd($aAllMsgIDs, $MsgID)
    Else
        ContinueLoop
    EndIf
Next

I think I have to change the format of For..to..step..next loop but I've looked in the help and can't find what, sorry to keep asking for help but I only write scripts occasioanly.

Thanks again.

Phill.

[Riviera_Phill]

Sorry, ignor that last message, I've found it, I have to use UBound.

Phill.