Jump to content
Skeletor

Array variable has incorrect number of subscripts

Recommended Posts

Skeletor

Hi Virtual People,

My array works perfectly fine. However, what is the best practice if the line in the array doesn't have the correct amount of columns and if I can add a placeholder?

 

For $count = 1 To _FileCountLines($FileRead1) Step 1
    $string = FileReadLine($FileRead1, $count)
    $input = StringSplit($string, ",", 1)
    $value1 = $input[1]
    $value2 = $input[2]
    $value3 = $input[3]

    _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "A1")
    _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "B1")
    _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1")
Next

 


Kind Regards
Skeletor

"I need coffee to turn me back to a human"

Microsoft Office Splash Screen | Basic Notepad Program (Beginner) | Wondering who uses AutoIt and what it can be used for ?

 

Share this post


Link to post
Share on other sites
caramen

Try that : 

 

Local $MyVar[3] = ["element 1", "element 2", "element 3"]


MsgBox (0, "", $MyVar)
MsgBox (0, "", $MyVar[0])
MsgBox (0, "", $MyVar[1])
MsgBox (0, "", $MyVar[2]) ;This is equal to $iRow amount (3) - 1 = 2 

$iRow = UBound ($MyVar)
MsgBox (0, "", $iRow)

If $iRow > 3 Then ; With that you dodged the fact to trying to access an non accessible $Variable. in this case it was $MyVar[3]
    MsgBox (0, "", $MyVar[$iRow-4]);$MyVar[3]
    MsgBox (0, "", $MyVar[$iRow-3]);$MyVar[2]
    MsgBox (0, "", $MyVar[$iRow-2]);$MyVar[1]
    MsgBox (0, "", $MyVar[$iRow-1]);$MyVar[0]
EndIf
If $iRow > 2 Then 
    MsgBox (0, "", $MyVar[$iRow-3]);$MyVar[2]
    MsgBox (0, "", $MyVar[$iRow-2]);$MyVar[1]
    MsgBox (0, "", $MyVar[$iRow-1]);$MyVar[0]
EndIf
If $iRow > 1 Then
    MsgBox (0, "", $MyVar[$iRow-2]);$MyVar[1]
    MsgBox (0, "", $MyVar[$iRow-1]);$MyVar[0]
EndIF
If $iRow > 0 Then
    MsgBox (0, "", $MyVar[$iRow-1]) ;$MyVar[0]
EndIf

 

Read help file about : 

UBound
IsArray

 

Edited by caramen
  • Thanks 1

Share this post


Link to post
Share on other sites
FrancescoDiMuro

@Skeletor
If you allow me, IsArray() doesn't tell you if you have less elements in your array and/or you array has some blank elements.
So, if you want to see if your array has less elements than the "normal", or has some blank elements, then you should do something like this:

#include <Array.au3>

Global $strIsArray = "Element1,Element2,ElementN", _
       $strLessElements = "Element1,Element2", _
       $strBlankElement = "Element1,,ElementN", _
       $arrIsArray = StringSplit($strIsArray, ",", $STR_NOCOUNT), _
       $arrLessElements = StringSplit($strLessElements, ",", $STR_NOCOUNT), _
       $arrBlankElements = StringSplit($strBlankElement, ",", $STR_NOCOUNT), _
       $varNotAnArray

_ArrayDisplay($arrIsArray)
_ArrayDisplay($arrLessElements)
_ArrayDisplay($arrBlankElements)

; To detect if the array has less elements than normal, use UBound()
If UBound($arrIsArray) < UBound($arrLessElements) Then
    ConsoleWrite("$arrLessElements has elements than $arrIsArray." & @CRLF)
EndIf

; To detect if the array has a blank element
For $i = 0 To UBound($arrBlankElements) - 1 Step 1
    If $arrBlankElements[$i] = "" Then ConsoleWrite("Detected a blank element at the index '" & $i & "'." & @CRLF)
Next

; As you can see from here, only $varNotAnArray, which is not an array, displays "False" as a result of IsArray() function
ConsoleWrite("Is $arrIsArray an array? " & (IsArray($arrIsArray) ? "True" : "False") & @CRLF & _             ; True
             "Is $arrLessElements an array? " & (IsArray($arrLessElements) ? "True" : "False") & @CRLF & _   ; True
             "Is $arrBlankElements an array? " & (IsArray($arrBlankElements) ? "True" : "False") & @CRLF & _ ; True
             "Is $varNotAnArray an array? " & (IsArray($varNotAnArray) ? "True" : "False") & @CRLF)          ; False

 

Edited by FrancescoDiMuro
  • Thanks 1

Click here to see my signature:

Spoiler

Thoughts:

  • I will always thank you for the time you spent for me.
    I'm here to ask, and from your response, I'd like to learn.
    By my knowledge, I can help someone else, and "that someone" could help in turn another, and so on.

/*--------------------------------------------------------------------------------------------------------------------------------------------------------------------------*/

ALWAYS GOOD TO READ:

 

Share this post


Link to post
Share on other sites
caramen

@FrancescoDiMuro 

Résultat de recherche d'images pour "smiley love" 

 

Loved that one. 

Edited by caramen
  • Confused 1

Share this post


Link to post
Share on other sites
Subz

StringSplit always returns an array, even if you use a blank line, see example below, personally I would just use the line count like in the example below or use Ubound as FrancescoDiMuro used.

#include <Array.au3>
Local $aArray, $aString[] = ["One,Two,Three", "", "Four,Five,Six,Seven,Eight","Nine,Ten"]
For $i = 0 To UBound($aString) - 1
    $aArray = StringSplit($aString[$i], ",")
    ;~ Check string has been split into three or more items
    If $aArray[0] >= 3 Then
        MsgBox(4096, "Success", "String has successfully been split into " & $aArray[0] & " line items.")
    Else
        MsgBox(16, "Failure", "String has been split into " & $aArray[0] & " line items.")
    EndIf
    _ArrayDisplay($aArray)
Next

 

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • MrCheese
      By MrCheese
      hi all,
      reviewing the forum, this thread is applicable: 
       
       
      I wanted to know if there is now a better way to do this?
      In essence, I load a tab delimited txt file into an array (works well). I used tab, as some fields in the original csv contains commas.
      However, I needed autoit to manipulate this array, and output it as a csv.
      IF my array contains items with a comma, without double quotes around the field, then how best do I get a csv out of this?
      My current workaround is to filewritefromarray tab delimited, then open it in excel and save as a csv. I will need to check this to see how the address fields behave that contain a comma.
       
      Any thoughts would be appreciated.
       
    • Skeletor
      By Skeletor
      Hi All,

      I would like to know how you would take a FileLineRead and insert it into an array which then inserts it into Excel?
      One thing to know is the files content is broken up, so I only use half of the content within $FileRead1.
      So its imperative that the $value1, $value2, etc variables be used. 
      Code below:
      $FileRead1 = FileReadLine("C:\temp\sample.txt",1) For $count = 1 To _FileCountLines($FileRead1) Step 1 $string = FileReadLine($FileRead1, $count) $input = StringSplit($string, ",", 1) $value1 = $input[1] $value2 = $input[2] $value3 = $input[3] $value4 = $input[4] _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "A1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "B1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value4, "D1") Next  
    • AnonymousX
      By AnonymousX
      Hello,
      I'm trying to write a script that moves copies excel cells into an array. I'll than manipulate the values and send array into another program. 
      I don't want range to be specific to a workbook, or sheet, or set of cells.
      I want user to be able to highlight desired cells and to copy either normally ("Ctrl+C") or by a hotkey ("Alt+C"). 
      Could someone help me with this?
      Thank you,
      I've tried to write the framework: (edited)
      #include <MsgBoxConstants.au3> #include <Array.au3> #include <Excel.au3> HotKeySet("!v", "Pastedata") While True Sleep(1000) WEnd func Makearray() local $bArray ;User has cells already copied ;Convert clipboard into an array ;I don;t know how excel stores data to clipboard so don;t know how to bring it into array _Arraydisplay($bArray) MsgBox(0,0,$bArray) return $bArray endfunc func Pastedata() Local $aArray MsgBox(0,0,"wait",1) ;make array based on assumption user has already copied a range to clipboard $aArray = Makearray() ;paste code ;don;t worry about this I got the rest endfunc  
    • Dzenan03
      By Dzenan03
      I want to make a while loop, that creates variables based on a array. For thist I created the array $iDsO with the number and the name of folders in an other folder. Every folder has a different name an I want to create variables(arrays) for each folder that show me all the files in that folder. For example: I have the Folder \Folder1. In it there are the Folders \1, \2, \3. In 1, 2 and 3 there are some files(.png). The array for Folder1 is $iDsO and now I want to crate the arrays $iDsO1, $iDsO2 and $iDsO3 with the files in them can I make something like this:
      While $iDs > 0 ;$iDs is the number of files in Folder1>> $iDsO[0] $iDs#here should come the Foldername for example '1'# = _FileListtoArray(@ProgramFilesDir&"\Folder1\"&$iDsO[$iDs]) $iDs = $iDs - 1 Wend So that in the End I have three variabels ($iDs1, $iDs2 and $iDs3)
       
      Is this posible or if not what could I do instead ( I don´t know the number of folders in Folder1 in the begining).
    • liagason
      By liagason
      Hello everyone,
      How can I display in ascending  sequence some numbers stored in a string variable?
      $str = "18,03,48,23" MsgBox(0,"test",$str) I would like it to display "03,18,23,48"
×