while statement loop exiting

[cdeleon]

HI I have a program that reads a file that contains the servername and IP address separated by a comma

The program reads perfectly until the last line which is a blank and it generates an error message 

samplereadcsvwithcommas.au3" (26) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:

$value2 = $input[2]
$value2 = ^ ERROR
>Exit code: 1    Time: 60.44
 

Here is the code

#include <File.au3>
$txtfile = FileOpen(@WorkingDir & "\devices.csv", 0)
While 1
              $line = FileReadLine($txtfile)
            If @error = -1 Then ExitLoop
               filewrite("dummy.csv",$line)
             ;msgbox (0, "Line", $line,5)
             $string = FileReadLine("DUMMY.csv",1)
             $input = StringSplit($string, ",", 1)
             $value1 = $input[1]
             $value2 = $input[2]
             msgbox (0, "Name", $VALUE1,5)
             msgbox (0, "IP Address", $VALUE2,5)
               SLEEP(20)
             fileDELETE("dummy.csv")
             ;Endif

WEnd

Any ideas ?  Thank you everyone!

 

Chris

 

 

 

[water]

Use

ConsoleWrite(@Error)
_ArrayDisplay($input)

after StringSplit to check for errors and see the returned array.

[OJBakker]

Add a check for empty line (empty string).

#include <File.au3>
$txtfile = FileOpen(@WorkingDir & "\devices.csv", 0)
While 1
    $line = FileReadLine($txtfile)
    If @error = -1 Then ExitLoop
    If $line = "" Then ExitLoop
    $input = StringSplit($line, ",", 1)
    $value1 = $input[1]
    $value2 = $input[2]
    MsgBox (0,"Result" ,"Name:" & $input[1] & @CRLF & "IP Address:" & $input[2], 5)
    SLEEP(20)
WEnd

 

[quickbeam]

Based on the return value described here: https://www.autoitscript.com/autoit3/docs/functions/StringSplit.htm

I would insert a check after StringSplit. It's a little more specific than checking for a blank line, as it could fail on non-blank inputs.

$string = FileReadLine("DUMMY.csv",1)
$input = StringSplit($string, ",", 1)
If $input[0] < 2 Then ExitLoop        ;   <-- check that StringSplit found (at least) two entries
$value1 = $input[1]
$value2 = $input[2]

 

Edited June 28, 2023 by quickbeam
formatting