Converting AM/PM time to 24-hour

[c.haslam]

Here's my code:

$tin = "8:00 PM"
$vec = StringSplit($tin,": ",0)    ; STR_CHRSPLIT
$hr = Number($vec[1])
$min = $vec[2]
If $vec[3]="PM" Then
    $hr = $hr + 12
EndIf
$ret = $hr + ":" + $min
MsgBox(0,"",$ret,15)

$ret should be 20:00 but it is actually 20

Ideas? I have tried applying String()

[rsn]

Change 

$ret = $hr + ":" + $min

to 

$ret = $hr & ":" & $min

 

[SmOke_N]

23 minutes ago, c.haslam said:

Here's my code:

$tin = "8:00 PM"
$vec = StringSplit($tin,": ",0)    ; STR_CHRSPLIT
$hr = Number($vec[1])
$min = $vec[2]
If $vec[3]="PM" Then
    $hr = $hr + 12
EndIf
$ret = $hr + ":" + $min
MsgBox(0,"",$ret,15)

$ret should be 20:00 but it is actually 20

Ideas? I have tried applying String()

I'd suggest you actually run that code, there's no $vec[3] so it will certainly crash.  As RSN stated, string concatenation is done with an ampersand -> &, we use the + operator only for math.

If your strings will look like what you have (eg. "8:00 PM"), then maybe try a regex.

Your code:
 

#include <Array.au3>
Global $gaArgs = StringSplit("8:00 PM", ":")
_ArrayDisplay($gaArgs)

 

Simple approach (keep in mind, the arrays for regular expressions are zero based)
 

#include <Array.au3>
Global $gsTime = "8:00 PM"
Global $gaArgs = StringRegExp($gsTime, "(.+?)(?:\W|$)", 3)
_ArrayDisplay($gaArgs)

 

[c.haslam]

Thank you both. I have been away from AutoIt for too long, so I tend to think PerfectScript.

[rsn]

@SmOke_N OP's StringSplit does have two delimiters (":" and " ") so $vec[3] is defined. Your explanation is certainly better than mine 🤦‍♂️

[SmOke_N]

5 minutes ago, rsn said:

@SmOke_N OP's StringSplit does have two delimiters (":" and " ") so $vec[3] is defined. Your explanation is certainly better than mine 🤦‍♂️

Damn these eyes.. I seriously didn't see the space!

[UEZ]

An old thread:

www.autoitscript.com/forum/topic/131335-convert-time-in-string-to-time-value

Edited April 12 by UEZ

[Nine]

Or m23 :

 

 

[jchd]

You can also use a one-liner:

Local $a = ["  12:0am", "12:12 AM", "2:3   aM", "11:59 am", "12:00 pm", "12:45pm ", "03:15 PM", "11:59 Pm"], $t
For $s In $a
    $t = Execute((StringRegExpReplace($s, "(?i)(\d{1,2}):(\d{1,2})\h*([AP])M", "StringFormat('%02i', Mod(Execute('((  ((''$3'' & ''$1'' = ''A12'') OR (''$3'' = ''P'' AND ''$1'' < 12)) ? 12 : 0) + $1)'), 24)) & ':' & StringFormat('%02i', '$2')")))
    ConsoleWrite($s & @TAB & $t & @LF)
Next

Beware that the OP code (even when fixed) gets 12 AM and 12 PM wrong!

[Nine]

Oh well, another one liner then (less abstruse )  :

$t = Mod(StringRegExp($s, "(\d{1,2})", 1)[0], 12) + (StringRegExp($s, "(?i).*([AP]M)", 1)[0] = "AM" ? 0 : 12) & StringRegExp($s, "(:\d{1,2})", 1)[0]

 

Edited April 13 by Nine

[jchd]

Ah yes, HH mod 12 is smarter.